[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

atmnpatel updated this revision to Diff 386426. atmnpatel added a comment. small nit fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113359/new/ https://reviews.llvm.org/D113359 Files: clang/lib/Basic/Targets/X86.h clang/lib/CodeGen/CGOpenMP

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

atmnpatel updated this revision to Diff 386425. atmnpatel added a comment. I removed the shared var opt - might be best to keep this in a separate patch @tianshilei1992. Also addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113359/

[PATCH] D113647: [X86] Honor command line features along with cpu_specific attribute

craig.topper created this revision. craig.topper added reviewers: andrew.w.kaylor, erichkeane, pengfei. craig.topper requested review of this revision. Herald added a project: clang. If the feature is on the command line we should honor it for all functions. I don't think we could reliably target

[PATCH] D113645: [clangd] Allow Unix config paths on Darwin

keith created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman, hiraditya. keith requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, MaskRay, ilya-biryukov. Herald added projects: LLVM, clang-tools-extra. It's common for CLIs on

[PATCH] D109051: Use Component in OpenBSD::getCompilerRT to find libraries

blackgnezdo added a comment. I reformatted with clang-format to address the lint complaint. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109051/new/ https://reviews.llvm.org/D109051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D109051: Use Component in OpenBSD::getCompilerRT to find libraries

blackgnezdo updated this revision to Diff 386414. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109051/new/ https://reviews.llvm.org/D109051 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp Index: clang/lib/Driver/ToolChains/OpenBSD.cpp =

[PATCH] D113642: [PowerPC] Provide XL-compatible vec_round implementation

nemanjai created this revision. nemanjai added reviewers: PowerPC, rzurob, qiongsiwu. Herald added subscribers: shchenz, kbarton, hiraditya. nemanjai requested review of this revision. Herald added projects: clang, LLVM. The XL implementation of `vec_round` for `vector double` uses "round-to-near

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Awesome! Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:559 + // Get the resolved template arguments from the canonical type. + // FIXME: Handle the as-written argume

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

dblaikie added a subscriber: rsmith. dblaikie added a comment. Some offline post-commit feedback from @rsmith - Rename printing policy to match closer to the function it's tested in. Will think about that, check the function name, etc, and commit a patch in the next few days, hopefully. Reposi

[PATCH] D113638: [xray] Add support for hexagon architecture

androm3da added a comment. This patch spans several areas, so I would be happy to decompose it into smaller parts if it made it easier for reviewers. Comment at: compiler-rt/lib/xray/xray_hexagon.cpp:76-84 +static void WriteInstFlushCache(void *Addr, uint32_t NewInstruction) {

[PATCH] D110898: Pass template parameters when printing template argument lists for function templates

dblaikie abandoned this revision. dblaikie added a comment. Talked to Richard offline - this is undesirable because it would mean that certain template overloads would not be disambiguated in their naming. I'll post a patch with a test case that demonstrates that desired behavior and abandon th

[PATCH] D113638: [xray] Add support for hexagon architecture

androm3da created this revision. androm3da added reviewers: dberris, kparzysz. Herald added subscribers: hiraditya, mgorny. androm3da requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Adds x-ray suppo

[PATCH] D112915: [clang][modules] Track number of includes per submodule

vsapsai added a comment. As we've discussed earlier, tracking `isImport` shouldn't be done per .pcm and here is the test case https://gist.github.com/vsapsai/a2d2bd19c54c24540495fd9b262106aa I'm not sure it is worth adding the second `#include` as the test fails just with one. Overall, the cha

[PATCH] D106585: Fix clang debug info irgen of i128 enums

glandium added a comment. In D106585#3122726 , @glandium wrote: > It seems to have been fixed in rG3c47c5ca13b8a502de3272e8105548715947b7a8 > . Actually, there are some remaining cases

[PATCH] D113636: format_arg attribute does not support nullable instancetype return type

fcloutier created this revision. fcloutier added reviewers: NoQ, ahatanak. fcloutier added a project: clang. Herald added a reviewer: aaron.ballman. fcloutier requested review of this revision. Herald added a subscriber: cfe-commits. Following up with D112670 , it

[PATCH] D113428: [AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test

This revision was automatically updated to reflect the committed changes. Closed by commit rG9303c7da3967: [AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 9303c7d - [AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test

Author: Jake Egan Date: 2021-11-10T20:46:57-05:00 New Revision: 9303c7da39678dbcf3397da4944bb9b4c6e1ac65 URL: https://github.com/llvm/llvm-project/commit/9303c7da39678dbcf3397da4944bb9b4c6e1ac65 DIFF: https://github.com/llvm/llvm-project/commit/9303c7da39678dbcf3397da4944bb9b4c6e1ac65.diff LOG

[PATCH] D113614: Disable clang-repl tests failing due to lack of 64-bit XCOFF support.

Jake-Egan accepted this revision. Jake-Egan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113614/new/ https://reviews.llvm.org/D113614 _

[PATCH] D113623: [OpenMP][FIX] Pass the num_threads value directly to parallel_51

jdoerfert created this revision. jdoerfert added reviewers: jhuber6, ggeorgakoudis, tianshilei1992, grokos, jdenny. Herald added subscribers: asavonic, guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added projects: clan

[PATCH] D113126: [OpenMP][NFCI] Embed the source location string size in the ident_t

jdoerfert added a comment. In D113126#3122659 , @tianshilei1992 wrote: > I'm not convinced. `std::strlen` can do the job. Can you explain more why > need it? Because the ident_t is on the device and you want to grab it from the host. Repository: rG

[PATCH] D113517: Correct handling of the 'throw()' exception specifier in C++17.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfddc4e41164e: Correct handling of the 'throw()' exception specifier in C++17. (authored by jyknight). Changed prior to commit: https://reviews.llvm.org/D113517?vs=385971&id=386326#toc Repository: rG

[clang] fddc4e4 - Correct handling of the 'throw()' exception specifier in C++17.

Author: James Y Knight Date: 2021-11-10T17:40:16-05:00 New Revision: fddc4e41164e2fd152605362639eb3255cc75212 URL: https://github.com/llvm/llvm-project/commit/fddc4e41164e2fd152605362639eb3255cc75212 DIFF: https://github.com/llvm/llvm-project/commit/fddc4e41164e2fd152605362639eb3255cc75212.diff

[PATCH] D113517: Correct handling of the 'throw()' exception specifier in C++17.

jyknight added a comment. In D113517#3122217 , @rsmith wrote: > In D113517#3121455 , @jyknight > wrote: > >> This change allows those future optimizations to apply to throw() as well, >> in C++17 mode, which is

[PATCH] D113614: Disable clang-repl tests failing due to lack of 64-bit XCOFF support.

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The following interpreter tests failed on AIX because 64-bit XCOFF object files are currently not supported on AIX. This patch disables the tests on A

[PATCH] D112820: Emit hidden hostcall argument for sanitized kernels.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b3881e9f319: Emit hidden hostcall argument for sanitized kernels (authored by yaxunl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGE

[clang] 4b3881e - Emit hidden hostcall argument for sanitized kernels

Author: Yaxun (Sam) Liu Date: 2021-11-10T17:05:57-05:00 New Revision: 4b3881e9f319b6c4ec69160f16a49c128ffbd7dd URL: https://github.com/llvm/llvm-project/commit/4b3881e9f319b6c4ec69160f16a49c128ffbd7dd DIFF: https://github.com/llvm/llvm-project/commit/4b3881e9f319b6c4ec69160f16a49c128ffbd7dd.dif

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

eugenis added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:124 + } + return SanitizerArgs(*this, JobArgs, /*DiagnoseErrors=*/false); } SanitizerArgs SanArgs(*this, JobArgs, !SanitizerArgsChecked); SanitizerArgsChecked = true; return SanArgs;

[clang] 80072fd - [CUDA][HIP] Allow comdat for kernels

Author: Yaxun (Sam) Liu Date: 2021-11-10T16:42:23-05:00 New Revision: 80072fde61d40a4e8a9da673476730d34a483fa2 URL: https://github.com/llvm/llvm-project/commit/80072fde61d40a4e8a9da673476730d34a483fa2 DIFF: https://github.com/llvm/llvm-project/commit/80072fde61d40a4e8a9da673476730d34a483fa2.dif

[PATCH] D112492: [CUDA][HIP] Allow comdat for kernels

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80072fde61d4: [CUDA][HIP] Allow comdat for kernels (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D106585: Fix clang debug info irgen of i128 enums

glandium added a comment. It seems to have been fixed in rG3c47c5ca13b8a502de3272e8105548715947b7a8 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106585/new/ https://reviews.ll

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

ymandel added a comment. Overall, looks good to me. But, I'd like to get a more experienced reviewer to confirm they're comfortable with the new behavior. Comment at: clang-tools-extra/clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:159 // automatically canoni

[PATCH] D113136: [Clang] Pass -z rel to linker for Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff11f0aa5de1: [Clang] Pass -z rel to linker for Fuchsia (authored by mcgrathr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] ff11f0a - [Clang] Pass -z rel to linker for Fuchsia

Author: Roland McGrath Date: 2021-11-10T13:31:22-08:00 New Revision: ff11f0aa5de1fffaec5f0dde53fad2ba333116b1 URL: https://github.com/llvm/llvm-project/commit/ff11f0aa5de1fffaec5f0dde53fad2ba333116b1 DIFF: https://github.com/llvm/llvm-project/commit/ff11f0aa5de1fffaec5f0dde53fad2ba333116b1.diff

[PATCH] D113518: [clang] Create delegating constructors even in templates

fwolff marked 2 inline comments as done. fwolff added a comment. Thanks for your review @carlosgalvezp! I have addressed your inline comments. I'm not sure about the failing test, but it looks like a regression test internal to libFuzzer? Maybe it goes away with the rebuild.

[PATCH] D106674: Runtime for Interop directive

RaviNarayanaswamy accepted this revision. RaviNarayanaswamy added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106674/new/ https://reviews.llvm.org/D106674 _

[PATCH] D113126: [OpenMP][NFCI] Embed the source location string size in the ident_t

tianshilei1992 added a comment. I'm not convinced. `std::strlen` can do the job. Can you explain more why need it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113126/new/ https://reviews.llvm.org/D113126

[PATCH] D113518: [clang] Create delegating constructors even in templates

fwolff updated this revision to Diff 386297. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113518/new/ https://reviews.llvm.org/D113518 Files: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp clang/lib/Sema/SemaDeclCXX.cpp Index: clang/lib/Sema

[PATCH] D113480: [analyzer] Fix region cast between the same types with different qualifiers.

ASDenysPetrov added a comment. @steakhal Thank you! > Please clang-format the patch to reflow the touched comment. Given that's > done, you are good to go. The comment is OK. `clang-format` doesn't complain on it. > Also, wait a couple days before committing to give chance to the rest of the

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107994/new/ https://reviews.llvm.org/D107994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D113136: [Clang] Pass -z rel to linker for Fuchsia

mcgrathr added a comment. Reordered the switches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113136/new/ https://reviews.llvm.org/D113136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D113136: [Clang] Pass -z rel to linker for Fuchsia

mcgrathr updated this revision to Diff 386293. mcgrathr marked an inline comment as done. mcgrathr added a comment. reordered switches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113136/new/ https://reviews.llvm.org/D113136 Files: clang/lib/Dr

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. @JDevlieghere can you take another pass? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

zahiraam added a comment. In D107994#3115589 , @thakis wrote: > This fixes tests on macOS, but I don't know if the space is there > intentionally to check for presence of any attributes: > > % git diff > diff --git a/clang/test/CodeGen/ffp-contract-o

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

zahiraam updated this revision to Diff 386279. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107994/new/ https://reviews.llvm.org/D107994 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D113599: Revert "[clang] Add early exit when checking for const init of arrays."

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d09aaecdfe5: Revert "[clang] Add early exit when checking for con

[clang] 6d09aae - Revert "[clang] Add early exit when checking for const init of arrays."

Author: Adam Czachorowski Date: 2021-11-10T20:59:35+01:00 New Revision: 6d09aaecdfe51e13fc64d539aa7c9a790de341d7 URL: https://github.com/llvm/llvm-project/commit/6d09aaecdfe51e13fc64d539aa7c9a790de341d7 DIFF: https://github.com/llvm/llvm-project/commit/6d09aaecdfe51e13fc64d539aa7c9a790de341d7.d

[PATCH] D113599: Revert "[clang] Add early exit when checking for const init of arrays."

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added a subscriber: kristof.beyls. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit 48bb5f4cbe8d5951c1153e469dc6713a122b7fa3

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz added a comment. Sorry for trouble, I will revert this for now. It's only the test that's causing the problem, the fix is fine, as far as I can tell. Still, better revert the whole thing for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

thakis added a comment. The test is failing on non-arm macs: http://45.33.8.238/mac/38601/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113120/new/ https://reviews.llvm.o

[clang-tools-extra] 26d195d - Replace include by forward declaration in test case

Author: serge-sans-paille Date: 2021-11-10T20:34:05+01:00 New Revision: 26d195d8b332d8615b7bd0ab9657bcf244f6b112 URL: https://github.com/llvm/llvm-project/commit/26d195d8b332d8615b7bd0ab9657bcf244f6b112 DIFF: https://github.com/llvm/llvm-project/commit/26d195d8b332d8615b7bd0ab9657bcf244f6b112.d

[PATCH] D112915: [clang][modules] Track number of includes per submodule

dexonsmith added a comment. Implementation looks a lot cleaner! I'd still like to drop NumIncludes first if possible because I think it'll be easier to reason about without this extra layer of complexity. Also, that'd mitigate the potential regression in `.pcm` size. (Note: I'd be more comfort

[PATCH] D113136: [Clang] Pass -z rel to linker for Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:64-65 CmdArgs.push_back("--pack-dyn-relocs=relr"); +CmdArgs.push_back("-z"); +CmdArgs.push_back("rel");

[PATCH] D113136: [Clang] Pass -z rel to linker for Fuchsia

mcgrathr updated this revision to Diff 386262. mcgrathr added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113136/new/ https://reviews.llvm.org/D113136 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/fuchsi

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

steakhal added subscribers: njames93, whisperity, steakhal. steakhal added a comment. Herald added subscribers: carlosgalvezp, manas, ASDenysPetrov. Herald added a project: clang-tools-extra. It seems like the list got pretty outdated by the time. Do you think we should really refer to the clang-a

[PATCH] D113480: [analyzer] Fix region cast between the same types with different qualifiers.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Please clang-format the patch to reflow the touched comment. Given that's done, you are good to go. Also, wait a couple days before committing to give chance to the rest of the reviewers t

[PATCH] D113126: [OpenMP][NFCI] Embed the source location string size in the ident_t

jdoerfert updated this revision to Diff 386255. jdoerfert added a comment. Herald added a subscriber: asavonic. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113126/new/ https://reviews.llvm.org/D113126 Files: clang/lib/CodeGen/CGOp

[PATCH] D113517: Correct handling of the 'throw()' exception specifier in C++17.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In D113517#3121455 , @jyknight wrote: > This change allows those future optimizations to apply to throw() as well, in > C++17 mode, which is the desir

[PATCH] D113518: [clang] Create delegating constructors even in templates

carlosgalvezp added a comment. Also, what's with the pre-merge test, is it related? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113518/new/ https://reviews.llvm.org/D113518 ___ cfe-commits mailing list

[PATCH] D113518: [clang] Create delegating constructors even in templates

carlosgalvezp requested changes to this revision. carlosgalvezp added a comment. This revision now requires changes to proceed. Amazing, thanks a lot for fixing this long-standing issue! I have a couple comments. I'm not familiar at all with the Sema part so someone that knows should look at it

[PATCH] D113499: [clang-tidy] Reduce false positives for `bugprone-infinite-loop` with dependent expressions

fwolff updated this revision to Diff 386244. fwolff added a comment. The test failed on Windows. I don't have a machine to reproduce this, but maybe adding `-fno-delayed-template-parsing` helps. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113499/new/ https://reviews.llvm.org/D113499

[PATCH] D113585: [clang-tidy] Fix false positive in `bugprone-throw-keyword-missing` check

fwolff created this revision. fwolff added reviewers: steveire, alexfh, Eugene.Zelenko. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#52400. The tests for `bu

[PATCH] D113575: Add `isInitCapture` and `forEachLambdaCapture` matchers.

fowles added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4224 +/// float z; +/// auto f = [=]() { return x + y + z; }; +/// } it would be nice to be able to do something like ``` int main() { int x, y; float z; auto

[PATCH] D113480: [analyzer] Fix region cast between the same types with different qualifiers.

ASDenysPetrov updated this revision to Diff 386226. ASDenysPetrov added a comment. Updated according to comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113480/new/ https://reviews.llvm.org/D113480 Files: clang/lib/StaticAnalyzer/Core/Store.cpp clang/test/Analysis/initializa

[PATCH] D113583: [clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG581a6a8118f5: [clang] Fix armv7-quick build by hardcoding -triple=

[clang] 581a6a8 - [clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test.

Author: Adam Czachorowski Date: 2021-11-10T19:24:06+01:00 New Revision: 581a6a8118f55d2662e180880558db95f808b0dc URL: https://github.com/llvm/llvm-project/commit/581a6a8118f55d2662e180880558db95f808b0dc DIFF: https://github.com/llvm/llvm-project/commit/581a6a8118f55d2662e180880558db95f808b0dc.d

[PATCH] D112492: [CUDA][HIP] Allow comdat for kernels

rnk added a comment. I think the key is the self-reference in the LEA instruction: > ; foo > .seh_proc "??$foo@H@@YAXH@Z" > ... > leaq"??$foo@H@@YAXH@Z"(%rip), %rcx > ... > ; foo > .seh_proc "??$foo@M@@YAXM@Z" > ... > leaq"??$foo@M@@YAXM@Z"(%rip), %rcx >

[PATCH] D113583: [clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test.

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added a subscriber: kristof.beyls. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The test was added in 48bb5f4cbe8d5951c1153e469dc6713a122b7fa3

[PATCH] D112914: Misleading identifier detection

serge-sans-paille added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-misleading-identifier.cpp:3 + +#include + RKSimon wrote: > @serge-sans-paille Any chance you can remove the include and just forward > declare printf()? Sure,

[PATCH] D113480: [analyzer] Fix region cast between the same types with different qualifiers.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/Store.cpp:98 QualType PointeeTy = CastToTy->getPointeeType(); QualType CanonPointeeTy = Ctx.getCanonicalType(PointeeTy); steakhal wrote: > You only use `CanonPointeeTy.getLocal

[PATCH] D113555: [clangd] Mark macros from preamble for code completion

usaxena95 accepted this revision. usaxena95 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:567 S.CanonicalDeclaration = R.Location; +if (!HeaderFileURIs->getIncludeHeader(SM.g

[PATCH] D51650: Implement target_clones multiversioning

erichkeane updated this revision to Diff 386205. erichkeane marked an inline comment as done. erichkeane added a comment. For the rest of multiversioning we count on the optimizer to remove variants made irrelevant, but I'm not sure opt can do anything like that yet :) But nit made. CHANGES S

[PATCH] D113480: [analyzer] Fix region cast between the same types with different qualifiers.

steakhal added a comment. Very solid patch! Comment at: clang/lib/StaticAnalyzer/Core/Store.cpp:98 QualType PointeeTy = CastToTy->getPointeeType(); QualType CanonPointeeTy = Ctx.getCanonicalType(PointeeTy); You only use `CanonPointeeTy.getLocalUnqualifi

[PATCH] D51650: Implement target_clones multiversioning

danielkiss added a comment. Thanks for the rebase! Looks got to me, `-march` may make the default same as one of the clone, in this case maybe we don't need to create two versions of the function. This could be solved later IMHO. Comment at: clang/lib/Sema/SemaDecl.cpp:1066

[PATCH] D113575: Add `isInitCapture` and `forEachLambdaCapture` matchers.

jcking1034 created this revision. jcking1034 added reviewers: ymandel, tdl-g, aaron.ballman, fowles. jcking1034 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This contributes follow-up work from https://reviews.llvm.org/D112491, which all

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

This revision was automatically updated to reflect the committed changes. Closed by commit rG48bb5f4cbe8d: [clang] Add early exit when checking for const init of arrays. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113120/new/

[clang] 48bb5f4 - [clang] Add early exit when checking for const init of arrays.

Author: Adam Czachorowski Date: 2021-11-10T18:11:21+01:00 New Revision: 48bb5f4cbe8d5951c1153e469dc6713a122b7fa3 URL: https://github.com/llvm/llvm-project/commit/48bb5f4cbe8d5951c1153e469dc6713a122b7fa3 DIFF: https://github.com/llvm/llvm-project/commit/48bb5f4cbe8d5951c1153e469dc6713a122b7fa3.d

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

steakhal added a comment. In D110927#3118936 , @ASDenysPetrov wrote: >> You could have a parameter, and take its address to accomplish your >> reinterpret casts and type puns. > > Do you mean: ... > If so, IMO it doesn't matter. I see. Sorry about the

[PATCH] D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension

stuij updated this revision to Diff 386195. stuij added a comment. addressing review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112431/new/ https://reviews.llvm.org/D112431 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Basic/Targ

[PATCH] D112645: [OpenMP] Fix: opposite attributes could be set by -fno-inline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4860f6cb25bd: [OpenMP] Fix: opposite attributes could be set by -fno-inline (authored by igor.kirillov). Repository: rG LLVM Github Monorepo CHAN

[clang] 4860f6c - [OpenMP] Fix: opposite attributes could be set by -fno-inline

Author: Igor Kirillov Date: 2021-11-10T16:48:09Z New Revision: 4860f6cb25bd20b0fc2f20403602526df650d7ed URL: https://github.com/llvm/llvm-project/commit/4860f6cb25bd20b0fc2f20403602526df650d7ed DIFF: https://github.com/llvm/llvm-project/commit/4860f6cb25bd20b0fc2f20403602526df650d7ed.diff LOG:

[PATCH] D112492: [CUDA][HIP] Allow comdat for kernels

yaxunl added a comment. I did an experiment regarding the ICF issue and it seems not to affect kernel stub. #include "hip/hip_runtime.h" template void bar(T x) { } template __global__ void foo(T x) {} int main() { foo<<<1,1>>>(1); printf("%p\n", foo); printf("%p\

[PATCH] D112914: Misleading identifier detection

RKSimon added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-misleading-identifier.cpp:3 + +#include + @serge-sans-paille Any chance you can remove the include and just forward declare printf()? Repository: rG LLVM Github Mono

[PATCH] D112914: Misleading identifier detection

RKSimon added a comment. @serge-sans-paille Still failing on https://lab.llvm.org/buildbot/#/builders/139/builds/12974 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914

[PATCH] D113517: Correct handling of the 'throw()' exception specifier in C++17.

Quuxplusone added a comment. Peanut gallery says: It seems like `Proto->canThrow()` is already returning the correct answer for C++17-and-later: a function declared `throw()` cannot throw. So from the POV of C++17-and-later, this could be a simple patch: - if (isNoexceptExceptionSpec(EST) &&

[PATCH] D113570: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a2b1bdb4c8a: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113

[clang] 7a2b1bd - [clang] Do not crash in APValue::prettyPrint() on forward-decl structs.

Author: Adam Czachorowski Date: 2021-11-10T17:17:00+01:00 New Revision: 7a2b1bdb4c8a099ebc38b7f802988244ad21fcc0 URL: https://github.com/llvm/llvm-project/commit/7a2b1bdb4c8a099ebc38b7f802988244ad21fcc0 DIFF: https://github.com/llvm/llvm-project/commit/7a2b1bdb4c8a099ebc38b7f802988244ad21fcc0.d

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl added a comment. @eugenis Any further changes needed? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111443/new/ https://reviews.llvm.org/D111443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D113299: [NFC] Inclusive Language: change master to main for .chm files

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3b15b71ce00: [NFC] Inclusive Language: change master to main for .chm files (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113299/new/

[PATCH] D113256: [AArch64][ARM] Enablement of Cortex-A710 Support

mubashar_ updated this revision to Diff 386165. mubashar_ marked 5 inline comments as done. mubashar_ added a comment. Placement of Cortex-A710 items changed to order specified by previous comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113256/new/ https://reviews.llvm.org/D1132

[PATCH] D113570: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113570/new/ https://reviews.llvm.org/D113570

[PATCH] D113517: Correct handling of the 'throw()' exception specifier in C++17.

jyknight added a comment. In D113517#3120030 , @rsmith wrote: > What's the motivation for this change? I believe the current behavior is > still conforming: `set_unexpected` is no longer (officially) part of the > standard library (though it still exist

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27177b82d4ca: [OpenMP] Lower printf to __llvm_omp_vprintf (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 27177b8 - [OpenMP] Lower printf to __llvm_omp_vprintf

Author: Jon Chesterfield Date: 2021-11-10T15:30:56Z New Revision: 27177b82d4ca4451f288168fc1e06c0736afbdaf URL: https://github.com/llvm/llvm-project/commit/27177b82d4ca4451f288168fc1e06c0736afbdaf DIFF: https://github.com/llvm/llvm-project/commit/27177b82d4ca4451f288168fc1e06c0736afbdaf.diff L

[PATCH] D113570: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs.

adamcz created this revision. adamcz added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. The call to getTypeSizeInChars() is replaced wi

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 386156. JonChesterfield added a comment. - regen test file using the better './llvm/utils/update_cc_test_checks.py --llvm-bin=/home/amd/llvm-install/bin clang/test/OpenMP/nvptx_target_printf_codegen.c', now passing Repository: rG LLVM Github Mono

[PATCH] D112492: [CUDA][HIP] Allow comdat for kernels

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4290-4293 - // Do not set COMDAT attribute for CUDA/HIP stub functions to prevent - // them being "merged" by the COMDAT Folding linker optimization. - if (D.hasAttr()) -return false; ---

[PATCH] D112915: [clang][modules] Track number of includes per submodule

jansvoboda11 updated this revision to Diff 386139. jansvoboda11 added a comment. Store only direct includes in the PCM (compared to transitive stored previously), use InputFile ID (instead of full filesystem path). Also: add test of transitive includes, fix bug in `VisibleModuleSet::setVisible`

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

arsenm updated this revision to Diff 386137. arsenm added a comment. Also test non-kernel CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113538/new/ https://reviews.llvm.org/D113538 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/OpenMP/amd

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

arsenm added a comment. In D113538#3121062 , @JonChesterfield wrote: > That seems important. What was the symptom of failing to set these? We may > now be redundantly setting some, e.g. > I think convergent is set somewhere else before this patch. A b

[clang] 4fb0805 - [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

Author: Vassil Vassilev Date: 2021-11-10T12:52:05Z New Revision: 4fb0805c6525b13e50067b9ddfe8677a0b7b2d7c URL: https://github.com/llvm/llvm-project/commit/4fb0805c6525b13e50067b9ddfe8677a0b7b2d7c DIFF: https://github.com/llvm/llvm-project/commit/4fb0805c6525b13e50067b9ddfe8677a0b7b2d7c.diff LO

  1   2   >