eugenis added inline comments.
================
Comment at: clang/lib/Driver/ToolChain.cpp:124
+ }
+ return SanitizerArgs(*this, JobArgs, /*DiagnoseErrors=*/false);
}
----------------
SanitizerArgs SanArgs(*this, JobArgs, !SanitizerArgsChecked);
SanitizerArgsChecked = true;
return SanArgs;
================
Comment at: clang/lib/Driver/ToolChains/FreeBSD.cpp:471
+bool FreeBSD::isPIEDefault(const llvm::opt::ArgList &Args) const {
+ return getSanitizerArgs(Args).requiresPIE();
+}
----------------
it looks like we do a lot of sanitizerargs recomputing. Is it worth it to try
and cache it?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111443/new/
https://reviews.llvm.org/D111443
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
