[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

ibookstein added a comment. Thanks; Might I ask that you commit this on my behalf? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113352/new/ https://reviews.llvm.org/D113352 ___ cfe-commits mailing li

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

RedDocMD added a comment. The issues highlighted here have been partially (one could argue mostly) solved by D105821 . That patch hasn't been merged because it needs more tests and also needs to be split. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parentheses, if is are one. + You meant "if there is o

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5016 llvm::Constant *Resolver = - GetOrCreateLLVMFunction(IFA->getResolver(), ResolverTy, GD, + GetOrCre

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

ibookstein added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5016 llvm::Constant *Resolver = - GetOrCreateLLVMFunction(IFA->getResolver(), ResolverTy, GD, + GetOrCreateLLVMFunction(IFA->getResolver(), ResolverTy, {},

[PATCH] D113168: [clang-tblgen] Fix non-determinism in generating AttrSubMatchRulesParserStringSwitches.inc

ikudrin added a comment. We've noticed binary differences in `clang` in several builds on our local build bots, and the patch fixed that. As for generating the documentation, the issue can be seen, for example, in Clang-12

LLVM build master will be restarted soon

Hello, LLVM build master will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5016 llvm::Constant *Resolver = - GetOrCreateLLVMFunction(IFA->getResolver(), ResolverTy, GD, + GetOrCreateLLVMFunction(IFA->getResolver(), ResolverTy, {},

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

FreddyYe added a comment. In D112777#3114566 , @craig.topper wrote: > In D112777#3114560 , @FreddyYe > wrote: > >> In D112777#3114502 , @craig.topper >> wrote: >> >>> N

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

craig.topper added a comment. In D112777#3114560 , @FreddyYe wrote: > In D112777#3114502 , @craig.topper > wrote: > >> Not directly related to this patch, but why is the suffix _pch and _sch when >> the instruct

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

FreddyYe added a comment. Thx for review. I found I missed many intrinsics, including _fcmul_* series. they need to be aliased with cmul_*. pls wait for update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://reviews.llvm.org/D11

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

FreddyYe added a comment. In D112777#3114502 , @craig.topper wrote: > Not directly related to this patch, but why is the suffix _pch and _sch when > the instruction names end in CPH and CSH? It kind of seems like the correct > intrinsic name would have

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

craig.topper added a comment. Not directly related to this patch, but why is the suffix _pch and _sch when the instruction names end in CPH and CSH? Why does the name here need to be aligned with mul_ps/pd? This a "complex" multiply which is a different operation. Is gcc also going to add alias

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

pengfei added a comment. Also missing *_sch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://reviews.llvm.org/D112777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

pengfei added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:3174 + #define _mm512_fmul_round_pch(A, B, R) \ ((__m512h)__builtin_ia32_vfmulcph512_mask( \ Missing th

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

FreddyYe added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://reviews.llvm.org/D112777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

hliao updated this revision to Diff 385378. hliao added a comment. Rebase and ping for further review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112041/new/ https://reviews.llvm.org/D112041 Files: clang/test/CodeGen/thinlto-distributed-newpm

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

MaskRay updated this revision to Diff 385375. MaskRay added a comment. add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://reviews.llvm.org/D113372 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

MaskRay created this revision. MaskRay added reviewers: foutrelis, manojgupta, sylvestre.ledru, thesamesam, tstellar. Herald added a subscriber: mgorny. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 2015-05, GCC added the conf

[PATCH] D113370: [Driver] Change Linux::isPIEDefault to true for all Android versions

MaskRay created this revision. MaskRay added reviewers: danalbert, srhines. Herald added a subscriber: danielkiss. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently any API level>=16 uses default PIE. If API level<16 is too

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, crayroud. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We can now

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

HazardyKnusperkeks added a comment. In D110833#3111632 , @crayroud wrote: > I do not have commit access, could you please help with the push? > > Here are the commit details: C. Rayroud - rayro...@gmail.com Will push it on tuesday, if no one objects. I a

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

ibookstein marked an inline comment as done. ibookstein added a comment. In D113352#3114009 , @dblaikie wrote: > I guess CodeGenOpts::VerifyModule is on by default, but I'll admit that > surprises me - for API-built modules, I figured it was expected the

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

ibookstein updated this revision to Diff 385361. ibookstein edited the summary of this revision. ibookstein added a comment. Herald added subscribers: steven_wu, hiraditya. - Fixed PR comment about documentation - Amended clang/test/CodeGen/lto-newpm-pipeline.c to reflect change - Fixed small bug

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

lhames added a comment. I've chatted about this with Joerg on a side thread and wanted to summarize my understanding of the situation. The problem is that we have incompatible behaviors for `__register_frame` and `__deregister_frame` between unwinders: - libgcc_s and the FreeBSD port of libunw

[clang] eb1c7c1 - [AST, Analysis] Use llvm::reverse (NFC)

Author: Kazu Hirata Date: 2021-11-07T09:53:14-08:00 New Revision: eb1c7c13390105f8b84c7ec85bd222a56e57a480 URL: https://github.com/llvm/llvm-project/commit/eb1c7c13390105f8b84c7ec85bd222a56e57a480 DIFF: https://github.com/llvm/llvm-project/commit/eb1c7c13390105f8b84c7ec85bd222a56e57a480.diff L

[PATCH] D113256: [AArch64][ARM] Enablement of Cortex-A710 Support

dmgreen added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:159-160 AArch64::AEK_RCPC | AArch64::AEK_SSBS)) +AARCH64_CPU_NAME("cortex-a710", ARMV9A, FK_NEON_FP_ARMV8, false, + (AArch64::AEK_MTE | AArch64::AEK_PAU

[clang] 2e20ff8 - [AVR] Remove a global initializer. NFCI.

Author: Benjamin Kramer Date: 2021-11-07T16:30:18+01:00 New Revision: 2e20ff8c1ab42ccfe102589114587008b411397f URL: https://github.com/llvm/llvm-project/commit/2e20ff8c1ab42ccfe102589114587008b411397f DIFF: https://github.com/llvm/llvm-project/commit/2e20ff8c1ab42ccfe102589114587008b411397f.dif

[PATCH] D113186: [NFC] Inclusive language: Remove instances of master in URLs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc71fbdd87b35: [NFC] Inclusive language: Remove instances of master in URLs (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D113299: [NFC] Inclusive Language: change master to main for .chm files

quinnp created this revision. Herald added a reviewer: bollu. Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, r

[clang] 8adb6d6 - [clang] Use llvm::reverse. NFCI.

Author: Benjamin Kramer Date: 2021-11-07T14:24:33+01:00 New Revision: 8adb6d6de29b67dd0df1016083392a1b2eb1d49a URL: https://github.com/llvm/llvm-project/commit/8adb6d6de29b67dd0df1016083392a1b2eb1d49a DIFF: https://github.com/llvm/llvm-project/commit/8adb6d6de29b67dd0df1016083392a1b2eb1d49a.dif

[PATCH] D113320: [clang-format] Address fixme

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113320/new/ https://reviews.llvm.org/D113320 ___ cfe-commits mailing list cfe-com

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

eopXD updated this revision to Diff 385329. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109215/new/ https://reviews.llvm.org/D109215 Files: clang/test/Driver/riscv-arch.c llvm/lib/Support/RISCVISAInfo.cpp Ind