ibookstein marked an inline comment as done. ibookstein added a comment. In D113352#3114009 <https://reviews.llvm.org/D113352#3114009>, @dblaikie wrote:
> I guess CodeGenOpts::VerifyModule is on by default, but I'll admit that > surprises me - for API-built modules, I figured it was expected they were > valid by construction (ie: like an assertion - it's a bug in clang if the > resulting module isn't valid - so we wouldn't want to validate that invariant > on every user's compilation, etc) - so I'd expect we should have to opt-in to > verifying on output. (verifying on /input/ would be always done - because the > input is untrusted) I agree that it is a bit surprising. It might make sense to change the default and make the clang llvm-lit tool substitutions opt-in. However, it is a somewhat useful default when considered in its position as the entry into the codegen pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113352/new/ https://reviews.llvm.org/D113352 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
