[PATCH] D108882: Add backward compatibility tests for PackConstructorInitializers

owenpan updated this revision to Diff 369308. owenpan added a comment. Reworked the logic for handling the backward compatibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108882/new/ https://reviews.llvm.org/D108882 Files: clang/lib/Format/Format.cpp clang/unittests/Format/Fo

[PATCH] D108886: Add RISC-V sifive-s51 cpu

apivovarov created this revision. apivovarov added reviewers: evandro, kito-cheng, khchen. Herald added subscribers: vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD,

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

rjmccall added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1975 + bool AlignAttrCanDecreaseAlignment = + AlignIsRequired && (Ty->getAs() != nullptr || FieldPacked); + stevewan wrote: > rjmccall wrote: > > stevewan wrote: > > > rjmccal

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

rjmccall added a comment. Thanks, this looks a lot cleaner. Minor requests only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 ___ cfe-commits mailing list c

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369293. stevewan added a comment. Adapt to new TypeInfo design Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST/

[PATCH] D108858: TypeInfo records more information about align requirement

This revision was automatically updated to reflect the committed changes. Closed by commit rG73733ae526a5: TypeInfo records more information about align requirement (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108858/new/ ht

[clang] 73733ae - TypeInfo records more information about align requirement

Author: Steven Wan Date: 2021-08-28T19:47:48-04:00 New Revision: 73733ae526a5152e5427973ac12dc54f7dd243fb URL: https://github.com/llvm/llvm-project/commit/73733ae526a5152e5427973ac12dc54f7dd243fb DIFF: https://github.com/llvm/llvm-project/commit/73733ae526a5152e5427973ac12dc54f7dd243fb.diff LO

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:18472 + FormatStyle::PCIS_Never); + Style.EmptyLineBeforeAccessModifier = FormatStyle::ELBAMS_LogicalBlock; owenpan wrote: >

[PATCH] D108882: Add backward compatibility tests for PackConstructorInitializers

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://review

[PATCH] D108881: [clang][driver] Honor the last -flto= flag even if an earlier -flto is present

mnadeem added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4495-4497 +Arg *A = Args.getLastArg(options::OPT_flto, options::OPT_flto_EQ); +if (A && A->getOption().matches(options::OPT_flto)) CmdArgs.push_back("-flto"); -

[PATCH] D108881: [clang][driver] Honor the last -flto= flag even if an earlier -flto is present

mnadeem created this revision. mnadeem added a project: clang. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. mnadeem requested review of this revision. Herald added a subscriber: cfe-commits. After D102479 `-flto=` options the end of the com

[PATCH] D108858: TypeInfo records more information about align requirement

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108858/new/ https://reviews.llvm.org/D108858 ___

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

nridge added a comment. Thanks for the updates! LGTM from my side. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:555 + // Iterate over the types of the function parameters. + // If any of them are non-const reference paramteres, add it as a + // h

[PATCH] D108858: TypeInfo records more information about align requirement

stevewan updated this revision to Diff 369258. stevewan added a comment. Add RequiredByEnum case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108858/new/ https://reviews.llvm.org/D108858 Files: clang/include/clang/AST/ASTContext.h clang/lib/A

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

mgartmann added a comment. @aaron.ballman Thanks a lot for your review! Can somebody help me merging this change? I do not have the rights to do so. Thanks in advanve! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102325/new/ https://reviews.llvm.

[PATCH] D108742: [WIP] Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin added a comment. In D108742#2970302 , @rsmith wrote: > In D108742#2970283 , @cor3ntin > wrote: > >>> Drive-by observation: under P2348 , Clang's >>> behavior of treating

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

tom-anders updated this revision to Diff 369249. tom-anders marked an inline comment as done. tom-anders added a comment. - Use llvm::SmallVector, add more FIXME, remove old commented out test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108320/new

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

tom-anders marked 5 inline comments as done. tom-anders added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:470 std::vector Tokens; + std::map> ExtraModifiers; const HeuristicResolver *Resolver; nridge wrote: > Looking at e

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

HazardyKnusperkeks added inline comments. Comment at: clang/docs/tools/dump_format_style.py:23 + plurals = { +'IncludeCategory': 'IncludeCategories' + } FederAndInk wrote: > HazardyKnusperkeks wrote: > > Could you not just check if there is a y at the end a