[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

yonghong-song created this revision. yonghong-song added a reviewer: rsmith. Herald added a subscriber: dexonsmith. yonghong-song requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Paul Chaignon reported a bpf verifier failur

[PATCH] D98061: [InstrProfiling] Generate runtime hook for Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG389dc94d4be7: [InstrProfiling] Generate runtime hook for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D98061?vs

[clang] 389dc94 - [InstrProfiling] Generate runtime hook for Fuchsia

Author: Petr Hosek Date: 2021-08-10T23:21:15-07:00 New Revision: 389dc94d4be7a75c243528981a25260c1c7a6103 URL: https://github.com/llvm/llvm-project/commit/389dc94d4be7a75c243528981a25260c1c7a6103 DIFF: https://github.com/llvm/llvm-project/commit/389dc94d4be7a75c243528981a25260c1c7a6103.diff LO

[PATCH] D107873: [WIP][clang-tidy] adds a const-qualified parameter check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/ConstParameterValueOrRef.cpp:57 +namespace { +bool isSharedPtr(const QualType &T) { + if (auto R = T->getAsCXXRecordDecl()) Please use `static`, not anonymous namespace f

[PATCH] D107876: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for-profiling together

wenlei added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3896 - // These two forms of profiling info can't be used together. - if (const Arg *A1 = Args.getLastArg(options::OPT_fpseudo_probe_for_profiling)) -if (const Arg *A2 = Args.getLastArg(option

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107668/new/ https://reviews.llvm.org/D107668 ___

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 365651. 0x8000- added a comment. Clean diff against origin/main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-tools-extra/cl

[PATCH] D107850: [WIP][asan] Implemented custom calling convention similar used by HWASan for X86. The feature should be code complete. The tests are coming in a later revision.

kstoimenov updated this revision to Diff 365650. kstoimenov added a comment. Fixed the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: clang/test/CodeGen/asan-use-callbacks.cpp llvm/inclu

[PATCH] D107528: [llvm][clang][NFC] updates inline licence info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. cjdb marked 3 inline comments as done. Closed by commit rGc874dd53628d: [llvm][clang][NFC] updates inline licence info (authored by cjdb). Changed prior to commit: h

[clang] c874dd5 - [llvm][clang][NFC] updates inline licence info

Author: Christopher Di Bella Date: 2021-08-11T02:48:53Z New Revision: c874dd53628db8170d4c5ba3878817abc385a695 URL: https://github.com/llvm/llvm-project/commit/c874dd53628db8170d4c5ba3878817abc385a695 DIFF: https://github.com/llvm/llvm-project/commit/c874dd53628db8170d4c5ba3878817abc385a695.dif

[clang-tools-extra] c874dd5 - [llvm][clang][NFC] updates inline licence info

Author: Christopher Di Bella Date: 2021-08-11T02:48:53Z New Revision: c874dd53628db8170d4c5ba3878817abc385a695 URL: https://github.com/llvm/llvm-project/commit/c874dd53628db8170d4c5ba3878817abc385a695 DIFF: https://github.com/llvm/llvm-project/commit/c874dd53628db8170d4c5ba3878817abc385a695.dif

[PATCH] D107528: [llvm][clang][NFC] updates inline licence info

cjdb updated this revision to Diff 365648. cjdb added a comment. uploading solely for a fast visual inspection on the diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107528/new/ https://reviews.llvm.org/D107528 Files: clang-tools-extra/clang-

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:186-188 + [FeatureExtZpsfoperand, +FeatureExtZpn, +FeatureExtZprvsfextra]>; Jim wrote: > jrtc27 wrote: > > These aren't

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added a comment. Hi @jrtc27, any further feedback? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D107876: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for-profiling together

hoy created this revision. Herald added subscribers: modimo, wenlei. hoy requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Previoulsy debug-info-for-profiling and pseudo-probe-for-profiling are mutual exclusive because they

[PATCH] D107843: [X86] Add parentheses around casts in some of the X86 intrinsic headers.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. Thanks Craig. I haven't find time to work on it. I think this is a good start. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107843/new/

[PATCH] D98061: [InstrProfiling] Generate runtime hook for Fuchsia

phosek updated this revision to Diff 365635. phosek retitled this revision from "[InstrProfiling] Generate runtime hook for ELF platforms" to "[InstrProfiling] Generate runtime hook for Fuchsia". phosek edited the summary of this revision. phosek added a comment. I have reworked the change and re

[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:15962 if (Depth > 0) { +SDValue FrameAddr = Please add a comment: ``` // The link register (return address) is saved in the caller's frame // not the callee's stack f

[PATCH] D107873: [WIP][clang-tidy] adds a const-qualified parameter check

cjdb added a comment. Those CI failures are kinda embarrassing. Is there any way to leverage clang-format in a case like this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107873/new/ https://reviews.llvm.org/D107873

[PATCH] D107873: [WIP][clang-tidy] adds a const-qualified parameter check

cjdb added a comment. Work left to do in this patch: add user options. Figured getting a non-config version up for review first would be a good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107873/new/ https://reviews.llvm.org/D107873 _

[PATCH] D107873: [WIP][clang-tidy] adds a const-qualified parameter check

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added subscribers: xazax.hun, mgorny. cjdb requested review of this revision. Herald added projects: LLVM, clang-tools-extra. Herald added subscribers: cfe-commits, llvm-commits. Checks ``const``-qualified parameters to deter

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens in declarations

cjdb added a comment. Ping @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107292/new/ https://reviews.llvm.org/D107292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

cjdb added a comment. Ping @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107294/new/ https://reviews.llvm.org/D107294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D106550: [PowerPC] Allow MMA built-ins to accept restrict qualified pointers

nemanjai requested changes to this revision. nemanjai added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaChecking.cpp:7329 +// and false if it is not valid. +auto IsValidType = [ArgType, ExpectedType]() { + if (Expect

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 365622. 0x8000- added a comment. Rebased on main and renamed from readability-variable-length to readability-identifier-length. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 Files: clang-tools-e

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

bnbarham updated this revision to Diff 365619. bnbarham added a comment. Removed the now unused UsesFoo.framework in the tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107690/new/ https://reviews.llvm.org/D107690 Files: clang/lib/Serializat

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

bnbarham added inline comments. Comment at: clang/test/VFS/umbrella-mismatch.m:4 - -// RUN: %clang_cc1 -Werror -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -ivfsoverlay %t.yaml -F %S/Inputs -fsyntax-only %s -Wno-atimport-in-framework-header -verify -// RUN: %clang_c

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:136 +CheckFactories.registerCheck( +"readability-variable-length"); } aaron.ballman wrote: > 0x8000- wrote: > > aaron.ballman wro

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 __

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107138/new/ https://reviews.llvm.org/D107138 __

[PATCH] D107850: [WIP][asan] Implemented custom calling convention similar used by HWASan for X86. The feature should be code complete. The tests are coming in a later revision.

kstoimenov updated this revision to Diff 365608. kstoimenov added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added an IR test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGd39ebdae674c: [analyzer] Cleanup a FIXME in SValBuilder.cpp (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] d39ebda - [analyzer] Cleanup a FIXME in SValBuilder.cpp

Author: Vince Bridgers Date: 2021-08-10T16:12:52-05:00 New Revision: d39ebdae674c8efc84ebe8dc32716ec353220530 URL: https://github.com/llvm/llvm-project/commit/d39ebdae674c8efc84ebe8dc32716ec353220530 DIFF: https://github.com/llvm/llvm-project/commit/d39ebdae674c8efc84ebe8dc32716ec353220530.diff

[clang-tools-extra] 0cecb42 - [Sema] Include full range of the switch condition in -Wswitch diagnostic

Author: Sam McCall Date: 2021-08-10T22:50:40+02:00 New Revision: 0cecb42e4e13e1ce55a3568958ad104bbe6b6d6e URL: https://github.com/llvm/llvm-project/commit/0cecb42e4e13e1ce55a3568958ad104bbe6b6d6e DIFF: https://github.com/llvm/llvm-project/commit/0cecb42e4e13e1ce55a3568958ad104bbe6b6d6e.diff LO

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

sammccall updated this revision to Diff 365601. sammccall added a comment. Oops, I'm just bad at git. Here's the test file! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107703/new/ https://reviews.llvm.org/D107703 Files: clang-tools-extra/clang

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

Conanap updated this revision to Diff 365596. Conanap added a comment. Removed unintended change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107138/new/ https://reviews.llvm.org/D107138 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/CodeG

[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

NeHuang updated this revision to Diff 365470. NeHuang added a comment. Address review comments on the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107646/new/ https://reviews.llvm.org/D107646 Files: llvm/lib/Target/PowerPC/PPCISelLow

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4390 + auto AddCompletions = [&](const ParsedAttrInfo &A) { +if (A.IsTargetSpecific && !A.existsInTarget(Context.getTargetInfo())) + return; aaron.ballman wrote: > Should w

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

vsapsai added a comment. Made the first review pass and `return Failure` makes sense to me as recovery isn't the best idea at this point. Still want to check more thoroughly if the removed code for `SUBMODULE_UMBRELLA_HEADER` and `SUBMODULE_UMBRELLA_DIR` has any load-bearing side-effects. Have

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Awesome, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 _

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

sammccall updated this revision to Diff 365585. sammccall added a comment. Oops, forgot test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107703/new/ https://reviews.llvm.org/D107703 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-

[PATCH] D107843: [X86] Add parentheses around casts in some of the X86 intrinsic headers.

spatel added a comment. Hard to see through all of the lint noise, but seems like a mechanical fix. Can we add a test like the one in the bug report? https://godbolt.org/z/sPT8e9vx9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107843/new/ https://

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers updated this revision to Diff 365582. vabridgers added a comment. only need the one test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.

[PATCH] D107791: [InlineAdvisor] Add single quotes around caller/callee names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76093b17394a: [InlineAdvisor] Add single quotes around caller/callee names (authored by MaskRay). Herald added a subscriber: emaste. Changed prior t

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

aaron.ballman added inline comments. Comment at: clang/unittests/AST/CMakeLists.txt:18 ASTVectorTest.cpp + AttrTest.cpp CommentLexer.cpp I don't think this new file got attached to the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D107647: [PowerPC] MMA - Remove deprecated built-ins and add new built-ins

nemanjai added a comment. In D107647#2937706 , @lei wrote: > Actually we should not be removing the deprecated bultins. Just need to add > the new ones. Yes, and also the semantics are different. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D107647: [PowerPC] MMA - Remove deprecated built-ins and add new built-ins

lei requested changes to this revision. lei added a comment. This revision now requires changes to proceed. Actually we should not be removing the deprecated bultins. Just need to add the new ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107

[PATCH] D107841: CodeGen: No need to check for isExternC if HasStrictReturn is already false

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107841/new/ https://reviews.llvm.org/D107841 ___

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rjmccall added a comment. It's not generically true that "anything can be tail-called if it's `noreturn`". For one, `noreturn` doesn't imply that the function doesn't exit by e.g. throwing or calling `longjmp`. For another, the most important user expectation of tail calls is that a long seri

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers updated this revision to Diff 365546. vabridgers added a comment. add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp clang/te

[libunwind] 08a5ac3 - libunwind: add missing break statements in EHABI

Author: Saleem Abdulrasool Date: 2021-08-10T17:53:31Z New Revision: 08a5ac36b956edeb989b4a65269a829eac26a5a2 URL: https://github.com/llvm/llvm-project/commit/08a5ac36b956edeb989b4a65269a829eac26a5a2 DIFF: https://github.com/llvm/llvm-project/commit/08a5ac36b956edeb989b4a65269a829eac26a5a2.diff

[clang] e2ff880 - [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs

Author: Leonard Chan Date: 2021-08-10T10:52:24-07:00 New Revision: e2ff880a7ed464f0649c47132603562312fff102 URL: https://github.com/llvm/llvm-project/commit/e2ff880a7ed464f0649c47132603562312fff102 DIFF: https://github.com/llvm/llvm-project/commit/e2ff880a7ed464f0649c47132603562312fff102.diff

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:628 + AI, Kind, + Remark << "A hardware CAS loop generated: if the memory is " +"known to be coarse-grain allocated then a hardware " Still the

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

ellis added a comment. @aprantl @dblaikie Can I get a review soon to avoid merge conflicts on these tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107024/new/ https://reviews.llvm.org/D107024 ___

[PATCH] D107843: [X86] Add parentheses around casts in some of the X86 intrinsic headers.

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel, pengfei. craig.topper requested review of this revision. Herald added a project: clang. This covers the SSE and AVX/AVX2 headers. AVX512 has a lot more macros due to rounding mode. Fixes part of PR51324. Reposito

[PATCH] D107825: [AIX] Define __HOS_AIX__ macro only for AIX target

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b39fa3e2815: [AIX] Define __HOS_AIX__ macro only for AIX target (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107825/new/ https://

[clang] 3b39fa3 - [AIX] Define __HOS_AIX__ macro only for AIX target

Author: Jake Egan Date: 2021-08-10T13:03:17-04:00 New Revision: 3b39fa3e2815538187ed8928549a9f27c6a71ef6 URL: https://github.com/llvm/llvm-project/commit/3b39fa3e2815538187ed8928549a9f27c6a71ef6 DIFF: https://github.com/llvm/llvm-project/commit/3b39fa3e2815538187ed8928549a9f27c6a71ef6.diff LOG

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 added a comment. @rampitec comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 365522. gandhi21299 added a comment. - restricting remarks emission on AMDGPU targets only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: clang/test/Cod

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365507. gAlfonso-bit added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLL

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 365519. MyDeveloperDay added a comment. - Rename the ConstFixer to QualifierAligmentFixer (as now we handle more than just const) and in preparation for handling others CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews

[clang-tools-extra] 1fdb3e3 - abseil-string-find-str-contains should not propose an edit for the three-parameter version of find().

Author: Tom Lokovic Date: 2021-08-10T16:39:17Z New Revision: 1fdb3e36ff379e5b3b05a00d49b6081435df727a URL: https://github.com/llvm/llvm-project/commit/1fdb3e36ff379e5b3b05a00d49b6081435df727a DIFF: https://github.com/llvm/llvm-project/commit/1fdb3e36ff379e5b3b05a00d49b6081435df727a.diff LOG: a

[PATCH] D107647: [PowerPC] MMA - Remove deprecated built-ins and add new built-ins

lei added a comment. LGTM Can we update the title and description to be more specific though? [PowerPC] MMA - Rename deprecated builtins mma_assemble_acc, vsx_assemble_pair Rename deprecated builtins : __builtin_mma_assemble_acc __builtin_vsx_assemble_pair To: __builtin_mma_b

[PATCH] D107837: abseil-string-find-str-contains should not propose an edit for the three-parameter version of find().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fdb3e36ff37: abseil-string-find-str-contains should not propose an edit for the three… (authored by tdl-g, committed by ymandel). Repository: rG

[PATCH] D107841: CodeGen: No need to check for isExternC if HasStrictReturn is already false

aschwaighofer created this revision. aschwaighofer added a reviewer: rjmccall. aschwaighofer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. NFC intended. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107841 Files: c

[clang] 497b57a - revert test commit

Author: Denys Petrov Date: 2021-08-10T19:19:27+03:00 New Revision: 497b57ad0b9ee34aeb8c56e9f47332912b50d58c URL: https://github.com/llvm/llvm-project/commit/497b57ad0b9ee34aeb8c56e9f47332912b50d58c DIFF: https://github.com/llvm/llvm-project/commit/497b57ad0b9ee34aeb8c56e9f47332912b50d58c.diff

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4390 + auto AddCompletions = [&](const ParsedAttrInfo &A) { +if (A.IsTargetSpecific && !A.existsInTarget(Context.getTargetInfo())) + return; Should we also early return

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:6964 +return DAG.getSetCC(DL, ResultVT, Op, DAG.getConstantFP(0.0, DL, OperandVT), +ISD::SETUO); + nemanjai wrote: > sepavloff wrote: > > ne

[PATCH] D106152: [analyzer] Move test case to existing test file and remove duplicated test file.

This revision was automatically updated to reflect the committed changes. Closed by commit rG497b1b95e606: [analyzer] Move test case to existing test file and remove duplicated test file. (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 365502. MyDeveloperDay added a comment. - Add CVQualifierOrder configuration validation and unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 365501. gAlfonso-bit added a comment. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp ==

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

sammccall updated this revision to Diff 365499. sammccall added a comment. add unit test for getDocumentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107703/new/ https://reviews.llvm.org/D107703 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

sammccall added a comment. In D107703#2937183 , @aaron.ballman wrote: > This generally LGTM but the only other thing I'm wondering is whether there > should be any clang-specific testing Makes sense. Here the "clang feature" is just the API, so I've ad

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

jhuber6 added a comment. In D107668#2937230 , @jdoerfert wrote: > Why the else? If this input isn't an OffloadingAction then it is a `.o` file which we already list as a temporary file. If it was an OffloadingAction then we have an extra device-specifi

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

jdoerfert added a comment. Why the else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107668/new/ https://reviews.llvm.org/D107668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D107837: abseil-string-find-str-contains should not propose an edit for the three-parameter version of find().

tdl-g created this revision. tdl-g added a reviewer: ymandel. tdl-g requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. std::string, std::string_view, and absl::string_view all have a three-parameter version of find() which has a "

[PATCH] D107836: [Attributes]: refactor to expose ParsedAttrInfo::acceptsLangOpts. NFC

sammccall created this revision. sammccall added a reviewer: aaron.ballman. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We will use this function to filter code completion of attributes. Repository: rG LLVM Github Monorepo

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. So does that mean this is ready to land? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This generally LGTM but the only other thing I'm wondering is whether there should be any clang-specific testing for this functionality. Right now, it relies on running the clang

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

sammccall updated this revision to Diff 365490. sammccall added a comment. Herald added subscribers: sstefan1, krytarowski. Herald added a reviewer: jdoerfert. Add support and tests for underscore-guarding. Add tests that omp attributes are not supported. Repository: rG LLVM Github Monorepo C

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz updated this revision to Diff 365487. beanz added a comment. Updated docs, added header-unsafe-macro diag group, and added test case to verify that the -Wpedantic-macros warnings don't trip on eachother. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

This revision was automatically updated to reflect the committed changes. Closed by commit rG638dcea010cf: [clang] Implement P0692R1 from C++20 (access checking on specializations and… (authored by aorlov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 638dcea - [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

Author: Alex Orlov Date: 2021-08-10T19:20:50+04:00 New Revision: 638dcea010cfc280f428d0cc13f4aa8578a1d69d URL: https://github.com/llvm/llvm-project/commit/638dcea010cfc280f428d0cc13f4aa8578a1d69d DIFF: https://github.com/llvm/llvm-project/commit/638dcea010cfc280f428d0cc13f4aa8578a1d69d.diff LO

[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

cebowleratibm added a comment. > Given that we have a legacy XL macro with no legacy cross compiler I think > it's fine if we set this according to the target only. It's fully redundant > to `_AIX ` but we'll define it for any working use-case with the current xlC > compiler. If IBM has a com

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-pwr9-warning.c:4 +// RUN: -verify %s + +extern unsigned long long ull; NeHuang wrote: > can we also add the run lines for 64 bit LE Linux, 64 bit AIX and 32 bit AIX? > Will also n

[PATCH] D107825: [AIX] Define __HOS_AIX__ macro only for AIX target

joerg accepted this revision. joerg added a comment. This revision is now accepted and ready to land. LGTM. Maybe include a small hint in the commit message that xlC never shipped cross-compiling support and the difference is therefore not observable anyway. Repository: rG LLVM Github Monorep

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei updated this revision to Diff 365480. lei marked 2 inline comments as done. lei added a comment. update sema check condition and remove duplicate tc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 Fil

[PATCH] D107095: Implement #pragma clang header_unsafe

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3916 +processed by the preprocessor after the ``#pragma`` annotation will log a +a warning. For example: + May want to put something in here along the lines of: Redefining the macr

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay added a comment. > In D69764#2936827 , > @HazardyKnusperkeks wrote: > >> First off, I think it should be configured in a different way, to prepare >> the path for also formatting static, inline, etc. I'm wondering if I'm gravitating more a

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay added a comment. In D69764#2936827 , @HazardyKnusperkeks wrote: > First off, I think it should be configured in a different way, to prepare the > path for also formatting static, inline, etc. To be honest I think if we wanted to do that w

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz added inline comments. Comment at: clang/test/Lexer/Inputs/unsafe-macro-2.h:23-26 +// not-expected-warning@+1{{macro 'UNSAFE_MACRO_2' has been marked as unsafe for use in headers}} +#undef UNSAFE_MACRO_2 +// not-expected-warning@+1{{macro 'UNSAFE_MACRO_2' has been marked a

[PATCH] D107095: Implement #pragma clang header_unsafe

aaron.ballman added inline comments. Comment at: clang/test/Lexer/Inputs/unsafe-macro-2.h:23-26 +// not-expected-warning@+1{{macro 'UNSAFE_MACRO_2' has been marked as unsafe for use in headers}} +#undef UNSAFE_MACRO_2 +// not-expected-warning@+1{{macro 'UNSAFE_MACRO_2' has been

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 365472. MyDeveloperDay added a comment. - elide the braces - use references CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rs

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

Quuxplusone added a comment. I'm not at all convinced that any of this complexity is worth it. Have you run this check on any large codebase to see how many false positives it has? Does it catch any true positives? Comment at: clang-tools-extra/test/clang-tidy/checkers/perfo

[PATCH] D107825: Define __HOS_AIX__ only for AIX target

Jake-Egan created this revision. Herald added subscribers: kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107825 Files: clang/lib/Basic/Target

[clang] 1397e19 - Set supported target for asan-use-callbacks test

Author: Thomas Preud'homme Date: 2021-08-10T15:01:44+01:00 New Revision: 1397e19129ef7aa6c2ba6f6018ff172a5022a1eb URL: https://github.com/llvm/llvm-project/commit/1397e19129ef7aa6c2ba6f6018ff172a5022a1eb DIFF: https://github.com/llvm/llvm-project/commit/1397e19129ef7aa6c2ba6f6018ff172a5022a1eb.

[PATCH] D107633: Set supported target for asan-use-callbacks test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1397e19129ef: Set supported target for asan-use-callbacks test (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D107633: Set supported target for asan-use-callbacks test

thopre updated this revision to Diff 365465. thopre added a comment. Remove REQUIRES Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107633/new/ https://reviews.llvm.org/D107633 Files: clang/test/CodeGen/asan-use-callbacks.cpp Index: clang/test/

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

sammccall added a comment. Herald added a project: clang-tools-extra. Whoops, lost this patch... In D97803#2602787 , @kbobyrev wrote: > So, if my understanding is correct, this will make the whole bundle > non-deprecated if at least one overload is not d

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz added inline comments. Comment at: clang/test/Lexer/Inputs/unsafe-macro-2.h:23-26 +// not-expected-warning@+1{{macro 'UNSAFE_MACRO_2' has been marked as unsafe for use in headers}} +#undef UNSAFE_MACRO_2 +// not-expected-warning@+1{{macro 'UNSAFE_MACRO_2' has been marked a

  1   2   >