bnbarham added inline comments.
================ Comment at: clang/test/VFS/umbrella-mismatch.m:4 - -// RUN: %clang_cc1 -Werror -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -ivfsoverlay %t.yaml -F %S/Inputs -fsyntax-only %s -Wno-atimport-in-framework-header -verify -// RUN: %clang_cc1 -Werror -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -F %S/Inputs -fsyntax-only %s -Wno-atimport-in-framework-header -verify ---------------- vsapsai wrote: > Are you deleting this test case because it is subsumed by > module-header-mismatches.m? > > Also if it makes sense to delete this test, need to do more cleanup because > UsesFoo.framework and Foo.framework seem to be used only from this test. > Though I'm not 100% sure. Yep, the check in this one is the same as the `header-frameworks`. `Foo.framework` is used by `subframework-symlink.m`. But `UsesFoo.framework` isn't used by anything else, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107690/new/ https://reviews.llvm.org/D107690 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
