[PATCH] D107325: [clang-tidy] Fix command line is too long issue which breaks test on Windows

dougpuob created this revision. Herald added a subscriber: xazax.hun. dougpuob requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Command line is too long with check_clang_tidy.py program on Windows, because the configuration is t

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

thakis added a comment. Any news here? This has been broken for over a day now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 ___ cfe-commits mailing list cfe-c

[PATCH] D43477: [CFG] [analyzer] Add MaterializeTemporaryExpr into the construction context.

lxfind added a comment. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, baloghadamsoftware. Hi! I have a question regarding the implementation of "VisitMaterializeTemporaryExpr". Specifically, I wonder if we should skip visiting

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77ebfba68b9a: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0. (authored by AMDChirag). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 77ebfba - [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

Author: Chirag Khandelwal Date: 2021-08-03T10:27:47+05:30 New Revision: 77ebfba68b9aa89e9ccbcdf8e285afa0661c8ca4 URL: https://github.com/llvm/llvm-project/commit/77ebfba68b9aa89e9ccbcdf8e285afa0661c8ca4 DIFF: https://github.com/llvm/llvm-project/commit/77ebfba68b9aa89e9ccbcdf8e285afa0661c8ca4.d

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 363625. AMDChirag added a comment. updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_print.cp

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 363624. AMDChirag added a comment. updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_print.cp

[PATCH] D107323: [clang-tidy] Add skip-headers; use skipLocation and setTraversalScope

chh created this revision. Herald added subscribers: kbarton, xazax.hun, nemanjai. chh requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. [clang-tidy] Add skip-headers; use skipLocation and setTraversalScope - This depends on http

[PATCH] D107141: [Inline-asm] Add semacheck for unsupported constraint

pengfei added a comment. > First I did not say "code doesn't make much sense to me". This is copy form > your description. Oop, my bad understanding. :) > both gcc and icc generated code is not making sense to you. Yes. Unless there's document to specify the behavior clearly. > So instead, yo

[PATCH] D107318: [OpenCL] allow generic address and non-generic defs for CL3.0

airlied added a subscriber: azabaznov. airlied added a comment. @azabaznov is this what you meant? I haven't tested this yet as my clang dev box died, but I'll get to it as soon as I can. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107318/new/ h

[PATCH] D107318: [OpenCL] allow generic address and non-generic defs for CL3.0

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. This allows both sets of definitions to exist on CL 3.0 Repository: rG LLVM Github Monorepo ht

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. In D104601#2919775 , @tstellar wrote: > Do we have all the issues fixed in trunk yet or do we need to revert in the > release/13.x branch. All known issues have been fixed on trunk. However, @alexfh said they are going to do

[PATCH] D107261: [clang] [MinGW] Let the last of -mconsole/-mwindows have effect

mati865 accepted this revision. mati865 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107261/new/ https://reviews.llvm.org/D107261 _

[PATCH] D105225: [clang] Add support for optional flag -fnew-infallible to restrict exception propagation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb40a2a533a9d: [clang] Add support for optional flag -fnew-infallible to restrict exception… (authored by modimo). Herald added a project: clang. Hera

[clang] b40a2a5 - [clang] Add support for optional flag -fnew-infallible to restrict exception propagation

Author: modimo Date: 2021-08-02T15:45:06-07:00 New Revision: b40a2a533a9dfb8dd5afb1f3b7d277da1e19f235 URL: https://github.com/llvm/llvm-project/commit/b40a2a533a9dfb8dd5afb1f3b7d277da1e19f235 DIFF: https://github.com/llvm/llvm-project/commit/b40a2a533a9dfb8dd5afb1f3b7d277da1e19f235.diff LOG: [

[PATCH] D107004: Turn off fp reassociation in IA intrinsic header files.

kbsmith1 abandoned this revision. kbsmith1 added a comment. Doesn't seem to have community support, abandoning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107004/new/ https://reviews.llvm.org/D107004

[PATCH] D106908: Improve UBSan documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG65e9d7efb090: Improve UBSan documentation (authored by hctim). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D106908?vs=362138&

[clang] 65e9d7e - Improve UBSan documentation

Author: Mitch Phillips Date: 2021-08-02T15:10:21-07:00 New Revision: 65e9d7efb090756e16bbb5ff929efbc795a8b0d4 URL: https://github.com/llvm/llvm-project/commit/65e9d7efb090756e16bbb5ff929efbc795a8b0d4 DIFF: https://github.com/llvm/llvm-project/commit/65e9d7efb090756e16bbb5ff929efbc795a8b0d4.diff

[PATCH] D107304: [clangd][query-driver] Extract GCC version from the driver output

ArcsinX added a comment. In D107304#2920960 , @joerg wrote: > What do you mean with "GCC macros are correct"? Imagine that we have a project and we build it with GCC, we have `compile_commands.json` file which contains all compile command used to build

[PATCH] D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag

lunasorcery updated this revision to Diff 363582. lunasorcery added a comment. How does this look? I've got a 'control' test to demonstrate the diagnostic as a child of ignored-qualifiers, as well as a test to demonstrate this diagnostic can be disabled in isolation. CHANGES SINCE LAST ACTION

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3816 + +def Error : Attr { + let Spellings = [GCC<"error">]; aaron.ballman wrote: > nickdesaulniers wrote: > > aaron.ballman wrote: > > > I think this should be an inheritable a

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:783 + else +Diags.Report(DiagID) << CalleeName << D.getMsgStr(); +} nickdesaulniers wrote: > aaron.ballman wrote: > > nickdesaulniers wrote: > > > aaron.ballman wrote: > >

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6026 +depend on optimizations, while providing diagnostics pointing to precise +locations of the call site in the source. + }]; aaron.ballman wrote: > nickdesaulnier

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers updated this revision to Diff 363581. nickdesaulniers marked 2 inline comments as done. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - reusing existing Diag/Notes, remove test comment, add test for indirect call Repository: rG LLVM Githu

[PATCH] D107304: [clangd][query-driver] Extract GCC version from the driver output

joerg added a comment. What do you mean with "GCC macros are correct"? Clang is *not* GCC 5 and not 1:1 compatible with GCC 5. Project that have checks like that should arrive in 2010... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107304/new/ h

[PATCH] D107312: [analyzer] Fix deprecated plistlib functions

manas created this revision. Herald added subscribers: steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: teemperor. manas requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

Quuxplusone added a comment. @dblaikie wrote: > Not a huge objection - but minor quandry: What's the motivation for this > patch? AIUI, this diagnostic is a PR stunt, similar to Clang's existing `-Wunicode-homoglyph`: test.cpp:3:13: warning: treating Unicode character as identifier charac

[PATCH] D106252: Make simple requirements starting with requires ill-formed in in requirement body

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. @cor3ntin: Sure, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106252/new/ https://reviews.llvm.org/D106252 ___

[PATCH] D106416: [analyzer] Fix build dependency issues for SATest

manas added a comment. Fixing another broken dependency packages error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106416/new/ https://reviews.llvm.org/D106416 ___ cfe-commits mailing list cfe-commits

[PATCH] D106416: [analyzer] Fix build dependency issues for SATest

manas updated this revision to Diff 363572. manas added a comment. upgrade cmake-3.21.0 to cmake-3.21.1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106416/new/ https://reviews.llvm.org/D106416 Files: clang/utils/analyzer/Dockerfile Index: cl

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.cpp:13 +namespace { +class CollectPragmaMarks : public clang::PPCallbacks { kadircet wrote: > can you nest this inside `clang::clangd` and drop the qualifiers ? Done, had to keep

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 363562. dgoldman marked 4 inline comments as done. dgoldman added a comment. More fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-to

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

cjdb added a subscriber: eric_niebler. cjdb added a comment. In D107292#2920774 , @dblaikie wrote: > In D107292#2920746 , @cjdb wrote: > >> In D107292#2920637 , @dblaikie

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

dblaikie added a comment. In D107292#2920746 , @cjdb wrote: > In D107292#2920637 , @dblaikie > wrote: > >> Not a huge objection - but minor quandry: What's the motivation for this >> patch? I don't know of any c

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

cjdb added a comment. In D107292#2920637 , @dblaikie wrote: > Not a huge objection - but minor quandry: What's the motivation for this > patch? I don't know of any codebase that encourages/uses the alternative > tokens and I wonder if adding more usabil

[PATCH] D107304: [clangd][query-driver] Extract GCC version from the driver output

ArcsinX created this revision. ArcsinX added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Clang uses 4.2.1 as a def

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz updated this revision to Diff 363550. beanz added a comment. Updates based on post-commit feedback from @lattner on D106732 . This should inline the determination for emitting warnings, but keep the actual warning emission in a call. Repository: rG LLV

[PATCH] D106864: [clang][cli] Expose -fno-cxx-modules in cc1

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106864/new/ https://reviews.llvm.org/D106864 ___ cfe-commits mailing list c

[PATCH] D106316: [clang][darwin] Add support for the -mtargetos= option to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf575f371822f: [clang][darwin] Add support for the -mtargetos= option to the driver (authored by arphaman). Herald added a project: clang. Repository

[clang] f575f37 - [clang][darwin] Add support for the -mtargetos= option to the driver

Author: Alex Lorenz Date: 2021-08-02T12:45:40-07:00 New Revision: f575f371822f6a07483b21701165492224a846bb URL: https://github.com/llvm/llvm-project/commit/f575f371822f6a07483b21701165492224a846bb DIFF: https://github.com/llvm/llvm-project/commit/f575f371822f6a07483b21701165492224a846bb.diff L

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

dblaikie added a comment. Not a huge objection - but minor quandry: What's the motivation for this patch? I don't know of any codebase that encourages/uses the alternative tokens and I wonder if adding more usability to them is a worthwhile investment in clang's codebase complexity, etc. Repo

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

cjdb added inline comments. Comment at: clang/test/Parser/warn-declare-references-with-symbols.cpp:2 +// RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify %s +// RUN: %clang_cc1 -std=c++20 -fsyntax-only -Wdeclare-references-with-symbols -verify %s + aaron.ballman

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

cjdb updated this revision to Diff 363546. cjdb marked 5 inline comments as done. cjdb edited the summary of this revision. cjdb added a comment. applies feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107292/new/ https://reviews.llvm.org/D1

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz added a reviewer: lattner. beanz added a subscriber: lattner. beanz added a comment. +@lattner, Chris provided some post-commit feedback on the macro deprecation patch, I'll address his feedback here since I'm touching the same code. Chris' feedback is: > /clang/lib/Lex/Preprocessor.cpp:

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 363542. AMDChirag added a comment. minor fix in test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_print.cp

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/new/ https://reviews.llvm.org/D105478

[PATCH] D107155: [clang][deps] Substitute clang-scan-deps executable in lit tests

dblaikie accepted this revision. dblaikie added a comment. Sounds good to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107155/new/ https://reviews.llvm.org/D107155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aeubanks added a comment. you can reopen the revision via "Add Action..." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 ___ cfe-commits mailing list cfe-commits

[PATCH] D107200: Stop emit incomplete type error for a variable in an omp map clause where should not.

jyu2 updated this revision to Diff 363538. jyu2 added a comment. Fix format problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107200/new/ https://reviews.llvm.org/D107200 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/distribute_f

[PATCH] D107141: [Inline-asm] Add semacheck for unsupported constraint

jyu2 added a comment. First I did not say "code doesn't make much sense to me". This is copy form your description. Okay, thank for explanation. So if I understand right, both gcc and icc generated code is not making sense to you. So instead, you want clang give error for this when output

[PATCH] D106252: Make simple requirements starting with requires ill-formed in in requirement body

cor3ntin added a comment. @Quuxplusone Are you happy with the fix? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106252/new/ https://reviews.llvm.org/D106252 ___ cfe-commits mailing list cfe-commi

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

cor3ntin updated this revision to Diff 363534. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5847-5849 +constexpr int AmpAmp = 1; +Diag(Loc, diag::warn_declare_references_with_symbols) +<< AmpAmp << AmpAmp; cjdb wrote: > aaron.ballman wrote: > > For

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added a subscriber: rsmith. awarzynski added a comment. In D99353#2919774 , @tstellar wrote: > This is something we could merge, just need a code owner ack. Let me add @rsmith as a reviewer. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D107294: [clang] adds warning to suggest users replace symbols with alt tokens

aaron.ballman added a comment. In D107294#2920477 , @cjdb wrote: > In D107294#2920355 , @aaron.ballman > wrote: > >> The usual community viewpoint on off-by-default diagnostics is that they're >> generally low v

[PATCH] D106614: [Clang] add btf_tag attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2019 +targets. This attribute may be attached to a struct/union, struct/union field, +function, function argument or variables declaration. If -g is specified, +the ``ARGUMENT`` info will be pr

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

cjdb added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5847-5849 +constexpr int AmpAmp = 1; +Diag(Loc, diag::warn_declare_references_with_symbols) +<< AmpAmp << AmpAmp; aaron.ballman wrote: > For consistency with the `Lv

[PATCH] D107291: [clang][lexer] adds a way for tokens to track their physical spelling

cjdb abandoned this revision. cjdb added a comment. In D107291#2920408 , @aaron.ballman wrote: > You should always be able to go back to the token's spelling through the > `SourceManager` object. Is there a reason why > `SourceManager::getCharacterData

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

thakis added a comment. In D86671#2920294 , @dougpuob wrote: > In D86671#2919077 , @thakis wrote: > >> This breaks tests on windows: http://45.33.8.238/win/43180/step_8.txt >> >> "The command line is too long" Maybe

[PATCH] D107294: [clang] adds warning to suggest users replace symbols with alt tokens

cjdb added a comment. In D107294#2920355 , @aaron.ballman wrote: > The usual community viewpoint on off-by-default diagnostics is that they're > generally low value and not something that users will manually enable. I was under the impression many warn

[PATCH] D107190: [AMDGPU][HIP] Switch default DWARF version to 5

This revision was automatically updated to reflect the committed changes. Closed by commit rG635c5ba45bae: [AMDGPU][HIP] Switch default DWARF version to 5 (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107190/new/ https://

[clang] 635c5ba - [AMDGPU][HIP] Switch default DWARF version to 5

Author: Scott Linder Date: 2021-08-02T18:04:01Z New Revision: 635c5ba45baee5c6a8841fbac06f6868ddae5a6d URL: https://github.com/llvm/llvm-project/commit/635c5ba45baee5c6a8841fbac06f6868ddae5a6d DIFF: https://github.com/llvm/llvm-project/commit/635c5ba45baee5c6a8841fbac06f6868ddae5a6d.diff LOG:

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 updated this revision to Diff 363498. gandhi21299 added a comment. correction in the CUDA LIT check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: clang/test/CodeGenCUDA/fp-atomics-o

[PATCH] D107291: [clang][lexer] adds a way for tokens to track their physical spelling

aaron.ballman added a comment. You should always be able to go back to the token's spelling through the `SourceManager` object. Is there a reason why `SourceManager::getCharacterData()` is insufficient? I'm a bit worried about adding another pointer to `Token` because we sometimes store these i

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added a comment. @rsmith Ping again! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D107291: [clang][lexer] adds a way for tokens to track their physical spelling

cor3ntin added a comment. A few questions, also for @aaron.ballman Can we have a "isDigraph" flag instead of keeping a pointer for the spelling? Do we maybe want to promote `and` etc to proper keywords and maybe add functions to check `isAndOrAmpAmp` ? so that we can in the future make `void f

[PATCH] D107296: Treat inttypes.h as a built-in header

markrowe created this revision. markrowe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It wraps a system header. This allows the system module map to declare a module for it. https://bugs.llvm.org/show_bug.cgi?id=51307 Repository: rG

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1552 + "use '%select{&|&&}0' when declaring %select{lvalue|rvalue and forwarding}1 references">, + InGroup>, DefaultWarn; + Pretty sure you don't need `DefaultWa

[PATCH] D107294: [clang] adds warning to suggest users replace symbols with alt tokens

aaron.ballman added a comment. The usual community viewpoint on off-by-default diagnostics is that they're generally low value and not something that users will manually enable. Because I don't think this will ever be reasonable to enable by default due to it inherently being a matter of style,

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

cjdb added inline comments. Comment at: clang/test/Parser/warn-declare-references-with-symbols.cpp:2 +// RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify %s +// RUN: %clang_cc1 -std=c++20 -fsyntax-only -Wdeclare-references-with-symbols -verify %s + I'm pretty co

[PATCH] D107294: [clang] adds warning to suggest users replace symbols with alt tokens

cjdb created this revision. cjdb added a reviewer: aaron.ballman. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. C++'s alternative tokens are a good way to improve readability and minimise bugs by expressing intention using words inst

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2919077 , @thakis wrote: > This breaks tests on windows: http://45.33.8.238/win/43180/step_8.txt > > "The command line is too long" Maybe some arts could be passed via a response > file instead? Hi @thakis : Thank you.

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

cjdb created this revision. cjdb added a reviewer: aaron.ballman. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Although the alternative tokens `bitand` and `and` _can_ respectively be used in place of `&` and `&&` for declarations,

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

frasercrmck added a comment. In D106939#2915784 , @HsiangKai wrote: > In D106939#2915134 , @HsiangKai > wrote: > >> In D106939#2912807 , @frasercrmck >> wrote: >> >>> LG

[PATCH] D107291: [clang][lexer] adds a way for tokens to track their physical spelling

cjdb created this revision. cjdb added a reviewer: aaron.ballman. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tokens don't currently have a way to track their source-based spelling, which makes implementing some warnings difficult.

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

frasercrmck created this revision. frasercrmck added reviewers: craig.topper, rogfer01, HsiangKai, evandro, arcbbb, khchen. Herald added subscribers: vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, j

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

compnerd added inline comments. Comment at: llvm/CMakeLists.txt:589 CACHE STRING "Doxygen-generated HTML documentation install directory") -set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "share/doc/llvm/ocaml-html" +set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "${CMAKE_INSTALL_DOCDIR}/${project}

[libunwind] d6d0b65 - unwind: repair register restoration for OR1K

Author: Saleem Abdulrasool Date: 2021-08-02T16:36:37Z New Revision: d6d0b6559e97a3d0b258814e870d3e19f3a7ffcc URL: https://github.com/llvm/llvm-project/commit/d6d0b6559e97a3d0b258814e870d3e19f3a7ffcc DIFF: https://github.com/llvm/llvm-project/commit/d6d0b6559e97a3d0b258814e870d3e19f3a7ffcc.diff

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2987 +if (ThisDecl) + ThisDecl->setInvalidDecl(); SkipUntil(tok::comma, StopAtSemi | StopBeforeMatch); hokein wrote: > it seems to me calling `Sema::ActOnInitiali

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz updated this revision to Diff 363495. adamcz added a comment. ActOnInializerError instead of SetInvalidDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/new/ https://reviews.llvm.org/D105478 Files: clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e02f58780ab: [analyzer] Highlight arrows for currently selected event (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92928/new/ ht

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97bcafa28deb: [analyzer] Add control flow arrows to the analyzer's HTML reports (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHA

[clang] 9e02f58 - [analyzer] Highlight arrows for currently selected event

Author: Valeriy Savchenko Date: 2021-08-02T19:15:01+03:00 New Revision: 9e02f58780ab8734e5d27a0138bd477d18ae64a1 URL: https://github.com/llvm/llvm-project/commit/9e02f58780ab8734e5d27a0138bd477d18ae64a1 DIFF: https://github.com/llvm/llvm-project/commit/9e02f58780ab8734e5d27a0138bd477d18ae64a1.d

[clang] 97bcafa - [analyzer] Add control flow arrows to the analyzer's HTML reports

Author: Valeriy Savchenko Date: 2021-08-02T19:15:00+03:00 New Revision: 97bcafa28deb95ad32f83fe339d78454d899ca1b URL: https://github.com/llvm/llvm-project/commit/97bcafa28deb95ad32f83fe339d78454d899ca1b DIFF: https://github.com/llvm/llvm-project/commit/97bcafa28deb95ad32f83fe339d78454d899ca1b.d

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:535 +/// by range. +std::vector mergePragmas(std::vector &Syms, + std::vector &Pragmas, kadircet wrote: > dgoldman wrote: > > kadircet wr

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 updated this revision to Diff 363490. gandhi21299 marked 3 inline comments as done. gandhi21299 added a comment. generalizing the description of the remark for conversion into CAS loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10689

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 updated this revision to Diff 363484. gandhi21299 added a comment. refreshing patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: clang/test/CodeGenCUDA/fp-atomics-optremarks.cu c

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko added a comment. In D92928#2913552 , @ASDenysPetrov wrote: > Or, we can find another symbiotic way. You can make changes the way without > painfull part of thinking about IE. And I will prepare the next patch > adjusting it. Thus, revisions w

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

frasercrmck added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:100 + Optional> + getVScaleRange(const LangOptions &LangOpts) const; + This clang-tidy warning needs satisfied. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106252: Make simple requirements starting with requires ill-formed in in requirement body

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106252/new/ https://reviews.llvm.org/D106252 ___ cfe-commits mailing list cfe-comm

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:95-96 + case '?': + case 'n': + case 't': +return true; aaron.ballman wrote: > Do you intend to miss a bunch of escapes like `\'` and `\r` (etc)? \' is there. I am less sure about

[PATCH] D106614: [Clang] add btf_tag attribute

yonghong-song updated this revision to Diff 363480. yonghong-song edited the summary of this revision. yonghong-song added a comment. address Aaron and Andrii's comments: - warned and ignored if a btf_tag attribute is added to record forward declaration. - warned and ignored if a btf_tag attribu

[PATCH] D107267: [clang-format] don't break between function and function name in JS

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107267/new/ https://reviews.llvm.org/D107267 ___

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske added a comment. > Will there ever be a way to get rid of the indeterminate position indicator > tag? Currently the `fseek` can reset this flag, and the `freopen` is another case for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1062

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske added a comment. > Do we ever intend to create a warning for FERROR? Probably not (but there may be some not yet modeled stream operation where this may be useful.). This is when FERROR is set but not the indeterminate position. It indicates that the last operation failed but it is OK

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske added a comment. > No matter what happens during analysis, as of now, the NoteTag message is > unambiguous at the point of the tags construction. The stream error state is designed to store a "superposition" of different error states. This is part of `evalFseek`: StateFailed = State

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Expr.h:1839-1840 StringRef getString() const { -assert(getCharByteWidth() == 1 && - "This function is used in places that assume strings use char"); +assert(isUnevaluated() || +

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG713a5d12cde5: [OpenMP][AMDGCN] Initial math headers support (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 713a5d1 - [OpenMP][AMDGCN] Initial math headers support

Author: Pushpinder Singh Date: 2021-08-02T14:38:52Z New Revision: 713a5d12cde58a5dff90cc3e2d1e67c2a78fe52f URL: https://github.com/llvm/llvm-project/commit/713a5d12cde58a5dff90cc3e2d1e67c2a78fe52f DIFF: https://github.com/llvm/llvm-project/commit/713a5d12cde58a5dff90cc3e2d1e67c2a78fe52f.diff L

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield accepted this revision. JonChesterfield added a comment. Latest patch can only misfire on amdgpu so lets go with it and try to work out variant vs ifdef subsequently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https:

  1   2   >