[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD added a comment. Would this test do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD updated this revision to Diff 360027. RedDocMD added a comment. Added a simple test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D103809: [Clang][RISCV] Implement vloxseg and vluxseg.

HsiangKai updated this revision to Diff 360026. HsiangKai added a comment. Remove RV32 test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103809/new/ https://reviews.llvm.org/D103809 Files: clang/include/clang/Basic/riscv_vector.td clan

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:275 +return false; + const auto *Decl = Call.getDecl(); + if (!Decl) xazax.hun wrote: > Can we model a function call without a declaration? I wonder if we sho

[PATCH] D103796: [Clang][RISCV] Implement vlsseg.

HsiangKai updated this revision to Diff 360024. HsiangKai added a comment. Remove RV32 test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103796/new/ https://reviews.llvm.org/D103796 Files: clang/include/clang/Basic/riscv_vector.td clan

[PATCH] D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux

lbenes added a comment. LGTM. No more test failures or build errors. And the libreoffice .configure error has been resolved now too. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106119/new/ https://reviews.llvm.org/D106119 __

[PATCH] D106344: [PowerPC] Correct behavior of __compare_and_swap

lkail created this revision. lkail added reviewers: jsji, nemanjai, w2yehia, shchenz, PowerPC. Herald added subscribers: jfb, kbarton. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. XL's `__compare_and_swap` has a weird behavior that

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

cjdb updated this revision to Diff 360016. cjdb added a comment. rebases to activate CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102728/new/ https://reviews.llvm.org/D102728 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/warn-free

[PATCH] D103809: [Clang][RISCV] Implement vloxseg and vluxseg.

HsiangKai updated this revision to Diff 360013. HsiangKai added a comment. Correct alignment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103809/new/ https://reviews.llvm.org/D103809 Files: clang/include/clang/Basic/riscv_vector.td clang/tes

[PATCH] D105516: [clang][PassManager] Add -falways-mem2reg to run mem2reg at -O0

jrtc27 added a comment. In D105516#2889411 , @efriedma wrote: > The part I'm most uncomfortable with is sticking "mem2reg" in a public, > documented driver option. I don't want to promise that the mem2reg pass will > exist forever. We should be focuse

[PATCH] D105516: [clang][PassManager] Add -falways-mem2reg to run mem2reg at -O0

efriedma added a comment. The part I'm most uncomfortable with is sticking "mem2reg" in a public, documented driver option. I don't want to promise that the mem2reg pass will exist forever. We should be focused on making sure the options we add are stable, and compose effectively, not just be

[PATCH] D105516: [clang][PassManager] Add -falways-mem2reg to run mem2reg at -O0

jrtc27 added a comment. This is not meant to be an -O0.5, this is meant to be an -Oepsilon. I don't want optimised code, I just want code that I can actually disassemble and understand without having to trawl through a mess of stack spills and loads. This is for debugging really basic bugs (eit

[PATCH] D105516: [clang][PassManager] Add -falways-mem2reg to run mem2reg at -O0

efriedma added a comment. I think it would be better to focus on making -O1 more usable for this sort of purpose, rather than introduce -O0.5. I mean, there's a lot of wiggle-room between -O0 and -O2, but I don't think it makes sense to add a driver option that promises to run exactly one opti

[PATCH] D104743: [UpdateCCTestChecks] Implement --global-hex-value-regex

jdenny added a comment. In D104743#2889228 , @jdoerfert wrote: > I don't understand what we do before, and how this work, Maybe part of the confusion is that `--global-hex-value-regex` does not change how the value is expected to appear in LLVM IR: deci

[PATCH] D105516: [clang][PassManager] Add -falways-mem2reg to run mem2reg at -O0

jrtc27 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105516/new/ https://reviews.llvm.org/D105516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D106340: [Clang][RISCV] Add half-precision FP for vle16/vse16.

HsiangKai created this revision. HsiangKai added a reviewer: craig.topper. Herald added subscribers: StephenFan, vkmr, frasercrmck, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzh

[PATCH] D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105958/new/ https://reviews.llvm.org/D105958 ___ cfe-commits mailing list cfe-

[PATCH] D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux

MaskRay added a comment. If you can accept this, I'll submit it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106119/new/ https://reviews.llvm.org/D106119 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D106316: [clang][darwin] Add support for the -mtargetos= option to the driver

arphaman added a comment. In D106316#2888628 , @steven_wu wrote: > Looks good in general. Just one corner case that we need to decide with > direction we go, following command builds arm64-ios and x86_64-ios-simulator: > `clang -arch arm64 -arch x86_64 -

[PATCH] D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class

arphaman updated this revision to Diff 359996. arphaman marked 2 inline comments as done. arphaman added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105958/new/ https://reviews.llvm.org/D105958 Files: clang/include/clang/Basic/DarwinSDKInfo.h

[PATCH] D104743: [UpdateCCTestChecks] Implement --global-hex-value-regex

jdoerfert added a comment. I don't understand what we do before, and how this work, is `[[#` special in lit? Also, why i32/64 only, that seems arbitrary, no? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104743/new/ https://reviews.llvm.org/D104743

[PATCH] D104742: [UpdateCCTestChecks] Implement --global-value-regex

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104742/new/ https://reviews.llvm.org/D104742 ___ cfe-commits mailing list cfe-commi

[PATCH] D105926: [PowerPC] Extra test case for LDARX

Conanap reopened this revision. Conanap added a comment. This revision is now accepted and ready to land. Had to revert this as I'm seeing failures on buildbots not owned by us. The error is: llc: error: : error: unable to get target for 'powerpc64le-unknown-linux-gnu', see --version and --tr

[clang] 0d4f63e - Revert "[PowerPC] Extra test case for LDARX"

Author: Albion Fung Date: 2021-07-19T21:27:02-05:00 New Revision: 0d4f63e1b78f6e44f7e406737c2639e96427f1d6 URL: https://github.com/llvm/llvm-project/commit/0d4f63e1b78f6e44f7e406737c2639e96427f1d6 DIFF: https://github.com/llvm/llvm-project/commit/0d4f63e1b78f6e44f7e406737c2639e96427f1d6.diff L

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser added a comment. @efriedma with this patch, all of conversion between VLST and VLAT should have same vector size(getElementType() * getElementCount()). The regression in D105097 will be fixed by using bitcast + vector.insert/extract directly Repos

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser created this revision. junparser added reviewers: efriedma, bsmith, joechrisellis, c-rhodes, paulwalker-arm. Herald added subscribers: psnobl, kristof.beyls, tschuett. junparser requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Acc

[PATCH] D106255: [Clang][RISCV] Correct the alignment of stores generated by vlseg/vlsegff.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d22dee2ca59: [Clang][RISCV] Correct the alignment of stores generated by vlseg/vlsegff. (authored by HsiangKai). Repository: rG LLVM Github Monor

[PATCH] D98710: [clang-tidy] New feature --skip-headers, part 1, setTraversalScope

chh added a comment. Sam, The latest tested change contained one of your suggestions: using setTraversalScope for all consumers in the ClangTidyASTConsumer::HandleTranslationUnit It is good to pass all existing tests, although not a proof of correctness yet. The failed libarcher.* tests ha

[PATCH] D105926: [PowerPC] Extra test case for LDARX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d3e77e7a842: [PowerPC] Extra test case for LDARX (authored by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] 1d3e77e - [PowerPC] Extra test case for LDARX

Author: Albion Fung Date: 2021-07-19T20:03:45-05:00 New Revision: 1d3e77e7a8421a9d2dd13e3ef499ea967ea8f85c URL: https://github.com/llvm/llvm-project/commit/1d3e77e7a8421a9d2dd13e3ef499ea967ea8f85c DIFF: https://github.com/llvm/llvm-project/commit/1d3e77e7a8421a9d2dd13e3ef499ea967ea8f85c.diff L

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 359969. josemonsalve2 added a comment. Adding test file `/clang/test/OpenMP/target_num_teams_num_threads_attributes.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106298/new/ https://reviews.llvm.org

[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

mbenfield updated this revision to Diff 359955. mbenfield added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104887/new/ https://reviews.llvm.org/D104887 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/Diagn

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

labrinea added a comment. > struct foo { unsigned long long x[8]; }; > void store(int *in, void *addr) > { > > struct foo x = { in[0], in[1], in[4], in[16], in[25], in[36], in[49], > in[64] }; > __asm__ volatile ("st64b %0,[%1]" : : "r" (x), "r" (addr) : "memory" ); > > } For this particular

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 359946. josemonsalve2 added a comment. Making the default num teams for `omp target` be 1. Also fixing clang-tidy error and missing initialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106298/new

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap updated this revision to Diff 359945. Conanap added a comment. Fixed a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews.llvm.org/D105946 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Tar

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6659 } return nullptr; } josemonsalve2 wrote: > Should I default here to 1? Since this is an `omp target` Yes, also above. This will make `omp target` and `omp

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

josemonsalve2 marked 2 inline comments as done. josemonsalve2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6659 } return nullptr; } Should I default here to 1? Since this is an `omp target` Repository: rG LLVM Github

[PATCH] D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations.

Anastasia added a subscriber: azabaznov. Anastasia added a comment. CC @azabaznov in case he has any feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106111/new/ https://reviews.llvm.org/D106111 _

[PATCH] D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106111/new/ https://reviews.llvm.org/D106111

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

tlively added a comment. In D104797#2879855 , @pmatos wrote: > @tlively once D105423 lands, is it enough > to test and reland it under this revision or shall i open a new one? You can just reland it under this revision

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:329 #endif // defined(__opencl_c_atomic_scope_all_devices) -#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups) +#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups) || defined(__ope

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 359930. josemonsalve2 added a comment. Changing the attribute names to those sugested by @jdoerfert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106298/new/ https://reviews.llvm.org/D106298 Files: cla

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/LangStandards.def:187 Digraphs | HexFloat | OpenCL) +LANGSTANDARD_ALIAS_DEPR(openclcpp10, "clc++") I am not sure we should move it into the deprecated category yet... for now

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

josemonsalve2 added a comment. In D106298#2888234 , @jdoerfert wrote: > Tests? If you are referring to new tests, working on them. If you are referring to those tests that are failing, is because introducing new attributes broke some tests because they

[PATCH] D106316: [clang][darwin] Add support for the -mtargetos= option to the driver

steven_wu added a comment. Looks good in general. Just one corner case that we need to decide with direction we go, following command builds arm64-ios and x86_64-ios-simulator: `clang -arch arm64 -arch x86_64 -c -o test.o test.c -mios-version-min=14` Should we document and deprecate that behavior

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0268e123bea5: [PowerPC] swdiv_nochk Builtins for XL Compat (authored by quinnp, committed by kamaub). Changed prior to commit: https://reviews.llv

[clang] 0268e12 - [PowerPC] swdiv_nochk Builtins for XL Compat

Author: Quinn Pham Date: 2021-07-19T16:51:10-05:00 New Revision: 0268e123bea5bbfe64c625203cfe3b159e85b2dc URL: https://github.com/llvm/llvm-project/commit/0268e123bea5bbfe64c625203cfe3b159e85b2dc DIFF: https://github.com/llvm/llvm-project/commit/0268e123bea5bbfe64c625203cfe3b159e85b2dc.diff LO

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105987/new/ https://reviews.llvm.org/D105987 ___ cfe-commits mailing list

[PATCH] D106254: [OpenCL][NFC] Refactors conditional versioning

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106254/new/ https://reviews.llvm.org/D106254

[PATCH] D106316: [clang][darwin] Add support for the -mtargetos= option to the driver

arphaman created this revision. arphaman added reviewers: steven_wu, Bigcheese. Herald added subscribers: dang, ributzka. arphaman requested review of this revision. The new `-mtargetos=` option is a replacement for the existing, OS-specific options like `-miphoneos-version-min=`. This allows us

[PATCH] D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.

anjankgk updated this revision to Diff 359926. anjankgk retitled this revision from "[AIX] Emit unsupported 128-bit long double option for AIX" to "[AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.". anjankgk edited the summary of this revision. anjankgk adde

[PATCH] D102507: [HIP] Support in device code

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102507/new/ https://reviews.llvm.org/D102507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D106315: [HIP] Preserve ASAN bitcode library functions

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner. Herald added subscribers: kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. Address sanitizer passes may generate call of ASAN bitcode library functions after bitcode linking in lld, therefore lld cannot add t

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08b289867b5a: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id (authored by nridge). Repository: rG LLVM Github Mon

[clang] 08b2898 - [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

Author: Nathan Ridge Date: 2021-07-19T17:31:51-04:00 New Revision: 08b289867b5adb45033db501461915234e9e1bd4 URL: https://github.com/llvm/llvm-project/commit/08b289867b5adb45033db501461915234e9e1bd4 DIFF: https://github.com/llvm/llvm-project/commit/08b289867b5adb45033db501461915234e9e1bd4.diff

[PATCH] D106301: [OpenMP] Disable trap before unreachable for OpenMP device jobs

JonChesterfield added a comment. I'm not sure about that - we could tie instcombine to -O0 or some similar proxy for debugging ve performance - but I'm practice it's fairly likely that most traps are compiler inserted so it probably works out the same. Conditional instcombine would let us remov

[PATCH] D106301: [OpenMP] Disable trap before unreachable for OpenMP device jobs

jdoerfert abandoned this revision. jdoerfert added a comment. Replaced by D106308 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106301/new/ https://reviews.llvm.org/D106301 ___

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3816 + +def Error : Attr { + let Spellings = [GCC<"error">]; aaron.ballman wrote: > I think this should be an inheritable attribute (same below) so that > redeclarations get th

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers updated this revision to Diff 359912. nickdesaulniers marked 5 inline comments as done. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. Herald added a subscriber: pengfei. - change IR Attr to dontcall - check during ISel(s) - rename td diag - h

[PATCH] D106100: [clang-scan-deps] ignore top-level module dependencies that aren't actually imported

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106100/new/ https://reviews.llvm.org/D106100 ___ cfe-commits mailing list

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov added a comment. While we are still reviewing this and it's probably going to take longer, I went ahead made a DR for fixing the same issue in main: https://reviews.llvm.org/D106303 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105951/new

[PATCH] D106303: [clang] fix oops: enable implicit moves in MSVC compatibility mode

mizvekov created this revision. mizvekov added a reviewer: aaron.ballman. mizvekov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. When disabling simpler implicit moves in MSVC compatibility mode as a workaround in D105518

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis accepted this revision. eugenis added a comment. In D105703#2887005 , @fmayer wrote: > I removed the stack-safety-analysis-asm.c test because I don't think it > really adds anything and it caused problems. SGTY? Absolutely. LGTM Repository:

[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9da70ab3d43c: [clang-format] Break an unwrapped line at a K&R C parameter decl (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES

[clang] 9da70ab - [clang-format] Break an unwrapped line at a K&R C parameter decl

Author: owenca Date: 2021-07-19T13:30:38-07:00 New Revision: 9da70ab3d43c79116f80fc06aa7cf517374ce42c URL: https://github.com/llvm/llvm-project/commit/9da70ab3d43c79116f80fc06aa7cf517374ce42c DIFF: https://github.com/llvm/llvm-project/commit/9da70ab3d43c79116f80fc06aa7cf517374ce42c.diff LOG: [

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

jdoerfert added a comment. Tests? Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6559 + if (DefaultValTeams > 0) { +OutlinedFn->addFnAttr(llvm::StringRef("NumTeams"), + std::to_string(DefaultValTeams)); Comme

[PATCH] D106301: [OpenMP] Disable trap before unreachable for OpenMP device jobs

jdoerfert added a comment. In D106301#2888203 , @JonChesterfield wrote: > In D106301#2888170 , @jdoerfert > wrote: > >> llvm.trap is preserved, thus branches to an llvm.trap are preserved. > > That's interesting

[PATCH] D106301: [OpenMP] Disable trap before unreachable for OpenMP device jobs

JonChesterfield added a comment. In D106301#2888170 , @jdoerfert wrote: > llvm.trap is preserved, thus branches to an llvm.trap are preserved. That's interesting. Consistent with IR in general, template int test(int x) { if (x < 42) { retur

[PATCH] D106301: [OpenMP] Disable trap before unreachable for OpenMP device jobs

jdoerfert added a comment. As an example, often end up with code like this right now: %26 = load i32, i32* addrspacecast (i32 addrspace(3)* @execution_param to i32*), align 4, !dbg !39, !tbaa !27 %and.i13.i.i = and i32 %26, 4, !dbg !39 %cmp.i14.not.i.i = icmp eq i32 %and.i13.i.i, 0,

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added a comment. Note that I think this was partially implemented as part of https://reviews.llvm.org/D74130 - which has not progressed since October. This PR implements P1937 only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In an unevaluated contexts, consteval functions should not be immediately evaluated. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D106301: [OpenMP] Disable trap before unreachable for OpenMP device jobs

jdoerfert added a comment. In D106301#2888162 , @JonChesterfield wrote: > What's the problem with emitting llvm.trap in various unreachable places? llvm.trap is preserved, thus branches to an llvm.trap are preserved. > Wondering if it also affects tran

[PATCH] D106301: [OpenMP] Disable trap before unreachable for OpenMP device jobs

jdoerfert updated this revision to Diff 359882. jdoerfert added a comment. Fix copy&paste error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106301/new/ https://reviews.llvm.org/D106301 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/

[PATCH] D106301: [OpenMP] Disable trap before unreachable for OpenMP device jobs

JonChesterfield added a comment. What's the problem with emitting llvm.trap in various unreachable places? Wondering if it also affects translating assert to an llvm.trap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106301/new/ https://reviews.ll

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 359878. dgoldman added a comment. Fetch marks from preamble as well Move Range helper into SourceCode.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: cla

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

xazax.hun requested changes to this revision. xazax.hun added a comment. This revision now requires changes to proceed. Commented some nits, but overall looks good to me. However, could you include some tests? We usually do not commit any changes without tests unless it is really hard to create

[PATCH] D105997: Implement _ExtInt conversion rules

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105997/new/ https://reviews.llvm.org/D105997 ___ cfe-commits mailing list cfe-commits

[PATCH] D106301: [OpenMP] Disable trap before unreachable for OpenMP device jobs

jdoerfert created this revision. jdoerfert added reviewers: jhuber6, tianshilei1992, JonChesterfield. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. We want to fold more

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

josemonsalve2 created this revision. josemonsalve2 added reviewers: ABataev, jdoerfert, JonChesterfield, ggeorgakoudis, jhuber6, baziotis, sstefan1, uenoku, tianshilei1992. Herald added subscribers: jfb, guansong, yaxunl. josemonsalve2 requested review of this revision. Herald added a project: cla

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added a comment. This was originally approved and landed on May 11th. I agreed to let it be reverted when it was discovered that some headers were triggering the warning. I reworked the code to not generate the warning when coming from system header files and also added option

[PATCH] D105997: Implement _ExtInt conversion rules

aaron.ballman added a comment. Ping. FWIW, I'm hoping to get these changes into the Clang 13 branch before we split off. I don't think we'll get fully conforming support for the feature in Clang 13 (we need some ABI discussion before I think we'll be ready to rename `_ExtInt` to `_BitInt`, but

[PATCH] D106255: [Clang][RISCV] Correct the alignment of stores generated by vlseg/vlsegff.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106255/new/ https://reviews.llvm.org/D106255 ___

[PATCH] D106296: [analyer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD updated this revision to Diff 359865. RedDocMD added a comment. Reformatted patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D106064: [clang][deps] Normalize paths in minimizing file system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. In D106064#2887753 , @jansvoboda11 wrote: > With the call to `llvm::sys::path::native` scoped only to `IgnoredFiles`, > would this patch LGTY

[PATCH] D106296: [analyer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD created this revision. RedDocMD added reviewers: NoQ, vsavchenko, xazax.hun, teemperor. Herald added subscribers: martong, rnkovacs. RedDocMD requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch: - Fixes how the std-namespac

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

morehouse added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5255 + CST = QualType(TargetDecl->getFunctionType(), 0); +else if (auto FPT = Callee.getAbstractInfo().getCalleeFunctionProtoType()) + CST = QualType(FPT, 0); Please fix this

[PATCH] D100139: [ifs][elfabi] Merge llvm-ifs/elfabi tools

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6103fdfab4e2: [ifs][elfabi] Merge llvm-ifs/elfabi tools (authored by haowei). Changed prior to commit: https://reviews.llvm.org/D100139?vs=353507&

[clang] 6103fdf - [ifs][elfabi] Merge llvm-ifs/elfabi tools

Author: Haowei Wu Date: 2021-07-19T11:23:19-07:00 New Revision: 6103fdfab4e2c051c070e2994db8b696fc440048 URL: https://github.com/llvm/llvm-project/commit/6103fdfab4e2c051c070e2994db8b696fc440048 DIFF: https://github.com/llvm/llvm-project/commit/6103fdfab4e2c051c070e2994db8b696fc440048.diff LOG

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap updated this revision to Diff 359850. Conanap added a comment. Changed flags for intrinsic of dcbtt and dcbtstt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews.llvm.org/D105946 Files: clang/include/clang/Basic/B

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc updated this revision to Diff 359847. mibintc marked 3 inline comments as done. mibintc added a reviewer: zahiraam. mibintc added a comment. I've rebased and applied clang-format. I'd like to push this, looking for your +1, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang marked 4 inline comments as done. NeHuang added a comment. Rebased the patch with ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.llvm.org/D105194 ___ cfe-commits m

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang updated this revision to Diff 359843. NeHuang added a comment. Address review comments from Nemanja. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.llvm.org/D105194 Files: clang/include/clang/Basic/BuiltinsPPC.

[PATCH] D106064: [clang][deps] Normalize paths in minimizing file system

jansvoboda11 added a comment. With the call to `llvm::sys::path::native` scoped only to `IgnoredFiles`, would this patch LGTY? Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:161-162 +const StringRef RawFilename) { + llvm::SmallString<25

[PATCH] D106203: [clangd] Propagate header-guarded flag from preamble to main AST

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/Preamble.cpp:87 + +const SourceManager &SM = CI.getSourceManager(); +const FileEntry *MainFE = SM.getFileEntryForID(S

[PATCH] D106064: [clang][deps] Normalize paths in minimizing file system

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:161-162 +const StringRef RawFilename) { + llvm::SmallString<256> Filename; + llvm::sys::path::native(RawFilename, Filename); + jansvoboda11

[PATCH] D106201: [clangd] Add tests covering existing header-guard behavior. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:725 + TU.Code = R"cpp( +#pragma once +; sammccall wrote: > kadircet wr

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106005/new/ https://reviews.llvm.org/D106005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

dblaikie added a comment. In D106084#2886659 , @jmorse wrote: > This is going to be excellent for linux targets and similar, > > In D106084#2882970 , @probinson > wrote: > >> + @jmorse who is better placed than I

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sure, sounds good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619 _

[PATCH] D106252: Implement P2092

cor3ntin updated this revision to Diff 359824. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106252/new/ https://reviews.llvm.org/D106252 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/lib/P

  1   2   >