jdenny added a comment. In D104743#2889228 <https://reviews.llvm.org/D104743#2889228>, @jdoerfert wrote:
> I don't understand what we do before, and how this work, Maybe part of the confusion is that `--global-hex-value-regex` does not change how the value is expected to appear in LLVM IR: decimal is still expected. It only changes how the value is represented in the FileCheck directive: hex is the representation. The only point is to make the FileCheck directives more readable because, at least in my OpenMP use case, we're dealing with flags. > is `[[#` special in lit? No, it starts a FileCheck numeric <https://llvm.org/docs/CommandGuide/FileCheck.html#filecheck-numeric-substitution-blocks>. > Also, why i32/64 only, that seems arbitrary, no? Good point. I suppose it should be any integer. I'll work on that. Thanks for the reviews. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104743/new/ https://reviews.llvm.org/D104743 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
