[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

tambre added inline comments. Comment at: clang/test/SemaCXX/cxx2a-lambda-decltype-this.cpp:1-4 +// RUN: %clang_cc1 -std=c++2a -fsyntax-only -fblocks -emit-llvm-only %s +// RUN: %clang_cc1 -std=c++2a -fsyntax-only -fblocks -fdelayed-template-parsing %s +// RUN: %clang_cc1 -std=c

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

nridge updated this revision to Diff 356605. nridge added a comment. Move a piece of Decl-specific code into DeclPrinterTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105457/new/ https://reviews.llvm.org/D105457 Files: clang/unittests/AS

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:159 +// indexed, we walk further up because Ref::Container should always be +// an indexed symbol. +const Decl *getRefContainer(const Decl *Enclosing, can you also add

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge added a comment. In D104619#2846262 , @dblaikie wrote: > If there's already some duplication, perhaps a pre-patch to generalize that > functionality, then using that functionality in this patch? I posted the patch to generalize the AST printing t

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge updated this revision to Diff 356604. nridge added a comment. Rebase on top of refactor patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619 Files: clang/lib/AST/TypePrinter.cpp clang/unittest

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

nridge added a comment. This is the refactor patch discussed in https://reviews.llvm.org/D104619#2846262. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105457/new/ https://reviews.llvm.org/D105457 ___ c

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:218-219 + + if (isStdOstreamOperatorCall(Call)) +return true; + When you're doing `evalCall` you're responsible for modeling *all* aspects of the call. One does no

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

nridge created this revision. nridge added a reviewer: dblaikie. nridge requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105457 Files: clang/unittests/AST/ASTPrint.h clang

[PATCH] D105436: [analyzer][solver] Use all sources of constraints

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. such passes @ much LLVM > Performance measurements also show the we are within the same margins. Great! I'd expect massive constraint solver improvements to actually make performance //better// bec

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

Conanap added a comment. In D105236#2858909 , @thakis wrote: > Looks like this breaks tests: http://45.33.8.238/linux/50465/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Hi! I accidentally included a test case meant fo

[clang] 203b48c - [PowerPC] Removed a test case meant for a later patch

Author: Albion Fung Date: 2021-07-05T22:31:17-05:00 New Revision: 203b48c71a0db835bd0d6869311578dbd7cc8b71 URL: https://github.com/llvm/llvm-project/commit/203b48c71a0db835bd0d6869311578dbd7cc8b71 DIFF: https://github.com/llvm/llvm-project/commit/203b48c71a0db835bd0d6869311578dbd7cc8b71.diff L

[PATCH] D105454: Removed accidentally added file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG203b48c71a0d: [PowerPC] Removed a test case meant for a later patch (authored by Conanap). Herald added a project: clang. Herald added a subscriber:

[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

qdelacru updated this revision to Diff 356591. qdelacru added a comment. Fix format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105451/new/ https://reviews.llvm.org/D105451 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/warn-cast-align.c Index: clang/test/Sema/warn-cast

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/50465/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

chh updated this revision to Diff 356589. chh edited the summary of this revision. chh added a comment. No more change to or derivation from MatchFinder, but override two member functions in MultiplexConsumer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llv

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d10dd60ce12: [PowerPC] Implament Load and Reserve and Store Conditional Builtins (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D105236?vs=356562&id=356590#toc Repository:

[clang] 7d10dd6 - [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Author: Albion Fung Date: 2021-07-05T21:35:41-05:00 New Revision: 7d10dd60ce126a6a0a29aa1f3948f596bd6e4fb0 URL: https://github.com/llvm/llvm-project/commit/7d10dd60ce126a6a0a29aa1f3948f596bd6e4fb0 DIFF: https://github.com/llvm/llvm-project/commit/7d10dd60ce126a6a0a29aa1f3948f596bd6e4fb0.diff L

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

pengfei updated this revision to Diff 356585. pengfei added a comment. Fix the capitalization mismatch in tests. Thanks Sanjay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105268/new/ https://reviews.llvm.org/D105268 Files: clang/include/clang

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

pengfei added inline comments. Comment at: llvm/test/CodeGen/X86/stack-folding-fp-avx512fp16vl-fma.ll:193-194 +define <8 x half> @stack_fold_fmsub123ph(<8 x half> %a0, <8 x half> %a1, <8 x half> %a2) { + ;check-label: stack_fold_fmsub123ph: + ;check: vfmsub213ph {{-?[0-9

[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

qdelacru created this revision. qdelacru added a reviewer: aaron.ballman. qdelacru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When there is unknown type in a struct in code compiled with -Wcast-align, the compiler crashes due to clang

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

lkail accepted this revision. lkail added a comment. lgtm,thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

stefanp accepted this revision. stefanp added a comment. Thank you! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 ___ cfe-commits mailing list cfe-commi

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG21106388eb96: [clang] fixes named return of variables with dependent alignment (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105380/n

[clang] 2110638 - [clang] fixes named return of variables with dependent alignment

Author: Matheus Izvekov Date: 2021-07-06T02:30:44+02:00 New Revision: 21106388eb96c87b3f580c42a322c76a61605261 URL: https://github.com/llvm/llvm-project/commit/21106388eb96c87b3f580c42a322c76a61605261 DIFF: https://github.com/llvm/llvm-project/commit/21106388eb96c87b3f580c42a322c76a61605261.dif

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

thakis added a comment. Thanks for the fix :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

stevewan added a comment. In D105112#2858702 , @thakis wrote: > Hi, you have to bump clang/include/clang/Serialization/ASTBitCodes.h's > VERSION_MAJOR after adding a LangOption, else builds with > LLVM_APPEND_VC_REV=NO won't invalidate their module cach

[clang] e2904c8 - [clang] unbreak Index/preamble-reparse-changed-module.m with LLVM_APPEND_VC_REV=NO after 9964b0e

Author: Steven Wan Date: 2021-07-05T19:51:00-04:00 New Revision: e2904c8e0fa901adeefe579297cb2ece2757fb18 URL: https://github.com/llvm/llvm-project/commit/e2904c8e0fa901adeefe579297cb2ece2757fb18 DIFF: https://github.com/llvm/llvm-project/commit/e2904c8e0fa901adeefe579297cb2ece2757fb18.diff LO

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

mizvekov updated this revision to Diff 356576. mizvekov added a comment. - Move it to VarDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105380/new/ https://reviews.llvm.org/D105380 Files: clang/include/clang/AST/Decl.h clang/lib/AST/Decl.

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas updated this revision to Diff 356575. manas edited the summary of this revision. manas added a comment. Edit summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105447/new/ https://reviews.llvm.org/D105447 Files: clang/utils/analyzer/ent

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas added a comment. In D105447#2858740 , @manas wrote: > Restore global cmake command Apparently, my initial observation of `LLVM_BUILD_RUNTIME=OFF` hogging up memory was false and I also didn't know what was the default value for this option. Hence

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas updated this revision to Diff 356574. manas added a comment. Restore global cmake command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105447/new/ https://reviews.llvm.org/D105447 Files: clang/utils/analyzer/entrypoint.py Index: clang/u

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDecl.cpp:13314 -/// Determines if a variable's alignment is dependent. -static bool hasDependentAlignment(VarDecl *VD) { - if (VD->getTy

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. I should note that I didn't use private headers in libc++'s `modules.modulemap` because it created a very noticeable impact to our test suite's run-time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105439/new/ https://revie

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas created this revision. Herald added subscribers: steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: teemperor. manas requested review of this revision. Herald added a reviewer: jdoerfert. Herald

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

thakis added a comment. Hi, you have to bump clang/include/clang/Serialization/ASTBitCodes.h's VERSION_MAJOR after adding a LangOption, else builds with LLVM_APPEND_VC_REV=NO won't invalidate their module cache correctly. See e.g. https://reviews.llvm.org/rGb8b7a9dcdcbc Without that, tests are

[PATCH] D105446: [clang] fix constexpr code generation for user conversions.

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When building the member call to a user conversion function during an implicit cast, the expression was not being checked for immediate invocation, so

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap marked 3 inline comments as done. Conanap added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64bit-only.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -verify-machinein

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

0x8000- added a comment. In D69764#2858656 , @MyDeveloperDay wrote: > Rebase on clang12 as requested Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 _

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

mizvekov updated this revision to Diff 356568. mizvekov added a comment. - Use llvm::any_of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105380/new/ https://reviews.llvm.org/D105380 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaD

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 356565. MyDeveloperDay removed reviewers: klimek, djasper. MyDeveloperDay added a comment. Rebase on clang12 as requested CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangForma

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

mizvekov added a comment. In D105380#2858638 , @aaronpuchert wrote: > I tend to follow the rule that if it's just used once I keep it local, but > you might have good reasons for making it public. Well it is used twice. Notice how I replaced a pre-exis

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9964b0ef828b: [clang] Add -fdump-record-layouts-canonical option (authored by daltenty, committed by stevewan). Repository: rG LLVM Github Monorep

[clang] 9964b0e - [clang] Add -fdump-record-layouts-canonical option

Author: David Tenty Date: 2021-07-05T17:35:37-04:00 New Revision: 9964b0ef828b685dc575a50f75bb1780b84b95c8 URL: https://github.com/llvm/llvm-project/commit/9964b0ef828b685dc575a50f75bb1780b84b95c8 DIFF: https://github.com/llvm/llvm-project/commit/9964b0ef828b685dc575a50f75bb1780b84b95c8.diff L

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

0x8000- added a comment. Is it possible to have this rebased on top of LLVM12 for those of us who find the trade-offs acceptable? I prefer a consistent formatting of const placement, and my code base does not have issues with the macros - if we find one that break the build, I'll suggest it

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

nemanjai accepted this revision. nemanjai added a comment. LGTM aside from a small nit. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64bit-only.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

aaronpuchert added a comment. I'd leave it to @rsmith to decide whether this makes sense in Sema.h. I tend to follow the rule that if it's just used once I keep it local, but you might have good reasons for making it public. Comment at: clang/lib/Sema/SemaDecl.cpp:13316 + re

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104085/new/ https://reviews.llvm.org/D104085 ___

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

amyk accepted this revision as: amyk. amyk added a comment. Also LGTM overall. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64bit-only.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -verify-m

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356562. Conanap added a comment. Removed entry from check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/l

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm with minor changes + clang-format. Comment at: compiler-rt/lib/hwasan/hwasan_fuchsia.cpp:29 + // now. Otherwise, ShadowBounds will be a zero-initialized global. +

[PATCH] D103544: [compiler-rt][Fuchsia] Disable interceptors while enabling new/delete replacements

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103544/new/ https://reviews.llvm.org/D103544 ___

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

NeHuang accepted this revision as: NeHuang. NeHuang added a comment. This revision is now accepted and ready to land. Overall LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

mcgrathr added a comment. Frankly I don't think it makes sense to have __sanitizer_mallinfo and those other allocator functions declared in hwasan_interface_internal.h at all. Those are neither APIs that the compiler emits nor ones that anyone else should use. They are just implementation detai

[PATCH] D105185: [AIX] Add _AIX73 version macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52f34673ead3: [AIX] Add _AIX73 version macro (authored by Jake-Egan, committed by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 52f3467 - [AIX] Add _AIX73 version macro

Author: Jake Egan Date: 2021-07-05T16:28:48-04:00 New Revision: 52f34673ead32e6818d337207661597de52b9808 URL: https://github.com/llvm/llvm-project/commit/52f34673ead32e6818d337207661597de52b9808 DIFF: https://github.com/llvm/llvm-project/commit/52f34673ead32e6818d337207661597de52b9808.diff LOG

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. @davidxl @vsk 😃 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104556/new/ https://reviews.llvm.org/D104556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap marked an inline comment as done. Conanap added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 ___ cfe-commits mailing li

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356559. Conanap marked 4 inline comments as done. Conanap added a comment. Updated test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/c

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added a comment. @rsmith @thakis @efriedma If there are no more changes required, please approve. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commi

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-StoreCond-64bit-only.c:1 +// RUN: not %clang_cc1 -triple=powerpc-unknown-aix -O2 -S -emit-llvm %s -o - 2>&1 |\ +// RUN: FileCheck %s --check-prefix=CHECK32-ERROR `-S`

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 356552. Conanap added a comment. Fixed incorrect diff update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files: clang/include/clang/Basic/BuiltinsPPC.def clan

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356551. Conanap added a comment. Changed to ForceXForm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 356550. Conanap added a comment. Changed to ForceXForm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 356549. Conanap added a comment. Changed to ForceXForm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356546. Conanap marked 2 inline comments as done. Conanap added a comment. Updated IR test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/includ

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

stefanp added a comment. Overall I think this is fine. I just have a few nits. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-StoreCond.c:11 +int test_lwarx(volatile int* a) { + // CHECK: entry: + // CHECK: %0 = bitcast i32* %a to i8* Please

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356545. Conanap added a comment. Updated 64 bit error test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

bmahjour added a comment. In D103615#2852430 , @krasimir wrote: > I'm unfamiliar with the altivec API. What's a reasonable source code update > that preserves the current default behavior `-altivec-src-compat=mixed` under > `-altivec-src-compat=xl`, i.e

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356542. Conanap added a comment. Added error test cases and sema checking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/clang/Basic/BuiltinsP

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

spatel added inline comments. Comment at: llvm/test/CodeGen/X86/stack-folding-fp-avx512fp16vl-fma.ll:193-194 +define <8 x half> @stack_fold_fmsub123ph(<8 x half> %a0, <8 x half> %a1, <8 x half> %a2) { + ;check-label: stack_fold_fmsub123ph: + ;check: vfmsub213ph {{-?[0-9]

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

NeHuang added a comment. Please add the sema check & error test case for the two 64 bit only builtins `ldarx` and `stdcx` Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64-only.ll:10 +declare i64 @llvm.ppc.ldarx(i8*) +define dso_local i64 @t

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112 __

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. The latest version looks good to me, let's land this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap marked 3 inline comments as done. Conanap added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 ___ cfe-commits mailing li

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. In D105439#2858291 , @Quuxplusone wrote: > Step 1 should be to find out if this is even a problem at all. For example, > try using one of these tools to compile a C++ program against GNU libstdc++, > or against a library like rang

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356533. Conanap added a comment. Updated C test case name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/l

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356532. Conanap added a comment. Changed test case file names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/clang/Basic/BuiltinsPPC.def cla

[PATCH] D105236: [PowerPC] Implament Atomic Load and Stores Builtins

Conanap updated this revision to Diff 356528. Conanap added a comment. Properly updated the diff with arc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/clang/Basic/BuiltinsPPC.de

[PATCH] D105236: [PowerPC] Implament Atomic Load and Stores Builtins

Conanap updated this revision to Diff 356527. Conanap added a comment. Moved the pattern definitions and removed unnecessary guard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: llvm/include/ll

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

Quuxplusone added a comment. I should add that if any particular library really wants to //enforce// "thou shalt not deep-link detail headers" (instead of just documenting it and/or relying on the user-programmer's common sense) they can do it pretty

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 356526. RedDocMD added a comment. Major bug fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/Checke

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

lebedev.ri added a comment. Why not solve this in the headers themselves? Just `#error` in implementation header if some macro isn't defined, and define said macro in parent header before including implementation detail headers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

Quuxplusone requested changes to this revision. Quuxplusone added a comment. This revision now requires changes to proceed. Step 1 should be to find out if this is even a problem at all. For example, try using one of these tools to compile a C++ program against GNU libstdc++, or against a librar

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. A few notes to reviewers: - The patch assumes everything is under a top-level `__libcxx` directory, because it seems there are other system headers that could be prefixed with `__`. libc++ currently has many top-level directories, following the trend of `__${STD_LIB_HEADE

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb created this revision. cjdb added reviewers: aaron.ballman, rsmith, manojgupta, gbiv, ldionne, EricWF. Herald added a reviewer: george.burgess.iv. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. libc++ has started splicing standar

[PATCH] D105436: [analyzer][solver] Use all sources of constraints

vsavchenko added a comment. I compared issues produced by this patch to the issues produced before that on all projects from `clang/utils/analyzer/projects`, and didn't find any difference. Performance measurements also show the we are within the same margins. F17774659: photo_2021-07-05 19.39.

[PATCH] D105436: [analyzer][solver] Use all sources of constraints

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, ASDenysPetrov, manas, RedDocMD. Herald added subscribers: dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-sync.c:240 +void test_icbt() { + __icbt(c); } From the document, `__icbt` only valid when -qarch is set to target pwr8 or higher processors. It looks like target cpu sema check

[PATCH] D105354: [clang][AST] Add support for DecompositionDecl to ASTImporter.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2305-2309 + BindingDecl *ToD; + if (GetImportedOrCreateDecl(ToD, D, Importer.getToContext(), DC, Loc, + Name.getAsIdentifierInfo())) +return ToD; + So, we

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

xazax.hun requested changes to this revision. xazax.hun added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:350 +QualType Type = getInnerPointerType(C, E->getType()->getAsCXXRecordDecl()); +

[PATCH] D105236: [PowerPC] Implament Atomic Load and Stores Builtins

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:1724 + +let Predicates = [HasP8Altivec] in { + def : Pat<(int_ppc_stdcx xoaddr:$dst, g8rc:$A), lkail wrote: > IIRC, `l(w|d)arx`, `st(w|d)cx` are supported very early and don't n

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

MyDeveloperDay added a comment. Can you show `for (;;) {}` in your tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98429/new/ https://reviews.llvm.org/D98429 ___ cfe-commits mailing list cfe-commits

[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

MyDeveloperDay added a comment. also D68554: [clang-format] Proposal for clang-format to give compiler style warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105408/new/ https://reviews.llvm.org/D105408 ___

[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Including clangFrontend has been discourage many times before, we don't want to add that to the list of dependencies please see D90121: clang-format: Add a consumer t

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong updated this revision to Diff 356504. martong added a comment. - Use std::set for ordering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintMan

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2583 + + llvm::SmallSet MembersStr; + for (std::pair ClassToSymbolSet : Members) Ah, `SmallSet` is not sorted :( I am gonna have to change this to either `std::

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong updated this revision to Diff 356502. martong added a comment. Herald added a subscriber: mgrang. - Change the dump methods to order the equivalence classes and the disequality info available before printing them out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong reopened this revision. martong added a comment. This revision is now accepted and ready to land. I have changed the dump methods to order the equivalence classes and the disequality info available before printing them out. The ordering is done based on their string representation. This

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-error.c:11 + +long long lla, llb; +int ia, ib; nit: Have these variables as `extern` like the other patches do. Comment at: clang/test/CodeGen/builtins-ppc-xlcompa

  1   2   >