[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

balazske added a comment. I could not find a way to pass the needed information from the BugReport to the `NoteTag`. The "sequence number" (in `EofSeqMap`) is only known when the bug is detected, this should be passed to the `NoteTag` somehow. The value is used to make the new note appear only

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge planned changes to this revision. nridge added a comment. In D104619#2846262 , @dblaikie wrote: > If there's already some duplication, perhaps a pre-patch to generalize that > functionality, then using that functionality in this patch? Sounds goo

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

dblaikie added a comment. In D104619#2846259 , @nridge wrote: > In D104619#2846258 , @dblaikie > wrote: > >> if that's the case, maybe there's room to refactor the commonality - >> avoiding the near(if it is nea

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge added a comment. In D104619#2846258 , @dblaikie wrote: > if that's the case, maybe there's room to refactor the commonality - avoiding > the near(if it is near) duplication and justifying the complexity/more > general design a bit more, by having

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

dblaikie added a comment. In D104619#2846255 , @nridge wrote: > I based the infrastructure closely on that in `DeclPrinterTest.cpp` and > `StmtPrinterTest.cpp`. I figured the general framework could come in useful > to people adding new type printing te

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge added a comment. I based the infrastructure closely on that in `DeclPrinterTest.cpp` and `StmtPrinterTest.cpp`. I figured the general framework could come in useful to people adding new type printing tests in the future. I'm happy to trim it down a bit (e.g. remove unused methods and suc

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dblaikie added a comment. In D103615#2846251 , @dyung wrote: > In D103615#2846245 , @dblaikie > wrote: > >> As mentioned in the reverting commit - these tests fail in non-asserts >> builds, because they assume n

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

dblaikie added a comment. The test code seems a bit overly general/overengineered for the use case, perhaps? (for instance it has unused parameters like the "Args" parameter - that neither caller passes in a value for, it has accessors (GetPRinted/getNumFoundTypes) when all the code fits on a (

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dyung added a comment. In D103615#2846245 , @dblaikie wrote: > As mentioned in the reverting commit - these tests fail in non-asserts > builds, because they assume named IR instructions (like the named entry BB > label), which aren't provided on a non-a

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dblaikie added a comment. As mentioned in the reverting commit - these tests fail in non-asserts builds, because they assume named IR instructions (like the named entry BB label), which aren't provided on a non-asserts build (there's a flag to turn them on - but that's probably not the right fi

[clang] e1b8fde - Revert "[Clang] Add option to handle behaviour of vector bool/vector pixel."

Author: David Blaikie Date: 2021-06-28T22:57:21-07:00 New Revision: e1b8fde1cbfc031d67d9b316f1b4ac3ab9c8801f URL: https://github.com/llvm/llvm-project/commit/e1b8fde1cbfc031d67d9b316f1b4ac3ab9c8801f DIFF: https://github.com/llvm/llvm-project/commit/e1b8fde1cbfc031d67d9b316f1b4ac3ab9c8801f.diff

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https://github.com/clangd/clangd

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

This revision was automatically updated to reflect the committed changes. Closed by commit rGc94c8d8b5d99: [AVR][clang] Fix wrong calling convention in functions return struct type (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D99237?vs=335368&id=355111#toc Reposit

[clang] c94c8d8 - [AVR][clang] Fix wrong calling convention in functions return struct type

Author: Ben Shi Date: 2021-06-29T11:32:39+08:00 New Revision: c94c8d8b5d999c97ea424b35a1cb540d2a1d3bc6 URL: https://github.com/llvm/llvm-project/commit/c94c8d8b5d999c97ea424b35a1cb540d2a1d3bc6 DIFF: https://github.com/llvm/llvm-project/commit/c94c8d8b5d999c97ea424b35a1cb540d2a1d3bc6.diff LOG:

[PATCH] D97824: [ObjC][ARC] Don't add operand bundle `clang.arc.attachedcall` to a call if the call already has the operand bundle

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97824/new/ https://reviews.llvm.org/D97824 _

[PATCH] D95807: [RFC][Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

lxfind updated this revision to Diff 355110. lxfind added a comment. Herald added subscribers: cfe-commits, qcolombet. Herald added a project: clang. After removing the legacy test command, I was finally able to update this patch. It's now ready for review. I will update the decription to reflect

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge updated this revision to Diff 355104. nridge added a comment. fix comment at top of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619 Files: clang/lib/AST/TypePrinter.cpp clang/unittests/AST

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge added a comment. In D104619#2831966 , @dblaikie wrote: > So likely what you'd need would be a unit test of some kind (check around in > clang/unittests to see if there are other AST pretty printer tests, for > instance). Thanks for the suggestio

[PATCH] D104619: [clang] [WIP] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge updated this revision to Diff 355103. nridge added a comment. Herald added a subscriber: mgorny. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619 Files: clang/lib/AST/TypePrinter.cpp cl

[clang] 948308e - Fix `-Wunused-variable` warning. NFC.

Author: Michael Liao Date: 2021-06-28T22:50:36-04:00 New Revision: 948308ef34dc7da8bb741a85eb9941cc2b05d227 URL: https://github.com/llvm/llvm-project/commit/948308ef34dc7da8bb741a85eb9941cc2b05d227 DIFF: https://github.com/llvm/llvm-project/commit/948308ef34dc7da8bb741a85eb9941cc2b05d227.diff

[PATCH] D104344: [modules] Track how headers are included by different modules.

vsapsai added a comment. Ping. It would be useful to know if this approach makes sense. If so, I can test it on a bigger codebase and see if there are any problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104344/new/ https://reviews.llvm.org

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

rupprecht added a comment. In D104261#2844636 , @aaronpuchert wrote: > In D104261#2841356 , @delesley > wrote: > >> since it's restricted to relockable managed locks, I'm not too worried... > > Not quite, it aff

[PATCH] D105066: [Coroutines] Remove CoroElide from O0 pipeline

This revision was automatically updated to reflect the committed changes. Closed by commit rG31eb696fc4cd: [Coroutines] Remove CoroElide from O0 pipeline (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105066/new/ https://reviews

[clang] 31eb696 - [Coroutines] Remove CoroElide from O0 pipeline

Author: Xun Li Date: 2021-06-28T19:28:27-07:00 New Revision: 31eb696fc4cd3b1ed8054d88af54f214c0f92989 URL: https://github.com/llvm/llvm-project/commit/31eb696fc4cd3b1ed8054d88af54f214c0f92989 DIFF: https://github.com/llvm/llvm-project/commit/31eb696fc4cd3b1ed8054d88af54f214c0f92989.diff LOG: [

[PATCH] D105066: [Coroutines] Remove CoroElide from O0 pipeline

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. > That's a separate topic though. Let's agree on this diff first and then I can > explain more about the always_inline issue. Yeah, maybe we should discuss it on the llvm-dev thread. R

[PATCH] D105066: [Coroutines] Remove CoroElide from O0 pipeline

lxfind added a comment. > Yeah, but it may be inlined after splitting, which could trigger coro elide. In O0, there is no inliner pass (after CoroSplit), so inlining should never happen. >> in fact, we should make it illegal to mark a coroutine "always_inline", >> because there is no guarante

[PATCH] D105066: [Coroutines] Remove CoroElide from O0 pipeline

ChuanqiXu added a comment. In D105066#2845978 , @lxfind wrote: > Coroutine functions cannot be inlined before splitting, even if it's marked > "always_inline" Yeah, but it may be inlined after splitting, which could trigger coro elide. > in fact, we s

[PATCH] D105066: [Coroutines] Remove CoroElide from O0 pipeline

lxfind added a comment. In D105066#2845958 , @ChuanqiXu wrote: > On O0, it is possible to inline if the user marked the function with > `always_inline`. > Since CoroElide is kind of optimization, it should be OK to skip in O0. > Out of curiosity, what's

[PATCH] D105066: [Coroutines] Remove CoroElide from O0 pipeline

ChuanqiXu added a comment. On O0, it is possible to inline if the user marked the function with `always_inline`. Since CoroElide is kind of optimization, it should be OK to skip in O0. Out of curiosity, what's the reason that you want to remove it? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D97824: [ObjC][ARC] Don't add operand bundle `clang.arc.attachedcall` to a call if the call already has the operand bundle

ahatanak updated this revision to Diff 355080. ahatanak added a comment. Check the presence of the operand bundle earlier in `emitARCOperationAfterCall`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97824/new/ https://reviews.llvm.org/D97824 File

[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

khchen added a comment. This all looks good to me except adding back the asm check. BTW, do we need to attach the half-precision floating point spec link? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105001/new/ https://reviews.llvm.org/D105001

[PATCH] D105066: [Coroutines] Remove CoroElide from O0 pipeline

lxfind updated this revision to Diff 355073. lxfind added a comment. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105066/new/ https://reviews.llvm.org/D105066 Files: clang/test/CodeGenCoroutines/coro-newpm-pipeline.cpp llvm/lib/P

[PATCH] D104088: Add clang frontend flags for MIP

ellis updated this revision to Diff 355066. ellis added a comment. Add min instruction count frontend flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104088/new/ https://reviews.llvm.org/D104088 Files: clang/include/clang/Driver/Options.td

[PATCH] D105066: [Coroutines] Remove CoroElide from O0 pipeline

lxfind created this revision. lxfind added reviewers: ChuanqiXu, rjmccall. Herald added subscribers: hoy, modimo, wenlei, hiraditya. lxfind requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. CoroElide pass works only when a p

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen added a comment. In D103938#2836470 , @rsmith wrote: > I've given this some more thought, and I think it's only the "constant > evaluated" check that we want to bypass in this case. It's common to use > `sizeof` or `decltype` with a comma operator

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen updated this revision to Diff 355054. ychen added a comment. - Add test case for 'constexpr if' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 Files: clang/include/clang/Sema/Sema.h clang/lib/S

Maintenance works in llvm lab tomorrow June 29

Hello, LLVM lab and build master will be unavailable tomorrow June 29 for about an hour starting 2PM PST due maintenance works in the lab. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

This revision was automatically updated to reflect the committed changes. Closed by commit rG633ca3ff2f8f: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing… (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 633ca3f - [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

Author: Hongtao Yu Date: 2021-06-28T14:50:41-07:00 New Revision: 633ca3ff2f8fc2e2b69001d17abc43f302578fc1 URL: https://github.com/llvm/llvm-project/commit/633ca3ff2f8fc2e2b69001d17abc43f302578fc1 DIFF: https://github.com/llvm/llvm-project/commit/633ca3ff2f8fc2e2b69001d17abc43f302578fc1.diff LO

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 355036. cor3ntin added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. Optimize character lookup for ascii Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman updated this revision to Diff 355035. dgoldman added a comment. Fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104117/new/ https://reviews.llvm.org/D104117 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D103461: [clang][deps] NFC: Preserve the original frontend action

dexonsmith added a comment. In D103461#2841918 , @bmahjour wrote: > @jansvoboda11 This change is causing the following LIT tests to fail on AIX: I think @jansvoboda11 is out this week (IIRC, back next week). A possible interim workaround would be to add

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, but since this hasn't been up for long maybe leave it open for a bit in case someone else has a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105052/new/ https

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks alright, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102356/new/ https://reviews.llvm.org/D102356 _

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:130 TT.isArch64Bit() -? "e-m:e-p:64:64-i64:64-n32:64-S128-ni:1" -: "e-m:e-p:32:32-i64:64-n32:64-S12

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

hoy updated this revision to Diff 355012. hoy added a comment. Herald added a subscriber: modimo. Added tests for static ctor/dtor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102356/new/ https://reviews.llvm.org/D102356 Files: clang/lib/CodeG

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

dblaikie added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10466 if (isa(D)) - return CheckFreeArgumentsOnLvalue(S, CalleeName, UnaryExpr, D); + if (!isa(D) || + !dyn_cast(D)->getType()->isReferenceType()) cjdb wrote: > db

[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

bansan added a comment. @kbobyrev Thanks, it's probably that. I thought I could send a patch/commit with my Phabricator account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104981/new/ https://reviews.llvm.org/D104981 __

Re: [clang] e5c7c17 - [clang] Rename StringRef _lower() method calls to _insensitive()

Ah, found it in https://reviews.llvm.org/D104819 - good to leave that in in the "Differential Revision: " part of the commit message (or if you end up splitting patches off from a review, such that it doesn't necessarily make sense for it to close the review (preparatory patches, etc) then linking

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1138 + +Ops[0] = TableSet; // The new chain is the TableSet itself + } I was expecting to see a TABLE_SET back to a null after the call here to avoid the GC ro

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

NoQ added a comment. > We have a few in `test/Analysis/exploded-graph-rewriter/` where we test parts > of the emitted html. And they're now failing on the pre-merge buildbots. So i guess updating existing tests would already be nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. More buildbot failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104729/new/ https://reviews.llvm

[clang] 1d85d08 - Revert "[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options"

Author: Melanie Blower Date: 2021-06-28T15:47:21-04:00 New Revision: 1d85d0879a75b9556b10f55739437af8233c0b64 URL: https://github.com/llvm/llvm-project/commit/1d85d0879a75b9556b10f55739437af8233c0b64 DIFF: https://github.com/llvm/llvm-project/commit/1d85d0879a75b9556b10f55739437af8233c0b64.diff

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

alexfh added a comment. Function-wise the patch looks good, but I'm somewhat concerned about silently breaking users. At the very least there should be a relevant entry in the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49864/new/

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

arphaman created this revision. arphaman added reviewers: dexonsmith, dcoughlin, Bigcheese. Herald added a subscriber: ributzka. Herald added a reviewer: aaron.ballman. arphaman requested review of this revision. This patch adds support for Mac Catalyst availability attribute, as supported by the

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:130 TT.isArch64Bit() -? "e-m:e-p:64:64-i64:64-n32:64-S128-ni:1" -: "e-m:e-p:32:32-i64:64-n32:64-S128

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

alexfh added a comment. I thought I sent this batch of comments loong ago =\ Better late than never. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:113-120 +#define FB(Name, K) MIX_##Name = (1ull << (K##ull - 1ull)) + + FB(None, 1),

[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

kbobyrev added a comment. In D104981#2845005 , @bansan wrote: > @kbobyrev Yes please. I downloaded arc. I created a commit where last line is > "Differential Revision: https://reviews.llvm.org/D104981";. > > I linked my github account to llvm's phabricat

[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGe837ce2a3236: [clang-tidy] Add -line-filter to run-clang-tidy.py (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104981/new/ https://r

[clang-tools-extra] e837ce2 - [clang-tidy] Add -line-filter to run-clang-tidy.py

Author: Kirill Bobyrev Date: 2021-06-28T21:17:36+02:00 New Revision: e837ce2a32369b2e9e8e5d60270c072c7dd63827 URL: https://github.com/llvm/llvm-project/commit/e837ce2a32369b2e9e8e5d60270c072c7dd63827 DIFF: https://github.com/llvm/llvm-project/commit/e837ce2a32369b2e9e8e5d60270c072c7dd63827.diff

[PATCH] D105049: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

etcwilde created this revision. etcwilde added a reviewer: compnerd. etcwilde added a project: clang. etcwilde requested review of this revision. Herald added a subscriber: cfe-commits. There are some trailing semicolons on namespaces in clang/lib/APINotes/APINotesFormat.h. These result in warnin

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dbe1c675fe9: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to c

[clang] 2dbe1c6 - [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

Author: Melanie Blower Date: 2021-06-28T15:09:53-04:00 New Revision: 2dbe1c675fe94eeb7973dcc25b049d25f4ca4fa0 URL: https://github.com/llvm/llvm-project/commit/2dbe1c675fe94eeb7973dcc25b049d25f4ca4fa0 DIFF: https://github.com/llvm/llvm-project/commit/2dbe1c675fe94eeb7973dcc25b049d25f4ca4fa0.diff

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. buildbot fails in lldb, will submit updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104729/new/ https://reviews.llvm.org/D104729 __

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. buildbot fails on lldb need to update this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/ https://reviews.llvm.org/D100118 _

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104556/new/ https://reviews.llvm.org/D104556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

bansan added a comment. @kbobyrev Yes please. I downloaded arc. I created a commit where last line is "Differential Revision: https://reviews.llvm.org/D104981";. I linked my github account to llvm's phabricator. But when I `arc land`, I can't logon with my github username. STRATEGY Merging

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 354973. cor3ntin added a comment. Fix clang tidy check, update cxx_status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/Diagnost

[PATCH] D105039: [clangd] Add a flag to disable formatting of tweak edits

This revision was automatically updated to reflect the committed changes. Closed by commit rG614b46e4dcab: [clangd] Add a flag to disable formatting of tweak edits (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105039/new/ htt

[clang-tools-extra] 614b46e - [clangd] Add a flag to disable formatting of tweak edits

Author: Kadir Cetinkaya Date: 2021-06-28T20:52:47+02:00 New Revision: 614b46e4dcab0d095e05f8b4da45ef935b7b86b4 URL: https://github.com/llvm/llvm-project/commit/614b46e4dcab0d095e05f8b4da45ef935b7b86b4 DIFF: https://github.com/llvm/llvm-project/commit/614b46e4dcab0d095e05f8b4da45ef935b7b86b4.dif

[clang] 280593b - [Clang] [NFC] fix CHECK lines for convergent attribute tests

Author: Sameer Sahasrabuddhe Date: 2021-06-29T00:21:07+05:30 New Revision: 280593bd3ff1db6d19ccb8182698dd9c816734e2 URL: https://github.com/llvm/llvm-project/commit/280593bd3ff1db6d19ccb8182698dd9c816734e2 DIFF: https://github.com/llvm/llvm-project/commit/280593bd3ff1db6d19ccb8182698dd9c816734e

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

cjdb added a comment. Oops, looks like I never submitted my replies! Comment at: clang/lib/Sema/SemaChecking.cpp:10466 if (isa(D)) - return CheckFreeArgumentsOnLvalue(S, CalleeName, UnaryExpr, D); + if (!isa(D) || + !dyn_cast(D)->getType()->isReferenceTy

Re: [clang] e5c7c17 - [clang] Rename StringRef _lower() method calls to _insensitive()

Was this design/code reviewed (there's no mention in the commit message of a link to a phab review, for instance)? Probably worth some discussion - if there was a review, could you link it here in a reply? On Thu, Jun 24, 2021 at 2:23 PM Martin Storsjö via cfe-commits < cfe-commits@lists.llvm.org>

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

NoQ added a comment. Yay, great, thanks! Can you add a test as well? We have a few in `test/Analysis/exploded-graph-rewriter/` where we test parts of the emitted html. Do you happen to have a screenshot of how it looks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D104550: [analyzer] Implement getType for SVal

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Amazing, thanks!! Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h:213 + /// bound expression AST node as well, since AST always has exact types. + QualT

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

NoQ added a comment. Thanks! Why isn't this a `NoteTag`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104925/new/ https://reviews.llvm.org/D104925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

Quuxplusone added a comment. @cor3ntin do you have any interest in making a similar patch for the LWG issues? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105024/new/ https://reviews.llvm.org/D105024 __

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

NoQ added a comment. Thanks, nice! More stuff to support. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:307 if (CastE->getCastKind() == CK_LValueToRValue) { for (ExplodedNodeSet::iterator I = dstPreStmt.begin(), E = dstPreStmt.end(); How

[PATCH] D104883: [CodeGen] Add ParmVarDecls to FunctionDecls that are created to generate ObjC property getter/setter functions

ahatanak added a comment. I'll wait a day or two in case someone else has feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104883/new/ https://reviews.llvm.org/D104883 ___ cfe-commits mailing list

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 18c3c7784975700ae463bb461487d46e74324a66 , thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang] 18c3c77 - Add papers adopted by the C++ committee in the June 2021 plenary

Author: Corentin Jabot Date: 2021-06-28T13:45:12-04:00 New Revision: 18c3c7784975700ae463bb461487d46e74324a66 URL: https://github.com/llvm/llvm-project/commit/18c3c7784975700ae463bb461487d46e74324a66 DIFF: https://github.com/llvm/llvm-project/commit/18c3c7784975700ae463bb461487d46e74324a66.diff

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#2844766 , @dmaclach wrote: > Has anything happened with this at all or did it get dropped? I can work with you and @rjmccall to land a version of this. We can chat offline if you'd like too. Repository: rG LLVM Githu

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

dmaclach added a comment. Has anything happened with this at all or did it get dropped? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 ___ cfe-commits mailing li

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 354945. pmatos added a comment. Checks for inttoptr and ptrtoint insts in wasm backend and bails out if necessary. Also addresses @tlively's comments to the original patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D105039: [clangd] Add a flag to disable formatting of tweak edits

kadircet updated this revision to Diff 354941. kadircet added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105039/new/ https://reviews.llvm.org/D105039 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extra/c

[PATCH] D104946: [AMDGPU] Add builtin functions image_bvh_intersect_ray

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:221-224 +TARGET_BUILTIN(__builtin_amdgcn_image_bvh_intersect_ray, "V4UiUifV4fV4fV4fV4Ui", "nc", "gfx10-insts") +TARGET_BUILTIN(__builtin_amdgcn_image_b

[clang] c27e5a2 - Revert "[clang][patch][fpenv] Add builtin __arithmetic_fence and option fprotect-parens"

Author: Melanie Blower Date: 2021-06-28T12:42:59-04:00 New Revision: c27e5a2a8e34aaa4c6037498cd8d21df0a8e8e70 URL: https://github.com/llvm/llvm-project/commit/c27e5a2a8e34aaa4c6037498cd8d21df0a8e8e70 DIFF: https://github.com/llvm/llvm-project/commit/c27e5a2a8e34aaa4c6037498cd8d21df0a8e8e70.diff

[clang] 8815ef8 - Revert "[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options"

Author: Melanie Blower Date: 2021-06-28T12:42:59-04:00 New Revision: 8815ef823c803e98f328068d1abde255296de9c3 URL: https://github.com/llvm/llvm-project/commit/8815ef823c803e98f328068d1abde255296de9c3 DIFF: https://github.com/llvm/llvm-project/commit/8815ef823c803e98f328068d1abde255296de9c3.diff

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaronpuchert added a subscriber: rupprecht. aaronpuchert added a comment. In D104261#2841356 , @delesley wrote: > since it's restricted to relockable managed locks, I'm not too worried... Not quite, it affects scoped locks with explicit unlock, which was

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f1238e44d80: [clang][patch][fpenv] Add builtin __arithmetic_fence and option fprotect-parens (authored by mibintc). Repository: rG LLVM Github Mo

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c02b0c3f454: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG931e95687d6d: [llvm][clang][fpenv] Create new intrinsic llvm.arith.fence to control FP… (authored by mibintc). Repository: rG LLVM Github Monorepo

[clang] 4f1238e - [clang][patch][fpenv] Add builtin __arithmetic_fence and option fprotect-parens

Author: Melanie Blower Date: 2021-06-28T12:26:53-04:00 New Revision: 4f1238e44d803b145997fa984677a6c5cdf1f417 URL: https://github.com/llvm/llvm-project/commit/4f1238e44d803b145997fa984677a6c5cdf1f417 DIFF: https://github.com/llvm/llvm-project/commit/4f1238e44d803b145997fa984677a6c5cdf1f417.diff

[clang] 2c02b0c - [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

Author: Melanie Blower Date: 2021-06-28T12:26:53-04:00 New Revision: 2c02b0c3f45414ac6c64583e006a26113c028304 URL: https://github.com/llvm/llvm-project/commit/2c02b0c3f45414ac6c64583e006a26113c028304 DIFF: https://github.com/llvm/llvm-project/commit/2c02b0c3f45414ac6c64583e006a26113c028304.diff

[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:27 // i -> int -// h -> half +// h -> half (__fp16) +// x -> half (_Float16) This also includes OpenCL half Comment at: clang/test/CodeGen/RISCV/rvv-int

[PATCH] D105039: [clangd] Add a flag to disable formatting of tweak edits

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG - I do think a config knob for this would be nice one day. As discussed offline it would also cover rename, code complete insertion... Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3fe847f9d90: [Clang] Add option to handle behaviour of vector bool/vector pixel. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615

[clang] c3fe847 - [Clang] Add option to handle behaviour of vector bool/vector pixel.

Author: Stefan Pintilie Date: 2021-06-28T11:16:37-05:00 New Revision: c3fe847f9d90de5a6a76fd1d5f5823ab4719accc URL: https://github.com/llvm/llvm-project/commit/c3fe847f9d90de5a6a76fd1d5f5823ab4719accc DIFF: https://github.com/llvm/llvm-project/commit/c3fe847f9d90de5a6a76fd1d5f5823ab4719accc.dif

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov updated this revision to Diff 354924. mizvekov added a comment. - Fix missing period as pointed by rsmith. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104680/new/ https://reviews.llvm.org/D104680 Files: clang/include/clang/Basic/Diagn

[PATCH] D105039: [clangd] Add a flag to disable formatting of tweak edits

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Some tweaks might edit file typ

  1   2   >