[PATCH] D103949: Only consider built-in compound assignment operators for -Wunused-but-set-*

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5b9489b2415: Only consider built-in compound assignment operators for -Wunused-but-set-* (authored by sberg). Changed prior to commit: https://re

[clang] b5b9489 - Only consider built-in compound assignment operators for -Wunused-but-set-*

Author: Stephan Bergmann Date: 2021-06-14T08:04:03+02:00 New Revision: b5b9489b2415dc48c39d4d7d4bae6197dc499f38 URL: https://github.com/llvm/llvm-project/commit/b5b9489b2415dc48c39d4d7d4bae6197dc499f38 DIFF: https://github.com/llvm/llvm-project/commit/b5b9489b2415dc48c39d4d7d4bae6197dc499f38.di

[PATCH] D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+

This revision was automatically updated to reflect the committed changes. Closed by commit rG092c303955cd: AMD k8 family does not support SSE4.x which are required by x86-64-v2+ (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: r

[clang] 092c303 - AMD k8 family does not support SSE4.x which are required by x86-64-v2+

Author: serge-sans-paille Date: 2021-06-14T07:17:30+02:00 New Revision: 092c303955cd18be6c0b923b1c0a1b96e2c91893 URL: https://github.com/llvm/llvm-project/commit/092c303955cd18be6c0b923b1c0a1b96e2c91893 DIFF: https://github.com/llvm/llvm-project/commit/092c303955cd18be6c0b923b1c0a1b96e2c91893.d

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

SouraVX added a comment. In D104118#2813358 , @stuart wrote: > Note: there is currently no DWARF language code defined for //C++ for > OpenCL//, so we must use DW_LANG_C_plus_plus* if we wish to be able to > determine whether output has been generated f

[PATCH] D104192: [clang][RISCV] Change implicit ARCH for explicitly specified ABI

benshi001 added a comment. In D104192#2815757 , @MaskRay wrote: > The thing looks weird. My mental model (ppc) is that `-march` can infer > `-mabi`, not the other way around... The original way in Driver/Toolchains/Arch/RISCV.cpp is if (MABI.equals_l

[PATCH] D100139: [ifs][elfabi] Merge llvm-ifs/elfabi tools

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/InterfaceStubs.cpp:18 namespace ifstool { void Merger::ConstructJob(Compilation &C, const JobAction &JA,

[libunwind] e03be2e - unwind: allow building with GCC

Author: Saleem Abdulrasool Date: 2021-06-13T14:44:54-07:00 New Revision: e03be2efe564026ad3b04d459794c89c674e1ed9 URL: https://github.com/llvm/llvm-project/commit/e03be2efe564026ad3b04d459794c89c674e1ed9 DIFF: https://github.com/llvm/llvm-project/commit/e03be2efe564026ad3b04d459794c89c674e1ed9.

[PATCH] D103807: [clang][deps] Ensure deterministic order of TU '-fmodule-file=' arguments

dexonsmith added a comment. I'm not sure the performance problems with std::map will matter in practice here, but have you considered sorting before emission rather than relying on the data structure's iteration order? (It'd make it easy to switch to StringMap in the future.) Repository: rG

[PATCH] D103526: [clang][deps] Handle modular dependencies present in PCH

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103526/new/ https://reviews.llvm.org/D103526 __

[PATCH] D103802: [clang][modules][pch] Allow loading PCH with different modules cache path

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103802/new/ https://reviews.llvm.org/D103802 __

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:3 --- NOTE: This file is automatically generated by running clang-tblgen -gen-opt-docs. Do not edit this file by hand!! ---

[PATCH] D104012: [clang][deps] Move stripping of diagnostic serialization from `clang-scan-deps` to `DependencyScanning` library

dexonsmith accepted this revision. dexonsmith added a comment. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104012/new/ https://reviews.llvm.org/D104012 ___ cfe-commits mailing list cfe-commit

[PATCH] D103461: [clang][deps] NFC: Preserve the original frontend action

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Okay, LGTM. (Sorry for the delay, I've been out.) In D103461#2793254 , @jansvoboda11 wrote: > My reason for the FIXME is that we could get ri

[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with one suggestion inline. Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:194 CompilerInstance &I, Depe

[PATCH] D104104: [clang][deps] NFC: Handle `DependencyOutputOptions` only once

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104104/new/ https://reviews.llvm.org/D104104 __

[PATCH] D104106: [clang][deps] NFC: Stop using moved-from object

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104106/new/ https://reviews.llvm.org/D104106 __

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

MaskRay added a comment. Note, clang-cl is an executable (`ninja clang-cl`), so using `clang-cl` in the subject can cause confusion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104076/new/ https://reviews.llvm.org/D104076 __

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG673c5ba58497: [clang-format] Adds a formatter for aligning arrays of structs (authored by feg208, committed by HazardyKnusperkeks). Repository: rG

[clang] 673c5ba - [clang-format] Adds a formatter for aligning arrays of structs

Author: Fred Grim Date: 2021-06-13T21:14:37+02:00 New Revision: 673c5ba58497298a684f8b8dfddbfb11cd89950e URL: https://github.com/llvm/llvm-project/commit/673c5ba58497298a684f8b8dfddbfb11cd89950e DIFF: https://github.com/llvm/llvm-project/commit/673c5ba58497298a684f8b8dfddbfb11cd89950e.diff LOG

[clang] 527a182 - DirectoryWatcher: also wait for the notifier thread

Author: Saleem Abdulrasool Date: 2021-06-13T10:58:55-07:00 New Revision: 527a1821e6f8e115db3335a3341c7ac491725a0d URL: https://github.com/llvm/llvm-project/commit/527a1821e6f8e115db3335a3341c7ac491725a0d DIFF: https://github.com/llvm/llvm-project/commit/527a1821e6f8e115db3335a3341c7ac491725a0d.

[PATCH] D104192: [clang][RISCV] Change implicit ARCH for explicitly specified ABI

MaskRay added a comment. The thing looks weird. My mental model is that `-march` can infer `-mabi`, not the other way around... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104192/new/ https://reviews.llvm.org/D104192 ___

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 351728. SaurabhJha added a comment. Forgot to add a colon in code-block header. Fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: clang/docs/Language

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha created this revision. Herald added a subscriber: tschuett. SaurabhJha requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds examples of compound assignment and type conversions for matrix types. Repository: rG LLV

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

HazardyKnusperkeks added a comment. >> In D104044#2812399 , @darwin wrote: >> >>> About the issue, let me explain it. It isn't bound to the google style or >>> LLVM style either, since both of them keep the first brace at the same line >>> of the namespa

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

darwin added a comment. In D104044#2814016 , @HazardyKnusperkeks wrote: > Going the full way, to fix the number of empty lines after/before/between > elements would be real nice. But even nicer would be if you can state a range. > > But I think all thos

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

darwin added a comment. In D104044#2813515 , @MyDeveloperDay wrote: > Do we need a set options for when we want to insert/retain/add a newline > after various constructs? frankly I've been mulling over the concept of > adding a > > NewLinesBetweenFun

[PATCH] D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ff3a89a7b94: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of… (authored by zero9178). Repository: rG LLVM Github Monorepo

[clang] 7ff3a89 - [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand

Author: Markus Böck Date: 2021-06-13T14:48:27+02:00 New Revision: 7ff3a89a7b94193638cb13f8a0a1ef70094c8263 URL: https://github.com/llvm/llvm-project/commit/7ff3a89a7b94193638cb13f8a0a1ef70094c8263 DIFF: https://github.com/llvm/llvm-project/commit/7ff3a89a7b94193638cb13f8a0a1ef70094c8263.diff L

[clang] 7d7e913 - SValExplainer.h - get APSInt values by const reference instead of value. NFCI.

Author: Simon Pilgrim Date: 2021-06-13T13:05:17+01:00 New Revision: 7d7e913e096a915038dd41d0bfe5dd8827da1f60 URL: https://github.com/llvm/llvm-project/commit/7d7e913e096a915038dd41d0bfe5dd8827da1f60 DIFF: https://github.com/llvm/llvm-project/commit/7d7e913e096a915038dd41d0bfe5dd8827da1f60.diff

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf2063178218: [clang] Implement P2266 Simpler implicit move (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews

[clang] bf20631 - [clang] Implement P2266 Simpler implicit move

Author: Matheus Izvekov Date: 2021-06-13T12:10:56+02:00 New Revision: bf20631782183cd19e0bb7219e908c2bbb01a75f URL: https://github.com/llvm/llvm-project/commit/bf20631782183cd19e0bb7219e908c2bbb01a75f DIFF: https://github.com/llvm/llvm-project/commit/bf20631782183cd19e0bb7219e908c2bbb01a75f.dif

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

vsavchenko added a comment. In D103314#2810795 , @martong wrote: > I have the first measurements results in the attached zip file. The file > contains the html file generated by csa-testbench. It's name contains `CTU` > but actually it was a regular non