[PATCH] D104192: [clang][RISCV] Change implicit ARCH for explicitly specified ABI

benshi001 created this revision. benshi001 added reviewers: asb, luismarques, MaskRay, craig.topper. Herald added subscribers: vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

wenlei added a comment. In D104099#2814167 , @davidxl wrote: > Adding Wei to help measure performance impact on our internal workloads. > Also add Wenlei to help measure impact with FB's workloads. Measured perf using FB internal workload w/ and w/o th

[PATCH] D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand

zero9178 added a comment. In D104182#2815397 , @davrec wrote: > Was this performance hit when using the static analyzer? A quick search > suggests `isAnyDestructorNoReturn()` is only called within the analyzer, > whereas comparable CXXRecordDecl method

[PATCH] D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand

davrec added a comment. Was this performance hit when using the static analyzer? A quick search suggests `isAnyDestructorNoReturn()` is only called within the analyzer, whereas comparable CXXRecordDecl methods whose results are stored (`hasIrrelevantDestructor()` etc.) seem to be called somewh

RE: [PATCH] D103131: support debug info for alias variable

> > 0x002a: DW_TAG_variable > > DW_AT_name ("oldname") > > DW_AT_type (0x003f "int") > > DW_AT_external (true) > > DW_AT_decl_file ("/folk/kkumar/tcllvm/llvm-build-lldb- > rel/bin/test.c") > >

[PATCH] D103131: support debug info for alias variable

dblaikie added a comment. In D103131#2814595 , @kamleshbhalui wrote: > In D103131#2814015 , @dblaikie > wrote: > >> In D103131#2811969 , >> @kamleshbhalui wrote: >> >>>

[clang] 76f1baa - Revert "Revert "DirectoryWatcher: add an implementation for Windows""

Author: Saleem Abdulrasool Date: 2021-06-12T09:27:44-07:00 New Revision: 76f1baa7875acd88bdd4b431eed6e2d2decfc0fe URL: https://github.com/llvm/llvm-project/commit/76f1baa7875acd88bdd4b431eed6e2d2decfc0fe DIFF: https://github.com/llvm/llvm-project/commit/76f1baa7875acd88bdd4b431eed6e2d2decfc0fe.

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd added a comment. I was able to play around with this further yesterday evening. You are correct - the issue is the load preventing the watcher thread from spinning up. I was able to reproduce this issue and resolve it by adding in a synchronization point (boolean + mutex + condition

[PATCH] D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand

zero9178 created this revision. zero9178 added reviewers: davrec, bruno, rsmith, aaron.ballman. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch addresses a performance issue I noticed when using clang-12 to compile proj

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks for the work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 ___ cfe-comm

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e50c3d785f4: [clang] NRVO: Improvements and handling of more cases. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ https:

[clang] 1e50c3d - [clang] NRVO: Improvements and handling of more cases.

Author: Matheus Izvekov Date: 2021-06-12T16:43:32+02:00 New Revision: 1e50c3d785f4563873ab1ce86559f2a1285b5678 URL: https://github.com/llvm/llvm-project/commit/1e50c3d785f4563873ab1ce86559f2a1285b5678 DIFF: https://github.com/llvm/llvm-project/commit/1e50c3d785f4563873ab1ce86559f2a1285b5678.dif

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski added a comment. @MyDeveloperDay, Thanks for the review. I do not have submit access. Can you take care of landing the revision when you have some free time ? Comment at: clang/unittests/Format/FormatTest.cpp:1243 + verifyFormat("int *f1(int &a) const & = 0;", Sty

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski updated this revision to Diff 351649. skirkovski marked 3 inline comments as done. skirkovski added a comment. Sort ReferenceAlignment after RawStringFormats in mapping() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

MyDeveloperDay added a comment. A crash (https://bugs.llvm.org/show_bug.cgi?id=50663) in 12.0.1 is fixed by your changes here when merged to the 12 branch, I'm not sure if this needs to be backported to 12 I guess it might depend on if we think it's critical enough or if there will more 12 rel

[PATCH] D19066: clang-format: `SpaceAfterTemplate` and `SpacesInBraces` options

MyDeveloperDay added a comment. This is already resolved with `SpaceAfterTemplateKeyword` and `SpaceInEmptyBlock` I'm going to commandeer and abandon CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19066/new/ https://reviews.llvm.org/D19066 __

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Format/Format.h:2647 - /// The ``&`` and ``*`` alignment style. + /// The ``&``, ``&&`` and ``*`` alignment style.

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski updated this revision to Diff 351645. skirkovski added a comment. Remove PAS_Pointer from Webkit style (since it derives from LLVM which already has it) Add empty lines between style change in the test case Split a verifyFormat with 3 different cases into different ones Add test cases