[PATCH] D100742: [clangd] Parameter hints for dependent calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f8963c80195: [clangd] Parameter hints for dependent calls (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 1f8963c - [clangd] Parameter hints for dependent calls

Author: Nathan Ridge Date: 2021-05-03T02:03:16-04:00 New Revision: 1f8963c80195aa86d02e81acedcf1ff3da127842 URL: https://github.com/llvm/llvm-project/commit/1f8963c80195aa86d02e81acedcf1ff3da127842 DIFF: https://github.com/llvm/llvm-project/commit/1f8963c80195aa86d02e81acedcf1ff3da127842.diff

[PATCH] D101741: [clangd] Improve resolution of static method calls in HeuristicResolver

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Githu

[PATCH] D100742: [clangd] Parameter hints for dependent calls

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:264 +// FIXME: This one does not work yet. +A::static_member($par3[[t]]); } sammccall wrote: > nridge wrote: > > This is an interesting case. Cl

[PATCH] D100742: [clangd] Parameter hints for dependent calls

nridge updated this revision to Diff 342314. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100742/new/ https://reviews.llvm.org/D100742 Files: clang-tools-extra/clangd/HeuristicResolver.cpp clang

[clang-tools-extra] 3504e50 - [clangd] Fix test failure in initialize-params.test

Author: Nathan Ridge Date: 2021-05-03T01:37:09-04:00 New Revision: 3504e50b6db5ec71cf0df5a14a2576c1003614c9 URL: https://github.com/llvm/llvm-project/commit/3504e50b6db5ec71cf0df5a14a2576c1003614c9 DIFF: https://github.com/llvm/llvm-project/commit/3504e50b6db5ec71cf0df5a14a2576c1003614c9.diff

[PATCH] D101740: [clangd] Fix test failure in initialize-params.test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3504e50b6db5: [clangd] Fix test failure in initialize-params.test (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D101740: [clangd] Fix test failure in initialize-params.test

nridge added a comment. Broke this in D101275 which put the capability behind a flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101740/new/ https://reviews.llvm.org/D101740 __

[PATCH] D101740: [clangd] Fix test failure in initialize-params.test

nridge created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[clang-tools-extra] 1f1fb5e - [clangd] Fix build error in SemanticHighlighting.cpp

Author: Nathan Ridge Date: 2021-05-03T01:19:07-04:00 New Revision: 1f1fb5e8e6b214f7f13a4e4731b6d6add33508aa URL: https://github.com/llvm/llvm-project/commit/1f1fb5e8e6b214f7f13a4e4731b6d6add33508aa DIFF: https://github.com/llvm/llvm-project/commit/1f1fb5e8e6b214f7f13a4e4731b6d6add33508aa.diff

[PATCH] D101275: [clangd] Hide inlay hints capability behind a command-line flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcea736e5b8a4: [clangd] Hide inlay hints capability behind a command-line flag (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES S

[clang-tools-extra] cea736e - [clangd] Hide inlay hints capability behind a command-line flag

Author: Nathan Ridge Date: 2021-05-03T01:01:57-04:00 New Revision: cea736e5b8a48065007a591d71699b53c04d95b3 URL: https://github.com/llvm/llvm-project/commit/cea736e5b8a48065007a591d71699b53c04d95b3 DIFF: https://github.com/llvm/llvm-project/commit/cea736e5b8a48065007a591d71699b53c04d95b3.diff

[PATCH] D101275: [clangd] Hide inlay hints capability behind a command-line flag

nridge updated this revision to Diff 342310. nridge marked 4 inline comments as done. nridge added a comment. Address review comments, including making the flag not hidden Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101275/new/ https://reviews.ll

[PATCH] D101270: [clangd] Avoid including HeuristicResolver.h from ParsedAST.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43cbf2bb84eb: [clangd] Avoid including HeuristicResolver.h from ParsedAST.h (authored by nridge). Changed prior to commit: https://reviews.llvm.or

[clang-tools-extra] 43cbf2b - [clangd] Avoid including HeuristicResolver.h from ParsedAST.h

Author: Nathan Ridge Date: 2021-05-03T00:55:22-04:00 New Revision: 43cbf2bb84eb319ff3e95b3316344ece35ea59b1 URL: https://github.com/llvm/llvm-project/commit/43cbf2bb84eb319ff3e95b3316344ece35ea59b1 DIFF: https://github.com/llvm/llvm-project/commit/43cbf2bb84eb319ff3e95b3316344ece35ea59b1.diff

[PATCH] D101739: [OpenMP] Fix non-determinism in clang task codegen

ggeorgakoudis created this revision. Herald added subscribers: mgrang, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https

[PATCH] D90110: [clang-tidy] Use --use-color in run-clang-tidy.py

Toni added a comment. Just a note for future changes: This change breaks parsers which relied on no colored input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90110/new/ https://reviews.llvm.org/D90110 __

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was temporarily disabled

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

dblaikie added a comment. I thought maybe /some/ of the other targets used end-to-end clang tests to test intrinsics, but I can't seem to find any (they seem to be a small minority, if there are any): grep -r -l intrin.h clang/test/ | xargs grep -L emit-llvm.*FileCheck | xargs grep RUN | les

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:836-837 + NewState, NewNode, + C.getNoteTag([Msg](PathSensitiveBugReport &BR, + llvm::raw_ostream &OS) { OS << Msg; })); } -

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

aheejin added a comment. In D101684#2732551 , @dblaikie wrote: > In D101684#2732522 , @aheejin wrote: > >> I think there's a clear upside on keeping this within clang/. >> >> 1. As @tlively said, there are many nu

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

dblaikie added a comment. In D101684#2732522 , @aheejin wrote: > I think there's a clear upside on keeping this within clang/. > > 1. As @tlively said, there are many number of instructions to test and > keeping "C function - LLVM intrinsic" and "LLVM in

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

aheejin added a comment. I think there's a clear upside on keeping this within clang/. 1. As @tlively said, there are many number of instructions to test and keeping "C function - LLVM intrinsic" and "LLVM intrinsic - Wasm instruction" tests in sync without autogeneration will be hard and error

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies updated this revision to Diff 342280. ffrankies marked 12 inline comments as done. ffrankies added a comment. Removed unused import statements from IdDependentBackwardBranch.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70094/new/ https://reviews.llvm.org/D70094 Files:

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

dblaikie added a comment. In D101684#2732408 , @tlively wrote: > In D101684#2732395 , @dblaikie > wrote: > >> In D101684#2732366 , @tlively >> wrote: >> >>> In order to

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies updated this revision to Diff 342278. ffrankies added a comment. Addressed comments by @aaron.ballman - Changed capitalization in enum - Used `std::move` in `IdDependencyRecord` constructors - Initialized `VariableDeclaration` and `FieldDeclaration` to `nullptr` - Used `isAssignmentOper

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

tlively added a comment. In D101684#2732395 , @dblaikie wrote: > In D101684#2732366 , @tlively wrote: > >> In order to get the benefit of this end-to-end test from split tests like >> that, the LLVM test would ha

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

dblaikie added a comment. In D101684#2732366 , @tlively wrote: > In D101684#2732310 , @dblaikie > wrote: > >>> Assembly tests are generally discouraged in clang, but in this case we >>> actually care about the s

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

tlively added a comment. In D101684#2732310 , @dblaikie wrote: >> Assembly tests are generally discouraged in clang, but in this case we >> actually care about the specific instruction being generated from the >> intrinsics. > > I don't think this is a

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

SaurabhJha added a comment. All comments addressed now :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101696/new/ https://reviews.llvm.org/D101696 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

SaurabhJha updated this revision to Diff 342266. SaurabhJha added a comment. Revert change of sext -> zext Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101696/new/ https://reviews.llvm.org/D101696 Files: clang/lib/CodeGen/CGExprScalar.cpp cla

[PATCH] D101561: [Prototype] Introduce attribute for ignoring C++ ABI

aeubanks added a comment. ah I wasn't aware of that, thanks! sorry for the extra noise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101561/new/ https://reviews.llvm.org/D101561 ___ cfe-commits mailing l

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

dblaikie added a comment. > Assembly tests are generally discouraged in clang, but in this case we > actually care about the specific instruction being generated from the > intrinsics. I don't think this is a sound reason to add an end-to-end test in clang. The same is true of all clang tests,

[PATCH] D101671: Modules: Remove an extra early return, NFC

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101671/new/ https://reviews.llvm.org/D101671 ___

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

SaurabhJha added inline comments. Comment at: clang/test/CodeGenCXX/matrix-casts.cpp:26 + // CHECK: [[C:%.*]] = load <25 x i8>, <25 x i8>* {{.*}}, align 1 + // CHECK-NEXT: [[CONV:%.*]] = sext <25 x i8> [[C]] to <25 x i32> + // CHECK-NEXT: [[CONV1:%.*]] = bitcast [25 x

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

SaurabhJha updated this revision to Diff 342262. SaurabhJha added a comment. Remove unnecessary newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101696/new/ https://reviews.llvm.org/D101696 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/

[PATCH] D101561: [Prototype] Introduce attribute for ignoring C++ ABI

dblaikie added a comment. In D101561#2730201 , @aeubanks wrote: > I'm first testing out if there are even noticeable benefits to doing this, > then if there are I'll put something together to post to cfe-dev. > https://crbug.com/1028731 for some backgro

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

SaurabhJha added a comment. Thanks for your review @fhahn . I have made some changes in CGExprScalar.cpp to address your comments on IR. I have also added a statement to test assignment to incorrect type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

SaurabhJha updated this revision to Diff 342261. SaurabhJha added a comment. Updating D101696 : [Matrix] Implement C-style explicit type conversions in CXX for matrix types 1. Remove bitcast when types are of the same size. 2. Make int conversion depend on wheth

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 added a comment. >> When I create the new RFC patch, I'll try to get details on that and include >> it in the description. Great! Thanks. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 _

[PATCH] D101700: [RISCV] Reorder masked builtin operands. Use clang_builtin_alias for all overloaded vector builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcfe3b0005f6e: [RISCV] Reorder masked builtin operands. Use clang_builtin_alias for all… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

hvdijk added a comment. In D63423#2732209 , @xbolva00 wrote: >>> Perhaps that should warn even if the RHS is in hex form > > It would be kinda strange, since in one clang release we ask users to silence > warning with hex form and newer release would warn

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil added a comment. In D101236#2716317 , @martong wrote: > You can create a similar descendant class, but with the MinimalImport flag > set to true. Then you could call `ImportDefinition` subsequently after an > `Import` call. Perhaps that co

[PATCH] D101561: [Prototype] Introduce attribute for ignoring C++ ABI

aaron.ballman added a comment. In D101561#2730201 , @aeubanks wrote: > I'm first testing out if there are even noticeable benefits to doing this, > then if there are I'll put something together to post to cfe-dev. > https://crbug.com/1028731 for some ba

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil updated this revision to Diff 342249. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest.cpp Index: clang/unittests/A

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 added a comment. >> Perhaps that should warn even if the RHS is in hex form It would be kinda strange, since in one clang release we ask users to silence warning with hex form and newer release would warn anyway. Not a fan of this decision. >> , or is an enumerator constant, or This

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

hvdijk added a comment. In D63423#2732199 , @xbolva00 wrote: > No, we want to preserve warning for 2 ^ MACRO or 10 ^ MACRO. Perhaps that should warn even if the RHS is in hex form, or is an enumerator constant, or is not even constant at all. libpng: #i

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 added a comment. No, we want to preserve warning for 2 ^ MACRO or 10 ^ MACRO. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

hvdijk added a comment. In D63423#2732186 , @xbolva00 wrote: > I remember that was interest to support macros too :) tbh I cant remember now > such real world case where “macro ^ cst” was an issue but.. it was a long > time ago ;) > > If you are want, yo

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 added a comment. I remember that was interest to support macros too :) tbh I cant remember now such real world case where “macro ^ cst” was an issue but.. it was a long time ago ;) If you are want, you can send patch to to avoid warning in this case, we can discuss it. Repository:

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

hvdijk added a comment. In D63423#2732158 , @Quuxplusone wrote: > In D63423#2732152 , @hvdijk wrote: > >> It's bad enough that this warns for >> >> #define A 2 >> int f() { return A ^ 1; } >> >> where as far as the

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

Quuxplusone added a comment. In D63423#2732152 , @hvdijk wrote: > It's bad enough that this warns for > > #define A 2 > int f() { return A ^ 1; } > > where as far as the users of A are concerned... I see how this warning is arguably overzealous in the //v

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

hvdijk added a comment. It's bad enough that this warns for #define A 2 #define B 0 int f() { return A ^ B; } where as far as the users of A are concerned, A is just some arbitrary value, it's just random chance it happens to be two and there is no chance of it being misinterpreted as exponent

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:124-126 DiagnosticBuilder configurationDiag(StringRef Description, DiagnosticIDs::Level Level = DiagnosticIDs::Warning); njames93 wrote: > You don

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

fhahn added inline comments. Comment at: clang/test/CodeGenCXX/matrix-casts.cpp:26 + // CHECK: [[C:%.*]] = load <25 x i8>, <25 x i8>* {{.*}}, align 1 + // CHECK-NEXT: [[CONV:%.*]] = sext <25 x i8> [[C]] to <25 x i32> + // CHECK-NEXT: [[CONV1:%.*]] = bitcast [25 x i32]*

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

SaurabhJha added inline comments. Comment at: clang/test/CodeGenCXX/matrix-casts.cpp:26 + // CHECK: [[C:%.*]] = load <25 x i8>, <25 x i8>* {{.*}}, align 1 + // CHECK-NEXT: [[CONV:%.*]] = sext <25 x i8> [[C]] to <25 x i32> + // CHECK-NEXT: [[CONV1:%.*]] = bitcast [25 x

[PATCH] D101700: [RISCV] Reorder masked builtin operands. Use clang_builtin_alias for all overloaded vector builtins.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Thanks for improvement! Comment at: clang/include/clang/Basic/riscv_vector.td:192 - // When the order of the parameters of clang builtin do not match the order of -

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

fhahn requested changes to this revision. fhahn added a comment. This revision now requires changes to proceed. Thanks for the patch! It looks like there might be a few cases where the wrong conversion is used at the moment. Comment at: clang/test/CodeGenCXX/matrix-casts.cpp:

[PATCH] D101721: [clang-tidy][NFC] Update tests and Default options to use boolean value

njames93 created this revision. njames93 added a reviewer: aaron.ballman. Herald added subscribers: kbarton, xazax.hun, nemanjai. njames93 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang-tools-extra. Change instances where options wh

[PATCH] D101239: [clang-tidy] Enable the use of IgnoreArray flag in pro-type-member-init rule

h-joo updated this revision to Diff 342233. h-joo added a comment. Change `1` to `true` in the test flag as requested by the reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101239/new/ https://reviews.llvm.org/D101239 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProT

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

aqjune added a comment. (BTW, if the patch is reviewed, then I believe we are finally ready to land this patch.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101191/new/ https://reviews.llvm.org/D101191 __

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

aqjune added a comment. I made D101720 to cover the remaining cases except `Transforms/InstCombine/and2.ll`. Supporting `and2.ll` doesn't seem super-straightforward, but maybe some minor tweaks can make it. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D101239: [clang-tidy] Enable the use of IgnoreArray flag in pro-type-member-init rule

njames93 added reviewers: aaron.ballman, njames93. njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.ignorearrays.cpp:4 +// RUN: -config="{CheckOptions: \ +// RUN: [{key: cppcoreguidelines-pro-type-membe

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:124-126 DiagnosticBuilder configurationDiag(StringRef Description, DiagnosticIDs::Level Level = DiagnosticIDs::Warning); You don't need a ClangTid

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. Hi @njames93, That's ok. You have helped me a lots. Thank you. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:450 +if (!isHungarianNotationSupportedStyle(I) && HPTOpt.hasValue()) + Options.diagnoseInvalidConfi