khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land.
LGTM. Thanks for improvement! ================ Comment at: clang/include/clang/Basic/riscv_vector.td:192 - // When the order of the parameters of clang builtin do not match the order of - // C/C++ api, we use permutation index to mapping the operand from clang ---------------- craig.topper wrote: > I remove this and added a couple ManualCodeGen blocks to permute builtin to > IR intrinsics operand order to make up for it. I could have used > PermuteOperands but then we would have had to translate it into C code to do > the permutation in CGBuiltin.cpp. Cool, using ManualCodeGen is more simple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101700/new/ https://reviews.llvm.org/D101700 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
