[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

aqjune added a comment. I found that there are a few more patterns that can be salvaged. Will create a patch for them. Comment at: llvm/test/Transforms/InstCombine/and.ll:898 ; CHECK-NEXT:[[Y:%.*]] = icmp ugt i72 [[C:%.*]], 42 -; CHECK-NEXT:[[AND:%.*]] = and i1 [[X]],

[PATCH] D101595: [Clang][OpenMP] Allow unified_shared_memory for Pascal-generation GPUs.

Meinersbur updated this revision to Diff 342190. Meinersbur edited the summary of this revision. Meinersbur added a comment. This revision is now accepted and ready to land. - Fix test case Will wait for D101498 is resolved, otherwise I cannot test this anymore

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. Wow these are really a lot of instructions! Comment at: clang/test/Headers/wasm.c:2 +// REQUIRES: webassembly-registered-target // expected-no-diagnostics --

[PATCH] D101654: [HIP] Fix device lib selection

This revision was automatically updated to reflect the committed changes. Closed by commit rGc58a6a6fb411: [HIP] Fix device lib selection (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101654/new/

[clang] c58a6a6 - [HIP] Fix device lib selection

Author: Yaxun (Sam) Liu Date: 2021-05-01T20:31:11-04:00 New Revision: c58a6a6fb4110ee1ffd0e45ad98872e55855b310 URL: https://github.com/llvm/llvm-project/commit/c58a6a6fb4110ee1ffd0e45ad98872e55855b310 DIFF: https://github.com/llvm/llvm-project/commit/c58a6a6fb4110ee1ffd0e45ad98872e55855b310.dif

[clang] 1fcf924 - [Cuda] Internalize a struct and a global variable

Author: Fangrui Song Date: 2021-05-01T16:24:39-07:00 New Revision: 1fcf9247de05bfd960a35c691b9cc47b6a94cd2b URL: https://github.com/llvm/llvm-project/commit/1fcf9247de05bfd960a35c691b9cc47b6a94cd2b DIFF: https://github.com/llvm/llvm-project/commit/1fcf9247de05bfd960a35c691b9cc47b6a94cd2b.diff

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl updated this revision to Diff 342182. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a subscriber: dang. added option -fhip-bundle-device-output CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101630/new/ https://reviews.llvm.org/D101630 Files:

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv created this revision. exv added reviewers: krasimir, MyDeveloperDay. exv requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds support for the null-coalescing assignment and null-forgiving oeprators. https://docs.microsoft.com/en-

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

craig.topper added a comment. In D99741#2730989 , @thakis wrote: >> ! In D99741#2721669 , @craig.topper >> wrote: >> We're preparing a patch to remove to stop testing both rv32 and rv64 on >> every test. That sho

[PATCH] D101700: [RISCV] Reoreder masked builtin operands. Use clang_builtin_alias for all overloaded vector builtins.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:192 - // When the order of the parameters of clang builtin do not match the order of - // C/C++ api, we use permutation index to mapping the operand from clang I remove

[PATCH] D101700: [RISCV] Reoreder masked builtin operands. Use clang_builtin_alias for all overloaded vector builtins.

craig.topper created this revision. craig.topper added reviewers: arcbbb, khchen, HsiangKai, evandro, rogfer01, frasercrmck. Herald added subscribers: StephenFan, vkmr, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

MaskRay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:218 +def err_drv_invalid_value_with_suggestion : Error< +"invalid value '%1' in '%0', valid values to '%0' are: %2">; def err_drv_invalid_remap_file : Error< Note %

[PATCH] D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else".

curdeius added a comment. I went a different way in order to keep backward compatibility. I renamed Alwayss to OnlyFirstIf and added AllIfsAndElse that behaves as Always in my initial patch. @MyDeveloperDay, please have another look. Names of the options can certainly be improved, but I'm curre

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

SaurabhJha created this revision. Herald added a subscriber: tschuett. SaurabhJha requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements C-style explicit type conversions in CXX for matrix types. It is part of fixing https:/

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

curdeius updated this revision to Diff 342170. curdeius added a comment. This revision is now accepted and ready to land. - [clang-format] Apply AllowShortIfStatementsOnASingleLine: AllIfsAndElse to "else if" and "else". Keep backward-compatibility. Repository: rG LLVM Github Monorepo CHANGE

[clang] f36e6e1 - [RISCV] Add missing frontend tests for vcompress intrinsics.

Author: Craig Topper Date: 2021-05-01T13:07:28-07:00 New Revision: f36e6e16a86eceaab39b0ac38517feb04775e0d4 URL: https://github.com/llvm/llvm-project/commit/f36e6e16a86eceaab39b0ac38517feb04775e0d4 DIFF: https://github.com/llvm/llvm-project/commit/f36e6e16a86eceaab39b0ac38517feb04775e0d4.diff

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

awarzynski added a comment. In D101387#2730043 , @nickdesaulniers wrote: > @FarisRehman when I run `llvm-lit -vv > flang/test/Driver/fixed-line-length.f90` I see: > > UNSUPPORTED: Flang :: Driver/fixed-line-length.f90 (1 of 1) > > This is with `-DLLVM

[PATCH] D36368: Fix type printing of array template args

This revision was automatically updated to reflect the committed changes. Closed by commit rG8518742104ab: Fix type printing of array template args (authored by reikdas, committed by v.g.vassilev). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 8518742 - Fix type printing of array template args

Author: Pratyush Das Date: 2021-05-01T18:50:09Z New Revision: 8518742104ab075296722ef6151f65aee7a0646d URL: https://github.com/llvm/llvm-project/commit/8518742104ab075296722ef6151f65aee7a0646d DIFF: https://github.com/llvm/llvm-project/commit/8518742104ab075296722ef6151f65aee7a0646d.diff LOG:

[PATCH] D101654: [HIP] Fix device lib selection

yaxunl updated this revision to Diff 342156. yaxunl marked an inline comment as done. yaxunl added a comment. Herald added a subscriber: dexonsmith. revise test by Fangrui's comment. Also fix test failure CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101654/new/ https://reviews.llvm.org

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

jubnzv updated this revision to Diff 342155. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101259/new/ https://reviews.llvm.org/D101259 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-

[PATCH] D101614: [clang-tidy][NFC] Simplify a lot of bugprone-sizeof-expression matchers

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. LGTM, but I think you could split it into 3 commits with a commit message saying what each is doing. "Simplify a lot of" doesn't say anything specific about what this patch does. It looks

[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Darwin.

delcypher marked an inline comment as done. delcypher added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:401 return "aix"; + case llvm::Triple::Darwin: +return "darwin"; arphaman wrote: > Should this also apply to `llvm::Triple::MacOSX` ,

[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Darwin.

delcypher updated this revision to Diff 342152. delcypher added a comment. - Support other Apple target triples. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101682/new/ https://reviews.llvm.org/D101682 Files: clang/lib/Driver/ToolChain.cpp c

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

This revision was automatically updated to reflect the committed changes. Closed by commit rG0175999805cf: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 0175999 - [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

Author: Yaxun (Sam) Liu Date: 2021-05-01T09:02:55-04:00 New Revision: 0175999805cf05d91c8a127ebd8c9d54a640abe9 URL: https://github.com/llvm/llvm-project/commit/0175999805cf05d91c8a127ebd8c9d54a640abe9 DIFF: https://github.com/llvm/llvm-project/commit/0175999805cf05d91c8a127ebd8c9d54a640abe9.dif

[PATCH] D101635: [analyzer] Fix assertion in SVals.h

steakhal added a comment. I don't know how did we miss this. I run your patch on several projects and it seemed good. Does anyone have an idea how to prevent such a silly mistake from happening again? I was thinking of coverage data, but that wouldn't be enough for this example.

[PATCH] D101614: [clang-tidy][NFC] Simplify a lot of bugprone-sizeof-expression matchers

njames93 updated this revision to Diff 342130. njames93 added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101614/new/ https://reviews.llvm.org/D101614 Files: clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. Sorry, I thought this landed months ago. I'll take a proper look again next week. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:158 +/// name \p LocalName shoud not present. +void diagnoseInvalidConfigOption(StringRef LocalName) co

[clang-tools-extra] 172a801 - [clang-tidy][NFC] Remove redudnant expr and qualType matchers from bugprone-sizeof-expression.

Author: Nathan James Date: 2021-05-01T08:54:00+01:00 New Revision: 172a8016788c08fff6eed71f0a8eccf0ce1ef26d URL: https://github.com/llvm/llvm-project/commit/172a8016788c08fff6eed71f0a8eccf0ce1ef26d DIFF: https://github.com/llvm/llvm-project/commit/172a8016788c08fff6eed71f0a8eccf0ce1ef26d.diff