steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land.
LGTM, but I think you could split it into 3 commits with a commit message saying what each is doing. "Simplify a lot of" doesn't say anything specific about what this patch does. It looks like you could split it into - "Remove obsolete `expr()`" (because of the ones in `hasLHS` and `hasRHS`) - "Simplify `anyOf(integerLiteral()...)` to `integerLiteral(anyOf())`" - "Use `hasArgumentOfType` matcher with `sizeOfExpr`" I'm not sure if this patch does anything else than those 3. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101614/new/ https://reviews.llvm.org/D101614 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
