[clang] 3a3fbbe - [Fuchsia] Use correct target triple for ARM

Author: Petr Hosek Date: 2021-04-26T23:48:12-07:00 New Revision: 3a3fbbe21720839e8ad9f7eb70db7b0b7cda1c4f URL: https://github.com/llvm/llvm-project/commit/3a3fbbe21720839e8ad9f7eb70db7b0b7cda1c4f DIFF: https://github.com/llvm/llvm-project/commit/3a3fbbe21720839e8ad9f7eb70db7b0b7cda1c4f.diff LO

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

RedDocMD added a comment. The call to `PathSensitiveBugReport::markInvalid()` is triggered by `LikelyFalsePositiveSuppressionBRVisitor::finalizeVisitor()`. So I guess we need to see now why the visitor thinks this is a false positive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D101338: [MS] Fix crash when calling __cpuid with /EHsc and -mavx2

pengfei updated this revision to Diff 340730. pengfei added a comment. Yes, it is a pretty implementation. Thanks Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101338/new/ https://reviews.llvm.org/D101338 Files: clang/lib/Headers/intrin.h

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4537c3f51bc: [Driver] Push multiarch path setup to individual drivers (authored by phosek). Herald added subscribers: libcxx-commits, s.egerton, sim

[clang] b4537c3 - [Driver] Push multiarch path setup to individual drivers

Author: Petr Hosek Date: 2021-04-26T22:17:26-07:00 New Revision: b4537c3f51bc6c011ddd9c10b80043ac4ce16a01 URL: https://github.com/llvm/llvm-project/commit/b4537c3f51bc6c011ddd9c10b80043ac4ce16a01 DIFF: https://github.com/llvm/llvm-project/commit/b4537c3f51bc6c011ddd9c10b80043ac4ce16a01.diff LO

[clang] f2a585e - [NFC] Fix "not used" warning

Author: Vitaly Buka Date: 2021-04-26T22:09:23-07:00 New Revision: f2a585e6d392f4c8587c1dac4d776037d4b588c5 URL: https://github.com/llvm/llvm-project/commit/f2a585e6d392f4c8587c1dac4d776037d4b588c5 DIFF: https://github.com/llvm/llvm-project/commit/f2a585e6d392f4c8587c1dac4d776037d4b588c5.diff L

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

jubnzv updated this revision to Diff 340724. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101259/new/ https://reviews.llvm.org/D101259 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen added a comment. In D100739#2718681 , @rjmccall wrote: > Here are the options I think the committee might take: > > 1. Always select an unaligned allocator and force implementors to dynamically > align. This seems unlikely to me. > 2. Allow an ali

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

rjmccall added a comment. Here are the options I think the committee might take: 1. Always select an unaligned allocator and force implementors to dynamically align. This seems unlikely to me. 2. Allow an aligned allocator to be selected. The issue here is that we cannot know until coroutine

[PATCH] D101338: [MS] Fix crash when calling __cpuid with /EHsc and -mavx2

craig.topper added a comment. If I remember correctly cpuid.h implementation handles this. Can we copy that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101338/new/ https://reviews.llvm.org/D101338 ___

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

NoQ accepted this revision. NoQ added a comment. Awesome, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101041/new/ https://reviews.llvm.org/D101041 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks like the fix is in the right place and it looks more or less how I expected it to look. Our casting procedure hopefully became more correct and now we have more correct analysis everywher

[PATCH] D101338: [MS] Fix crash when calling __cpuid with /EHsc and -mavx2

pengfei updated this revision to Diff 340718. pengfei added a comment. Update for test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101338/new/ https://reviews.llvm.org/D101338 Files: clang/lib/Headers/intrin.h clang/test/CodeGen/ms-intrinsi

[PATCH] D100839: [analyzer] Adjust the reported variable name in retain count checker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks!~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100839/new/ https://reviews.llvm.org/D100839 __

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:1425 + }; + return std::find(ValidRegs.begin(), ValidRegs.end(), RegName.upper()) != + ValidRegs.end(); We should avoid static constructors/destructors if possible.

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

qiucf added a comment. Ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92815/new/ https://reviews.llvm.org/D92815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://reviews.llvm.org/D101324 __

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Driver/hurd.cpp:21 +// CHECK: "-dynamic-linker" "/lib/ld.so" +// CHECK: "{{.*}}/usr/lib/gcc/i686-gnu/4.6.0{{/|}}crtbegin.o" +// CHECK: "-L

[PATCH] D101338: [MS] Fix crash when calling __cpuid with /EHsc and -mavx2

pengfei created this revision. pengfei added reviewers: rnk, craig.topper, hans. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a workaround for PR50133. When we do frame lowering for some complex scenarios, we may use RBX

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ChuanqiXu added a comment. In D100739#2718514 , @ychen wrote: > Oh, right now C++ coroutine standard is written in the way that the aligned > new is not searched by the frontend. The limitation will be lifted in C++23 > (hopefully). I see. I am curious

[clang] 9360430 - Revert "Reapply "[AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed""

Author: Pushpinder Singh Date: 2021-04-27T02:23:44Z New Revision: 93604305bb72201641f31cc50a6e7b2fe65d3af3 URL: https://github.com/llvm/llvm-project/commit/93604305bb72201641f31cc50a6e7b2fe65d3af3 DIFF: https://github.com/llvm/llvm-project/commit/93604305bb72201641f31cc50a6e7b2fe65d3af3.diff L

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ChuanqiXu added a comment. In D100739#2717582 , @rjmccall wrote: > That's not really what I meant, no. I meant it would be better to find a way > to use an allocator that promises to return a well-aligned value when > possible. We've talked about this b

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen added a comment. In D100739#2715964 , @ChuanqiXu wrote: > In D100739#2713579 , @ychen wrote: > >> In D100739#2711698 , @ChuanqiXu >> wrote: >> This is an alter

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Is this abandoned patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96203/new/ https://reviews.llvm.org/D96203 ___

[PATCH] D70340: Add a key method to Sema to optimize debug info size

rnk added a subscriber: akhuang. rnk added inline comments. Comment at: clang/include/clang/Sema/Sema.h:335 + /// A key method to reduce duplicate type info from Sema. + virtual void anchor(); erichkeane wrote: > rnk wrote: > > hans wrote: > > > I worry that

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. I assume we are not moving forward with this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92078/new/ https://reviews.l

[clang] 6d78c38 - Move Sema's key function around and add more comments

Author: Reid Kleckner Date: 2021-04-26T18:32:50-07:00 New Revision: 6d78c38986fa0974ea0b37e66f8cb89b256f4e0d URL: https://github.com/llvm/llvm-project/commit/6d78c38986fa0974ea0b37e66f8cb89b256f4e0d DIFF: https://github.com/llvm/llvm-project/commit/6d78c38986fa0974ea0b37e66f8cb89b256f4e0d.diff

[PATCH] D101248: [RISCV] [1/2] Add IR intrinsic for Zbm extension

LevyHsu updated this revision to Diff 340705. LevyHsu added a comment. 1. clang/test/CodeGen/RISCV/rvb-intrinsics/riscv64-zbm.c - All test cases renamed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101248/new/ https://reviews.llvm.org/D101248 F

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul added inline comments. Comment at: clang/test/Driver/hurd.cpp:4 +// RUN: %clang -no-canonical-prefixes %s -### 2>&1 \ +// RUN: --target=i386-pc-gnu \ +// RUN: --sysroot=%S/Inputs/basic_hurd_tree \ MaskRay wrote: > The target should exactly match

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul updated this revision to Diff 340703. sthibaul marked 6 inline comments as done. sthibaul added a comment. Move all tests to hurd.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101331/new/ https://reviews.llvm.org/D101331 Files: clan

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

MaskRay added inline comments. Comment at: clang/test/Driver/hurd.cpp:4 +// RUN: %clang -no-canonical-prefixes %s -### 2>&1 \ +// RUN: --target=i386-pc-gnu \ +// RUN: --sysroot=%S/Inputs/basic_hurd_tree \ The target should exactly match the hurd triple. O

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul marked 4 inline comments as done. sthibaul added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3014 llvm::opt::ArgStringList &CC1Args) const { - addGCCLibStdCxxIncludePaths(DriverArgs, CC1Args); + if (!GCCInsta

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul updated this revision to Diff 340700. sthibaul marked 3 inline comments as done. sthibaul added a comment. Fix GCCInstallation.isValid use in Generic_GCC::addLibStdCxxIncludePaths Fix test further Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

vitalybuka added a subscriber: delcypher. vitalybuka added a comment. In D101122#2711962 , @joerg wrote: > There are two approaches that work for reviewing: starting from clang and > going down or starting from compiler-rt and going up the layers. I'd pr

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

MaskRay added a subscriber: thakis. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3014 llvm::opt::ArgStringList &CC1Args) const { - addGCCLibStdCxxIncludePaths(DriverArgs, CC1Args); + if (!GCCInstallation.

[clang] 2509f9f - [clang] Don't crash when loading invalid VFS for the module dep collector

Author: Alex Lorenz Date: 2021-04-26T17:05:22-07:00 New Revision: 2509f9fbad0d37e3e5fea934c0ae7af3877ba4ae URL: https://github.com/llvm/llvm-project/commit/2509f9fbad0d37e3e5fea934c0ae7af3877ba4ae DIFF: https://github.com/llvm/llvm-project/commit/2509f9fbad0d37e3e5fea934c0ae7af3877ba4ae.diff L

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul marked 2 inline comments as done. sthibaul added inline comments. Comment at: clang/test/Driver/hurd.cpp:1 +// RUN: %clang -no-canonical-prefixes %s -### 2>&1 \ +// RUN: --target=i386-pc-gnu \ MaskRay wrote: > I think we need -NEXT patterns to preven

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul updated this revision to Diff 340689. sthibaul added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101331/new/ https://reviews.llvm.org/D101331 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2a3ca8d9796: BPF: emit debuginfo for Function of DeclRefExpr if requested (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100567/

[clang] a2a3ca8 - BPF: emit debuginfo for Function of DeclRefExpr if requested

Author: Yonghong Song Date: 2021-04-26T16:53:25-07:00 New Revision: a2a3ca8d97962d90443ee758e47877e15d7e3832 URL: https://github.com/llvm/llvm-project/commit/a2a3ca8d97962d90443ee758e47877e15d7e3832 DIFF: https://github.com/llvm/llvm-project/commit/a2a3ca8d97962d90443ee758e47877e15d7e3832.diff

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > dblaikie wrote: > > hoy wrote: > > > dblaikie wrote: > > > > hoy wrote: > > > > > dblaik

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

MaskRay added inline comments. Comment at: clang/test/Driver/hurd.cpp:1 +// RUN: %clang -no-canonical-prefixes %s -### 2>&1 \ +// RUN: --target=i386-pc-gnu \ I think we need -NEXT patterns to prevent unintentional new paths. IMO `linux-cross.cpp` uses a good

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen added a comment. In D100739#2717582 , @rjmccall wrote: > In D100739#2717259 , @ychen wrote: > >> In D100739#2717227 , @rjmccall >> wrote: >> >>> Yes, if you can dyn

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul created this revision. sthibaul requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up of e92d2b80c6c9 ("[Driver] Detect libstdc++ include paths f

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_interceptors.cpp:28 +#if SANITIZER_POSIX #include "sanitizer_common/sanitizer_platform_limits_posix.h" +#endif we usually include them unconditionaly and .h itself has guards against un

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:2844 + auto *Fn = + dyn_cast(LV.getPointer(*this)->stripPointerCasts()); + if (DI && !Fn->getSubprogram()) dblaikie wrote: > Oh, please change this to cast, rather th

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song updated this revision to Diff 340675. yonghong-song added a comment. formatting to mode "DI = CGM.getModuleDebugInfo()" and use cast<...> instead of dyn_cast<...> since there should be no possibility of null ptr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/cmake/config-ix.cmake:285 +# The st_mtim.tv_nsec member of a `stat` structure is not reliable on some AIX +# environments. + set(HAVE_STRUCT_STAT_ST_MTIM_TV_NSEC 0) jsji wrote: > Maybe add a warning

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked an inline comment as done. Closed by commit rGbdc4ec04d42a: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX (authored by h

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb added a comment. In D101139#2718057 , @phosek wrote: > In D101139#2713530 , @aabbaabb > wrote: > >> The python script assumes relative directory while finding things. For >> example, for resources folde

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b0501abc7b5: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable (authored by mbenfield, committed by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] 9b0501a - [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Author: Michael Benfield Date: 2021-04-26T15:09:03-07:00 New Revision: 9b0501abc7b515b740fb5ee929817442dd3029a5 URL: https://github.com/llvm/llvm-project/commit/9b0501abc7b515b740fb5ee929817442dd3029a5 DIFF: https://github.com/llvm/llvm-project/commit/9b0501abc7b515b740fb5ee929817442dd3029a5.di

[PATCH] D101139: Create install targets for scan-build-py.

phosek added a comment. In D101139#2713530 , @aabbaabb wrote: > The python script assumes relative directory while finding things. For > example, for resources folder, it uses os.path.join(this_dir, 'resources') in > report.py, which means resource need

[PATCH] D101328: [clangd] run clang-format on FindTargetTests.cpp

dgoldman updated this revision to Diff 340666. dgoldman added a comment. Remove temporary comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101328/new/ https://reviews.llvm.org/D101328 Files: clang-tools-extra/clangd/unittests/FindTargetTest

[PATCH] D101328: [clangd] run clang-format on FindTargetTests.cpp

dgoldman updated this revision to Diff 340665. dgoldman added a comment. Actually fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101328/new/ https://reviews.llvm.org/D101328 Files: clang-tools-extra/clangd/unittests/FindTargetTests

[PATCH] D101328: [clangd] run clang-format on FindTargetTests.cpp

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Addressing comments in https://reviews.llvm.org/D98984 Re

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman added a comment. Reverted in ab0df6c0346e for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100807/new/ https://reviews.llvm.org/D100807 _

[clang] ab0df6c - Revert "[clang][driver] Use the provided arch name for a Darwin target triple"

Author: Alex Lorenz Date: 2021-04-26T14:57:00-07:00 New Revision: ab0df6c0346e515291a381467527621ab0ccf953 URL: https://github.com/llvm/llvm-project/commit/ab0df6c0346e515291a381467527621ab0ccf953 DIFF: https://github.com/llvm/llvm-project/commit/ab0df6c0346e515291a381467527621ab0ccf953.diff L

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

nickdesaulniers updated this revision to Diff 340662. nickdesaulniers added a comment. - remove comment about string case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101327/new/ https://reviews.llvm.org/D101327 Files: clang/lib/Driver/ToolChai

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman added a comment. In D100807#2717778 , @thakis wrote: > Looks like this breaks tests on mac/arm (by making two unexpectedly pass): > http://45.33.8.238/macm1/8249/step_7.txt > > Please take a look, and please revert for now if it takes a while to

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

nickdesaulniers created this revision. nickdesaulniers added reviewers: echristo, jyknight, rsmith. Herald added a subscriber: kristof.beyls. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In order to support arbitrary AArc

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman updated this revision to Diff 340659. dgoldman marked an inline comment as done. dgoldman added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98984/new/ https://reviews.llvm.org/D98984 Files: clang-tools-extra/clangd/F

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman added a comment. In D100807#2717778 , @thakis wrote: > Looks like this breaks tests on mac/arm (by making two unexpectedly pass): > http://45.33.8.238/macm1/8249/step_7.txt > > Please take a look, and please revert for now if it takes a while to

[PATCH] D101325: [CodeGenOptions] make StackProtectorGuardOffset signed

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101325/new/ https://reviews.llvm.org/D101325 _

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:125 + CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( + -1))) return false; krasimir wrote: > penagos wrote: > > krasimi

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

jsji accepted this revision as: jsji. jsji added inline comments. Comment at: llvm/cmake/config-ix.cmake:285 +# The st_mtim.tv_nsec member of a `stat` structure is not reliable on some AIX +# environments. + set(HAVE_STRUCT_STAT_ST_MTIM_TV_NSEC 0) Maybe add a wa

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos updated this revision to Diff 340656. penagos added a comment. Add justification comment for changes in parseAngle() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100778/new/ https://reviews.llvm.org/D100778 Files: clang/lib/Format/Token

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added a comment. @nathanchance do you prefer me to revert the patch first as it might take me a while to investigate it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94355/new/ https://reviews.llvm.org/D94355 _

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

aaron.ballman added a comment. It looks like the CI pipeline is failing on the tests. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:68 + if (Desugar == Context.getBuiltinMSVaListType().getDesugaredType(Context)) { +const auto MSVaListTy

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

hubert.reinterpretcast added a comment. In D101323#2717925 , @jsji wrote: > Have we considered workaround this in `llvm/lib/Support/Unix/Path.inc` > instead? Yes. I think this is a more general fix that would automatically apply in other situations whe

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman marked 3 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:1048 )cpp", - "0: targets = {global}\n" - "1: targets = {param}\n" sammccall wrote: > there

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:2844 + auto *Fn = + dyn_cast(LV.getPointer(*this)->stripPointerCasts()); + if (DI && !Fn->getSubprogram()) Oh, please change this to cast, rather than dyn_cast before comm

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

jsji added a comment. Have we considered workaround this in `llvm/lib/Support/Unix/Path.inc` instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101323/new/ https://reviews.llvm.org/D101323 ___ cfe-co

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3138 } +if (EffectiveTriple.isAArch64() && Value != "sp_el0") { + D.Diag(diag::err_drv_invalid_value_with_suggestion) nickdesaulniers wrote: > nickdesaulniers w

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman updated this revision to Diff 340653. dgoldman marked 2 inline comments as done. dgoldman added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98984/new/ https://reviews.llvm.org/D98984 Files: clang-too

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 340652. nickdesaulniers added a comment. This revision is now accepted and ready to land. - add support for NPOT and negative offsets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://re

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

dblaikie accepted this revision. dblaikie added a comment. Looks good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100567/new/ https://reviews.llvm.org/D100567 ___ cfe-commits mailing list cfe

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

daltenty accepted this revision as: daltenty. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101323/new/ https://reviews.llvm.org/D101323 _

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77013/new/ https://reviews.llvm.org/D77013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song updated this revision to Diff 340650. yonghong-song added a comment. - use stripPointerCasts() to remove the cast of DeclRefExpr pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100567/new/ https://reviews.llvm.org/D100567 Files

[PATCH] D101325: [CodeGenOptions] make StackProtectorGuardOffset signed

nickdesaulniers created this revision. nickdesaulniers added reviewers: xiangzhangllvm, craig.topper, MaskRay, LemonBoy. Herald added subscribers: jansvoboda11, dexonsmith, dang, pengfei, hiraditya. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

sthibaul created this revision. sthibaul requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up of 35dd6470de84 for the Hurd case, to avoid the duplication

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song added a comment. Looks like stripPointerCasts() is enough to make it work (no null Function pointer any more). This is consistent with llvm::Constant *CodeGenModule::GetOrCreateLLVMFunction( StringRef MangledName, llvm::Type *Ty, GlobalDecl GD, bool ForVTable, bool Do

[PATCH] D100874: [OpenMP] Use irbuilder as default for masked and master construct

cchen updated this revision to Diff 340641. cchen added a comment. This revision is now accepted and ready to land. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100874/new/ https://reviews.llvm.org/D100874 Files: clang/lib/CodeGen/CGStmt

[PATCH] D94355: [Passes] Add relative lookup table converter pass

nathanchance added a comment. In D94355#2717813 , @gulfem wrote: > Thanks for the report @nathanchance, and I'm looking at it now. Thanks! > Is this failure from one of the bots? No, this was discovered by a user of my LLVM build script: https://github

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: daltenty, Xiangling_L, jsji. Herald added a subscriber: mgorny. hubert.reinterpretcast requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. The value observed

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added a comment. > This patch breaks a two stage build with LTO: Thanks for the report @nathanchance, and I'm looking at it now. Is this failure from one of the bots? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94355/new/ https://reviews.

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. yeah you have to manually go to "Edit Revision" and update the message. I'll just amend it locally though Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581 ___

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2717182 , @aeubanks wrote: > I can land this for you, but could you update the description to be a bit > more descriptive? Explaining what the warnings do. Are you looking at the updated message in the commit, or th

[PATCH] D101322: [clang-format] Add comment justification for https://reviews.llvm.org/D100778

penagos added a comment. Please ignore this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101322/new/ https://reviews.llvm.org/D101322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

thakis added a comment. Looks like this breaks tests on mac/arm (by making two unexpectedly pass): http://45.33.8.238/macm1/8249/step_7.txt Please take a look, and please revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D101322: [clang-format] Add comment justification for https://reviews.llvm.org/D100778

penagos created this revision. penagos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101322 Files: clang/lib/Format/TokenAnnotator.cpp Index: clang/lib/Format/TokenAnno

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a comment. Sorry for the delay. I think all my points have been resolved beside the insertion SourceLoc. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:184 + SourceLocation NewLoc = SM.getLocForStartOfFile(SM.getMainFileID()) +

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

ASDenysPetrov added a comment. In D92639#2717134 , @vsavchenko wrote: > In D92639#2716973 , @ASDenysPetrov > wrote: > >> @vsavchenko >> I make some tests and fixes. Please, consider. > > OMG, that's so awesome! Th

[PATCH] D99386: [compiler-rt][hwasan] Add definition for Symbolizer::SymbolizeFrame

This revision was automatically updated to reflect the committed changes. Closed by commit rGa786f2badc41: [compiler-rt][hwasan] Add definition for Symbolizer::SymbolizeFrame (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:2843-2844 + CGDebugInfo *DI = CGM.getModuleDebugInfo(); + auto *Fn = dyn_cast(LV.getPointer(*this)); + if (DI && Fn && !Fn->getSubprogram()) +DI->EmitFunctionDecl(FD, FD->getLocation()

[PATCH] D99386: [compiler-rt][hwasan] Add definition for Symbolizer::SymbolizeFrame

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99386/new/ https://reviews.llvm.org/D99386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

leonardchan added a comment. *ping* @mcgrathr Given my explanation before, does it still make sense to refactor in this case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/ https://reviews.llvm.org/D99381 ___

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. > That's odd. Does your `CMakeCache.txt` file have > `CLANG_ROUND_TRIP_CC1_ARGS:BOOL=OFF` by any chance? It's possible it didn't > get switched to `ON` when D97462 landed. > > With the way the tests are written now, I'd expect them t

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan updated this revision to Diff 340620. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/DiagnosticDriverKinds.td clang/inc

  1   2   3   >