sthibaul marked 2 inline comments as done. sthibaul added inline comments.
================ Comment at: clang/test/Driver/hurd.cpp:1 +// RUN: %clang -no-canonical-prefixes %s -### 2>&1 \ +// RUN: --target=i386-pc-gnu \ ---------------- MaskRay wrote: > I think we need -NEXT patterns to prevent unintentional new paths. > > IMO `linux-cross.cpp` uses a good style and can serve as a reference. Ok, fixed so. ================ Comment at: clang/test/Driver/hurd.cpp:5 +// RUN: | FileCheck --check-prefix=CHECK %s +// CHECK-NOT: warning: +// CHECK: "-cc1" ---------------- MaskRay wrote: > The warning negative pattern doesn't really work. You mean because it was misplaced? Indeed, fixed so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101331/new/ https://reviews.llvm.org/D101331 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
