[clang] b4f2e80 - [RISCV] Refactor conversion of B extensions to IR intrinsics a little to reduce clang binary size.

Author: Craig Topper Date: 2021-04-02T23:49:44-07:00 New Revision: b4f2e8060075761dd0e9727ea01ca0142b4e767f URL: https://github.com/llvm/llvm-project/commit/b4f2e8060075761dd0e9727ea01ca0142b4e767f DIFF: https://github.com/llvm/llvm-project/commit/b4f2e8060075761dd0e9727ea01ca0142b4e767f.diff

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder added a comment. I compiled libc++ with a clang that has this patch applied and didn't run into more problems. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 ___ cfe-commits mailing list cfe-

[PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks Comment at: openmp/runtime/src/include/omp.h.var:479 +# endif + # undef __KAI_KMPC_CONVENTION hbae wrote: > jdoerfert wrote: > > Do we

[clang] 2458aa0 - Add missing override to clang tblgen AttrEmitter

Author: David Blaikie Date: 2021-04-02T20:47:49-07:00 New Revision: 2458aa0b9136e7616f529b027d1d478cf699340f URL: https://github.com/llvm/llvm-project/commit/2458aa0b9136e7616f529b027d1d478cf699340f DIFF: https://github.com/llvm/llvm-project/commit/2458aa0b9136e7616f529b027d1d478cf699340f.diff

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov updated this revision to Diff 335055. mizvekov added a comment. Just rebased, removing trailing whitespace noise. Other review points to be addressed later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99225/new/ https://reviews.llvm.org

[PATCH] D99826: [clang] NFC: remove trailing white spaces from some tests

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbac74a50e99f: [clang] NFC: remove trailing white spaces from some

[clang] bac74a5 - [clang] NFC: remove trailing white spaces from some tests

Author: Matheus Izvekov Date: 2021-04-03T03:18:22+02:00 New Revision: bac74a50e99f3d014d6e5a67272fd3b20eeb7fed URL: https://github.com/llvm/llvm-project/commit/bac74a50e99f3d014d6e5a67272fd3b20eeb7fed DIFF: https://github.com/llvm/llvm-project/commit/bac74a50e99f3d014d6e5a67272fd3b20eeb7fed.dif

[PATCH] D99826: [clang] NFC: remove trailing white spaces from some tests

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99826 Files: clang/test/CXX/drs/dr3xx.cpp clang/test/CXX/expr/expr.prim/expr.prim

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov added a comment. @Quuxplusone Thank you for the review. All your points are good ones and will be addressed in time! The new NRVO propagation `clang/test/CodeGen/nrvo-tracking.cpp` is also breaking on the buildbot, but it works on my machine. Will also take a look at that one. =

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

Quuxplusone added a comment. LGTM (just a bunch of style comments from me), but I think you'll have to get someone else's attention if you're expecting to get signoff from someone to land this. I also think it would make sense for you to land the absolutely trivial trailing-whitespace diffs ri

[PATCH] D99821: [PGO, test] Fix typo in FileCheck var

xur accepted this revision. xur added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99821/new/ https://reviews.llvm.org/D99821 ___ cfe-com

[PATCH] D99696: [clang] WIP: NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 335045. mizvekov added a comment. Fixes for auto&, decltype(auto). Exclude candidates from functions with dependent / undeduced return types which are references. Adjusts the CodeGen tests from D99225 . Repository: rG LLV

[PATCH] D99225: [clang] cxx tests: cleanup, update and add some new ones

mizvekov updated this revision to Diff 335044. mizvekov added a comment. Includes some new NRVO tests which will be used in D99696 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99225/new/ https://reviews.llvm.org

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rjmccall added a comment. In D99517#2667088 , @rsmith wrote: > In D99517#2667025 , @rjmccall wrote: > >> You should structure this code so it's easy to add exceptions for certain >> calling conventions that can sup

[PATCH] D99821: [PGO, test] Fix typo in FileCheck var

thopre created this revision. thopre added reviewers: bogner, xur, davidxl. Herald added a subscriber: wenlei. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99821 Fi

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added a comment. In D99517#2667025 , @rjmccall wrote: > You should structure this code so it's easy to add exceptions for certain > calling conventions that can support tail calls with weaker restrictions > (principally, callee-pop conventions).

[PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

hbae added inline comments. Comment at: openmp/runtime/src/include/omp.h.var:479 +# endif + # undef __KAI_KMPC_CONVENTION jdoerfert wrote: > Do we want them to be static? I would have expected odr linkage instead. > > > Current clang fails to link two fil

[PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

hbae updated this revision to Diff 335034. hbae added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Removed omp_is_initial_device() from clang built-ins. Added a new test under openmp/libomptarget. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D99791: [CGCall] Annotate pointer argument with alignment

efriedma added a comment. This feels scary: the C standard technically allows this, but we haven't done it in the past, and it could break otherwise functioning code. (We've only assumed alignment about pointers that are dereferenced/dereferenceable.) For D99790

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rjmccall added a reviewer: varungandhi-apple. rjmccall added a comment. CC'ing Varun Gandhi. Is `musttail` actually supported generically on all LLVM backends, or does this need a target restriction? You should structure this code so it's easy to add exceptions for certain calling conventions

Re: [clang] 9320ac9 - [Clang] Only run test when X86 backend is built.

On Thu, Apr 1, 2021 at 1:29 PM Florian Hahn wrote: > > > > On Thu, Apr 1, 2021 at 8:11 PM David Blaikie wrote: >> >> On Thu, Apr 1, 2021 at 1:16 AM Florian Hahn wrote: >> > >> > Hi, >> > >> > On Tue, Mar 30, 2021 at 7:52 PM David Blaikie wrote: >> >> >> >> Is there a more reliable remark that c

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5315-5317 +// TODO(haberman): insert checks/assertions to verify that this early exit +// is safe. We tried to verify this in Sema but we should double-check +// here. rsmith wrote

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added a comment. Thanks, I think this is looking really good. @rjmccall, no explicit need to review; I just wanted to make sure you'd seen this and had a chance to express any concerns before we go ahead. Comment at: clang/include/clang/Basic/AttrDocs.td:452 +optimizat

[clang] 0fe8af9 - Fix build bot problem with missing OMPC_novariants in switch.

Author: Jennifer Yu Date: 2021-04-02T13:58:39-07:00 New Revision: 0fe8af94688aa03c01913c2001d6a1a911f42ce6 URL: https://github.com/llvm/llvm-project/commit/0fe8af94688aa03c01913c2001d6a1a911f42ce6 DIFF: https://github.com/llvm/llvm-project/commit/0fe8af94688aa03c01913c2001d6a1a911f42ce6.diff L

[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in 4be8a26951da9a6e04de327b38dd158f4c8e3280 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99809/new/ https://reviews.llvm.org/D99809 _

[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Accepting on my own authority so I can close in a moment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99809/new/ https://reviews.llvm.org/D99809 _

[clang] 4be8a26 - Use tablegen to diagnose mutually exclusive attributes

Author: Aaron Ballman Date: 2021-04-02T16:34:42-04:00 New Revision: 4be8a26951da9a6e04de327b38dd158f4c8e3280 URL: https://github.com/llvm/llvm-project/commit/4be8a26951da9a6e04de327b38dd158f4c8e3280 DIFF: https://github.com/llvm/llvm-project/commit/4be8a26951da9a6e04de327b38dd158f4c8e3280.diff

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

jyu2 closed this revision. jyu2 added a comment. cb424fee3d6b27dbd38de666382b702100935286 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D9967

[clang] cb424fe - [OPENMP5.1]Initial support for novariants clause.

Author: Jennifer Yu Date: 2021-04-02T13:19:01-07:00 New Revision: cb424fee3d6b27dbd38de666382b702100935286 URL: https://github.com/llvm/llvm-project/commit/cb424fee3d6b27dbd38de666382b702100935286 DIFF: https://github.com/llvm/llvm-project/commit/cb424fee3d6b27dbd38de666382b702100935286.diff L

[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

aaron.ballman updated this revision to Diff 335021. aaron.ballman added a comment. Correcting lint warnings, adding documentation for the new feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99809/new/ https://reviews.llvm.org/D99809 Files: clang/docs/InternalsManual.rst clan

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov added a comment. @steakhal thanks for the approval. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:564-565 } - - llvm_unreachable("Unknown SVal kind"); } steakhal wrote: > You probably don't want to remove this. The same applies to

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

ASDenysPetrov added a comment. @vsavchenko FYI. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:112-113 +RangeSet RangeSet::Factory::add(RangeSet LHS, RangeSet RHS) { + if (LHS.isEmpty()) +return RHS; + for (const Range &R : RHS) Also

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

rjmccall added inline comments. Comment at: clang/test/CodeGen/matrix-cast.c:15 + // CHECK: [[C:%.*]] = load <25 x i8>, <25 x i8>* {{.*}}, align 1 + // CHECK-NEXT: [[CONV:%.*]] = zext <25 x i8> [[C]] to <25 x i32> + // CHECK-NEXT: store <25 x i32> [[CONV]], <25 x i32>*

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

ASDenysPetrov updated this revision to Diff 335011. ASDenysPetrov added a comment. Updated. Restored complexity to O(N). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstr

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder updated this revision to Diff 335016. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/ParsedAttr.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

thakis added a comment. In D99009#2666797 , @jrtc27 wrote: > In D99009#2666793 , @thakis wrote: > >> Looks like this doesn't build on windows: >> http://45.33.8.238/win/36271/step_4.txt >> >> Please take a look and

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

MaskRay added a comment. > This layout matches the layout use by other compilers like GCC. Clarification: this is similar but not match GCC's layout, where the multiarch path component (e.g. `/x86_64-linux-gnu`) is appended to `.../include` % clang++ --target=aarch64-pc-linux-gnu a.cc '-###'

[clang] 2165c0d - [OPENMP][DOCS]Update status of the supported constructs, NFC.

Author: Mike Rice Date: 2021-04-02T12:31:36-07:00 New Revision: 2165c0d389c0b8f7dfd383ea6abd0d9b5d2ee07f URL: https://github.com/llvm/llvm-project/commit/2165c0d389c0b8f7dfd383ea6abd0d9b5d2ee07f DIFF: https://github.com/llvm/llvm-project/commit/2165c0d389c0b8f7dfd383ea6abd0d9b5d2ee07f.diff LOG

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. @ldionne I have update the change description to explain the new layout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 ___ cfe-commits m

[clang] be7358d - Revert "[RISCV] Try using toupper instead of std::toupper to make the build bots happy."

Author: Craig Topper Date: 2021-04-02T12:30:23-07:00 New Revision: be7358df1e3066d09171159211b9fa578272585e URL: https://github.com/llvm/llvm-project/commit/be7358df1e3066d09171159211b9fa578272585e DIFF: https://github.com/llvm/llvm-project/commit/be7358df1e3066d09171159211b9fa578272585e.diff

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

jrtc27 added a comment. In D99009#2666793 , @thakis wrote: > Looks like this doesn't build on windows: > http://45.33.8.238/win/36271/step_4.txt > > Please take a look and revert for now if it takes a while to fix. Hopefully fixed in 1bd4986e7cdc

[clang] 5311abc - [RISCV] Try using toupper instead of std::toupper to make the build bots happy.

Author: Craig Topper Date: 2021-04-02T12:29:07-07:00 New Revision: 5311abc7a24e4170e5e6d06f1022da87f1413dd7 URL: https://github.com/llvm/llvm-project/commit/5311abc7a24e4170e5e6d06f1022da87f1413dd7 DIFF: https://github.com/llvm/llvm-project/commit/5311abc7a24e4170e5e6d06f1022da87f1413dd7.diff

[clang] 1bd4986 - [Sema] Fix Windows build after b001d574d7d9

Author: Jessica Clarke Date: 2021-04-02T20:27:58+01:00 New Revision: 1bd4986e7cdc124fecbf4b4527039a9a845e61f5 URL: https://github.com/llvm/llvm-project/commit/1bd4986e7cdc124fecbf4b4527039a9a845e61f5 DIFF: https://github.com/llvm/llvm-project/commit/1bd4986e7cdc124fecbf4b4527039a9a845e61f5.diff

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

thakis added a comment. Looks like this doesn't build on windows: http://45.33.8.238/win/36271/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99009/new/ https://reviews.l

[PATCH] D99711: [RISCV] [1/2] Add intrinsic for Zbc extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGf78d932cf23a: [RISCV] Add IR intrinsics for Zbc extension (authored by LevyHsu, committed by craig.topper). Changed prior to commit: https://reviews.llvm.org/D99711?vs=334882&id=335008#toc Repository:

[clang] f78d932 - [RISCV] Add IR intrinsics for Zbc extension

Author: Levy Hsu Date: 2021-04-02T12:09:13-07:00 New Revision: f78d932cf23a6521a1f9a08c539d1a00148ebe54 URL: https://github.com/llvm/llvm-project/commit/f78d932cf23a6521a1f9a08c539d1a00148ebe54 DIFF: https://github.com/llvm/llvm-project/commit/f78d932cf23a6521a1f9a08c539d1a00148ebe54.diff LOG:

[PATCH] D99811: [TextAPI] move source code files out of subdirectory, NFC

cishida created this revision. cishida added reviewers: steven_wu, ributzka. Herald added subscribers: hiraditya, mgorny. Herald added a reviewer: int3. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. cishida requested review of this revision. Herald added projects: clang, LL

[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

aaron.ballman added a comment. @rsmith -- I am posting the review so that I can see how the CI pipeline likes the functionality (because this impacts so many different attributes), but I intend to commit it on my own authority once CI passes. Feel free to review it if you'd like and I'll addres

[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

aaron.ballman created this revision. aaron.ballman added a reviewer: rsmith. aaron.ballman requested review of this revision. Herald added a project: clang. Currently, when one or more attributes are mutually exclusive, the developer adding the attribute has to manually emit diagnostics. In pract

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG944adbf28550: Recommit "[RISCV] Add IR intrinsic for Zbb extension" (authored by LevyHsu, committed by craig.topper). Changed prior to commit: htt

[clang] 944adbf - Recommit "[RISCV] Add IR intrinsic for Zbb extension"

Author: Levy Hsu Date: 2021-04-02T11:50:19-07:00 New Revision: 944adbf285505ac481551157c4ee3cc3c0724900 URL: https://github.com/llvm/llvm-project/commit/944adbf285505ac481551157c4ee3cc3c0724900 DIFF: https://github.com/llvm/llvm-project/commit/944adbf285505ac481551157c4ee3cc3c0724900.diff LOG:

[clang] 1f0b309 - Revert "[RISCV] Add IR intrinsic for Zbb extension"

Author: Craig Topper Date: 2021-04-02T11:47:02-07:00 New Revision: 1f0b309f24ba7ed144ddcd20cccedc284d990074 URL: https://github.com/llvm/llvm-project/commit/1f0b309f24ba7ed144ddcd20cccedc284d990074 DIFF: https://github.com/llvm/llvm-project/commit/1f0b309f24ba7ed144ddcd20cccedc284d990074.diff

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D99679 ___ c

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:13567-13568 +case OMPD_dispatch: + CaptureRegion = OMPD_task; + break; +default: jyu2 wrote: > ABataev wrote: > > What about other directives? > Hi Alexey, > > As of now "

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

dexonsmith added a comment. In D97462#2666485 , @jansvoboda11 wrote: > Thanks for reporting that. D99606 fixes one > aspect of `-plugin-arg`, but it seems the order of generation is > non-deterministic (most likely rela

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added inline comments. Comment at: clang/test/CodeGen/matrix-cast.c:15 + // CHECK: [[C:%.*]] = load <25 x i8>, <25 x i8>* {{.*}}, align 1 + // CHECK-NEXT: [[CONV:%.*]] = zext <25 x i8> [[C]] to <25 x i32> + // CHECK-NEXT: store <25 x i32> [[CONV]], <25 x i32>* {{

[PATCH] D99808: [Sema] Move 'char-expression-as-unsigned < 0' into a separate diagnostic

AntonBikineev created this revision. AntonBikineev added reviewers: aaron.ballman, thakis. AntonBikineev requested review of this revision. Herald added a project: clang. This change splits '-Wtautological-unsigned-zero-compare' by reporting char-expressions-interpreted-as-unsigned under a separat

[clang] 1808194 - [RISCV] Add IR intrinsic for Zbb extension

Author: Craig Topper Date: 2021-04-02T11:23:57-07:00 New Revision: 1808194590dd2b308bc146406425d5d52e46b7e6 URL: https://github.com/llvm/llvm-project/commit/1808194590dd2b308bc146406425d5d52e46b7e6 DIFF: https://github.com/llvm/llvm-project/commit/1808194590dd2b308bc146406425d5d52e46b7e6.diff

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:13567-13568 +case OMPD_dispatch: + CaptureRegion = OMPD_task; + break; +default: ABataev wrote: > What about other directives? Hi Alexey, As of now "novariants" clause only a

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok marked an inline comment as done. alok added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs,

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

jrtc27 added a comment. Thanks, and good point re ordering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99009/new/ https://reviews.llvm.org/D99009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

craig.topper added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11190 +def err_riscv_builtin_requires_extension : Error< + "builtin requires %0 extension support to be enabled">; } // end of sema component. jrtc27 wrote: > This

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

dblaikie added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) alok

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11190 +def err_riscv_builtin_requires_extension : Error< + "builtin requires %0 extension support to be enabled">; } // end of sema component. This lost the quotes

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha added inline comments. Comment at: clang/test/CodeGen/matrix-cast.c:15 + // CHECK: [[C:%.*]] = load <25 x i8>, <25 x i8>* {{.*}}, align 1 + // CHECK-NEXT: [[CONV:%.*]] = zext <25 x i8> [[C]] to <25 x i32> + // CHECK-NEXT: store <25 x i32> [[CONV]], <25 x i32

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb001d574d7d9: [RISCV] Add IR intrinsic for Zbr extension (authored by LevyHsu, committed by craig.topper). Changed prior to commit: https://review

[clang] b001d57 - [RISCV] Add IR intrinsic for Zbr extension

Author: Levy Hsu Date: 2021-04-02T10:58:45-07:00 New Revision: b001d574d7d94bcf1508fa4cdc22e02a0bf4adea URL: https://github.com/llvm/llvm-project/commit/b001d574d7d94bcf1508fa4cdc22e02a0bf4adea DIFF: https://github.com/llvm/llvm-project/commit/b001d574d7d94bcf1508fa4cdc22e02a0bf4adea.diff LOG:

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok marked 2 inline comments as done. alok added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs,

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman added inline comments. Comment at: clang/test/Parser/cxx0x-attributes.cpp:377 + template friend class[[]] vector2; // expected-error {{an attribute list cannot appear here}} + template friend class [[clang::__type_visib

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

dblaikie added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) prob

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

ASDenysPetrov added a comment. @vsavchenko OK, what do you think of ***adjacency*** feature? I mean it simplifies such ranges `[1,2][3,4][5,6]` to `[1,6]`. Is it worth for implementation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ ht

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5066 +CmdArgs.push_back("-mllvm"); +CmdArgs.push_back("-treat-scalable-fixed-error-as-warning"); + } Does this introduce an option in the CC1 command line for most cases? We

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/altera-id-dependent-backward-branch.rst:9 + +Based on the `Altera SDK for OpenCL: Best Practices Guide +

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 334985. haberman added a comment. - Fixed unit test by running `opt` in a separate invocation. - Formatting fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 File

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies updated this revision to Diff 334979. ffrankies added a comment. - Rebased on top of latest changes in main branch - The diagnostic that identifies the code location where an ID-dependent variable/field is assigned has been changed from a warning to a note - Changes addressing code styl

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 added a comment. In D97462#2666366 , @akhuang wrote: > In Chrome we noticed that plugin flags are not being roundtripped (and build > fails with `error: Generated arguments do not match in round-trip`): > > example of the differing args: > >

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:13567-13568 +case OMPD_dispatch: + CaptureRegion = OMPD_task; + break; +default: What about other directives? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

ASDenysPetrov added a comment. In D99797#2666358 , @vsavchenko wrote: > Thanks for working on improvements of the solver and constraints! However, I > have some tough questions about this patch. > > What I really want to understand here is motivation. W

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

jyu2 updated this revision to Diff 334969. jyu2 added a comment. Thank you, Alexey for the review!!! This changes have been addressed as you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D99679 Files:

[PATCH] D99537: [OPENMP51]Initial support for the dispatch directive

mikerice added a comment. @jyu2 is currently working on the novariants and nocontext clauses. We are still working on the overall construct so I'm not sure yet what more we will have to contribute. I'll look into updating the support doc. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

akhuang added a comment. In Chrome we noticed that plugin flags are not being roundtripped (and build fails with `error: Generated arguments do not match in round-trip`): example of the differing args: "-plugin-arg-blink-gc-plugin" "no-members-in-stack-allocated" "-plugin-arg-find-bad-con

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

vsavchenko added a comment. Thanks for working on improvements of the solver and constraints! However, I have some tough questions about this patch. What I really want to understand here is motivation. Why do we need to have `add` operation semantics like this in the first place? My guess is

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: vsavchenko, steakhal, NoQ, xazax.hun, dcoughlin, Szelethus. ASDenysPetrov added a project: clang. Herald added subscribers: martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware.

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

aganea added a comment. In D99426#2666141 , @abhina.sreeskantharajan wrote: > In D99426#2665361 , @aganea wrote: > >> I am still concerned by the fact that this patch doesn't fix the issue >> mentionned in https:/

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. In D95246#2606343 , @abhina.sreeskantharajan wrote: > This issue has been fixed in https://reviews.llvm.org/D97472. > @ASDenysPetrov I'm

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. In D95808#2657744 , @jhenderson wrote: > @ASDenysPetrov, I think you need to mark this patch as Accepted so that > someone can close this

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list= to match gcc options.

oliverbrowne added a comment. Hi Folks, don't know if this review is still active but I can provide some context on the GCC behavior with respect to namespaces, template params and function arguments, they were bugs, fixed in 2019. Associated bug reports for namespace/class, and template parame

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added a comment. In D99037#2666230 , @SaurabhJha wrote: > Update commit message to more accurately reflect the patch Just FYI, `arc diff ` does not update the patch description on Phabricator. I think you have to edit it via the web-interface. Re

[PATCH] D99537: [OPENMP51]Initial support for the dispatch directive

jdoerfert added a subscriber: jyu2. jdoerfert added a comment. Cool, are you expecting to hook this up to the variant selection logic as well? @jyu2 similarly do you intend to hook up `novariant`? We should also update https://clang.llvm.org/docs/OpenMPSupport.html to claim parts you are workin

[clang] 3ebfa36 - Remove attribute handling code for simple attributes; NFC

Author: Aaron Ballman Date: 2021-04-02T11:35:10-04:00 New Revision: 3ebfa363f356eff744b73885023cc1fc62fad973 URL: https://github.com/llvm/llvm-project/commit/3ebfa363f356eff744b73885023cc1fc62fad973 DIFF: https://github.com/llvm/llvm-project/commit/3ebfa363f356eff744b73885023cc1fc62fad973.diff

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:7659 +/// clause with condition 'a > 5'. +class OMPNovariantsClause : public OMPClause, public OMPClauseWithPreInit { + friend class OMPClauseReader; `final` Com

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 added a comment. So unfortunately it seems the `clang/runtime`'s use was triggered by `LLVM_BUILD_EXTERNAL_COMPILER_RT`, which is in use in a few places still? (And not just Apple ones.) On the other hand, since this is doing an *external* CMake for compiler-rt, I fail to see why `

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

jyu2 updated this revision to Diff 334956. jyu2 added a comment. Fix format problem as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D99679 Files: clang/include/clang/AST/OpenMPClause.h clang/incl

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 updated this revision to Diff 334955. Ericson2314 added a comment. Remove add_subdirectory(runtime) for deleted dir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99755/new/ https://reviews.llvm.org/D99755 Files: clang/CMakeLists.txt

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder updated this revision to Diff 334954. tbaeder added a comment. Herald added a subscriber: jdoerfert. A little earlier than expected. Happy Easter :P CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 Files: clang/include/clang/Parse/Pars

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 334952. kamleshbhalui added a comment. Making changes effective only for windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files: clang/lib/CodeGen/CGDebu

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 334951. SaurabhJha added a comment. Update commit message to more accurately reflect the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://reviews.llvm.org/D99037 Files: clang/include

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7400 + } else { +return Diag(R.getBegin(), +diag::err_invalid_conversion_between_matrix_and_scalar) When we get here, `SrcTy` may not necessarily be a scalar I think (see my

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2916 // Require the operand to be a scalar or vector. + if (!SrcType->isScalarType() && !SrcType->isVectorType() && ` ... or a matrix`? Comment at: clang/test/Sema/matri

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:547 + case CK_MatrixCast: { +// TODO: Handle MatrixCast here. + } SaurabhJha wrote: > I thought doing changes here is is outside the scope of casting so I jus

  1   2   >