[PATCH] D99008: [RISCV] [2/2] Add intrinsic for Zbr extension

LevyHsu updated this revision to Diff 333219. LevyHsu added a comment. in clang/test/Headers/rvintrin.c RUN: -target-feature +experimental-zbr %s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99008/new/ https://reviews.llvm.org/D99008 Files: c

[PATCH] D99245: [Driver] Add -fno-split-stack

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20b4f484d16f: [Driver] Add -fno-split-stack (authored by ChuanqiXu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed

[clang] 20b4f48 - [Driver] Add -fno-split-stack

Author: Chuanqi Xu Date: 2021-03-25T14:18:28+08:00 New Revision: 20b4f484d16faa73123fa81ac332d283ada6771e URL: https://github.com/llvm/llvm-project/commit/20b4f484d16faa73123fa81ac332d283ada6771e DIFF: https://github.com/llvm/llvm-project/commit/20b4f484d16faa73123fa81ac332d283ada6771e.diff LO

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

keryell requested changes to this revision. keryell added a comment. This revision now requires changes to proceed. Great to have some design documentation! Just a feedback on the first 20%... Comment at: clang/docs/SYCLSupport.md:23 +files (which are really LLVM IR files) are

[PATCH] D99308: [Triple][Driver] Add muslx32 environment and use /lib/ld-musl-x32.so.1 for -dynamic-linker

MaskRay updated this revision to Diff 333208. MaskRay added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99308/new/ https://reviews.llvm.org/D99308 Files: clang/lib/Driver/ToolChains/Linux.cpp clang/test/Driver/linux-cross

[PATCH] D99308: [Triple][Driver] Add muslx32 environment and use /lib/ld-musl-x32.so.1 for -dynamic-linker

MaskRay added a comment. In D99308#2649636 , @raj.khem wrote: > once you fix the clang-format issue reported this looks good to me. I'll ignore it... The first block does not directly touch the formatted part and the second block would need a larger form

[PATCH] D99308: [Triple][Driver] Add muslx32 environment and use /lib/ld-musl-x32.so.1 for -dynamic-linker

raj.khem accepted this revision. raj.khem added a comment. This revision is now accepted and ready to land. once you fix the clang-format issue reported this looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99308/new/ https://reviews

[PATCH] D99121: [IR][InstCombine] IntToPtr Produces Typeless Pointer To Byte

dblaikie added a comment. In D99121#2649546 , @ruiling wrote: >> No, sorry I don't - I ran out of steam after the initial work, and haven't >> been able to get back into it. A few folks have picked up my slack in the >> last year or two & made some incre

[PATCH] D99121: [IR][InstCombine] IntToPtr Produces Typeless Pointer To Byte

ruiling added a comment. > No, sorry I don't - I ran out of steam after the initial work, and haven't > been able to get back into it. A few folks have picked up my slack in the > last year or two & made some incremental progress. > > It'd be good to tag any workarounds somehow (I don't know how

[PATCH] D98812: [OPENMP]Map data field with l-value reference types.

jyu2 accepted this revision. jyu2 added a comment. This revision is now accepted and ready to land. Thanks Alexey for adding this! The changes LGTM, but I'm not super well-versed with this. You may wait a bit for other reviewers to weigh in before landing. Repository: rG LLVM Github Monorepo

[clang] cdd993f - [Driver] Use -dynamic-linker /lib/ld-musl-i386.so.1 for i?86-linux-musl

Author: Fangrui Song Date: 2021-03-24T19:44:53-07:00 New Revision: cdd993fab3629474011b73985285c04722cffd61 URL: https://github.com/llvm/llvm-project/commit/cdd993fab3629474011b73985285c04722cffd61 DIFF: https://github.com/llvm/llvm-project/commit/cdd993fab3629474011b73985285c04722cffd61.diff

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

LuoYuanke added a comment. In D99152#2647681 , @fhahn wrote: > I can't see any `load <256 x i32>` in the linked example, just a store. Could > you check the example? I create another example at https://gcc.godbolt.org/z/v6od5ceEz. In bar() function, you

[PATCH] D99121: [IR][InstCombine] IntToPtr Produces Typeless Pointer To Byte

dblaikie added a comment. In D99121#2647187 , @nlopes wrote: > In D99121#2645593 , @dblaikie wrote: > >> In D99121#2644362 , @lebedev.ri >> wrote: >> >>> In D99121#2644223 <

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

benshi001 added a comment. This patch just fix the wrong return type in ABI. The wrong parameters passing with be fixed in another patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99237/new/ https://reviews.llvm.org/D99237 ___ cfe-commit

[PATCH] D98881: [RISCV] Fix mcount name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef58ae86ba77: [RISCV] Fix mcount name (authored by nathanchance). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] ef58ae8 - [RISCV] Fix mcount name

Author: Nathan Chancellor Date: 2021-03-24T18:11:37-07:00 New Revision: ef58ae86ba778ed7d01cd3f6bd6d08f943abab44 URL: https://github.com/llvm/llvm-project/commit/ef58ae86ba778ed7d01cd3f6bd6d08f943abab44 DIFF: https://github.com/llvm/llvm-project/commit/ef58ae86ba778ed7d01cd3f6bd6d08f943abab44.d

[PATCH] D98881: [RISCV] Fix mcount name

nathanchance updated this revision to Diff 333185. nathanchance added a comment. Drop "riscv32" and "riscv64" from list of checked triples (thanks to Fangrui for catching it with a good explanation). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98

[PATCH] D99308: [Triple][Driver] Add muslx32 environment and use /lib/ld-musl-x32.so.1 for -dynamic-linker

MaskRay created this revision. MaskRay added reviewers: compnerd, raj.khem. Herald added subscribers: dexonsmith, hiraditya. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo ht

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

aprantl requested changes to this revision. aprantl added a comment. This revision now requires changes to proceed. Can you explain your motivation? There is usually no good reason not to emit more specific attributes from future DWARF versions if they aren't in direct conflict with the older ve

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov marked 2 inline comments as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8643 QualType MatchedType = -BuildDecltypeType(E, E->getBeginLoc()).getCanonicalType(); +BuildDecltypeType(E, E->getBeginLoc(), true, true).g

[PATCH] D97831: [Clang][Sema] Implement GCC -Wcast-function-type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG217f0f735afe: [Clang][Sema] Implement GCC -Wcast-function-type (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 217f0f7 - [Clang][Sema] Implement GCC -Wcast-function-type

Author: Yuanfang Chen Date: 2021-03-24T16:04:18-07:00 New Revision: 217f0f735afec57a51fa6f9ab863d4713a2f85e2 URL: https://github.com/llvm/llvm-project/commit/217f0f735afec57a51fa6f9ab863d4713a2f85e2 DIFF: https://github.com/llvm/llvm-project/commit/217f0f735afec57a51fa6f9ab863d4713a2f85e2.diff

[PATCH] D97831: [Clang][Sema] Implement GCC -Wcast-function-type

ychen updated this revision to Diff 333162. ychen added a comment. - update doc to match diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97831/new/ https://reviews.llvm.org/D97831 Files: clang/docs/DiagnosticsReference.rst clang/incl

[PATCH] D97831: [Clang][Sema] Implement GCC -Wcast-function-type

ychen added a comment. Thanks for the insightful suggestions. I'll definitely send a follow-up patch for these (pointerLike arguments, TargetInfo refactoring, promotable integral types). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97831/new/ ht

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov updated this revision to Diff 333158. mizvekov added a comment. Rebased on top of D99225 , running on a bunch of extra tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.o

[clang] 35dd647 - [Driver] Bring back "Clean up Debian multiarch /usr/include/ madness"

Author: Fangrui Song Date: 2021-03-24T15:25:37-07:00 New Revision: 35dd6470de847636c212d7e0cd4d7ac2995679cc URL: https://github.com/llvm/llvm-project/commit/35dd6470de847636c212d7e0cd4d7ac2995679cc DIFF: https://github.com/llvm/llvm-project/commit/35dd6470de847636c212d7e0cd4d7ac2995679cc.diff

[clang] bfbfd83 - [Driver] Linux.cpp: delete unneeded D.getVFS().exists checks

Author: Fangrui Song Date: 2021-03-24T15:25:36-07:00 New Revision: bfbfd83f147f0e02e652f3ae2635dd834c2e6b46 URL: https://github.com/llvm/llvm-project/commit/bfbfd83f147f0e02e652f3ae2635dd834c2e6b46 DIFF: https://github.com/llvm/llvm-project/commit/bfbfd83f147f0e02e652f3ae2635dd834c2e6b46.diff

[PATCH] D99301: [HIP] add __builtin_get_device_side_mangled_name

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a couple of nits. Comment at: clang/include/clang/Basic/Builtins.h:39 OMP_LANG = 0x80,// builtin requires OpenMP. + HIP_LANG = 0x100, // builtin requires HIP.

[PATCH] D98554: Save strings for CC_PRINT env vars

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Comment at: clang/lib/Driver/Driver.cpp:4042 - if (!CCPrintStatReportFilename) { + if (CCPrintStatReportFilename.emp

[PATCH] D97831: [Clang][Sema] Implement GCC -Wcast-function-type

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good. Some possible improvements to make the diagnostic a bit more precise, but I'd be happy if you want to address some of those as follow-ups after this change. Com

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha added a comment. Hey @fhahn , I realise, as you pointed out before, that we need to do some changes in CodeGen too. I think its going to be more involved so before starting on that, it would be great if you can confirm whether I am on the right path. I will describe what I did, what

[PATCH] D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter

davidstone marked 2 inline comments as done. davidstone added a comment. I believe this addresses the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82880/new/ https://reviews.llvm.org/D82880 ___

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

davidstone updated this revision to Diff 333135. davidstone added a comment. [clang] Handle 128-bits IntegerLiterals in StmtPrinter This fixes PR35677: "__int128_t or __uint128_t as non-type template parameter causes crash when considering invalid constructor". Repository: rG LLVM Github Mono

[PATCH] D99301: [HIP] add __builtin_get_device_side_mangled_name

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Add builtin function __builtin_get_device_side_mangled_name to get device side manged name for functions and global variables, which can be used to get symbol address of kernels or variables by ma

[PATCH] D99243: [CMake][Fuchsia] Include llvm-lipo

This revision was automatically updated to reflect the committed changes. Closed by commit rG39f3e9a9e07d: [CMake][Fuchsia] Include llvm-lipo (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99243/new/ https://reviews.llvm.org/D99

[clang] 39f3e9a - [CMake][Fuchsia] Include llvm-lipo

Author: Petr Hosek Date: 2021-03-24T14:21:40-07:00 New Revision: 39f3e9a9e07db547b8daac67155abf3a56b34181 URL: https://github.com/llvm/llvm-project/commit/39f3e9a9e07db547b8daac67155abf3a56b34181 DIFF: https://github.com/llvm/llvm-project/commit/39f3e9a9e07db547b8daac67155abf3a56b34181.diff LO

[PATCH] D98747: Thread safety analysis: Don't warn about managed locks on join points

aaronpuchert added a comment. Not replying in order, I hope that's not confusing. Let's start with the motivation. In D98747#2648381 , @delesley wrote: > Is there a compelling reason for this change, other than consistency/symmetry > concerns? In other

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added a comment. In D96771#2647848 , @gribozavr2 wrote: > Pushed the most minimal fix in > https://github.com/llvm/llvm-project/commit/41454c30f6a38c3e107d857e63da0561610fd141, > please double check. This looks great! Thanks for fixing this!

[PATCH] D99297: [OPENMP]Fix PR49636: Assertion `(!Entry.getAddress() || Entry.getAddress() == Addr) && "Resetting with the new address."' failed.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a project: clang. The original issue is caused by the fact that the variable is allocated with incorrect type i1 instead of i8. Th

[PATCH] D98286: [Driver] Enable kernel address and memory sanitizers on FreeBSD

markj updated this revision to Diff 333106. markj added a comment. - Add a couple of regression tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98286/new/ https://reviews.llvm.org/D98286 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp clan

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

Anastasia added a comment. I have done some measurements using the test produced from this Tablegen emitter (59K lines). I have used the test it in two files: 1. `SemaOpenCL/all-std-buitins.cl` that has the following RUN line appended 6 times (for every supported OpenCL version v1.0, v1.1, v1.

[PATCH] D98286: [Driver] Enable kernel address and memory sanitizers on FreeBSD

markj added a comment. In D98286#2648449 , @dim wrote: > LGTM, but this would probably need some sort of test, at least that it > correctly accepts the flag(s) now? Working on it, I see some examples. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

This revision was automatically updated to reflect the committed changes. Closed by commit rGe030ce3ec790: [Tooling] Handle compilation databases containing commands with double dashes (authored by jnykiel, committed by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e030ce3 - [Tooling] Handle compilation databases containing commands with double dashes

Author: Janusz Nykiel Date: 2021-03-24T16:01:47-04:00 New Revision: e030ce3ec790a0017ec789b4f487afec99e1cac9 URL: https://github.com/llvm/llvm-project/commit/e030ce3ec790a0017ec789b4f487afec99e1cac9 DIFF: https://github.com/llvm/llvm-project/commit/e030ce3ec790a0017ec789b4f487afec99e1cac9.diff

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

This revision was automatically updated to reflect the committed changes. Closed by commit rGe29bb074c62c: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D95458?vs=329015&id=333101#toc Repository:

[PATCH] D99288: [OPENMP]Fix PR49468: Declare target should allow empty sequences and namespaces.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e9f6eba84f0: [OPENMP]Fix PR49468: Declare target should allow empty sequences and namespaces. (authored by ABataev). Repository: rG LLVM Github M

[clang] 9e9f6eb - [OPENMP]Fix PR49468: Declare target should allow empty sequences and namespaces.

Author: Alexey Bataev Date: 2021-03-24T12:53:33-07:00 New Revision: 9e9f6eba84f01785ef154539878a7ebd2692344a URL: https://github.com/llvm/llvm-project/commit/9e9f6eba84f01785ef154539878a7ebd2692344a DIFF: https://github.com/llvm/llvm-project/commit/9e9f6eba84f01785ef154539878a7ebd2692344a.diff

[PATCH] D98275: [clang-tidy] Fix mpi checks when running multiple TUs per clang-tidy process

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/mpi/BufferDerefCheck.cpp:29-30 + if (!FuncClassifier) +FuncClassifier.emplace(*Result.Context); + aaron.ballman wrote: > njames93 wrote: > >

[PATCH] D99259: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6aae5f7fcd1: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions (authored by aheejin). Repository: rG LLVM Github Monorepo

[clang] a6aae5f - [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions

Author: Heejin Ahn Date: 2021-03-24T12:27:49-07:00 New Revision: a6aae5f7fcddb87bfe77072912484213f872 URL: https://github.com/llvm/llvm-project/commit/a6aae5f7fcddb87bfe77072912484213f872 DIFF: https://github.com/llvm/llvm-project/commit/a6aae5f7fcddb87bfe77072912484213f872.diff LO

[PATCH] D99262: [analyzer] Fix dead store checker false positive

steakhal added a comment. In D99262#2648533 , @vsavchenko wrote: > In D99262#2648512 , @steakhal wrote: > >> I see your point. >> >> Would it report this issue? >> >> int test() { >> struct Foo foo = {0, 0}; /

[PATCH] D98275: [clang-tidy] Fix mpi checks when running multiple TUs per clang-tidy process

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/mpi/BufferDerefCheck.cpp:29-30 + if (!FuncClassifier) +FuncClassifier.emplace(*Result.Context); + njames93 wrote: > aaron.ballman wrote: > > This is racy, but I don't think we su

[PATCH] D99288: [OPENMP]Fix PR49468: Declare target should allow empty sequences and namespaces.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99288/new/ https://reviews.llvm.org/D99288 ___

[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:135-138 + + /// Updates this instance based on the extension of the input file (e.g. f90 + /// s F90) + void updateBasedOnExtension(const FrontendInputFile &inputFile);

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

This revision was automatically updated to reflect the committed changes. Closed by commit rG279ea930fa21: [clang] Add fixit for Wreorder-ctor (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98745/new/ https://reviews.llvm.org/

[clang] 279ea93 - [clang] Add fixit for Wreorder-ctor

Author: Nathan James Date: 2021-03-24T19:22:53Z New Revision: 279ea930fa21b283688b2598816095a48d0ca4d7 URL: https://github.com/llvm/llvm-project/commit/279ea930fa21b283688b2598816095a48d0ca4d7 DIFF: https://github.com/llvm/llvm-project/commit/279ea930fa21b283688b2598816095a48d0ca4d7.diff LOG:

[PATCH] D98275: [clang-tidy] Fix mpi checks when running multiple TUs per clang-tidy process

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/mpi/BufferDerefCheck.cpp:29-30 + if (!FuncClassifier) +FuncClassifier.emplace(*Result.Context); + aaron.ballman wrote: > This is racy, but I

[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added subscribers: jansvoboda11, dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds support for the `-cpp` and `-nocpp` flags. The im

[PATCH] D99291: [AIX] Support init priority attribute

Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, ZarkoCA, xingxue. Herald added a reviewer: aaron.ballman. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gi

[PATCH] D98275: [clang-tidy] Fix mpi checks when running multiple TUs per clang-tidy process

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clang-tidy/mpi/BufferDerefCheck.cpp:29-30 + if (!FuncClassifier) +FuncClassifier.emplace(*Result.Context); +

[PATCH] D99262: [analyzer] Fix dead store checker false positive

vsavchenko added a comment. In D99262#2648512 , @steakhal wrote: > I see your point. > > Would it report this issue? > > int test() { > struct Foo foo = {0, 0}; // I would expect a warning here, that 'foo' was > initialized but never read. > (vo

[PATCH] D99262: [analyzer] Fix dead store checker false positive

steakhal added a comment. I see your point. Would it report this issue? int test() { struct Foo foo = {0, 0}; // I would expect a warning here, that 'foo' was initialized but never read. (void)foo; return 0; } Only nits besides this. Comment at: clang/lib/Sta

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst:17 +Calls to ``new`` can throw exception of type ``bad_alloc`` that should be +handled by the code. Alternatively the nonthrowing form of ``new`` can

[PATCH] D99288: [OPENMP]Fix PR49468: Declare target should allow empty sequences and namespaces.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. The emty declare target/end declare target region should not cause

[PATCH] D98286: [Driver] Enable kernel address and memory sanitizers on FreeBSD

dim accepted this revision. dim added a comment. LGTM, but this would probably need some sort of test, at least that it correctly accepts the flag(s) now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98286/new/ https://reviews.llvm.org/D98286 __

[PATCH] D99285: [SystemZ][z/OS] csv files should be text files

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch sets the OF_Text flag correctly for the csv file. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D65572: Fix static linking failure with --unwindlib=libunwind

raj.khem added a comment. @MaskRay how should be proceeed here Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65572/new/ https://reviews.llvm.org/D65572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D98747: Thread safety analysis: Don't warn about managed locks on join points

delesley added a comment. Thanks for roping me into the conversation, Aaron, and sorry about the delay. I have mixed feelings about this patch. With respect to the purpose of thread safety analysis, finding race conditions is obviously a major concern, because race conditions are hard to find

[PATCH] D71369: Detect libdl from cmake variable

raj.khem abandoned this revision. raj.khem added a comment. 0073c293a401774ac96b4b3d27f05e13f379f98e has fixed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71369/new/ http

[PATCH] D46914: Run scan-view on systems with python3 as default python provider

raj.khem abandoned this revision. raj.khem added a comment. it works with python3 too, perhaps it would be good to ask for python3 instead Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46914/new/ https://reviews.llvm.org/D46914 __

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 updated this revision to Diff 333052. usaxena95 added a comment. Remove unintended changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99086/new/ https://reviews.llvm.org/D99086 Files: clang-tools-extra/clangd/ParsedAST.cpp clang/

[PATCH] D18174: Fix libcxx build on musl

raj.khem abandoned this revision. raj.khem added a comment. this is no longer needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18174/new/ https://reviews.llvm.org/D18174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 updated this revision to Diff 333045. usaxena95 marked 6 inline comments as done. usaxena95 edited the summary of this revision. usaxena95 added a comment. Herald added a subscriber: arphaman. Herald added a project: clang-tools-extra. Made the optimization an 'opt-in'. Created `TokenBuf

[PATCH] D99259: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions

aheejin updated this revision to Diff 333041. aheejin added a comment. Add break Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99259/new/ https://reviews.llvm.org/D99259 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/Driver/wasm

[PATCH] D99235: [HIP] Change to code object v4

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:116 + if (getOrCheckAMDGPUCodeObjectVersion(C.getDriver(), Args) >= 4) +OffloadKind = OffloadKind + "v4"; for (const auto &II : Inputs) { ---

[PATCH] D99259: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99259/new/ https://reviews.llvm.org/D99259 ___

[PATCH] D99200: [SystemZ][z/OS] JSON file should be text files

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bf833f670bd: [SystemZ][z/OS] JSON file should be text files (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99200/new/

[clang] 0bf833f - [SystemZ][z/OS] JSON file should be text files

Author: Abhina Sreeskantharajan Date: 2021-03-24T13:28:08-04:00 New Revision: 0bf833f670bdc42009b0ff208e8266f528e0a82c URL: https://github.com/llvm/llvm-project/commit/0bf833f670bdc42009b0ff208e8266f528e0a82c DIFF: https://github.com/llvm/llvm-project/commit/0bf833f670bdc42009b0ff208e8266f528e0

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. This patch does not model faithfully how reinterpretcasting member pointers should work. The base specifiers represent the history for the member pointer (aka. mptr), describing

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

sammccall added a comment. In D98499#2644313 , @kadircet wrote: > In D98499#2626502 , @sammccall wrote: > >> My model for modules using this diagnostic stuff (apart from the >> build-system stuff which sadly can't

[PATCH] D99280: [OPENMP]Fix PR48571: critical/master in outlined contexts cause crash.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7654bb6303d2: [OPENMP]Fix PR48571: critical/master in outlined contexts cause crash. (authored by ABataev). Repository: rG LLVM Github Monorepo C

[clang] 7654bb6 - [OPENMP]Fix PR48571: critical/master in outlined contexts cause crash.

Author: Alexey Bataev Date: 2021-03-24T10:15:24-07:00 New Revision: 7654bb6303d290b19cad29137be810e69a0bf917 URL: https://github.com/llvm/llvm-project/commit/7654bb6303d290b19cad29137be810e69a0bf917 DIFF: https://github.com/llvm/llvm-project/commit/7654bb6303d290b19cad29137be810e69a0bf917.diff

[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

jrtc27 added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vle16ff.c:9 +// RUN: -target-feature +experimental-zfh -target-feature +m -fallow-half-arguments-and-returns -Werror -Wall -S -o - %s >/dev/null 2>%t +// RUN: FileCheck --check-prefix=ASM --allow

[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

jrtc27 added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vle16ff.c:9 +// RUN: -target-feature +experimental-zfh -target-feature +m -fallow-half-arguments-and-returns -Werror -Wall -S -o - %s >/dev/null 2>%t +// RUN: FileCheck --check-prefix=ASM --allow

[PATCH] D99280: [OPENMP]Fix PR48571: critical/master in outlined contexts cause crash.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99280/new/ https://reviews.llvm.org/D99280 _

[PATCH] D99274: [analyzer] Fix crash when reasoning about C11 atomics (PR49422)

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99274/new/ https://reviews.llvm.org/D99274 _

[PATCH] D98538: [clangd] Perform merging for stale symbols in MergeIndex

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/Merge.cpp:59 + + bool DynamicIndexIsAuthoritative = + // We expect the definition to see the canonical decl

[PATCH] D99280: [OPENMP]Fix PR48571: critical/master in outlined contexts cause crash.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. If emit inlined region for master/critical directives, no need to

[PATCH] D98505: [clangd] Propagate data in diagnostics

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Diagnostics.h:77 + // list. + std::vector OpaqueData; }; Hmm, you've replaced the json::Array with an array

[PATCH] D98724: Fix false negative in -Wthread-safety-attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6a1c3051dbd: Fix false negative in -Wthread-safety-attributes (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] a6a1c30 - Fix false negative in -Wthread-safety-attributes

Author: Aaron Puchert Date: 2021-03-24T17:45:25+01:00 New Revision: a6a1c3051dbd2cc5ccc70272890cf38d11dca9c7 URL: https://github.com/llvm/llvm-project/commit/a6a1c3051dbd2cc5ccc70272890cf38d11dca9c7 DIFF: https://github.com/llvm/llvm-project/commit/a6a1c3051dbd2cc5ccc70272890cf38d11dca9c7.diff

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith, rjmccall. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sorry for the title, I'm not 100% sure that's even correct here. This call to `ProhibitAttribu

[PATCH] D99235: [HIP] Change to code object v4

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:116 + if (getOrCheckAMDGPUCodeObjectVersion(C.getDriver(), Args) >= 4) +OffloadKind = OffloadKind + "v4"; for (const auto &II : Inputs) { We do not do it for v2/v3. Could you elabo

[PATCH] D98747: Thread safety analysis: Don't warn about managed locks on join points

aaron.ballman added a comment. I'd really like to hear from @delesley about these changes, specifically because of this bit: > the primary goal of the Thread safety analysis is not to find double locks > but race conditions. I believe the primary goal of TSA is to find threading-related issues

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen added inline comments. Comment at: llvm/lib/CodeGen/ValueTypes.cpp:17 +unsigned EVT::getVectorNumElements() const { + auto Error = []() { ctetreau wrote: > Out of curiosity, what is the eventual plan for this function? Does it go > away, or will it

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen updated this revision to Diff 333018. sdesmalen marked 5 inline comments as done. sdesmalen added a comment. Moved implementation of EVT::getVectorNumElements back to header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98856/new/ https:

[PATCH] D99274: [analyzer] Fix crash when reasoning about C11 atomics (PR49422)

vsavchenko created this revision. vsavchenko added reviewers: NoQ, steakhal, xazax.hun, ASDenysPetrov. Herald added subscribers: Charusso, dkrupp, donat.nagy, Szelethus, jfb, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald adde

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5052-5055 + if (isa(JA)) { +CmdArgs.push_back("-mllvm"); +CmdArgs.push_back("-treat-scalable-fixed-error-as-warning"); + } paulwalker-arm wrote: > Are there any concerns

[PATCH] D98724: Fix false negative in -Wthread-safety-attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98724/new/ https://reviews.llvm.org/D98724 __

[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vle16ff.c:9 +// RUN: -target-feature +experimental-zfh -target-feature +m -fallow-half-arguments-and-returns -Werror -Wall -S -o - %s >/dev/null 2>%t +// RUN: FileCheck --check-prefix=ASM -

  1   2   >