jrtc27 added inline comments.
================ Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vle16ff.c:9 +// RUN: -target-feature +experimental-zfh -target-feature +m -fallow-half-arguments-and-returns -Werror -Wall -S -o - %s >/dev/null 2>%t +// RUN: FileCheck --check-prefix=ASM --allow-empty %s <%t + ---------------- jrtc27 wrote: > craig.topper wrote: > > jrtc27 wrote: > > > khchen wrote: > > > > nit: skip the temporary file and remove +experimental-zfh and > > > > -fallow-half-arguments-and-returns. > > > Can we please stop putting ASM tests in Clang, and if they really are > > > needed, splitting them out into their own files separate from the IR > > > tests? > > For more background, this approach was copied from AArch64 SVE where they > > said this was beneficial to catch warnings from TypeSize's implicit > > conversion to uint64_t. > You can have the ASM tests in a separate .test file though so you can still > run the IR tests without the backend if there's value in having the > end-to-end tests (well s/tests/RUN lines/) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99151/new/ https://reviews.llvm.org/D99151 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
