[clang] ce97d8e - Revert "[WoA][MSVC] Use default linker setting in MSVC-compatible driver"

Author: Petr Hosek Date: 2021-03-18T23:42:31-07:00 New Revision: ce97d8e6c7409501e9b42de3db34ae0486115e25 URL: https://github.com/llvm/llvm-project/commit/ce97d8e6c7409501e9b42de3db34ae0486115e25 DIFF: https://github.com/llvm/llvm-project/commit/ce97d8e6c7409501e9b42de3db34ae0486115e25.diff LO

[PATCH] D98922: Delete Redundant parameters in clang/unittests/AST/CMakeLists.txt

joker881 created this revision. joker881 added a reviewer: Jessica. Herald added a subscriber: mgorny. joker881 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is a redundant ASTTraverserTest.cpp in “clang/unittests/AST/ CMakeLists.t

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

yubing updated this revision to Diff 331766. yubing added a comment. address Pengfei's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110 Files: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp llvm/

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:318-319 +// calculate idxa, idxb, idxc +// %eltc = extractelement <256 x i32> %vec.c.inner.phi, i16 %idxc +// %eltcf32 = bitcast i32 %eltc to float +// %elta = extractelement <

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc1812a0ad75: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and… (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] fc1812a - [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

Author: Hongtao Yu Date: 2021-03-18T22:11:16-07:00 New Revision: fc1812a0ad757838b66aab57e1df720ec205a16a URL: https://github.com/llvm/llvm-project/commit/fc1812a0ad757838b66aab57e1df720ec205a16a DIFF: https://github.com/llvm/llvm-project/commit/fc1812a0ad757838b66aab57e1df720ec205a16a.diff LO

[PATCH] D98918: [clang][lit] Allow test cases to use the compiler that are used to compile Clang

OikawaKirie created this revision. OikawaKirie added reviewers: thakis, steakhal. OikawaKirie added a project: clang. OikawaKirie requested review of this revision. Herald added a subscriber: cfe-commits. Required by D83660 . Test cases may want to use the host co

[clang] d8ab7ad - Fix example in documentation.

Author: Richard Smith Date: 2021-03-18T20:06:17-07:00 New Revision: d8ab7ad317305d80e405ffdb4f33983f743a6ca2 URL: https://github.com/llvm/llvm-project/commit/d8ab7ad317305d80e405ffdb4f33983f743a6ca2 DIFF: https://github.com/llvm/llvm-project/commit/d8ab7ad317305d80e405ffdb4f33983f743a6ca2.diff

[clang] 5c689e4 - Improve documentation for the [[clang::lifetimebound]] attribute.

Author: Richard Smith Date: 2021-03-18T19:58:21-07:00 New Revision: 5c689e4bb0473e08645547ddbf9874b5e2fa04d0 URL: https://github.com/llvm/llvm-project/commit/5c689e4bb0473e08645547ddbf9874b5e2fa04d0 DIFF: https://github.com/llvm/llvm-project/commit/5c689e4bb0473e08645547ddbf9874b5e2fa04d0.diff

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

jdoerfert added a comment. @tra, so you think we should not do this? The user will see a link error late I assume, might be better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98902/new/ https://reviews.llvm.org/D98902 _

[PATCH] D98912: Fix -Winteger-overflow to diagnose regardless of the top-level syntactic form.

rsmith created this revision. rsmith added a reviewer: vsapsai. rsmith requested review of this revision. Herald added a project: clang. Previously -Winteger-overflow did not do any checking of expressions whose top-level syntactic form wasn't one of a small list of special cases. This meant that

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

phosek added a comment. This is still broken, we're seeing multiple failing tests, can we please revert this change for now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98493/new/ https://reviews.llvm.org/D98493

[PATCH] D97902: [docs] Improve documentation of -B and --gcc-toolchain

MaskRay updated this revision to Diff 331738. MaskRay retitled this revision from "[Driver] Clarify --gcc-toolchain" to "[docs] Improve documentation of -B and --gcc-toolchain". MaskRay added a comment. Rebase on D97993 Repository: rG LLVM Github Monorepo CH

[PATCH] D97993: [Driver] Suppress GCC detection under -B

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:76-77 +- ``-B `` (when ``>`` is a directory) used to detect GCC + installations under . This behavior is incompatible with GCC, + causes interop issues with ``--gcc-toolchain``, and is thus dropped. Spe

[PATCH] D97993: [Driver] Suppress GCC detection under -B

MaskRay updated this revision to Diff 331736. MaskRay marked 5 inline comments as done. MaskRay retitled this revision from "[Driver] Suppress GCC detection under -B for non-Android" to "[Driver] Suppress GCC detection under -B". MaskRay edited the summary of this revision. MaskRay added a comment

[PATCH] D98881: [RISCV] Fix mcount name for Linux

nathanchance added a comment. Such a diff does not look too bad: diff --git a/clang/lib/Basic/Targets/OSTargets.h b/clang/lib/Basic/Targets/OSTargets.h index 539466c4f678..c32972c1e04e 100644 --- a/clang/lib/Basic/Targets/OSTargets.h +++ b/clang/lib/Basic/Targets/OSTargets.h @@ -256,6

[PATCH] D98904: Instantiate static constexpr data members on MS ABI.

zoecarver added a comment. > So. I think the status quo is OK but not great; we accept invalid code, in > the name of MSVC compatibility, that MSVC doesn't accept. I don't think > following MSVC would be a good thing, as that'd lead to our rejecting valid > code (that MSVC also rejects but that

[PATCH] D98904: Instantiate static constexpr data members on MS ABI.

rsmith added a comment. In D98904#2636109 , @zoecarver wrote: > I think we'd basically need a condition that says: `is-microsoft && > less-than-cxx17 && is-constexpr && is-static-data-member`. Yes. Looking back over the history a bit here, https://revie

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. Let's drop the Android part, too? Update the description (commit message), too? I checked our oldest supported kernel version, and we don't use `-B` either: https:/

[PATCH] D98907: [WebAssembly] Remove experimental instructions from wasm_simd128.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcbab2cd6bf77: [WebAssembly] Remove experimental instructions from wasm_simd128.h (authored by tlively). Repository: rG LLVM Github Monorepo CHANG

[clang] cbab2cd - [WebAssembly] Remove experimental instructions from wasm_simd128.h

Author: Thomas Lively Date: 2021-03-18T17:13:50-07:00 New Revision: cbab2cd6bf77f121c0d8a46abf607895b2911a20 URL: https://github.com/llvm/llvm-project/commit/cbab2cd6bf77f121c0d8a46abf607895b2911a20 DIFF: https://github.com/llvm/llvm-project/commit/cbab2cd6bf77f121c0d8a46abf607895b2911a20.diff

[PATCH] D98907: [WebAssembly] Remove qfma/qfms from wasm_simd128.h

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These experimental builtin func

[PATCH] D98904: Instantiate static constexpr data members on MS ABI.

zoecarver added a comment. > (I think you're missing something here to trigger the instantiation of the > class, such as Invalid x;.) Yes, you're right. > The above example is valid in C++17 onwards, because in C++17 onwards, static > constexpr data members are implicitly inline, and the delay

[PATCH] D98904: Instantiate static constexpr data members on MS ABI.

rsmith added a comment. In D98904#2636021 , @zoecarver wrote: > So, as I mentioned in the description of this patch, the reason that these > members are treated as definitions is that Clang implicitly marks them as > inline when targeting MS. This is sor

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97993/new/ https://reviews.llvm.org/D97993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

kkwli0 added a comment. I tried the patch in our environment and it works. LG. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98902/new/ https://reviews.llvm.org/D98902 ___ cfe-commits mailing l

[PATCH] D98904: Instantiate static constexpr data members on MS ABI.

zoecarver added a comment. So, as I mentioned in the description of this patch, the reason that these members are treated as definitions is that Clang implicitly marks them as inline when targeting MS. This is sort of interesting a) because it only applies to constexpr vars, and b) because this

[PATCH] D98338: [clang-tidy] Fix bugprone-terminating-continue when continue appears inside a switch

njames93 updated this revision to Diff 331713. njames93 marked an inline comment as done. njames93 added a comment. Add test case for do inside switch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98338/new/ https://reviews.llvm.org/D98338 Files:

[PATCH] D98904: Instantiate static constexpr data members on MS ABI.

zoecarver created this revision. zoecarver added a reviewer: rsmith. zoecarver requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because MSVC will not treat the definition of a static data member as part of the declaration, it will not get i

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

tianshilei1992 added a comment. In D98902#2635930 , @tra wrote: >> My question is, if DeviceOffloadingKind == Action::OFK_Cuda, and we use -S, >> do we also want to skip as well? > > I do not think so. Libdevice is needed to implement some libcalls that L

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

tra added a comment. > My question is, if DeviceOffloadingKind == Action::OFK_Cuda, and we use -S, > do we also want to skip as well? I do not think so. Libdevice is needed to implement some libcalls that LLVM currently does not know how to handle. We do need it even when we compile with `-S`.

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

rjmccall added a comment. Yes, I think that would be reasonable, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 ___ cfe-commits mailing list cfe-commi

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

tianshilei1992 created this revision. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. https://lists.llvm.org/pipermail/openmp-dev/2021-M

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

amyk added a comment. Hi, Thanks for fixing the tests. I've tested this patch on the environment of `clang-ppc64le-rhel` (https://lab.llvm.org/buildbot/#/builders/57), and there seems to be two failures that still remain: Failed Tests (2): Clang :: OpenMP/linking.c Clang :: Driver/ms

[PATCH] D98881: [RISCV] Fix mcount name for Linux

nathanchance added a comment. Would it be better to hoist it into `RISCVTargetInfo` and modify the BSD switch statements to respect that in their respective TargetInfo constructors? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98881/new/ https://

[PATCH] D98881: [RISCV] Fix mcount name for Linux

jrtc27 added a comment. This should really be for all OSes on RISC-V, which I think means copying it N times? :/ (GCC defines MCOUNT_NAME in riscv/riscv.h, not riscv/linux.h) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98881/new/ https://review

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

asavonic added a comment. I'm not sure that this is the right approach, but I wanted to get feedback on how the issue should be fixed. Currently, the compiler crashes on almost any code with `long double` (excluding cases where CG does not properly disable x87): long double foo(long double x,

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

asavonic created this revision. asavonic added a reviewer: andrew.w.kaylor. Herald added a subscriber: pengfei. asavonic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch attempts to fix a compiler crash that occurs when `long doub

[PATCH] D98889: [clang] Replaced some manual pointer tagging with llvm::PointerIntPair.

haberman marked an inline comment as done. haberman added a comment. > Thanks! Do we need InitializedEntity::getDecl to return a pointer to > non-const? Yes, if I try to propagate `const` the change starts to snowball. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D98889: [clang] Replaced some manual pointer tagging with llvm::PointerIntPair.

haberman updated this revision to Diff 331679. haberman added a comment. Updated comment "the low bit" -> "the integer". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98889/new/ https://reviews.llvm.org/D98889 Files: clang/include/clang/Sema/Ini

[PATCH] D98893: Updated comment "the low bit" -> "the integer".

haberman abandoned this revision. haberman added a comment. This was meant to be an update on https://reviews.llvm.org/D98889 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98893/new/ https://reviews.llvm.org/D98893

[PATCH] D98893: Updated comment "the low bit" -> "the integer".

haberman created this revision. haberman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98893 Files: clang/include/clang/Sema/Initialization.h Index: clang/include/clang

[PATCH] D98892: [HWASan] Mention x86_64 aliasing mode in design doc.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:279 + +HWASAN's approach is not applicable to 32-bit architectures. This statement

[PATCH] D98887: [clang-cl] make -ffile-compilation-dir a CoreOption.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c740b29fae3: [clang-cl] make -ffile-compilation-dir a CoreOption. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 1c740b2 - [clang-cl] make -ffile-compilation-dir a CoreOption.

Author: Zequan Wu Date: 2021-03-18T13:20:47-07:00 New Revision: 1c740b29fae3962a9c8644496352b10798d925ef URL: https://github.com/llvm/llvm-project/commit/1c740b29fae3962a9c8644496352b10798d925ef DIFF: https://github.com/llvm/llvm-project/commit/1c740b29fae3962a9c8644496352b10798d925ef.diff LOG

[PATCH] D98892: [HWASan] Mention x86_64 aliasing mode in design doc.

morehouse updated this revision to Diff 331670. morehouse added a comment. - Format `fork()` as code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98892/new/ https://reviews.llvm.org/D98892 Files: clang/docs/HardwareAssistedAddressSanitizerDesi

[PATCH] D98892: [HWASan] Mention x86_64 aliasing mode in design doc.

morehouse created this revision. morehouse added reviewers: pcc, eugenis. morehouse requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98892 Files: clang/docs/HardwareAssisted

[PATCH] D98746: [clang][amdgpu] Use implicit code object default

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1115-1124 + // Currently defaults to 3 in AMDGPUBaseInfo.cpp + // Using that default lets clang emit IR for amdgcn when llvm has been built + // without that target, provided the user wants this co

[PATCH] D98887: [clang-cl] make -ffile-compilation-dir a CoreOption.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98887/new/ https://reviews.llvm.org/D98887 ___ c

[PATCH] D98338: [clang-tidy] Fix bugprone-terminating-continue when continue appears inside a switch

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Herald added a project: clang-tools-extra. LGTM, but please commit with a better commit message. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugpron

[PATCH] D98890: [SystemZ][z/OS] Ignore leading zero width bitfield alignment on z/OS target

fanbo-meng created this revision. fanbo-meng added reviewers: abhina.sreeskantharajan, hubert.reinterpretcast, Kai, SeanP, rsmith. fanbo-meng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Zero length bitfield alignment is not respected i

[PATCH] D98889: [clang] Replaced some manual pointer tagging with llvm::PointerIntPair.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Do we need `InitializedEntity::getDecl` to return a pointer to non-const? Looks good assuming we do. Comment at: clang/include/clang/Sema/Initialization.h:190 /

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy updated this revision to Diff 331660. hoy added a comment. Addresssing David's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98799/new/ https://reviews.llvm.org/D98799 Files: clang/lib/AST/ItaniumMangle.cpp clang/lib/CodeGen/CGDeb

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3525-3526 llvm::DINode::DIFlags &Flags) { - const auto *FD = cast(GD.getDecl()); + GlobalDecl CanonicalGD = GD.getCanonicalDecl(); + const auto *FD = cast(Canon

[PATCH] D98889: [clang] Replaced some manual pointer tagging with llvm::PointerIntPair.

haberman created this revision. haberman added a reviewer: rsmith. haberman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is no functional change here (hence no new tests). The only change is to replace a couple uintptr_t members wi

[PATCH] D98827: [AST] Ensure that an empty json file is generated if compile errors

steveire added a comment. In D98827#2635303 , @njames93 wrote: > Are there any tests that ensure something is always outputted? The test verifies that the generated c++ either gives no introspection data or introspection data which the test expects. Re

[PATCH] D98887: [clang-cl] make -ffile-compilation-dir a CoreOption.

zequanwu created this revision. zequanwu added reviewers: thakis, phosek. Herald added subscribers: jansvoboda11, dang. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Let clang-cl accepts `-ffile-compilation-dir` flag. Repositor

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

tmsriram added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:18 +// since it doesn't come with valid prototype. +static int bar(a) int a; +{ Nice test, I didnt know you could do this! Repository: rG LLVM Github Monorepo

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - couple of minor/optional things. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3525-3526 llvm::DINode::DIFlags &F

[PATCH] D98881: [RISCV] Fix mcount name for Linux

nathanchance created this revision. Herald added subscribers: vkmr, evandro, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook. nathanchance requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for this! The changes LGTM, but wait to land it for a day or two in case @rsmith has concerns. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5242 + if (Pr

[PATCH] D98827: [AST] Ensure that an empty json file is generated if compile errors

njames93 added a comment. Are there any tests that ensure something is always outputted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98827/new/ https://reviews.llvm.org/D98827 ___ cfe-commits mailing l

[PATCH] D98676: [WebAssembly] Finalize SIMD names and opcodes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5764a8654e3: [WebAssembly] Finalize SIMD names and opcodes (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D98676?vs=330

[clang] f5764a8 - [WebAssembly] Finalize SIMD names and opcodes

Author: Thomas Lively Date: 2021-03-18T11:21:25-07:00 New Revision: f5764a8654e3caa6ca5dab3a89238c165062228f URL: https://github.com/llvm/llvm-project/commit/f5764a8654e3caa6ca5dab3a89238c165062228f DIFF: https://github.com/llvm/llvm-project/commit/f5764a8654e3caa6ca5dab3a89238c165062228f.diff

[PATCH] D98466: [WebAssembly] Remove experimental SIMD instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f2ae08da91d: [WebAssembly] Remove experimental SIMD instructions (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D98466?

[clang] 2f2ae08 - [WebAssembly] Remove experimental SIMD instructions

Author: Thomas Lively Date: 2021-03-18T11:21:24-07:00 New Revision: 2f2ae08da91dc5c188d5bb4d8b0b096d0a120a4a URL: https://github.com/llvm/llvm-project/commit/2f2ae08da91dc5c188d5bb4d8b0b096d0a120a4a DIFF: https://github.com/llvm/llvm-project/commit/2f2ae08da91dc5c188d5bb4d8b0b096d0a120a4a.diff

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 updated this revision to Diff 331635. njames93 marked an inline comment as done. njames93 added a comment. Address nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98745/new/ https://reviews.llvm.org/D98745 Files: clang/include/clang

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 marked 4 inline comments as done. njames93 added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5242 + if (Previous->isAnyMemberInitializer()) +Diag << 0 << Previous->getAnyMember()->getDeclName(); + else aaron.ballman wrote: > This w

[PATCH] D98867: [HIP] Fix ROCm detection

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:271 +} +if (LatestROCm < FileName) + LatestROCm = FileName.str(); This will rank `rocm-3.9` higher than `rocm-3.10`. I think you do need to extract and compare the version

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 added a comment. In D98278#2635190 , @ashi1 wrote: > In D98278#2618936 , @zero9178 wrote: > >> In D98278#2616932 , @mstorsjo wrote: >> >>> In D98278#2616916

[PATCH] D98812: [OPENMP]Map data field with l-value reference types.

ABataev updated this revision to Diff 331623. ABataev added a comment. Rebase + fixes for references to complex data structures mapping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98812/new/ https://reviews.llvm.org/D98812 Files: clang/lib/Cod

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

ashi1 added a comment. In D98278#2618936 , @zero9178 wrote: > In D98278#2616932 , @mstorsjo wrote: > >> In D98278#2616916 , @zero9178 wrote: >> >>> Add GetErrcMessages.cmake,

[PATCH] D98855: [OpenCL] Support template parameters for as_type

svenvh added inline comments. Herald added a subscriber: ldrumm. Comment at: clang/test/SemaOpenCLCXX/template-astype.cl:5 +auto templated_astype(T x) { + return as_int2(x); + // expected-error@-1{{invalid reinterpretation: sizes of 'int2' (vector of 2 'int' values) and '__pri

[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

jnykiel updated this revision to Diff 331605. jnykiel added a comment. Fixed logic error in `injectResourceDir` causing a test failure on the build machine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98824/new/ https://reviews.llvm.org/D98824 Files: clang/lib/Tooling/ArgumentsAdj

[PATCH] D98876: [clang][ASTImporter] Add import support for SourceLocExpr.

balazske created this revision. Herald added subscribers: martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8611 +def warn_some_initializers_out_of_order : Warning< + "some initializers aren't given in the correct order">, + InGroup, DefaultIgnore; Hmmm, how about `initi

[PATCH] D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98864/new/ https://reviews.llvm.org/D98864 ___ cfe-co

[clang] 92ccc6c - Reapply "[NPM][CGSCC] FunctionAnalysisManagerCGSCCProxy: do not clear immutable function passes"

Author: Mircea Trofin Date: 2021-03-18T09:44:34-07:00 New Revision: 92ccc6cb17a4fd1b9506bac51f2eb1a96f4cd345 URL: https://github.com/llvm/llvm-project/commit/92ccc6cb17a4fd1b9506bac51f2eb1a96f4cd345 DIFF: https://github.com/llvm/llvm-project/commit/92ccc6cb17a4fd1b9506bac51f2eb1a96f4cd345.diff

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

protze.joachim added a comment. Hi Andrzej, thanks for the detailed insights. I think I really misunderstood, what the -W flags can do here. I also was not up-to-date regarding the state of the flang implementation. I just found, that compiling Spec OMP 2012 with clang-12 worked fine with my

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity marked 5 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:377 + + bool indicatesMixability() const { return Flags > MIX_None; } + aaron.ballman wrote: > Sh

[PATCH] D98834: [OPENMP51]Support for the 'destroy' clause with interop variable

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2f8e158f57c: [OPENMP51]Support for the 'destroy' clause with interop variable. (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] c2f8e15 - [OPENMP51]Support for the 'destroy' clause with interop variable.

Author: Mike Rice Date: 2021-03-18T09:12:56-07:00 New Revision: c2f8e158f57c173298ac39db8fd44211604ed003 URL: https://github.com/llvm/llvm-project/commit/c2f8e158f57c173298ac39db8fd44211604ed003 DIFF: https://github.com/llvm/llvm-project/commit/c2f8e158f57c173298ac39db8fd44211604ed003.diff LOG

[PATCH] D98415: [aarch64][WOA64][docs] Release note for WoA-hosted LLVM 12 binary

maxim-kuvyrkov closed this revision. maxim-kuvyrkov added a comment. This is merged to release/12.x branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98415/new/ https://reviews.llvm.org/D98415 ___ cf

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 updated this revision to Diff 331582. njames93 added a comment. Arc got confused Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98745/new/ https://reviews.llvm.org/D98745 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/li

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 updated this revision to Diff 331581. njames93 added a comment. Fix formatting issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98745/new/ https://reviews.llvm.org/D98745 Files: clang/test/SemaCXX/constructor-initializer.cpp clang

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 added a comment. In D98113#2634758 , @luismarques wrote: > I just looked at this again and I don't have the full context in my mind > right now but won't the test just exercise the BareMetal toolchain and not > your changes? I've since lost my re

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:377 + + bool indicatesMixability() const { return Flags > MIX_None; } + Should this be `MIX_WorkaroundDisableCanonicalEquivalence` instead

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

luismarques added a comment. I just looked at this again and I don't have the full context in my mind right now but won't the test just exercise the BareMetal toolchain and not your changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

maxim-kuvyrkov added a comment. @SureYeaah , does this fix your internal buildbot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98862/new/ https://reviews.llvm.org/D98862 ___ cfe-commits mailing list cf

[PATCH] D98873: Document -fcrash-diagnostics-dir

probinson created this revision. probinson added a reviewer: hans. Herald added subscribers: jansvoboda11, dang. probinson requested review of this revision. Herald added a project: clang. This was added in LLVM 7.0 but without help text or other docs. Repository: rG LLVM Github Monorepo http

[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

jnykiel updated this revision to Diff 331570. jnykiel retitled this revision from "[Tooling] Handle compilation databases with clang-cl commands generated by CMake 3.19+" to "[Tooling] Handle compilation databases containing commands with double dashes". jnykiel edited the summary of this revisio

[PATCH] D98855: [OpenCL] Support template parameters for as_type

Anastasia accepted this revision. Anastasia added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaOpenCLCXX/template-astype.cl:5 +auto templated_astype(T x) { + return as_int2(x); + // expected-error@-1{{invalid reinterpretation: siz

[PATCH] D98747: Thread safety analysis: Don't warn about managed locks on join points

aaronpuchert updated this revision to Diff 331567. aaronpuchert added a comment. Negative capabilities don't need to be considered as managed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98747/new/ https://reviews.llvm.org/D98747 Files: clang/

[PATCH] D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95736/new/ https://reviews.llvm.org/D95736 ___ cfe-commits mailing list

[PATCH] D72235: [clang-tidy] new altera unroll loops check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Mostly just nits for the check, otherwise this LGTM. Comment at: clang-tools-extra/clang-tidy/altera/UnrollLoopsCheck.cpp:65 +} +if (isa(Loop) || isa(Lo

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:529 +/// ReturnStmts return them from the function. +class Returned { + llvm::SmallVector ReturnedParams; aaron.ballman wrote: > whisperity w

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 331564. whisperity marked 4 inline comments as done. whisperity added a comment. **NFC** Turned some `Optional` into just `T`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78652/new/ https://reviews.llvm.or

[clang] c539be1 - [Hexagon] Add support for named registers cs0 and cs1

Author: Sid Manning Date: 2021-03-18T09:53:22-05:00 New Revision: c539be1dcbcf88530cfaf1728b077feb564b72ec URL: https://github.com/llvm/llvm-project/commit/c539be1dcbcf88530cfaf1728b077feb564b72ec DIFF: https://github.com/llvm/llvm-project/commit/c539be1dcbcf88530cfaf1728b077feb564b72ec.diff L

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity updated this revision to Diff 331560. whisperity marked 2 inline comments as done. whisperity added a comment. - **NFC** Fixed some nits - Added a new check option, //`MinimumIdentifierNameLength`// instead of a hardcoded `3` value. Defaults to `3`. - Fixed an issue with heuristics mat

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2632848 , @rjmccall wrote: > In D96033#2630978 , @v.g.vassilev > wrote: > I'm nervous in general about the looming idea of declaration unloading, but the fact that

  1   2   >