[PATCH] D98889: [clang] Replaced some manual pointer tagging with llvm::PointerIntPair.

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

Thanks! Do we need `InitializedEntity::getDecl` to return a pointer to 
non-const? Looks good assuming we do.



================
Comment at: clang/include/clang/Sema/Initialization.h:190
     /// When Kind == EK_Parameter, the ParmVarDecl, with the
     /// low bit indicating whether the parameter is "consumed".
+    llvm::PointerIntPair<ParmVarDecl *, 1> Parameter;
----------------
Here and below, consider updating "the low[er] bit" to "the integer" or similar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98889/new/

https://reviews.llvm.org/D98889

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits