[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks great. Comment at: clang-tools-extra/clangd/XRefs.cpp:1387 +if (auto LSPLoc = +toLSPLocation(Object.CanonicalDeclaration, *MainFile

[PATCH] D95737: [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ee1f64a2e82: [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build (authored by xgupta). Repository: rG LLVM Github Monorepo C

[clang] 6ee1f64 - [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build

Author: xgupta Date: 2021-02-02T13:08:40+05:30 New Revision: 6ee1f64a2e828d27a6c20839232b3ac828367123 URL: https://github.com/llvm/llvm-project/commit/6ee1f64a2e828d27a6c20839232b3ac828367123 DIFF: https://github.com/llvm/llvm-project/commit/6ee1f64a2e828d27a6c20839232b3ac828367123.diff LOG: [

[PATCH] D95737: [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. I build the project on my system x64 with shared libraries enable. It is working correctly. It is also NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

hoy marked an inline comment as done. hoy added inline comments. Comment at: clang/test/Driver/pseudo-probe-lto.c:6 +// RUN: %clang -### %t.o -target x86_64-unknown-linux -flto -fno-pseudo-probe-for-profiling 2>&1 | FileCheck %s --check-prefix=NOPROBE +// RUN: %clang -### %t.o -

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

hoy updated this revision to Diff 320686. hoy added a comment. Addressing Wei's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95271/new/ https://reviews.llvm.org/D95271 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Too

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

hoy added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:609-610 + // Pass an option to enable pseudo probe emission. + if (Args.hasFlag(options::OPT_fpseudo_probe_for_profiling, + options::OPT_fno_pseudo_probe_for_profiling)) +Cmd

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

wmi added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:609-610 + // Pass an option to enable pseudo probe emission. + if (Args.hasFlag(options::OPT_fpseudo_probe_for_profiling, + options::OPT_fno_pseudo_probe_for_profiling)) +Cmd

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc marked 14 inline comments as done. poelmanc added inline comments. Comment at: clang/lib/Format/Format.cpp:2381 +// if so adds a Replacement to NewReplacements that removes the entire line. +llvm::Error MaybeRemoveBlankLine(tooling::Replacements &NewReplaces, +

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320685. usaxena95 added a comment. Remove unintended changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tools-extra/clangd/XRefs.cpp clang-tool

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

MaskRay created this revision. MaskRay added reviewers: jdoerfert, jhenderson, mtrofin. Herald added subscribers: okura, kuter, thopre. MaskRay requested review of this revision. Herald added a reviewer: sstefan1. Herald added a reviewer: baziotis. Herald added subscribers: llvm-commits, cfe-commit

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320683. usaxena95 added a comment. Print value of new OverriddenBy flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek added inline comments. Comment at: compiler-rt/test/profile/instrprof-gc-sections.c:30 +// RUN: llvm-nm -jgU %t | grep -vE "main|_start|_IO_stdin_used|__libc_.*" > %t.code.syms +// RUN: diff %t.nocode.syms %t.code.syms + MaskRay wrote: > This fails on my

[clang-tools-extra] af6be9a - [test] Fix unused FileCheck prefixes in clang-tidy and one llvm/test/Reduce test

Author: Fangrui Song Date: 2021-02-01T22:51:29-08:00 New Revision: af6be9a7bb0fca891ec60138608902cd37b9f84f URL: https://github.com/llvm/llvm-project/commit/af6be9a7bb0fca891ec60138608902cd37b9f84f DIFF: https://github.com/llvm/llvm-project/commit/af6be9a7bb0fca891ec60138608902cd37b9f84f.diff

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

hoy updated this revision to Diff 320680. hoy added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95271/new/ https://reviews.llvm.org/D95271 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/CommonAr

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao updated this revision to Diff 320679. hliao added a comment. Revise comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/De

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc updated this revision to Diff 320678. poelmanc changed the repository for this revision from rCTE Clang Tools Extra to rG LLVM Github Monorepo. poelmanc added a comment. Herald added subscribers: dexonsmith, mgorny. Glad to be back after a year away from clang-tidy, and sorry to have let

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

pengfei added a comment. Hi @RKSimon, what's the status of updating these reduce intrinsics? Is there any difficulty for always assigning them fast math flag? I received bug report for the previous change D92940 . Can we revert it if the problem is not easy to f

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

MaskRay added a subscriber: akuegel. MaskRay added inline comments. Comment at: compiler-rt/test/profile/instrprof-gc-sections.c:30 +// RUN: llvm-nm -jgU %t | grep -vE "main|_start|_IO_stdin_used|__libc_.*" > %t.code.syms +// RUN: diff %t.nocode.syms %t.code.syms + -

[clang] 80f5395 - [test] Default clang/test to FileCheck --allow-unused-prefixes=false

Author: Fangrui Song Date: 2021-02-01T22:02:59-08:00 New Revision: 80f539526eec31f03aadd96753648686312b1ad1 URL: https://github.com/llvm/llvm-project/commit/80f539526eec31f03aadd96753648686312b1ad1 DIFF: https://github.com/llvm/llvm-project/commit/80f539526eec31f03aadd96753648686312b1ad1.diff

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 added a comment. In D95812#2535077 , @sammccall wrote: > This looks about right to me... > Unfortunately I landed ff4832dbff0ccf1fd29f726efe72fd1220cd645a > and > 1eb7fd089e2

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320673. usaxena95 added a comment. Rebase + Add OverriddenBy flag for such references. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tools-extra/clan

[PATCH] D95608: [OpenCL][PR48896] Fix address space in binding of initializer lists to references

rjmccall added a comment. Thanks, LGTM with the value-kind fix. Comment at: clang/lib/Sema/SemaInit.cpp:4308 + if (T1Quals.hasAddressSpace()) +Sequence.AddQualificationConversionStep(cv1T1, VK_XValue); +} else Anastasia wrote: > rjmccall wrote:

[PATCH] D95725: clang-extra: fix incorrect use of std::lock_guard by adding variable name (identified by MSVC [[nodiscard]] error)

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b70c86e2007: clang-extra: fix incorrect use of std::lock_guard by adding variable name… (authored by poelmanc, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 0b70c86 - clang-extra: fix incorrect use of std::lock_guard by adding variable name (identified by MSVC [[nodiscard]] error)

Author: Conrad Poelman Date: 2021-02-02T06:02:59+01:00 New Revision: 0b70c86e2007d3f32968f0a7d9efe8eab3bf0f0a URL: https://github.com/llvm/llvm-project/commit/0b70c86e2007d3f32968f0a7d9efe8eab3bf0f0a DIFF: https://github.com/llvm/llvm-project/commit/0b70c86e2007d3f32968f0a7d9efe8eab3bf0f0a.diff

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecb00a77624c: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to… (authored by nathawes). Repository: rG LLVM Github Mo

[clang] ecb00a7 - [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

Author: Nathan Hawes Date: 2021-02-02T14:56:17+10:00 New Revision: ecb00a77624c94ce38fccf9b4095e026ecf14aed URL: https://github.com/llvm/llvm-project/commit/ecb00a77624c94ce38fccf9b4095e026ecf14aed DIFF: https://github.com/llvm/llvm-project/commit/ecb00a77624c94ce38fccf9b4095e026ecf14aed.diff

[PATCH] D95793: [clang][cli] Generate and round-trip language options

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1196 const std::vector &Sanitizers, DiagnosticsEngine &Diags, SanitizerSet &S) { + bool Success = true; Can

[PATCH] D95792: [clang][cli] Report result of ParseLangArgs

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3096 + + return Success; } Would this avoid the changes above? ``` return Success && !Diags.hasErrorOccurred(); ``` ? Alternatively, might it be cleaner to shove the `Succe

[PATCH] D95846: [analyzer] Updated comments to reflect D85817

RedDocMD created this revision. RedDocMD added reviewers: NoQ, vsavchenko. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. RedDocMD requested review of this revision. Herald added a proj

[PATCH] D95845: [ObjC] Add a command line flag that disables recognition of objc_direct for testability

erik.pilkington created this revision. erik.pilkington added reviewers: arphaman, MadCoder, rjmccall. Herald added subscribers: dexonsmith, dang, ributzka, jkorous. Herald added a reviewer: jansvoboda11. erik.pilkington requested review of this revision. Programmers would like to be able to test d

[clang] 98768ba - [test] Fix unuses FileCheck prefixes in clang/test/Modules

Author: Fangrui Song Date: 2021-02-01T19:46:23-08:00 New Revision: 98768bab19b27db71f497b0e5d87dfa9e5a0f05a URL: https://github.com/llvm/llvm-project/commit/98768bab19b27db71f497b0e5d87dfa9e5a0f05a DIFF: https://github.com/llvm/llvm-project/commit/98768bab19b27db71f497b0e5d87dfa9e5a0f05a.diff

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak added a comment. We could run another pass to clean up the IR after inlining, but I think it's better to do the cleanup right after the callee function is cloned in the caller function. Comment at: llvm/include/llvm/IR/Intrinsics.td:449

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 320663. ahatanak marked 4 inline comments as done. ahatanak added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 Files: clang/li

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94973/new/ https://reviews.llvm.org/D94973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D95842: [NFC] Remove unused prefixes under clang/test/OpenMP

mtrofin created this revision. mtrofin added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. mtrofin requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The full list of pertinent tests is larger, so chunking the cha

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

jdoerfert added a comment. Generally OK, the more I look at it the more things pop up. Other than my comments, I'm fine with this going in. Comment at: clang/lib/Driver/Driver.cpp:767 + } + TC = AMDGPUOpenMPTC.get(); } else --

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes updated this revision to Diff 320646. nathawes added a comment. Made the following changes as a speculative fix for the windows test failures in the pre-merge checks: - When appending the remaining path components to the external redirect path of a directory-remap entry, use the separa

[PATCH] D95558: [NFC][CUDA] Refactor registering device variable

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:924 + +void CGNVCUDARuntime::adjustShadowVarLinkage( +const VarDecl *D, llvm::GlobalValue::LinkageTypes &Linkage) { tra wrote: > yaxunl wrote: >

[PATCH] D95822: [FE][AIX] Use i8 as guard variable type in both load and store operation

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGenCXX/aix-static-init.cpp:143 // CHECK: init.check: -// CHECK: %1 = call i32 @__cxa_guard_acquire(i64* @_ZGVZN5test41fEvE11staticLocal) +// CHECK: %1 = call i32 @__cxa_guard_acquire(i8* @_ZGVZN5test4

[PATCH] D95560: [CUDA][HIP] Fix function scope static variable

yaxunl updated this revision to Diff 320644. yaxunl marked 6 inline comments as done. yaxunl added a comment. Revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95560/new/ https://reviews.llvm.org/D95560 Files: clang/lib/AST/ASTContext.cpp clang/lib/CodeGen/C

[PATCH] D95840: [CUDA][HIP] Fix checking dependent initalizer

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Defer constant checking of dependent initializer to template instantiation since it cannot be done for dependent values. This is separated from https://reviews.llvm.org/D95560 https://reviews.l

[PATCH] D95560: [CUDA][HIP] Fix function scope static variable

yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:101 +// does that. +class CUDAStaticDeviceVarEmitter +: public StmtVisitor { tra wrote: > Nit. "This class does that" could be dropped. I'd

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

poelmanc updated this revision to Diff 320637. poelmanc added a comment. Add period to end of comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95714/new/ https://reviews.llvm.org/D95714 Files: clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp clang-tools-extra/test/c

[PATCH] D95822: [FE][AIX] Use i8 as guard variable type in both load and store operation

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGenCXX/aix-static-init-temp-spec-and-inline-var.cpp:193 // CHECK: %1 = call i32 @atexit(void ()* @__dtor__ZN5test12t1IiEE) -// CHECK: store i64 1, i64* @_ZGVN5test12t1IiEE // CHECK: br label %init.e

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. Thank you for the update. From comparing the diffs, here is the list of main changes I found: 1. Create `OMPLoopBasedDirective` as a new base class for OMPLoopDirective (and OMPTileDirective) for CollapsedNum and some utility methods for analyzing the CapturedStmt/F

[PATCH] D95765: [OpenMP] Introduce the `disable_selector_propagation` variant selector trait

JonChesterfield added a comment. Yes, OK. I'm a little nervous that variant is evolving into a turing complete sublanguage, but I see the use of opting out of the implicit inheritance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95765/new/ https

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. That sounds reasonable. We can probably expect features to be renamed and semantically adjusted on their way to standardisation anyway. Repository: rG LLVM Github Monorepo

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

sammccall added a comment. This looks about right to me... Unfortunately I landed ff4832dbff0ccf1fd29f726efe72fd1220cd645a and 1eb7fd089e2fcf3fe211f865b28e2fed12128c3f

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

arnamoy10 updated this revision to Diff 320617. arnamoy10 added a comment. A few more comments addressed and a new test case added for write-module check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95448/new/ https://reviews.llvm.org/D95448 Files: clang/include/clang/Driver/Option

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf3e39f60b35: [InstrProfiling] Use !associated metadata for counters, data and values (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D768

[clang] df3e39f - [InstrProfiling] Use !associated metadata for counters, data and values

Author: Petr Hosek Date: 2021-02-01T15:01:43-08:00 New Revision: df3e39f60b356ca9dbfc11e96e5fdda30afa7acb URL: https://github.com/llvm/llvm-project/commit/df3e39f60b356ca9dbfc11e96e5fdda30afa7acb DIFF: https://github.com/llvm/llvm-project/commit/df3e39f60b356ca9dbfc11e96e5fdda30afa7acb.diff LO

[PATCH] D95824: [clangd] Sketch: interning filenames

sammccall created this revision. Herald added subscribers: usaxena95, kadircet, jfb, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This is an idea to attack two problems: - simplify string track

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu added inline comments. Comment at: clang/lib/Basic/Targets/M68k.cpp:77-79 + Builder.defineMacro("M68k"); + Builder.defineMacro("__M68k__"); + Builder.defineMacro("__M68K__"); jrtc27 wrote: > myhsu wrote: > > jrtc27 wrote: > > > Where are these coming fro

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 320604. myhsu added a comment. - Addressed feedback - Remove redundant target macro definitions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang/Basic/Attr.td clang/lib/Basic/CM

[clang] 8e661d3 - [AMDGPU] Set s-memtime-inst feature from clang

Author: Stanislav Mekhanoshin Date: 2021-02-01T14:20:43-08:00 New Revision: 8e661d3d9c52ea9e5e68cbf699701d9cfa071a8f URL: https://github.com/llvm/llvm-project/commit/8e661d3d9c52ea9e5e68cbf699701d9cfa071a8f DIFF: https://github.com/llvm/llvm-project/commit/8e661d3d9c52ea9e5e68cbf699701d9cfa071a

[PATCH] D95822: [FE][AIX] Use i8 as guard variable type in both load and store operation

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, jasonliu, abhina.sreeskantharajan. Herald added a subscriber: jfb. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For static init, use i8

[PATCH] D95753: [CoverageMapping] Don't absolutize source paths

vsk added a comment. Thanks for pointing DW_AT_comp_dir out. For coverage, gating the use of relative paths on a flag sounds reasonable to me. It should also be possible to extend the .covmapping format to include something like DW_AT_comp_dir: compared to adding a flag, this would take a lot m

[PATCH] D95725: clang-extra: fix incorrect use of std::lock_guard by adding variable name (identified by MSVC [[nodiscard]] error)

poelmanc marked an inline comment as done. poelmanc added a comment. s/Guard/Lock/! I don't have commit access so appreciate a push. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95725/new/ https://reviews.llvm.org/D95725 ___ cfe-commits mail

[PATCH] D95725: clang-extra: fix incorrect use of std::lock_guard by adding variable name (identified by MSVC [[nodiscard]] error)

poelmanc updated this revision to Diff 320594. poelmanc added a comment. Change Guard to Lock. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95725/new/ https://reviews.llvm.org/D95725 Files: clang-tools-extra/clangd/support/Function.h Index: clang-tools-extra/clangd/support/Functio

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Registry.cpp:697 - if (IsPolymorphic) { -OS << "Matcher " << Name << "(Matcher"; + std::string TypedText = std::string(Name); + aaron.ballman wrote: > Any reason this de

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire updated this revision to Diff 320593. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94880/new/ https://reviews.llvm.org/D94880 Files: clang/include/clang/ASTMatchers/Dynamic/Diagnostics.h clang/include

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks updated this revision to Diff 320589. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. Fixed documentation (and rebased). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93844/new/ https://re

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG772eb24e0062: [clang-format] Add option to control the spaces in a line comment (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monor

[clang] 772eb24 - [clang-format] Add option to control the spaces in a line comment

Author: Björn Schäpers Date: 2021-02-01T22:48:50+01:00 New Revision: 772eb24e00629faaae0244aa0d6d6204542c579b URL: https://github.com/llvm/llvm-project/commit/772eb24e00629faaae0244aa0d6d6204542c579b DIFF: https://github.com/llvm/llvm-project/commit/772eb24e00629faaae0244aa0d6d6204542c579b.diff

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

jrtc27 added inline comments. Comment at: clang/lib/Basic/Targets/M68k.cpp:77-79 + Builder.defineMacro("M68k"); + Builder.defineMacro("__M68k__"); + Builder.defineMacro("__M68K__"); myhsu wrote: > jrtc27 wrote: > > Where are these coming from? GCC only defines

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2101 + static const char *const M68kLibDirs[] = {"/lib"}; + static const char *const M68kTriples[] = { MaskRay wrote: > The second `const ` is redundant I don't think so...first, `co

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu updated this revision to Diff 320586. myhsu marked 5 inline comments as done. myhsu added a comment. Herald added a reviewer: jansvoboda11. - Addressed feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files: clang/include/clang/

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu added inline comments. Comment at: clang/lib/Basic/Targets/M68k.cpp:63 +.Case("generic", CK_68000) +.Case("M68000", CK_68000) +.Case("M68010", CK_68010) jrtc27 wrote: > GCC's -mcpu excludes any M prefix and is just the nu

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 320585. myhsu marked 4 inline comments as done. myhsu added a comment. - Addressed feedbacks - Now M68k tries to use ABI that is compatible with GCC CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: c

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:160 +parent directory (or its parent if there is none). If there is no parent +file found it falls back to the ``LLVM`` style.

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added a subscriber: svenvh. bader added a comment. > Regarding SYCLDevice and SYCLAddrSpaceMap I am still not very convinced about > the flow. Have you had any design discussion regarding this already that you > could point to? We discussed this with you in https://github.com/intel/llvm/p

[clang] 68b0595 - NFC: Re-generate out-of-date matchers docs

Author: Stephen Kelly Date: 2021-02-01T21:25:29Z New Revision: 68b0595ccb8de1b0a9459f958dda17164341ee87 URL: https://github.com/llvm/llvm-project/commit/68b0595ccb8de1b0a9459f958dda17164341ee87 DIFF: https://github.com/llvm/llvm-project/commit/68b0595ccb8de1b0a9459f958dda17164341ee87.diff LOG:

[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

steveire updated this revision to Diff 320578. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95739/new/ https://reviews.llvm.org/D95739 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatc

[PATCH] D95740: [ASTMatchers] Ignore parts of BindingDecls which are not spelled in source

steveire updated this revision to Diff 320572. steveire added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95740/new/ https://reviews.llvm.org/D95740 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/lib/ASTMatchers/

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 320571. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. Herald added subscribers: rupprecht, arphaman, steven_wu, hiraditya. I've previously changed Permission denied errors before. Fixing t

[PATCH] D95740: [ASTMatchers] Ignore parts of BindingDecls which are not spelled in source

steveire added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:2607 +EXPECT_TRUE(matches(Code, traverse(TK_AsIs, M))); +EXPECT_FALSE(matches(Code, traverse(TK_IgnoreUnlessSpelledInSource, M))); + } aaron.ballman wrot

[PATCH] D95735: [ASTMatchers] Fix matching after generic top-level matcher

steveire added a comment. In D95735#2534400 , @aaron.ballman wrote: > I'm a bit confused -- I only get one match when I try out your example: > https://godbolt.org/z/xn9efY Are there other changes in-flight that > necessitate this, or is something else

[PATCH] D95403: [clang-tidy][analyzer][WIP] Clang-tidy reverse integration into Static Analyzer.

aaron.ballman added a comment. Thank you for working on this, I think it's fantastic effort! > I'll make sure to implement (and hopefully test) a reasonable behavior for > all various combinations of CMake flags (eg., clang-tidy enabled/disabled, > static analyzer enabled/disabled, static-analy

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao updated this revision to Diff 320568. hliao added a comment. - Remove `DeviceManglingNumber` to reduce memory usage. - Add a table in ASTContext for device lambda mangling numbers if that lamba requires. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D95099: [clang-scan-deps] : Support -- in clang command lines.

saudi added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95099/new/ https://reviews.llvm.org/D95099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

aaron.ballman added a comment. In D93110#2529917 , @NoQ wrote: >> What I want to avoid is having a static analyzer-specific suppression >> attribute, and a different one for clang-tidy, and a third one for the >> frontend. > > Given that there are alread

[PATCH] D95558: [NFC][CUDA] Refactor registering device variable

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Couple of minor nits LGTM otherwise, Comment at: clang/lib/CodeGen/CGCUDANV.cpp:924 + +void CGNVCUDARuntime::adjustShadowVarLinkage( +const VarDecl *D, llvm::GlobalValue::Linka

[PATCH] D95814: [NFC] Simplify test to use multiple FileCheck prefixes.

varungandhi-apple created this revision. varungandhi-apple added a reviewer: aschwaighofer. varungandhi-apple requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Minor cleanup where we can avoid calling the compiler twice with the same argument

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

MaskRay accepted this revision. MaskRay added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320563. usaxena95 added a comment. Move Index query to more logical place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek added a comment. In D76802#2534118 , @MaskRay wrote: > "prevents discarding" is not accurate in the context. `__llvm_prf_*` cannot > be discarded because C identifier name input sections are GC roots. > > Add "C identifier name input sections are G

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek updated this revision to Diff 320562. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/test/profile/instrprof-gc-sections.c llvm/include/llvm/Transforms/Instrumentation.h llvm/incl

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. See: https://github.com/clangd/clangd/issues/668 struct A { virtual void foo(

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

rjmccall added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1479 +Unsupported, +Init, +C11LoadStore, yaxunl wrote: > rjmccall wrote: > > `atomic_init` is not actually an atomic operation, so there's never an > > inherent reason

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jyknight added a comment. I still have the same fundamental objection as before to the parts of this patch for prohibiting FP add/sub on some targets. If a particular LLVM target cannot handle transforming an FP add/sub (or any other RMW operations!) into the correct cmpxchg or LL/SC loop, that

[PATCH] D95753: [CoverageMapping] Don't absolutize source paths

phosek added a comment. In D95753#2534061 , @vsk wrote: > For context, the reason abspaths are used here is because users don't expect > coverage results to go missing if the build directory changes (e.g. given `cd > A; cc x.c; cd ../B; cc x.c`, the expe

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

smeenai added a comment. I saw this on LLVM Weekly, and I like it a lot :) Now if only Windows could case-correct their SDKs so we didn't need VFS overlays and symlinks for the linker... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95534/new/ ht

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: muiez, fanbo-meng, Kai, jhenderson, grimar. Herald added subscribers: delcypher, emaste. abhina.sreeskantharajan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay.

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

rnk added subscribers: smeenai, compnerd. rnk added a comment. +People who have spent time on cross-compilation Windows sysroots in the past: @smeenai @compnerd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95534/new/ https://reviews.llvm.org/D955

[PATCH] D95735: [ASTMatchers] Fix matching after generic top-level matcher

aaron.ballman added a comment. I'm a bit confused -- I only get one match when I try out your example: https://godbolt.org/z/xn9efY Are there other changes in-flight that necessitate this, or is something else going on? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D95482: [PATCH] [clang] Fix bug 48848 by removing assertion related to recoverFromMSUnqualifiedLookup

erik.pilkington added a comment. Sorry, yeah, I'm OK with this change. Comment at: clang/test/SemaCXX/lambda-expressions.cpp:671 +#else +template +void Decider(const RT &sp, ET &ep) { I think it makes more sense for this test to be in its own file since entire

[PATCH] D95523: [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:35 +// Enable extensions that are enabled in opencl-c-base.h. +#if (defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= 200) +#define cl_khr_subgroup_ballot 1 No

[PATCH] D95482: [PATCH] [clang] Fix bug 48848 by removing assertion related to recoverFromMSUnqualifiedLookup

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08d46d50599a: [clang][PATCH] Fix bug 48848 assertion related to recoverFromMSUnqualifiedLookup (authored by mibintc). Repository: rG LLVM Github M

[clang] 08d46d5 - [clang][PATCH] Fix bug 48848 assertion related to recoverFromMSUnqualifiedLookup

Author: Melanie Blower Date: 2021-02-01T10:56:47-08:00 New Revision: 08d46d50599a7005380e1a9eebb276ceb2b0ad93 URL: https://github.com/llvm/llvm-project/commit/08d46d50599a7005380e1a9eebb276ceb2b0ad93 DIFF: https://github.com/llvm/llvm-project/commit/08d46d50599a7005380e1a9eebb276ceb2b0ad93.diff

  1   2   >