hoy added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:609-610
+ // Pass an option to enable pseudo probe emission.
+ if (Args.hasFlag(options::OPT_fpseudo_probe_for_profiling,
+ options::OPT_fno_pseudo_probe_for_profiling))
+ CmdArgs.push_back("-plugin-opt=pseudo-probe-for-profiling");
----------------
wmi wrote:
> The third arg of Args.hasFlag defaults to true, which means
> -plugin-opt=pseudo-probe-for-profiling will be inserted even if no
> -fpseudo-probe-for-profiling or -fno-pseudo-probe-for-profiling is provided.
> Is it expected?
Good catch, it's not expected. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95271/new/
https://reviews.llvm.org/D95271
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
