[PATCH] D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets

This revision was automatically updated to reflect the committed changes. Closed by commit rG018984ae6833: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets (authored by kernigh, committed by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 018984a - [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets

Author: George Koehler Date: 2021-01-23T00:13:36-05:00 New Revision: 018984ae6833fae107aa9c502ab5536efceca88e URL: https://github.com/llvm/llvm-project/commit/018984ae6833fae107aa9c502ab5536efceca88e DIFF: https://github.com/llvm/llvm-project/commit/018984ae6833fae107aa9c502ab5536efceca88e.diff

[PATCH] D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets

kernigh added a comment. I forgot about this diff for a month. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4722 bool isI64 = Ty->isIntegerType() && getContext().getTypeSize(Ty) == 64; - bool isInt = - Ty->isIntegerType() || Ty->isPointerType() || Ty->isAggregateType()

[PATCH] D95161: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

tianshilei1992 updated this revision to Diff 318719. tianshilei1992 added a comment. Made test more robust Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95161/new/ https://reviews.llvm.org/D95161 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D95161: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

tianshilei1992 updated this revision to Diff 318717. tianshilei1992 added a comment. Fixed the test issue caused by wrong path seperator on Windows and Linux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95161/new/ https://reviews.llvm.org/D95161

[PATCH] D95249: [NFC] Disallow unused prefixes in clang/test/Analysis

NoQ added a comment. I added those for consistency but i think your effort is worth it so let's ditch them. Comment at: clang/test/Analysis/exploded-graph-rewriter/trimmers.dot:4 // RUN: %exploded_graph_rewriter -s %s \ -// RUN: | FileCheck %s -check-prefixes=ONE,TWO,NOTH

[PATCH] D95279: Support: Remove duplicated code in {File,clang::ModulesDependency}Collector, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, thanks for cleaning this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95279/new/ https://reviews.llvm.org/D95279 ___

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:24 + return() +endif() + JonChesterfield wrote: > jdoerfert wrote: > > we need the 32 bit versions as well, I guess? > We could limit to 64 and see if a feature

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

hoy updated this revision to Diff 318714. hoy added a comment. Fixing test failure on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95271/new/ https://reviews.llvm.org/D95271 Files: clang/include/clang/Driver/Options.td clang/lib/Driv

[PATCH] D95279: Support: Remove duplicated code in {File,clang::ModulesDependency}Collector, NFC

dexonsmith created this revision. dexonsmith added reviewers: dblaikie, JDevlieghere. Herald added subscribers: ributzka, hiraditya. dexonsmith requested review of this revision. Herald added projects: clang, LLVM. Refactor the duplicated canonicalize-path logic in `FileCollector` and `ModulesDepe

[PATCH] D95204: [lld-macho] switch default to new Darwin port

gkm planned changes to this revision. gkm added a comment. Pulling this back from review ... Not ready for prime time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ https://reviews.llvm.org/D95204 ___

[PATCH] D95202: ADT: Use 'using' to inherit assign and append in SmallString

dexonsmith marked 2 inline comments as done. dexonsmith added a comment. Thanks for the review! Pushed with suggestions applied in ba5628f2c2a9de049b80b3e276f7e05f481c49e7 . Comment at: llvm/lib/Support/File

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 updated this revision to Diff 318678. njames93 edited the summary of this revision. njames93 added a comment. Fix failing tests. Updated message for tweak from a specified base class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94942/new/

[PATCH] D95202: ADT: Use 'using' to inherit assign and append in SmallString

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba5628f2c2a9: ADT: Use 'using' to inherit assign and append in SmallString (authored by dexonsmith). Changed prior to commit: https://reviews.llvm

[clang] ba5628f - ADT: Use 'using' to inherit assign and append in SmallString

Author: Duncan P. N. Exon Smith Date: 2021-01-22T16:17:58-08:00 New Revision: ba5628f2c2a9de049b80b3e276f7e05f481c49e7 URL: https://github.com/llvm/llvm-project/commit/ba5628f2c2a9de049b80b3e276f7e05f481c49e7 DIFF: https://github.com/llvm/llvm-project/commit/ba5628f2c2a9de049b80b3e276f7e05f481c

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17921 + " another_function(arg, arg, arg, arg, arg, arg);"; + EXPECT_EQ(IfElseSourceLong, format(IfElseSourceLong, Style)); + can you use verifyFormat() instead of EXPE

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a subscriber: djasper. MyDeveloperDay added a comment. I think this is one of those reviews that ultimately I think would be useful if we could ensure it works 100% correctly, but I think it goes against the original ethos of clang-format and I think if @djasper or @klimek t

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

hoy created this revision. Herald added subscribers: wenlei, dang, steven_wu, hiraditya. Herald added a reviewer: jansvoboda11. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As titled. Repository: rG LLVM Github Monorepo https://

[clang] e92be7c - PR47682: Merge the DeclContext of a merged FunctionDecl before we inherit

Author: Richard Smith Date: 2021-01-22T15:46:41-08:00 New Revision: e92be7cd9f03ab3eb8c4a21e686743c2575a169a URL: https://github.com/llvm/llvm-project/commit/e92be7cd9f03ab3eb8c4a21e686743c2575a169a DIFF: https://github.com/llvm/llvm-project/commit/e92be7cd9f03ab3eb8c4a21e686743c2575a169a.diff

[PATCH] D95131: [CodeComplete] Add ranged for loops code pattern.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd18c3c7b18e9: [CodeComplete] Add ranged for loops code pattern. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95131/new/ https://rev

[clang] d18c3c7 - [CodeComplete] Add ranged for loops code pattern.

Author: Nathan James Date: 2021-01-22T23:40:35Z New Revision: d18c3c7b18e9e78145d701c4687682848071ab98 URL: https://github.com/llvm/llvm-project/commit/d18c3c7b18e9e78145d701c4687682848071ab98 DIFF: https://github.com/llvm/llvm-project/commit/d18c3c7b18e9e78145d701c4687682848071ab98.diff LOG:

[PATCH] D95270: [clangd][NFC] Simplify handing on methods with no params

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Add bind methods handling the case

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang updated this revision to Diff 318657. akhuang added a comment. -add to comment -Add externally visible lambda to test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://reviews.llvm.org/D95187 Files: clang/include/clan

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit P10 instructions from stubs

amyk added a comment. A few general comments. Comment at: lld/ELF/Config.h:74 +// For --power10-stub +enum class P10Stub { Default, No }; + We have a "yes", but does it need to be here, too? Comment at: lld/ELF/Driver.cpp:763 +static P10Stu

[PATCH] D95202: ADT: Use 'using' to inherit assign and append in SmallString

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - some optional feedback on the code fixes. Please run clang-format on the changes here (phab lint picked up some cases in the test code that could be cleaned up). ==

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

tomrittervg updated this revision to Diff 318632. tomrittervg added a comment. Try rebasing it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94624/new/ https://reviews.llvm.org/D94624 Files: clang-tools-extra/clang-query/Query.cpp clang-too

[PATCH] D95228: Add swift_async_context parameter attribute mapping to IR equivalent

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a documentation question and a testing request. Comment at: clang/include/clang/Basic/AttrDocs.td:4404 + +A context parameter must have pointer or ref

[PATCH] D70701: Fix more VFS tests on Windows

dexonsmith added a comment. In D70701#2515934 , @amccarth wrote: > BTW, I hope I didn't come across as overly negative in my previous > response. No, not at all! > [...] On Windows, a process can have multiple > current directories: one for each drive.

[PATCH] D95002: [RISCV] Update B extension version to 0.93.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20f2e32d2c54: [RISCV] Update B extension version to 0.93. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D94617: [RISCV] Add Zba feature and move add.uw and slli.uw to it.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e6ad11bc6f2: [RISCV] Add Zba feature and move add.uw and slli.uw to it. (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D94617?vs=318217&id=318616#toc Repository: rG LL

[PATCH] D94582: [RISCV] Rename mnemonics slliu.w->slli.uw and addu.w->add.uw to match 0.93 bitmanip spec.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb825278364d9: [RISCV] Rename mnemonics slliu.w->slli.uw and addu.w->add.uw to match 0.93… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 4e6ad11 - [RISCV] Add Zba feature and move add.uw and slli.uw to it.

Author: Craig Topper Date: 2021-01-22T12:49:10-08:00 New Revision: 4e6ad11bc6f29eecfbef7f5d5b7e581dd26e2024 URL: https://github.com/llvm/llvm-project/commit/4e6ad11bc6f29eecfbef7f5d5b7e581dd26e2024 DIFF: https://github.com/llvm/llvm-project/commit/4e6ad11bc6f29eecfbef7f5d5b7e581dd26e2024.diff

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. I know you mentioned doing this for more targets in follow-up commits. It would be good to also do this for `-O0`, so that we have a single correct pattern coming out of the fronte

[PATCH] D94979: [CGExpr] Use getCharWidth() more consistently in CCGExprConstant. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea2cfda386f1: [CGExpr] Use getCharWidth() more consistently in CCGExprConstant. NFC (authored by bjope). Changed prior to commit: https://reviews.

[PATCH] D94977: [CodeGen] Use getCharWidth() more consistently in CGRecordLowering. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72f863fd37c3: [CodeGen] Use getCharWidth() more consistently in CGRecordLowering. NFC (authored by bjope). Repository: rG LLVM Github Monorepo CH

[clang] ea2cfda - [CGExpr] Use getCharWidth() more consistently in CCGExprConstant. NFC

Author: Bjorn Pettersson Date: 2021-01-22T21:12:17+01:00 New Revision: ea2cfda386f1a0f0b8cab06a9400bbf4cf7bfbaa URL: https://github.com/llvm/llvm-project/commit/ea2cfda386f1a0f0b8cab06a9400bbf4cf7bfbaa DIFF: https://github.com/llvm/llvm-project/commit/ea2cfda386f1a0f0b8cab06a9400bbf4cf7bfbaa.di

[clang] 72f863f - [CodeGen] Use getCharWidth() more consistently in CGRecordLowering. NFC

Author: Bjorn Pettersson Date: 2021-01-22T21:12:17+01:00 New Revision: 72f863fd37c3471e7e1b152ac613da00ab6faaba URL: https://github.com/llvm/llvm-project/commit/72f863fd37c3471e7e1b152ac613da00ab6faaba DIFF: https://github.com/llvm/llvm-project/commit/72f863fd37c3471e7e1b152ac613da00ab6faaba.di

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 318594. ahatanak edited the summary of this revision. ahatanak added a comment. Stop using `clang.arc.rv_marker` and just use "clang.arc.rv"="retain/claim". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/n

[PATCH] D89490: Introduce __attribute__((darwin_abi))

rjmccall added a comment. In D89490#2514695 , @aguinet wrote: >> I may be over-reacting to the way the patch seemed to be touching on the C++ >> ABI in multiple places. My understanding is that `ms_abi` is just a >> calling-convention attribute; it's ba

[PATCH] D95253: [clang][Fuchsia] Add relative-vtables + asan multilibs

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: mgorny. leonardchan requested review of this revision. We're choosing to take an opt-in approach for landing Relative VTables, so we'll need asan-equiva

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

rnk added a comment. I see a variety of presubmit failures in Harbormaster that seem related, so make sure to check those. Comment at: clang/include/clang/AST/Mangle.h:92 + virtual StringRef getLambdaString(const CXXRecordDecl *Lambda) = 0; + I think I woul

[clang] 520b5ec - [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

Author: Abhina Sreeskantharajan Date: 2021-01-22T13:54:25-05:00 New Revision: 520b5ecf856152f35ee38207eec39f5674dd2bd4 URL: https://github.com/llvm/llvm-project/commit/520b5ecf856152f35ee38207eec39f5674dd2bd4 DIFF: https://github.com/llvm/llvm-project/commit/520b5ecf856152f35ee38207eec39f5674dd

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

This revision was automatically updated to reflect the committed changes. Closed by commit rG520b5ecf8561: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit… (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D94355: [SimplifyCFG] Add relative switch lookup tables

leonardchan added a comment. Almost there! Just a few more comments on my end. Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:5694 +Constant *CaseRes = Values[I].second; +if (auto *GlobalVal = dyn_cast(CaseRes)) + if (!GlobalVal->isDSOLocal()) --

[PATCH] D95249: [NFC] Disallow unused prefixes in clang/test/Analysis

mtrofin created this revision. mtrofin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95249 Files: clang/test/Analysis/auto-obj-dtors-cfg-output.cpp clang/test/Analysis/

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ImplementAbstract.cpp:354 + return "Implement pure virtual methods from '" + + FromBase->getType().getAsString() + "'"; +} Maybe this should be changed as it

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Please, look at my solution. Is it worth to be accepted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

dgoldman accepted this revision. dgoldman added a comment. This revision is now accepted and ready to land. In D94919#2515987 , @adamcz wrote: > The crash happens while indexing the file, not during code completion. The > code completion tests generally s

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

adamcz added a comment. The crash happens while indexing the file, not during code completion. The code completion tests generally specify a cursor position, but in this case it is not relevant and could confuse the reader. This seemed like a logical place for indexing bug, in the spirit of usi

[PATCH] D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

kpn updated this revision to Diff 318567. kpn added a comment. Update for review comments: Move uses of CGFPOptionsRAII lower and closer to where they are needed. This should be less error prone as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94614/new/ https://reviews.llvm.org/

[PATCH] D95168: [clang-format] Add InsertBraces option

tiagoma updated this revision to Diff 318563. tiagoma added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/F

Re: [PATCH] D70701: Fix more VFS tests on Windows

BTW, I hope I didn't come across as overly negative in my previous response. I'd love to see the situation improved. I just don't know what that would look like. > One thing I see, but wasn't obvious from your description, is that the mixed/hybrid separator behaviour only happens for `defined(_W

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

JDevlieghere added a comment. Overall this looks good. I wonder if abstracting the ExternalRedirect as a small wrapper class around a SmallString would help. There's a few operations that are repeated, like the example below, and it could also house the logic that's currently in the lambda.

[PATCH] D95168: Add InsertBraces option

tiagoma added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2254 + + * ``BIS_WrapLikely`` (in configuration: ``WrapLikely``) +Insert braces if wrapping is likely curdeius wrote: > Shouldn't it be consistent with clang-tidy? So instead o

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

muiez accepted this revision. muiez added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95246/new/ https://reviews.llvm.org/D95246 ___ cfe

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:2342 +attrs = attrs.addAttribute(CGF.getLLVMContext(), + llvm::AttributeList::ReturnIndex, "rv_marker"); +callBase->setAttributes(attrs); rjmccall wrote

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: fanbo-meng, anirudhp, muiez, Kai, yusra.syeda. Herald added subscribers: rupprecht, steven_wu, hiraditya, sbc100. Herald added a reviewer: alexshap. Herald added a reviewer: rupprecht. Herald added a reviewer:

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 318553. saudi marked an inline comment as done. saudi added a comment. Applied the suggestions from the parent patch D95099 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 Fi

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

dgoldman requested changes to this revision. dgoldman added a comment. This revision now requires changes to proceed. Looks good but I think for posterity we should add a similar test to clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp for the exact intended code complete behavior (or in

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 updated this revision to Diff 318552. njames93 added a comment. If cursor is over one of the base specifiers, offer to implement only the pure methods from that base class. Depends on D95231 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D95002: [RISCV] Update B extension version to 0.93.

craig.topper updated this revision to Diff 318548. craig.topper added a comment. Remove reference to version from the rori comment. The version doesn't really matter, I doubt the encoding will ever be added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske added a comment. Should add some responsible (for this code) reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244 ___ cfe-commits mailing list cfe-

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske created this revision. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Type of `Callee` can be overloaded function type that was not handled. This causes a c

[PATCH] D94814: [HIP] Support `__managed__` attribute

This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rG622eaa4a4cea: [HIP] Support __managed__ attribute (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D94814?v

[clang] 622eaa4 - [HIP] Support __managed__ attribute

Author: Yaxun (Sam) Liu Date: 2021-01-22T11:43:58-05:00 New Revision: 622eaa4a4cea17c2cec6942d9702b010deae392b URL: https://github.com/llvm/llvm-project/commit/622eaa4a4cea17c2cec6942d9702b010deae392b DIFF: https://github.com/llvm/llvm-project/commit/622eaa4a4cea17c2cec6942d9702b010deae392b.dif

[PATCH] D95145: [clang] Fix a nullptr dereference bug on invalid code

adamcz added a comment. PTAL Comment at: clang/test/SemaCXX/subst-func-type-invalid-ret-type.cpp:2 +// RUN: %clang -fsyntax-only -std=c++17 %s -Xclang -verify +#include + adamcz wrote: > hokein wrote: > > A common practice is to avoid depending on STL in tests

[PATCH] D95145: [clang] Fix a nullptr dereference bug on invalid code

adamcz updated this revision to Diff 318534. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95145/new/ https://reviews.llvm.org/D95145 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp clang

[PATCH] D94814: [HIP] Support `__managed__` attribute

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8245 "%select{__device__|__global__|__host__|__host__ __device__}0 functions">; -def err_cuda_nonstatic_constdev: Error<"__constant__ and __dev

[PATCH] D95017: [clang-format] add case aware include sorting

HazardyKnusperkeks added a comment. I can push that, but will wait a bit longer so the others have time to object. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 ___

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

adamcz added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1807-1811 +@interface Foo +- (void)fun:(bool)foo + bar:(bool)bar, + baz:(bool)baz; +@end dgoldman wrote: > It's hard to tell what Clang ma

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

adamcz updated this revision to Diff 318529. adamcz marked an inline comment as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94919/new/ https://reviews.llvm.org/D94919 Files: clang-tools-e

[PATCH] D95225: [clang][cli] NFC: Pass CC1Option explicitly to BoolOption

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM; this is much better! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95225/new/ https://reviews.llvm.org/D95225 ___

[PATCH] D95221: [clang][cli] NFC: Move prefix to the front of BoolOption

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95221/new/ https://reviews.llvm.org/D95221

[PATCH] D95057: [clangd] WIP: configurable compilation database directory

sammccall updated this revision to Diff 318526. sammccall added a comment. Add tests and fix bugs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95057/new/ https://reviews.llvm.org/D95057 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clan

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 updated this revision to Diff 318523. njames93 added a comment. Update FindTargets to fix symbol renaming on a CXXBaseSpecifier. Add test to ensure rename wont trigger on a CXXBaseSpecifier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D952

[PATCH] D95002: [RISCV] Update B extension version to 0.93.

frasercrmck added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoB.td:732 // There's no encoding for roli in the current version of the 'B' extension // (v0.92) as it can be implemented with rori by negating the immediate. let Predicates = [HasStdExtZbbOrZbp]

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

SjoerdMeijer added a comment. In D94779#2515157 , @dmgreen wrote: > Thanks. @fhahn @SjoerdMeijer what do we think about the edge case where the > width==1? As far as I understand (with this patch): > > #pragma clang loop vectorize_predicate(disable) vec

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 created this revision. njames93 added reviewers: kadircet, hokein, sammccall. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Selection now includes the

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 added a comment. In D94942#2515049 , @kadircet wrote: > Thanks this looks great, and something i've been longing for some time! But I > got a couple of questions about the how the interaction is designed (sorry if > I missed some high level disc

[PATCH] D95229: [clangd] Treat optional field type mismatches as soft failures

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd currently throws away any protocol m

[PATCH] D95228: Add swift_async_context parameter attribute mapping to IR equivalent

t.p.northover created this revision. Herald added subscribers: dexonsmith, jdoerfert, mcrosier. Herald added a reviewer: aaron.ballman. t.p.northover requested review of this revision. This adds `__attribute__((swift_async_context))` very much following the existing `swift_context` so that Swift'

[PATCH] D95145: [clang] Fix a nullptr dereference bug on invalid code

adamcz added inline comments. Comment at: clang/test/SemaCXX/subst-func-type-invalid-ret-type.cpp:2 +// RUN: %clang -fsyntax-only -std=c++17 %s -Xclang -verify +#include + hokein wrote: > A common practice is to avoid depending on STL in tests. I think we need t

[clang] 98a8344 - [clang][ASTImporter] Add support for importing CXXFoldExpr.

Author: Balázs Kéri Date: 2021-01-22T15:20:55+01:00 New Revision: 98a8344895a8e1f2cfa98b664b50fb7b864afa52 URL: https://github.com/llvm/llvm-project/commit/98a8344895a8e1f2cfa98b664b50fb7b864afa52 DIFF: https://github.com/llvm/llvm-project/commit/98a8344895a8e1f2cfa98b664b50fb7b864afa52.diff L

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG98a8344895a8: [clang][ASTImporter] Add support for importing CXXFoldExpr. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ h

[PATCH] D94814: [HIP] Support `__managed__` attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. The attribute parts LGTM aside from some small nits. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8245 "%select{__device__|__global__|__host__|__host__ __device__}0 functions">; -def err_c

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4671 + D.Diag(diag::err_aix_default_altivec_abi); } Just to confirm, because the patch description confuses me a bit on this: The intent is to not complain

[PATCH] D94293: [clangd] automatically index STL

kuhnel abandoned this revision. kuhnel added a comment. thx for the review and feedback! I guess I'll re-design the feature and add a new indexing layer instead. However that might take a while, so I'll abandon this revision and start a new one later on. Repository: rG LLVM Github Monorepo

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal added a comment. The patch doesn't seem to affect the reports. It only introduced 3 new reports during the analysis of clang + clang-tidy. The analysis times indeed increased slightly, ~~ +3%. Overall, I think it's a valuable patch, which resolves crashes when the Z3 refutation enabled.

[PATCH] D95057: [clangd] WIP: configurable compilation database directory

sammccall updated this revision to Diff 318499. sammccall added a comment. Rebase, implement yaml bits (no tests yet) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95057/new/ https://reviews.llvm.org/D95057 Files: clang-tools-extra/clangd/Clangd

[PATCH] D95087: [clangd] Inject context provider rather than config into ClangdServer. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG60cd75a098d4: [clangd] Inject context provider rather than config into ClangdServer. NFC (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D95087?vs=317995&id=318498#toc Reposi

[clang-tools-extra] 60cd75a - [clangd] Inject context provider rather than config into ClangdServer. NFC

Author: Sam McCall Date: 2021-01-22T14:34:30+01:00 New Revision: 60cd75a098d4f18d9c8903ddcb466b4e7deb0580 URL: https://github.com/llvm/llvm-project/commit/60cd75a098d4f18d9c8903ddcb466b4e7deb0580 DIFF: https://github.com/llvm/llvm-project/commit/60cd75a098d4f18d9c8903ddcb466b4e7deb0580.diff LO

[PATCH] D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call

This revision was automatically updated to reflect the committed changes. Closed by commit rG7388c3468595: [clangd][SwapIndex] ensure that the old index is alive while we are using it… (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang-tools-extra] 7388c34 - [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call

Author: Aleksandr Platonov Date: 2021-01-22T16:26:39+03:00 New Revision: 7388c34685954862e5f1fa4734f42f7087e697a2 URL: https://github.com/llvm/llvm-project/commit/7388c34685954862e5f1fa4734f42f7087e697a2 DIFF: https://github.com/llvm/llvm-project/commit/7388c34685954862e5f1fa4734f42f7087e697a2.

[PATCH] D95225: [clang][cli] NFC: Pass CC1Option explicitly to BoolOption

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added subscribers: dang, jfb. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When `Bool{F,G}Option` were introduced, they were des

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0e30914f8c8: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94599/new/ h

[clang] a0e3091 - [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

Author: Mikhail Maltsev Date: 2021-01-22T13:01:41Z New Revision: a0e30914f8c8bb60795a008ce2d9e3c0a4f9b7a2 URL: https://github.com/llvm/llvm-project/commit/a0e30914f8c8bb60795a008ce2d9e3c0a4f9b7a2 DIFF: https://github.com/llvm/llvm-project/commit/a0e30914f8c8bb60795a008ce2d9e3c0a4f9b7a2.diff LO

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

This revision was automatically updated to reflect the committed changes. Closed by commit rGe16959c9b855: Don't delete default constructor of PathDiagnosticConsumerOptions (authored by MoritzS). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/ne

[clang] e16959c - Don't delete default constructor of PathDiagnosticConsumerOptions

Author: Moritz Sichert Date: 2021-01-22T13:42:38+01:00 New Revision: e16959c9b8553a60ec5e9aa55d101154d5805292 URL: https://github.com/llvm/llvm-project/commit/e16959c9b8553a60ec5e9aa55d101154d5805292 DIFF: https://github.com/llvm/llvm-project/commit/e16959c9b8553a60ec5e9aa55d101154d5805292.diff

[PATCH] D95221: [clang][cli] NFC: Move prefix to the front of BoolOption

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added subscribers: dang, jfb. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The prefix used to be the last (optional) argument to

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 318447. khchen marked 2 inline comments as done. khchen added a comment. 1. do not need to manually define new op in gen-rvv-tests.py. 2. do not need to manually add new op define in ALL marco. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >