[PATCH] D94477: [clangd] Add main file macros into the main-file index.

ArcsinX updated this revision to Diff 316331. ArcsinX added a comment. - std::pair => struct MacroOccurrence - remove addressed fixme comment - assert() => cantFail() - use toSourceCode() to get the macro name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2493 +} +std::string::size_type position2 = Constraints.find("=A"); +if (position2 != std::string::npos) { Should consider the `Clobber == "edx"`? Repository: rG L

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, evandro, rogfer01, frasercrmck, asb, luismarques, kito-cheng. Herald added subscribers: NickHung, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe updated this revision to Diff 316324. FreddyYe added a comment. consider "=A" into the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeG

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. Thanks for the commits, Aaron. If you don't mind I have a short question: both commits don't seem to list the test cases, have they not been committed at all or are they filtered out in github and/or phabricator? Did I mess something up? CHANGES SINCE LAST ACTION htt

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

wenlei added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:412 + + Remark << ";"; } nit: any special reason for adding this? doesn't seem consistent with other remarks we have. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added a comment. @nullptr.cpp: I may or may not come up with more review comments, but either way I'm a dead end — I don't consider myself authorized to "accept" Clang changes. You're still going to have to attract the attention of someone with the authority and/or force-of-will to

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

dblaikie added a comment. I'll leave this one to @aprantl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94391/new/ https://reviews.llvm.org/D94391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 316302. nullptr.cpp added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/c

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

This revision was automatically updated to reflect the committed changes. Closed by commit rG0066a09579ca: [libc++] Give extern templates default visibility on gcc (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35388/new/ https

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay added a comment. In D94391#2494531 , @dblaikie wrote: > In D94391#2494316 , @MaskRay wrote: > >> I removed `CurLoc` from call sites and tried a stage 2 build. There is such >> a difference: >> >> 0x000622

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay updated this revision to Diff 316286. MaskRay edited the summary of this revision. MaskRay added a comment. Add another workaround. stage 2 -DCMAKE_BUILD_TYPE=Debug clang is byte identical. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9439

[PATCH] D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm

compnerd added a comment. I think that it makes more sense to ignore the `aapcs-vfp` calling convention attribute (returning `CCCR_Ignore`), and warn on the `aapcs`. The redundant calling convention attribute does nothing, and I think that simply ignoring it would solve your issue. However, c

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

jasonliu accepted this revision. jasonliu added a comment. LGTM with minor nits. Comment at: clang/lib/Sema/SemaAttr.cpp:74 return; - // The #pragma align/pack affected a record in an included file, so Clang - // should warn when that the pragma was written in a file tha

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

aprantl added a comment. I like that this makes getLineNumber behave less "magic". I'm slightly worried that this isn't quite as NFC as think (and the other cases are just not caught by the testsuite). Perhaps you could compile Clang (and a sample of Clang's ObjC(xx) tests) with the patch and d

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

dblaikie added a comment. In D94391#2494316 , @MaskRay wrote: > I removed `CurLoc` from call sites and tried a stage 2 build. There is such a > difference: > > 0x00062228: DW_TAG_structure_type > DW_AT_calling_convention(DW_C

[PATCH] D94554: [clangd][WIP] Add a Filesystem that overlays Dirty files.

njames93 created this revision. Herald added subscribers: arphaman, javed.absar. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Before I start, this should probably be on clangd-dev, but that list seems kinda dead so I've

[PATCH] D94463: [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate are used together

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf45731f0eae: [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate… (authored by MaskRay). Repository: rG LLVM Github Mono

[clang] cf45731 - [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate are used together

Author: Fangrui Song Date: 2021-01-12T14:19:55-08:00 New Revision: cf45731f0eaead79e1ac501b397e330df41ec152 URL: https://github.com/llvm/llvm-project/commit/cf45731f0eaead79e1ac501b397e330df41ec152 DIFF: https://github.com/llvm/llvm-project/commit/cf45731f0eaead79e1ac501b397e330df41ec152.diff

[PATCH] D94463: [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate are used together

MaskRay updated this revision to Diff 316238. MaskRay added a comment. Fix test on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94463/new/ https://reviews.llvm.org/D94463 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/

[PATCH] D94463: [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate are used together

xur accepted this revision. xur added a comment. This revision is now accepted and ready to land. looks good to me. Thanks for working on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94463/new/ https://reviews.llvm.org/D94463 __

[PATCH] D94463: [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate are used together

MaskRay updated this revision to Diff 316233. MaskRay retitled this revision from "[Driver] Make -fcs-profile-generate require -fprofile-use" to "[Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate are used together". MaskRay edited the summary of this revision. MaskRay a

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay added a comment. I removed `CurLoc` from call sites and tried a stage 2 build. 0x00062228: DW_TAG_structure_type DW_AT_calling_convention(DW_CC_pass_by_value) DW_AT_name ("__va_list_tag") DW_AT_byte_size (0x18)

[PATCH] D94476: [analyzer] Implement conversion from Clang diagnostics to PathDiagnostics.

NoQ added inline comments. Comment at: clang/lib/Analysis/PathDiagnosticConverterDiagnosticConsumer.cpp:1 +//===--- PathDiagnosticConverterDiagnosticConsumer.cpp --*- C++ -*-===// +// steakhal wrote: > I've seen this a few times, and I still don't know w

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a49b7c64a33: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it (authored by modimo). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG L

[clang] 2a49b7c - [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

Author: modimo Date: 2021-01-12T13:43:48-08:00 New Revision: 2a49b7c64a33566cf5db1a5b4042d6037ccc7cf5 URL: https://github.com/llvm/llvm-project/commit/2a49b7c64a33566cf5db1a5b4042d6037ccc7cf5 DIFF: https://github.com/llvm/llvm-project/commit/2a49b7c64a33566cf5db1a5b4042d6037ccc7cf5.diff LOG: [

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

awarzynski added a comment. Thank you for the reviewing @andreil99 ! Comment at: clang/include/clang/Driver/Options.td:652 Flags<[CC1Option,CC1AsOption]>, MetaVarName<"">, -HelpText<"Add directory to include search path. If there are multiple -I " - "option

[PATCH] D94438: Fis for Assertion failure on dependent expression.

This revision was automatically updated to reflect the committed changes. Sunil_Srivastava marked an inline comment as done. Closed by commit rGf706486eaf07: Fix for crash in __builtin_return_address in template context. (authored by Sunil_Srivastava). Changed prior to commit: https://reviews.l

[clang] f706486 - Fix for crash in __builtin_return_address in template context.

Author: Sunil Srivastava Date: 2021-01-12T12:37:18-08:00 New Revision: f706486eaf07020b11f2088274c757e4070fe6d1 URL: https://github.com/llvm/llvm-project/commit/f706486eaf07020b11f2088274c757e4070fe6d1 DIFF: https://github.com/llvm/llvm-project/commit/f706486eaf07020b11f2088274c757e4070fe6d1.di

[PATCH] D94381: [test] Add Clang side tests for -fdebug-info-for-profiling

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94381/new/ https://reviews.llvm.org/D94381 __

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay added a comment. In D94391#2493978 , @dblaikie wrote: > In D94391#2491229 , @MaskRay wrote: > >> In D94391#2491178 , @dblaikie wrote: >> >>> Any particular bug you're

[PATCH] D94381: [test] Add Clang side tests for -fdebug-info-for-profiling

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/fdebug-info-for-profiling.cpp:14-16 +// RUN: echo > %t.proftext +// RUN: llvm-profdata merge %t.proftext -o %t.profdata +// RUN: %clang_cc1 -emit-llvm -fno-legacy-pass-manager -fdebug-pass-manager -O1 -fprofile-ins

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

hoy added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:41 // [18:3] - probe id - // [25:19] - reserved + // [25:19] - probe distribution factor // [28:26] - probe type, see PseudoProbeType wmi wrote: > The bits in discriminator is a

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

andreil99 accepted this revision. andreil99 added a comment. This revision is now accepted and ready to land. Thanks for suggesting `DocBrief`, Richard! Looks good to me with a nit. Comment at: clang/include/clang/Driver/Options.td:652 Flags<[CC1Option,CC1AsOption]>, Meta

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. This patch looks ready to land. Are there any other concerns or feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits

[PATCH] D94381: [test] Add Clang side tests for -fdebug-info-for-profiling

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/fdebug-info-for-profiling.cpp:14-16 +// RUN: echo > %t.proftext +// RUN: llvm-profdata merge %t.proftext -o %t.profdata +// RUN: %clang_cc1 -emit-llvm -fno-legacy-pass-manager -fdebug-pass-manager -O1 -fprofile-in

[PATCH] D94453: [clang-tidy][NFC] Add test for Transformer-based checks with diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG922a5b894114: [clang-tidy] Add test for Transformer-based checks with diagnostics. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94453

[clang-tools-extra] 922a5b8 - [clang-tidy] Add test for Transformer-based checks with diagnostics.

Author: Yitzhak Mandelbaum Date: 2021-01-12T20:15:22Z New Revision: 922a5b894114defb5302e514973de8c9cd23af6a URL: https://github.com/llvm/llvm-project/commit/922a5b894114defb5302e514973de8c9cd23af6a DIFF: https://github.com/llvm/llvm-project/commit/922a5b894114defb5302e514973de8c9cd23af6a.diff

[PATCH] D94537: [IR] move nomerge attribute from function declaration/definition to callsites

This revision was automatically updated to reflect the committed changes. zequanwu marked an inline comment as done. Closed by commit rGe53bbd99516f: [IR] move nomerge attribute from function declaration/definition to callsites (authored by zequanwu). Changed prior to commit: https://reviews.ll

[clang] e53bbd9 - [IR] move nomerge attribute from function declaration/definition to callsites

Author: Zequan Wu Date: 2021-01-12T12:10:46-08:00 New Revision: e53bbd99516fc7b612df1ae08d48288d0b8784ea URL: https://github.com/llvm/llvm-project/commit/e53bbd99516fc7b612df1ae08d48288d0b8784ea DIFF: https://github.com/llvm/llvm-project/commit/e53bbd99516fc7b612df1ae08d48288d0b8784ea.diff LOG

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

dblaikie added a subscriber: JDevlieghere. dblaikie added a comment. In D94391#2491229 , @MaskRay wrote: > In D94391#2491178 , @dblaikie wrote: > >> Any particular bug you're trying to fix? (this looks like it chang

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5f51fdd650c: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate (authored by DavidTruby). Changed prior to commit: https://reviews.llvm.org/D92751?vs=315788&id=316181#toc Reposit

[clang] e5f51fd - [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

Author: David Truby Date: 2021-01-12T19:44:01Z New Revision: e5f51fdd650c6d20c81fedb8e856e9858aa10991 URL: https://github.com/llvm/llvm-project/commit/e5f51fdd650c6d20c81fedb8e856e9858aa10991 DIFF: https://github.com/llvm/llvm-project/commit/e5f51fdd650c6d20c81fedb8e856e9858aa10991.diff LOG: [

[PATCH] D94537: [IR] move nomerge attribute from function declaration/definition to callsites

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Comment at: clang/lib/CodeGen/CGCall.cpp:1973 } - if (!AttrOnCallSite && TargetDecl->hasAttr()) FuncAttrs.addAttribute(llvm::Attribute::NoMerge);

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

dblaikie added a comment. Do you need to run the destructor before placement new in these situations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237 ___ cfe-comm

[PATCH] D94537: [IR] move nomerge attribute from function declaration/definition to callsites

zequanwu created this revision. zequanwu added reviewers: aaron.ballman, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move nomerge attribute from function declaration/definition to callsites to allow virtual function calls

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

ldionne removed a reviewer: EricWF. ldionne added a subscriber: EricWF. ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. In D35388#2493696 , @smeenai wrote: > It's been a long time since I've contrib

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

wmi added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:41 // [18:3] - probe id - // [25:19] - reserved + // [25:19] - probe distribution factor // [28:26] - probe type, see PseudoProbeType The bits in discriminator is a scare resour

[PATCH] D94382: [clangd] Avoid recursion in TargetFinder::add()

This revision was automatically updated to reflect the committed changes. Closed by commit rG4718ec01669b: [clangd] Avoid recursion in TargetFinder::add() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94382/new/ https://reviews

[clang-tools-extra] 4718ec0 - [clangd] Avoid recursion in TargetFinder::add()

Author: Nathan Ridge Date: 2021-01-12T13:57:54-05:00 New Revision: 4718ec01669b01373180f4cd1256c6e2dd6f3999 URL: https://github.com/llvm/llvm-project/commit/4718ec01669b01373180f4cd1256c6e2dd6f3999 DIFF: https://github.com/llvm/llvm-project/commit/4718ec01669b01373180f4cd1256c6e2dd6f3999.diff

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

t-tye added a comment. In D93525#2493024 , @yaxunl wrote: > can you document this in ClangOffloadBundler.rst ? I think we need a clear > description about how clang-offload-bundler knows which file in the .a file > belongs to which target. How does the

[PATCH] D94533: [clang] Add AddClang.cmake to the list of the installed CMake modules

awarzynski created this revision. Herald added subscribers: rriddle, mgorny. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, stephenneuendorffer. Herald added a project: clang. This makes sure that AddClang.cmake is installed alongside other Clang CMake modules

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

steakhal added a comment. In D93224#2493515 , @xazax.hun wrote: > In D93224#2493434 , @steakhal wrote: > >> How should I continue to get this working with CTU? > > We have two CTU modes. One loading the dump and the

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

ldionne added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4009 +// mangling. Previously, it used a special-cased nonstandard extension. +if (Context.getASTContext().getLangOpts().getClangABICompat() >= +LangOptions::ClangABI::Ver11) {

[PATCH] D94472: [clang][cli] Manually generate header search arguments

dexonsmith added a comment. It'd be much nicer to add the tests as part of the patch. I've added a comment to D94474 with a possible way to do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94472/new/ https:/

[PATCH] D94474: [WIP][clang][cli] Test manual header search argument generation with round-trip

dexonsmith added a comment. I'm wondering if we can get this in incrementally without needing to list in code which options are correctly handled. Here's one way to do it: - Add a tool, `clang-cc1-args`, that shows the diff between round-tripping when given a set of args. (This could potentiall

[PATCH] D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result

lebedev.ri added a comment. @aaron.ballman thank you for taking a look! @NoQ thank you for commenting. Indeed, i very much don't want to diagnose just the cases where the overflow can be proven to happen, doing that i believe, would remove most of the true-positive reports. So indeed, this is be

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

smeenai added a comment. It's been a long time since I've contributed to libc++, and the pre-merge CI setup is a massive improvement over what we had before. A huge kudos to everyone who made it possible :) This is still showing up as Needs Review. I'm not sure if that's because of @EricWF's p

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

smeenai updated this revision to Diff 316161. smeenai added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35388/new/ https

[PATCH] D94474: [WIP][clang][cli] Test manual header search argument generation with round-trip

dexonsmith added inline comments. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:199-203 void generateCC1CommandLine(llvm::SmallVectorImpl &Args, StringAllocator SA) const; + void generateCC1CommandLine(llvm::SmallVectorImpl &Args

[PATCH] D94453: [clang-tidy][NFC] Add test for Transformer-based checks with diagnostics.

ymandel added a comment. Reworked, per our discussion. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94453/new/ https://reviews.llvm.org/D94453 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D94488: [clang][cli] Port more CodeGenOptions to marshalling infrastructure

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with one nit. It'd be nice to add more detail to the commit message as well. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1146 - Opts.SSPBufferSize =

[clang] ef3800e - Return false from __has_declspec_attribute() if not explicitly enabled

Author: Timm Bäder Date: 2021-01-12T13:20:08-05:00 New Revision: ef3800e82169c674219501d9ac09ef12b28e6359 URL: https://github.com/llvm/llvm-project/commit/ef3800e82169c674219501d9ac09ef12b28e6359 DIFF: https://github.com/llvm/llvm-project/commit/ef3800e82169c674219501d9ac09ef12b28e6359.diff LO

[PATCH] D94453: [libTooling] Add function to Transformer for creating a diagnostic-only rule.

ymandel updated this revision to Diff 316158. ymandel added a comment. Discarded API changes, reduced to new clang-tidy lib test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94453/new/ https://reviews.llvm.org/D94453 Files: clang-tools-extra/u

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 348471575d9c24bbfb124ca5eac1589de075da88 , thank you for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/

[clang] 3484715 - Add -ansi option to CompileOnly group

Author: Timm Bäder Date: 2021-01-12T13:16:49-05:00 New Revision: 348471575d9c24bbfb124ca5eac1589de075da88 URL: https://github.com/llvm/llvm-project/commit/348471575d9c24bbfb124ca5eac1589de075da88 DIFF: https://github.com/llvm/llvm-project/commit/348471575d9c24bbfb124ca5eac1589de075da88.diff LO

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

nridge added a comment. I think that, as with incoming calls, the incremental value is in seeing the tree at a glance. So, you might query the outgoing calls for a function, expand the tree, and look over the transitive callees to see if the function ends up performing a certain type of operati

[PATCH] D94503: [clangd] Avoid having the same file in the queue twice in the background index.

sammccall updated this revision to Diff 316152. sammccall retitled this revision from "[clangd] Avoid having the same file in the queue twice in the background index. (For future reference. We decided not to do this for now in favor of simply not re-indexing the same CDB multiple times, as too mu

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. Yes, I was gonna ask somebody else but if you have time, committing this one and https://reviews.llvm.org/D94478 would be nice CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

aaron.ballman added a comment. In D93375#2493480 , @tbaeder wrote: > And thank you for reviewing my patches :) Happy to help! Btw, do you need someone to commit them on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

xazax.hun added a comment. In D93224#2493434 , @steakhal wrote: > How should I continue to get this working with CTU? We have two CTU modes. One loading the dump and the other loading from AST source file. I assume that you refer to the former? Could you

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added a comment. Ping x 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] dd95577 - Fix typo in diagnostic message

Author: Akira Hatanaka Date: 2021-01-12T09:58:11-08:00 New Revision: dd955771240289fbcba5fa1312cb8c78f20cd78f URL: https://github.com/llvm/llvm-project/commit/dd955771240289fbcba5fa1312cb8c78f20cd78f DIFF: https://github.com/llvm/llvm-project/commit/dd955771240289fbcba5fa1312cb8c78f20cd78f.diff

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. And thank you for reviewing my patches :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375 ___ cfe-c

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

steakhal added a comment. Updates: - Rebased. --- Unfortunately, I could not come up with a proper CTU implementation. It seems that when we load the AST/dump, no preprocessor events are replayed. Without those events, my `PPCallbacks` implementation and tokenwatcher would not record anything,

[PATCH] D94513: [clangd] Remove "decision-forest-base" experimental flag.

usaxena95 created this revision. usaxena95 added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. The value of this flag can only be fine t

[PATCH] D93223: [RFC][analyzer] Create MacroExpansionContext member in AnalysisConsumer and pass down to the diagnostics consumers

steakhal updated this revision to Diff 316126. steakhal marked 2 inline comments as done. steakhal added a comment. Updates: - New the construction of `MacroExpansionContext` won't hook the `Preprocessor` in the constructor. Hooking is done via the `registerForPreprocessor(PP)` member function.

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder updated this revision to Diff 316118. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375 Files: clang/include/clang/Driver/Options.td clang/test/Driver/ansi.c Index: clang/test/Driver/ansi.c =

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder updated this revision to Diff 316115. tbaeder added a comment. Okay, I've added a test and made sure it fails before and succeeds after this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375 Files: clang/include/clang/Driver/Opti

[PATCH] D94503: [clangd] Avoid having the same file in the queue twice in the background index. (For future reference. We decided not to do this for now in favor of simply not re-indexing the same CD

sammccall created this revision. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. ...updated and in practice it's often a net negative) Repository: rG LLVM G

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

yaxunl added a comment. can you document this in ClangOffloadBundler.rst ? I think we need a clear description about how clang-offload-bundler knows which file in the .a file belongs to which target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:858 +std::string RelatedNS = OS.str(); +if (!RelatedNS.empty()) { + Signals.RelatedNamespaces[RelatedNS + "::"] += 1; nit: I think you can just

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj created this revision. timwoj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit removes the old way of handling Whitesmiths mode in favor of just setting the levels during parsing and letting the formatter handle it from t

[PATCH] D94476: [analyzer] Implement conversion from Clang diagnostics to PathDiagnostics.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/PathDiagnosticConverterDiagnosticConsumer.h:38 + + std::map> + PartialPDs; A pointer pair might be small enough for a DenseMap? Comment at: clang/lib/Analysis/Path

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f7b4ce96065: [PowerPC] Add support for embedded devices with EFPU2 (authored by nemanjai). Changed prior to commit: https://reviews.llvm.org/D92935?vs=315119&id=316093#toc Repository: rG LLVM Github

[clang] 3f7b4ce - [PowerPC] Add support for embedded devices with EFPU2

Author: Nemanja Ivanovic Date: 2021-01-12T09:47:00-06:00 New Revision: 3f7b4ce96065eea66bf4344973173e76ec1a4255 URL: https://github.com/llvm/llvm-project/commit/3f7b4ce96065eea66bf4344973173e76ec1a4255 DIFF: https://github.com/llvm/llvm-project/commit/3f7b4ce96065eea66bf4344973173e76ec1a4255.di

[PATCH] D94476: [analyzer] Implement conversion from Clang diagnostics to PathDiagnostics.

steakhal added a comment. Seems pretty straightforward and clean. The cleanup of the report's message should be reworked. Besides, that looks good to me. I think these cases should be tested as well: - [Warning, Warning, Warning] - [Warning, Note, Note] - [Warning, Note, Note, Warning, Note] -

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

ldionne accepted this revision. ldionne added a comment. Can you rebase onto `main` and re-upload the diff? It will trigger CI. If the CI passes, this is good to go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35388/new/ https://reviews.llvm.org

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

sammccall added a comment. Thanks for looking into this feature! I do have to ask a fairly naive question though - what's it useful for, beyond protocol completeness? The obvious alternative to a user is looking at a function's implementation, which is an extra context switch but also provides

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

awarzynski updated this revision to Diff 316074. awarzynski added a comment. Use `DocBrief`, as suggested by @richard.barton.arm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94169/new/ https://reviews.llvm.org/D94169 Files: clang/docs/ClangCom

[PATCH] D94473: [clangd] Use AST-based signals in CodeCompletion.

usaxena95 updated this revision to Diff 316071. usaxena95 added a comment. Edge cases fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94473/new/ https://reviews.llvm.org/D94473 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-ex

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 316068. tinloaf added a comment. Fixed formatting issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Re

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a few small issues to fix. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:893 +def err_pragma_pack_identifer_not_supported : Error

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

bjope added a comment. I've just landed this on behalf of @ebevhan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86632/new/ https://reviews.llvm.org/D86632 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

kiausch added a comment. Could somebody with write access please commit this patch if there are no further objections? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92935/new/ https://reviews.llvm.org/D92935 ___ cfe-commits mailing l

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4944a6f53f6: [Fixed Point] Add codegen for conversion between fixed-point and floating point. (authored by ebevhan, committed by bjope). Herald add

[clang] c4944a6 - [Fixed Point] Add codegen for conversion between fixed-point and floating point.

Author: Bevin Hansson Date: 2021-01-12T13:53:01+01:00 New Revision: c4944a6f53f6d1876e76563599f5f149328e7f8f URL: https://github.com/llvm/llvm-project/commit/c4944a6f53f6d1876e76563599f5f149328e7f8f DIFF: https://github.com/llvm/llvm-project/commit/c4944a6f53f6d1876e76563599f5f149328e7f8f.diff

[PATCH] D94477: [clangd] Add main file macros into the main-file index.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Ah, this is a bit ugly... I'm not really happy with our representation of info extracted from the preprocessor, but that's something to tackle another time. Thanks for fixing this! ==

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

richard.barton.arm added a comment. I think the right long-term solution is going to be SUGGESTION 2, or a variant of that. We have implemented this feature downstream in Arm Compiler for Linux, i.e. a separate, normally longer and more detailed, Doc string for the CommandLineReference.rst file

  1   2   >