dexonsmith added a comment.

I'm wondering if we can get this in incrementally without needing to list in 
code which options are correctly handled. Here's one way to do it:

- Add a tool, `clang-cc1-args`, that shows the diff between round-tripping when 
given a set of args. (This could potentially grow other functionality vs. 
diffing. So maybe `clang-cc1-args diff [args]` would be the usage?)
- Add `RUN` lines to tests that test the args we think should round-trip 
correctly and confirm there's no diff. This can be done incrementally as 
options get handled.
- Only once we think we have all the options covered, add the assertion from 
this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94474/new/

https://reviews.llvm.org/D94474

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to