[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn added a comment. Thanks, it look more clear really. I'm trying to make the hover looks like `auto` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92041/new/ https://reviews.llvm.org/D92041 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song updated this revision to Diff 308884. yonghong-song edited the summary of this revision. yonghong-song added a comment. - remove -mcpu=v4. - for new instructions (except xadd), for 32bit mode, only alu32 mode is supported. I chose this way since we have -mcpu=v3 for a while which ha

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy added a comment. In D91756#2427759 , @wmi wrote: > Another question. Sorry for not bringing it up earlier. When a call with > probe metadata attached is inlined, the probe will be gone or it will be kept > somehow? I think you want to keep the probe

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jdoerfert requested changes to this revision. jdoerfert added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/Targets/SPIR.h:108 + + virtual bool hasInt128Type() const { return false; } }; Not virtual but override.

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

wmi added a comment. Another question. Sorry for not bringing it up earlier. When a call with probe metadata attached is inlined, the probe will be gone or it will be kept somehow? I think you want to keep the probe especially for inline instance to reconstruct the context but I didn't figure i

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy updated this revision to Diff 308874. hoy added a comment. Updating D91756 : [CSSPGO] Pseudo probes for function calls. Adding messages for asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91756/new/ htt

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added a subscriber: david_stone. Quuxplusone added inline comments. Comment at: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp:22 + return c; +} +#else @rsmith @david_stone (or anyone), what is the status in C++20 of the following test ca

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu added inline comments. Comment at: clang/lib/Basic/Targets.cpp:314 +default: + return new M68kTargetInfo(Triple, Opts); +} rengolin wrote: > No support for bare-metal? currently we don't have any plan for that Comment at: cla

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 308866. myhsu marked 3 inline comments as done. myhsu added a comment. - Addressed all the feedbacks - Fixed minor issues that would retrieve the wrong TargetCodeGenInfo instance CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews

[PATCH] D72184: [BPF] support atomic instructions

ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFMIChecking.cpp:199 + unsigned newOpcode; + switch(MI.getOpcode()) { + case BPF::XFADDW32: newOpcode = BPF::XADDW32; break; yonghong-song wrote: > yonghong-song wrote: > > ast wrote: > >

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFMIChecking.cpp:199 + unsigned newOpcode; + switch(MI.getOpcode()) { + case BPF::XFADDW32: newOpcode = BPF::XADDW32; break; yonghong-song wrote: > ast wrote: > > With this logic

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFMIChecking.cpp:199 + unsigned newOpcode; + switch(MI.getOpcode()) { + case BPF::XFADDW32: newOpcode = BPF::XADDW32; break; ast wrote: > With this logic in place Andrii has a po

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added a comment. > If it is not possible to copy or move the type at all, it is not possible to > copy or move it trivially. This was a bit confusing to me because I think this changed between C++14 and 17. In C++14, a class was trivially copyable if it had no non-trivial copy/move c

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

wmi added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:33-34 + static uint32_t packProbeData(uint32_t Index, uint32_t Type) { +assert(Index <= 0x); +assert(Type <= 0x7); +return (Index << 3) | (Type << 26) | 0x7; Add assertion

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. Regarding things like Altivec and VSX: Altivec should be just fine to run in 32-bit LE. I am undecided as to whether VSX should be banned or not. However that goes, it should be identical in powerpc64 -m32 and powerpc64le -m32. Regarding codegen: CPU capabilities are a

[PATCH] D72184: [BPF] support atomic instructions

ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFMIChecking.cpp:199 + unsigned newOpcode; + switch(MI.getOpcode()) { + case BPF::XFADDW32: newOpcode = BPF::XADDW32; break; With this logic in place Andrii has a point. There is no need f

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

ychen added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:356 + HELP, METAVAR, VALUES) \ + if (DriverID::OPT_##ALIAS != DriverID::OPT_INVALID && ALIASARGS == nullptr) \ +AddAlias(DriverID::

[PATCH] D92386: [VE] Add standard include path and library path for C++

kaz7 planned changes to this revision. kaz7 added inline comments. Comment at: clang/lib/Driver/ToolChains/VEToolchain.cpp:109 +return; + if (const char *cl_include_dir = getenv("NCC_CPLUS_INCLUDE_PATH")) { +SmallVector Dirs; simoll wrote: > Do we want a

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2427537 , @Bdragon28 wrote: > In D92445#2427438 , @nemanjai wrote: > >> This seems problematic to me for a few reasons: >> >> 1. There is no 32-bit toolchains or libraries for li

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2427439 , @MaskRay wrote: > This patch should be split. I suggest that you create 4 patches. > > - llvm: triple change > - llvm: llvm/Object/ELFObjectFile.h llvm-readobj llvm-objdump > - clang > - lld Can do. Reposit

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2427438 , @nemanjai wrote: > This seems problematic to me for a few reasons: > > 1. There is no 32-bit toolchains or libraries for little endian Linux systems > 2. There is no support in the ELFv2 ABI for 32-bit object

[PATCH] D92444: [CMake][Fuchsia] Install llvm-elfabi

haowei accepted this revision. haowei added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92444/new/ https://reviews.llvm.org/D92444 ___ c

[PATCH] D92445: [PowerPC] Add powerpcle target.

MaskRay added a comment. This patch should be split. I suggest that you create 4 patches. - llvm: triple change - llvm: llvm/Object/ELFObjectFile.h llvm-readobj llvm-objdump - clang - lld Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ ht

[PATCH] D92445: [PowerPC] Add powerpcle target.

nemanjai added a comment. This seems problematic to me for a few reasons: 1. There is no 32-bit toolchains or libraries for little endian Linux systems 2. There is no support in the ELFv2 ABI for 32-bit object mode and there may be a number of places we assume that little endian systems use ELFv

[clang] e181a6a - s/instantate/instantiate/ throughout. NFCI.

Author: Arthur O'Dwyer Date: 2020-12-01T22:13:40-05:00 New Revision: e181a6aeddc26ef0512b2dba94db6360ba32f2ff URL: https://github.com/llvm/llvm-project/commit/e181a6aeddc26ef0512b2dba94db6360ba32f2ff DIFF: https://github.com/llvm/llvm-project/commit/e181a6aeddc26ef0512b2dba94db6360ba32f2ff.diff

[clang-tools-extra] e181a6a - s/instantate/instantiate/ throughout. NFCI.

Author: Arthur O'Dwyer Date: 2020-12-01T22:13:40-05:00 New Revision: e181a6aeddc26ef0512b2dba94db6360ba32f2ff URL: https://github.com/llvm/llvm-project/commit/e181a6aeddc26ef0512b2dba94db6360ba32f2ff DIFF: https://github.com/llvm/llvm-project/commit/e181a6aeddc26ef0512b2dba94db6360ba32f2ff.diff

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. On FreeBSD, the main use of this will be on the new powerpc64le arch, where we need to build a 32-bit LE bootloader for use with pseries. (it is easier to retarget LLVM than make a cross-endian bootloader, as it would involve rewriting filesystem code etc.) On Linux,

[PATCH] D92441: Add CLangOffloadBundler documentation to Clang index

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa417cb086209: [NFC] Add CLangOffloadBundler documentation to Clang index (authored by t-tye). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] a417cb0 - [NFC] Add CLangOffloadBundler documentation to Clang index

Author: Tony Date: 2020-12-02T02:47:44Z New Revision: a417cb086209c2a01c2460d3e1ea64453f53c68e URL: https://github.com/llvm/llvm-project/commit/a417cb086209c2a01c2460d3e1ea64453f53c68e DIFF: https://github.com/llvm/llvm-project/commit/a417cb086209c2a01c2460d3e1ea64453f53c68e.diff LOG: [NFC] Ad

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 created this revision. Bdragon28 added reviewers: MaskRay, PowerPC, jhibbits. Bdragon28 added a project: PowerPC. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven.zhang, shchenz, rupprecht, kbarton, hiraditya, krytarowski, arichardson, nemanjai, emaste. Herald add

[PATCH] D92444: [CMake][Fuchsia] Install llvm-elfabi

mcgrathr created this revision. mcgrathr added reviewers: leonardchan, haowei. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. mcgrathr requested review of this revision. The canonical Fuchsia toolchain configuration installs llvm-elfabi. Repository: rG LLVM Githu

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added a comment. That's an excellent example to study. The fundamental question we are looking to answer is whether a type representationally depends on its address. Absent the `trivial_abi` attribute, the criterion for knowing that it does not is whether it is possible to copy or mo

[PATCH] D92441: Add CLangOffloadBundler documentation to Clang index

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92441/new/ https://reviews.llvm.org/D92441 _

[PATCH] D92441: Add CLangOffloadBundler documentation to Clang index

t-tye created this revision. t-tye added reviewers: kzhuravl, scott.linder, b-sumner, tpr, rampitec, yaxunl, kerbowa. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. t-tye requested review of this revision. Change-Id: I1a35bea10861cb5219e0dd13e14a86df56b38825 Rep

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

ahatanak added a comment. In the following example, should `S1` be passed directly or indirectly? The current patch passes it indirectly. struct __attribute__((trivial_abi)) S0 { S0(); S0(const S0 &) = delete; S0(S0 &&) = delete; int a; }; struct S1 { S0 s0; };

[PATCH] D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion

shivanshu3 updated this revision to Diff 308827. shivanshu3 added a comment. Clang format the test file. Forgot to do it before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91129/new/ https://reviews.llvm.org/D91129 Files: clang/lib/Parse/Pars

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 created this revision. jyu2 added reviewers: erichkeane, aaron.ballman, Fznamznon, rjmccall, jdoerfert, rsmith. jyu2 added a project: clang. Herald added a subscriber: Anastasia. jyu2 requested review of this revision. Emit error for use of 128-bit integer inside device code had been already

[clang] 1e91803 - Recommit "[clang][Fuchsia] Add relative-vtables multilib"

Author: Leonard Chan Date: 2020-12-01T17:03:13-08:00 New Revision: 1e91803c671a105f1eabce0e496766b512242f1d URL: https://github.com/llvm/llvm-project/commit/1e91803c671a105f1eabce0e496766b512242f1d DIFF: https://github.com/llvm/llvm-project/commit/1e91803c671a105f1eabce0e496766b512242f1d.diff

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 308817. jdoerfert marked an inline comment as done. jdoerfert added a comment. Addressed comments, lambda handling and more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D9

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert marked 6 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3210 + +SmallVector DeclContexts; +DeclContexts.push_back(CurContext); ABataev wrote: > jdoerfert wrote: > > ABataev wrote: > > > jdoerf

[PATCH] D91673: [PGO] Enable preinline and cleanup when optimize for size

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks, my concerns are addressed, and I believe @xur's are as well. Please wait for his input before landing, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang] 1f40d60 - Remove CXXBasePaths::found_decls and simplify and modernize its only

Author: Richard Smith Date: 2020-12-01T16:35:03-08:00 New Revision: 1f40d60a3b7f310ff3f77bb8643a27d979a703cb URL: https://github.com/llvm/llvm-project/commit/1f40d60a3b7f310ff3f77bb8643a27d979a703cb DIFF: https://github.com/llvm/llvm-project/commit/1f40d60a3b7f310ff3f77bb8643a27d979a703cb.diff

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

dexonsmith added inline comments. Comment at: clang/include/clang/Frontend/PrecompiledPreamble.h:108 bool CanReuse(const CompilerInvocation &Invocation, -const llvm::MemoryBuffer *MainFileBuffer, PreambleBounds Bounds, -llvm::vfs::FileSystem *V

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

ychen created this revision. ychen added reviewers: efriedma, philip.pfaffe, chandlerc. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, dang, hiraditya, mgorny. Herald added projects: clang, LLVM. ychen requested review of this revision. Currently, -ftime-report + new pass manage

[PATCH] D91673: [PGO] Enable preinline and cleanup when optimize for size

zequanwu updated this revision to Diff 308810. zequanwu added a comment. - sync NPM with LPM. - use PreInlineThreshold flag value instead of hardcode number. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91673/new/ https://reviews.llvm.org/D91673

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy updated this revision to Diff 308806. hoy added a comment. Updating D91756 : [CSSPGO] Pseudo probes for function calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91756/new/ https://reviews.llvm.org/D91756

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy added inline comments. Comment at: llvm/lib/CodeGen/PseudoProbeInserter.cpp:50 +for (MachineBasicBlock &MBB : MF) { + MachineInstr *FirstInstr = nullptr; + for (MachineInstr &MI : MBB) { wmi wrote: > What is the usage of FirstInstr? Good patch.

[PATCH] D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode

shivanshu3 added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15752-15754 + bool AnonymousEnumEligible = getLangOpts().MSVCCompat && + (Kind == TTK_Enum) && + Tag->getDeclName().isEmp

[PATCH] D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode

shivanshu3 updated this revision to Diff 308803. shivanshu3 retitled this revision from "Allow anonymous enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode" to "Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode". shivanshu3 edited t

[PATCH] D92434: [NFC][AMDGPU] AMDGPU code object V4 ABI documentation

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92434/new/ https://reviews.llvm.org/D92434 _

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

wmi added inline comments. Comment at: llvm/lib/CodeGen/PseudoProbeInserter.cpp:50 +for (MachineBasicBlock &MBB : MF) { + MachineInstr *FirstInstr = nullptr; + for (MachineInstr &MI : MBB) { What is the usage of FirstInstr? Commen

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:449 + // We currently only use these for --print-before/after. + if (PIC && (!printBeforePasses().empty() || !printAfterPasses().empty())) { +#define MODULE_PASS(NAME, CREATE_PASS)

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks updated this revision to Diff 308797. aeubanks added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/D87216 Files: llvm/include/llvm/IR/PassInstrumentation.h llvm/in

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

dexonsmith added a comment. I think `DefaultsTo{True,False}` and `InvertedBy{Negative,Positive}Flag` makes the axes clear, it's way better; thanks for thinking this through. Thinking out loud: I'm still a bit resistant to making this keypath-centric. The reason is that `llvm::Option` is a libra

[clang] 1e4d6d1 - [clang-format] Add new option PenaltyIndentedWhitespace

Author: Mark Nauwelaerts Date: 2020-12-01T23:59:44+01:00 New Revision: 1e4d6d1c1ff3f5a4d6e7dda053386ff411fd7de4 URL: https://github.com/llvm/llvm-project/commit/1e4d6d1c1ff3f5a4d6e7dda053386ff411fd7de4 DIFF: https://github.com/llvm/llvm-project/commit/1e4d6d1c1ff3f5a4d6e7dda053386ff411fd7de4.di

[PATCH] D90534: [clang-format] Add new option PenaltyIndentedWhitespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e4d6d1c1ff3: [clang-format] Add new option PenaltyIndentedWhitespace (authored by mnauw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

fghanim added a comment. Thanks; just two more mediocre things if possible. if not. you are good to go. :) @jdoerfert In D92189#2424677 , @jdoerfert wrote: > In D92189#2424216 , @fghanim wrote: > >> To be honest,

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

ASDenysPetrov updated this revision to Diff 308781. ASDenysPetrov added a comment. @NoQ , considered your suggestions about the case of recursive mutexes. Implemented this feature. Now this works like below: recursive_mutex rm; rm.lock(); rm.lock(); // no-warning recursive_timed_mutex rt

[PATCH] D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis.

NoQ updated this revision to Diff 308771. NoQ added a comment. Whoops, fix typos in header formalities. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92432/new/ https://reviews.llvm.org/D92432 Files: clang/include/clang/Analysis/CrossTUAnalysisHelper.h clang/include/clang/Analysis/

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 308770. saudi added a comment. Rebase after https://reviews.llvm.org/D92330. Also, improved the detection of target obj file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 Files: clang/test/ClangScanDeps/I

[PATCH] D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis.

NoQ created this revision. NoQ added reviewers: vsavchenko, xazax.hun, baloghadamsoftware, Charusso, martong, balazske, gamesh411. Herald added subscribers: steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet. NoQ requested review of this revision.

[clang] 1b8ed1d - [OpenMP51][DOCS] Claim "add present modifier in defaultmap clause", NFC.

Author: cchen Date: 2020-12-01T16:07:00-06:00 New Revision: 1b8ed1d03dee63fd0b787ab52d0b195df9c35b9c URL: https://github.com/llvm/llvm-project/commit/1b8ed1d03dee63fd0b787ab52d0b195df9c35b9c DIFF: https://github.com/llvm/llvm-project/commit/1b8ed1d03dee63fd0b787ab52d0b195df9c35b9c.diff LOG: [O

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaafb3662103f: Reland [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/ (authored by aeubanks). Repository: rG LLVM Github Monore

[clang] aafb366 - Reland [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

Author: Arthur Eubanks Date: 2020-12-01T14:00:32-08:00 New Revision: aafb3662103f4b3df315967c0cf4f6eec6bff0c4 URL: https://github.com/llvm/llvm-project/commit/aafb3662103f4b3df315967c0cf4f6eec6bff0c4 DIFF: https://github.com/llvm/llvm-project/commit/aafb3662103f4b3df315967c0cf4f6eec6bff0c4.diff

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

cchen added a comment. I now only update `target_defaultmap_messages` test since I'm not sure what I've done is correct for the new version. Will add all other defaultmap_messages tests once corrected the stuff I added in `target_defaultmap_messages`. Repository: rG LLVM Github Monorepo CH

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

aeubanks updated this revision to Diff 308761. aeubanks added a comment. set LLVM_ENABLE_NEW_PASS_MANAGER to the value of ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER, not the string itself Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92072/new/ https://

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

cchen updated this revision to Diff 308760. cchen added a comment. Rebase and fix coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92427/new/ https://reviews.llvm.org/D92427 Files: clang/include/clang/Basic/OpenMPKinds.def clang/lib/

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM; thanks. Comment at: llvm/test/CodeGen/PowerPC/aix-exception.ll:108-109 +; ASM: .byte 255 # @LPStart Encoding = omit +; ASM32: .byte 187

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Support present modifier in defaul

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu marked 2 inline comments as done. jasonliu added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix-exception.ll:108-109 +; ASM: .byte 255 # @LPStart Encoding = omit +; ASM32: .byte 187 #

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu updated this revision to Diff 308752. jasonliu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91455/new/ https://reviews.llvm.org/D91455 Files: clang/lib/CodeGen/CGCleanup.h clang/lib/CodeGen/CGException.cpp clang/test/CodeGenCXX/persona

[clang] 806a76c - Revert "[CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/"

Author: Arthur Eubanks Date: 2020-12-01T13:12:12-08:00 New Revision: 806a76c001233f2c70bf93c73fb955c64c1c080f URL: https://github.com/llvm/llvm-project/commit/806a76c001233f2c70bf93c73fb955c64c1c080f DIFF: https://github.com/llvm/llvm-project/commit/806a76c001233f2c70bf93c73fb955c64c1c080f.diff

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

aeubanks added a comment. In D92072#2426511 , @nikic wrote: > It looks like this change has also enabled the new pass manager by default. Whoops, I'll revert and see what went wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

nikic added a comment. It looks like this change has also enabled the new pass manager by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92072/new/ https://reviews.llvm.org/D92072 ___ cfe-commits

[PATCH] D80450: [CUDA][HIP] Fix HD function resolution

tra accepted this revision. tra added a comment. LGTM. I'd suggest adding more details on the background of this change to the commit log (point to the comment in the `isBetterOverloadCandidate` ?) and outline the intention to enable the new way to do overloading after some soak time. Also, n

[clang] f9eaa46 - Fix erroneous edit in https://github.com/llvm/llvm-project/actions/runs/394499364

Author: Zahira Ammarguellat Date: 2020-12-01T12:34:18-08:00 New Revision: f9eaa4650f5d5948af7050efef9d4098ff7f0ae8 URL: https://github.com/llvm/llvm-project/commit/f9eaa4650f5d5948af7050efef9d4098ff7f0ae8 DIFF: https://github.com/llvm/llvm-project/commit/f9eaa4650f5d5948af7050efef9d4098ff7f0ae8

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaExpr.cpp:1957 +// host variable in a device or host device lambda. +static bool isCapturingReferenceToHostVarInCUDADeviceLambda(Sema &S, +

[PATCH] D63852: [Clang] Move assembler into a separate file

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Thanks for the explanation, lgtm. -eric Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63852/new/ https://reviews.llvm.org/D63852 _

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

jamieschmeiser added a comment. I agree that having the callbacks ask for the names is an improvement as it is cleaner and allows other callbacks to use this feature if desired. Generally, things look good. I have a couple of minor concerns mentioned in the code but I think it would be accept

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, one comment and two nits. Feel free to commit if you agree with the suggestions or come back with concerns. Thanks for working on this and taking the time to fix it like this! =

[PATCH] D92418: [hip] Fix host object creation from fatbin

ashi1 added a comment. Looks good to me, were you able to run staging on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92418/new/ https://reviews.llvm.org/D92418 ___ cfe-commits mailing list

[PATCH] D92403: [LSan][RISCV] Enable LSan for RISCV64

luismarques updated this revision to Diff 308737. luismarques added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92403/new/ https://reviews.llvm.org/D92403 Files: clang/lib/Driver/ToolChains/Linux.cpp clang/test/Dri

[PATCH] D92363: [HIP] Warn no --offload-arch option

tra added a comment. While I agree that the default GPU choice is not likely to be correct, or usable, for everyone, but the warning seems to be a half-measure. If the default is not usable, then it should not be the default. If it's usable, then we don't need a warning. Having a warning would

[PATCH] D92418: [hip] Fix host object creation from fatbin

hliao added a comment. Even there's no functionality change, the original one breaks the kernel extraction script, which is designed to find the `.hip_fatbin` section. That internal tool is still required to extract kernels from objects generated from RDC linking. Repository: rG LLVM Github

[PATCH] D92418: [hip] Fix host object creation from fatbin

hliao created this revision. hliao added reviewers: yaxunl, ashi1. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao requested review of this revision. - `__hip_fatbin` should a symbol in `.hip_fatbin` section. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D92330: [clang-scan-deps] Improve argument parsing to find target object file path.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79ba7967f481: [clang-scan-deps] Improve argument parsing to find target object file path. (authored by saudi). Repository: rG LLVM Github Monorepo

[clang] 79ba796 - [clang-scan-deps] Improve argument parsing to find target object file path.

Author: Sylvain Audi Date: 2020-12-01T15:04:15-05:00 New Revision: 79ba7967f4813445c3ce5624170c19584bbfda72 URL: https://github.com/llvm/llvm-project/commit/79ba7967f4813445c3ce5624170c19584bbfda72 DIFF: https://github.com/llvm/llvm-project/commit/79ba7967f4813445c3ce5624170c19584bbfda72.diff

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

cjdb added a comment. In D92176#2419011 , @manojgupta wrote: > lgtm but not an expert in this area. Ditto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews.llvm.org/D92176 _

[clang] a36bd4c - [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

Author: Arthur Eubanks Date: 2020-12-01T11:42:17-08:00 New Revision: a36bd4c90dcca82be9b64f65dbd22e921b6485ef URL: https://github.com/llvm/llvm-project/commit/a36bd4c90dcca82be9b64f65dbd22e921b6485ef DIFF: https://github.com/llvm/llvm-project/commit/a36bd4c90dcca82be9b64f65dbd22e921b6485ef.diff

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa36bd4c90dcc: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/ (authored by aeubanks). Repository: rG LLVM Github Monorepo CHA

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

rnk accepted this revision. rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92072/new/ https://reviews.llvm.org/D92072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D92413: Argument dependent lookup with class argument is recursing into base classes that haven't been instantiated. This is generating an assertion in DeclTemplate.h. Fix for Bug25668.

cryptoad abandoned this revision. cryptoad added a comment. This is an arc fail on my side Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92413/new/ https://reviews.llvm.org/D92413 ___ cfe-commits mailing

[PATCH] D92413: Argument dependent lookup with class argument is recursing into base classes that haven't been instantiated. This is generating an assertion in DeclTemplate.h. Fix for Bug25668.

cryptoad created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. cryptoad requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92413 Files:

[clang] 4eaa024 - APINotes: constify `dump` methods (NFC)

Author: Saleem Abdulrasool Date: 2020-12-01T19:01:06Z New Revision: 4eaa024863f4a86151beb7971301c6ab10a9de01 URL: https://github.com/llvm/llvm-project/commit/4eaa024863f4a86151beb7971301c6ab10a9de01 DIFF: https://github.com/llvm/llvm-project/commit/4eaa024863f4a86151beb7971301c6ab10a9de01.diff

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2426188 , @rsmith wrote: > Let's just disable this broken GCC warning. IIRC, the corresponding clang > warning covers the actual bugs caused by line continuation in comments, and > doesn't warn if the next line begins wi

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

aeubanks updated this revision to Diff 308713. aeubanks added a comment. Herald added a subscriber: dang. rename to LLVM_ENABLE_NEW_PASS_MANAGER Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92072/new/ https://reviews.llvm.org/D92072 Files: clan

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

rsmith added a comment. Let's just disable this broken GCC warning. IIRC, the corresponding clang warning covers the actual bugs caused by line continuation in comments, and doesn't warn if the next line begins with a `//`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 3734079 - Argument dependent lookup with class argument is recursing into base

Author: Zahira Ammarguellat Date: 2020-12-01T10:33:12-08:00 New Revision: 37340798ccb00b9c3a53e8a5f1b6430e85870338 URL: https://github.com/llvm/llvm-project/commit/37340798ccb00b9c3a53e8a5f1b6430e85870338 DIFF: https://github.com/llvm/llvm-project/commit/37340798ccb00b9c3a53e8a5f1b6430e85870338

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2426160 , @ABataev wrote: > I would just remove this extra symbol. But then the example code is no longer copy/pastable. Note that I expect people to copy/paste but it's nice if it looks authentic. Note that I don't mind

[PATCH] D92406: [OpenCL] Add some more kernel argument tests

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Comment at: clang/test/SemaOpenCL/invalid-kernel-parameters.cl:40 +void no_addrspace_param(global int x) { } // expected-error{{parameter may not be qua

  1   2   >