Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land.
LGTM! Thanks ================ Comment at: clang/test/SemaOpenCL/invalid-kernel-parameters.cl:40 +void no_addrspace_param(global int x) { } // expected-error{{parameter may not be qualified with an address space}} + ---------------- Btw this is tested in C, C++, and C++ for OpenCL. But I think it's good to test here as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92406/new/ https://reviews.llvm.org/D92406 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits