[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

FreddyYe updated this revision to Diff 303047. FreddyYe added a comment. Use header file macros instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822 Files: clang/lib/Headers/gfniintrin.h Index: clang

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

pengfei added a comment. In D90822#2375469 , @craig.topper wrote: > In D90822#2375463 , @FreddyYe wrote: > >> In D90822#2375423 , @pengfei wrote: >> >>> Craig's method sound

[PATCH] D90828: [clangd] Trivial: Log missing completion signals.

usaxena95 created this revision. usaxena95 added a reviewer: adamcz. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

craig.topper added a comment. In D90822#2375463 , @FreddyYe wrote: > In D90822#2375423 , @pengfei wrote: > >> Craig's method sounds good. >> @FreddyYe , Why we check AVX512BW instead of AVX512F. I saw SDM says it >

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

pengfei added a comment. In D90822#2375445 , @craig.topper wrote: > In D90822#2375425 , @pengfei wrote: > >> In D90822#2375423 , @pengfei wrote: >> >>> Craig's method sounds

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

FreddyYe added a comment. In D90822#2375423 , @pengfei wrote: > Craig's method sounds good. > @FreddyYe , Why we check AVX512BW instead of AVX512F. I saw SDM says it > depends on AVX512F. I was referring to the old implement and test case. Seems like a e

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

craig.topper added a comment. In D90822#2375425 , @pengfei wrote: > In D90822#2375423 , @pengfei wrote: > >> Craig's method sounds good. > > I think it may result in potential problem once we change the order of the

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

pengfei added a comment. In D90822#2375423 , @pengfei wrote: > Craig's method sounds good. I think it may result in potential problem once we change the order of them in immintrin.h, it should be better to use the first method. #if !(defined(_MSC_VER)

[clang] 5fd3193 - [test] Add 'REQUIRES: bpf-registered-target' to bpf-O0.c

Author: Arthur Eubanks Date: 2020-11-04T23:19:14-08:00 New Revision: 5fd3193c88d82f04571897a9b9d8a49a9f491d88 URL: https://github.com/llvm/llvm-project/commit/5fd3193c88d82f04571897a9b9d8a49a9f491d88 DIFF: https://github.com/llvm/llvm-project/commit/5fd3193c88d82f04571897a9b9d8a49a9f491d88.diff

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

pengfei added a comment. Craig's method sounds good. @FreddyYe , Why we check AVX512BW instead of AVX512F. I saw SDM says it depends on AVX512F. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae3854004266: [NewPM] Provide method to run all pipeline callbacks, used for -O0 (authored by aeubanks). Changed prior to commit: https://reviews.

[clang] ae38540 - [NewPM] Provide method to run all pipeline callbacks, used for -O0

Author: Arthur Eubanks Date: 2020-11-04T22:27:16-08:00 New Revision: ae38540042668675dd16c642d850115f217ea59f URL: https://github.com/llvm/llvm-project/commit/ae38540042668675dd16c642d850115f217ea59f DIFF: https://github.com/llvm/llvm-project/commit/ae38540042668675dd16c642d850115f217ea59f.diff

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

craig.topper added a comment. In D90822#2375372 , @FreddyYe wrote: > The fails are all unknown type errors on Windows, since those typedefs are > declared in other header files. > The error message goes like: > > $ clang -march=tremont gfni.c > ..

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

FreddyYe added a comment. The fails are all unknown type errors on Windows, since those typedefs are declared in other header files. The error message goes like: $ clang -march=tremont gfni.c .. ...\lib\clang\12.0.0\include\gfniintrin.h:129:37: error: unknown type name '__mmask

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

craig.topper added a comment. What compilation failure do you get without this? The feature checks are compile time optimization for MSVC because windows.h includes intrin.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

craig.topper added inline comments. Comment at: clang/lib/Headers/gfniintrin.h:23 +#ifdef __AVX__ +#ifdef __AVX512BW__ This needs to be more like #if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) || \

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

FreddyYe created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. FreddyYe requested review of this revision. Tremont microarchitecture only has GFNI(SSE) version, not AVX and AVX512 version. This patch is to avoid compiling fail on Windows when using -march=tr

[PATCH] D78899: [Driver] Add callback to Command execution

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20b4f4f76030: [Driver] Add callback to Command execution (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 20b4f4f - [Driver] Add callback to Command execution

Author: Serge Pavlov Date: 2020-11-05T12:21:40+07:00 New Revision: 20b4f4f76030f8712824c91b5f0b0a611476f747 URL: https://github.com/llvm/llvm-project/commit/20b4f4f76030f8712824c91b5f0b0a611476f747 DIFF: https://github.com/llvm/llvm-project/commit/20b4f4f76030f8712824c91b5f0b0a611476f747.diff

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

It is rare to report an error in BackendUtil.cpp . So I checked the other Diags.Report instance and noticed that -split-dwarf-file a.dwo -split-dwarf-output a.dwo (when a.dwo is not writable) suppresses the output. So there is no reason that -fbasic-block-sections=list= should not follow the conven

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aqjune added a comment. In D90275#2374648 , @gulfem wrote: > Leaf attribute is specifically intended for library functions and I think all > the existing usage of leaf attribute is in the library function declarations. > For ex, it is only used in syscall

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Nov 4, 2020 at 8:08 PM Fāng-ruì Sòng wrote: > I checked chmod -w a.dwo; clang -cc1 -debug-info-kind=limited > -dwarf-version=4 -split-dwarf-file a.dwo -split-dwarf-output a.dwo > -emit-obj -o - split-debug-output.c > which suppresses the output, so -fbasic-block-sections=list= should > fo

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

I checked chmod -w a.dwo; clang -cc1 -debug-info-kind=limited -dwarf-version=4 -split-dwarf-file a.dwo -split-dwarf-output a.dwo -emit-obj -o - split-debug-output.c which suppresses the output, so -fbasic-block-sections=list= should follow the convention as well. Sent https://reviews.llvm.org/D908

[PATCH] D90815: -fbasic-block-sections=list=: Suppress output if failed to open the file

MaskRay created this revision. MaskRay added reviewers: dblaikie, tmsriram. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90815 Files: clang/lib/CodeGen/BackendUt

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @chandlerc @majnemer @lvoufo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Tue, Oct 27, 2020 at 2:21 PM Sriraman Tallam via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Tue, Oct 27, 2020 at 2:14 PM David Blaikie via Phabricator < > revi...@reviews.llvm.org> wrote: > >> dblaikie added a comment. >> >> @tmsriram ping on the follow-up here >> > > I checked i

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac73b73c1652: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction (authored by atmnpatel). Repository: rG LLVM Github Monorepo

[clang] ac73b73 - [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

Author: Atmn Patel Date: 2020-11-04T22:03:14-05:00 New Revision: ac73b73c16526c9e51943759ea6cab285a57e33f URL: https://github.com/llvm/llvm-project/commit/ac73b73c16526c9e51943759ea6cab285a57e33f DIFF: https://github.com/llvm/llvm-project/commit/ac73b73c16526c9e51943759ea6cab285a57e33f.diff LO

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

hliao created this revision. hliao added reviewers: b-sumner, tony-tye, rampitec, yaxunl. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, hiraditya, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl, arsenm. Herald added projects: clang, LLVM. hliao requested review of this revision

[PATCH] D90329: [PowerPC] Fix va_arg in Objective-C on 32-bit ELF targets

kernigh added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4723 + bool isInt = Ty->isIntegerType() || Ty->hasPointerRepresentation() || + Ty->isAggregateType(); bool isF64 = Ty->isFloatingType() && getContext().getTypeSize(Ty) == 64; ---

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:60 enum GCMode { NonGC, GCOnly, HybridGC }; - enum StackProtectorMode { SSPOff, SSPOn, SSPStrong, SSPReq }; + enum StackProtectorMode { SSPOff, SSPOn, SSPStrong, SSPReq, SSPUnspecified

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. I think the documentation isn't quite right yet, but otherwise I think I'm happy. (With a couple of code change suggestions.) In D79279#2240487

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

void added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:60 enum GCMode { NonGC, GCOnly, HybridGC }; - enum StackProtectorMode { SSPOff, SSPOn, SSPStrong, SSPReq }; + enum StackProtectorMode { SSPOff, SSPOn, SSPStrong, SSPReq, SSPUnspecified }; -

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

LiuChen3 added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2851 +// Parse MASM style pseudo prefixes. +// FIXME: This prefix should only be used for MASM, not for intel-syntax. +if (isParsingIntelSyntax()) { craig.toppe

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

MaskRay added inline comments. Herald added a subscriber: pengfei. Comment at: clang/test/Frontend/optimization-remark-missed-inline-stack-protectors.c:1 +// RUN: %clang_cc1 -stack-protector 2 -Rpass-missed=inline -O2 -verify %s -emit-llvm-only + Emm. I am a bi

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

nickdesaulniers added a comment. Bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90194/new/ https://reviews.llvm.org/D90194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D90348: [Driver] specify -stack-protector 0 for -fno-stack-protector

nickdesaulniers added a comment. Bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90348/new/ https://reviews.llvm.org/D90348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

dblaikie added a comment. Since the same code is used to mangle all these things, probably just test one of them? Could use macros to stamp out longer names without having to write them out manually? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

jdoerfert added inline comments. Comment at: clang/docs/OpenMPSupport.rst:343 ++--+--+--+---+ +| mis

[PATCH] D82035: [PowerPC] Add Sema checks for MMA types

bsaleil added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10339 + if (Context.getTargetInfo().getTriple().isPPC64()) +CheckPPCMMAType(RetValExp->getType(), ReturnLoc); } NeHuang wrote: > CheckPPCMMAType returns bool value. Do we need add it

[PATCH] D90799: [PowerPC] Add paired vector load and store builtins and intrinsics

bsaleil updated this revision to Diff 302983. bsaleil added a comment. Add builtin tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90799/new/ https://reviews.llvm.org/D90799 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/CodeGe

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

dreachem created this revision. dreachem added reviewers: kkwli0, jdoerfert, ABataev, RaviNarayanaswamy. Herald added subscribers: cfe-commits, jfb, guansong, yaxunl. Herald added a project: clang. dreachem requested review of this revision. Herald added a subscriber: sstefan1. Adding features in

[PATCH] D82035: [PowerPC] Add Sema checks for MMA types

NeHuang added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10339 + if (Context.getTargetInfo().getTriple().isPPC64()) +CheckPPCMMAType(RetValExp->getType(), ReturnLoc); } CheckPPCMMAType returns bool value. Do we need add it in the if condit

[PATCH] D82035: [PowerPC] Add Sema checks for MMA types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf976ba613958: [PowerPC] Add Sema checks for MMA types (authored by bsaleil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D86105: [darwin] Disable the -Wpsabi warning

arphaman marked 2 inline comments as done. arphaman added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2561-2565 // The "avx" feature changes how vectors >128 in size are passed. "avx512f" // additionally changes how vectors >256 in size are passed. Lik

[clang] f976ba6 - [PowerPC] Add Sema checks for MMA types

Author: Baptiste Saleil Date: 2020-11-04T17:01:47-06:00 New Revision: f976ba61395811732b4605b6fb9b6ba5cd489372 URL: https://github.com/llvm/llvm-project/commit/f976ba61395811732b4605b6fb9b6ba5cd489372 DIFF: https://github.com/llvm/llvm-project/commit/f976ba61395811732b4605b6fb9b6ba5cd489372.dif

[PATCH] D86105: [darwin] Disable the -Wpsabi warning

arphaman updated this revision to Diff 302977. arphaman added a comment. Address Ahmed's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86105/new/ https://reviews.llvm.org/D86105 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/target-avx-abi-diag.c clang/test/

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

nickdesaulniers added a comment. In D90180#2357247 , @aaron.ballman wrote: > When you pass `-fix` to clang-tidy, it will apply fix-its from the compiler > as well. See https://godbolt.org/z/7vzM4b and try adding a semicolon to the > end of the `switch`

[PATCH] D90799: [PowerPC] Add paired vector load and store builtins and intrinsics

bsaleil created this revision. bsaleil added reviewers: nemanjai, amyk, saghir, lei. bsaleil added projects: LLVM, PowerPC. Herald added subscribers: llvm-commits, cfe-commits, shchenz, kbarton, hiraditya. Herald added a project: clang. bsaleil requested review of this revision. This patch adds t

[PATCH] D90481: Basic: Change Module::Umbrella to a PointerUnion, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e73cfa8363d: Basic: Change Module::Umbrella to a PointerUnion, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang] 6e73cfa - Basic: Change Module::Umbrella to a PointerUnion, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-04T16:19:39-05:00 New Revision: 6e73cfa8363d43689f77b0e4e4c2787ae6ae3fb6 URL: https://github.com/llvm/llvm-project/commit/6e73cfa8363d43689f77b0e4e4c2787ae6ae3fb6 DIFF: https://github.com/llvm/llvm-project/commit/6e73cfa8363d43689f77b0e4e4c2787ae6ae

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added a comment. In D90275#2371343 , @jdoerfert wrote: > The more I think about it, the more I think we should never create a > `leaf`/`nocallback` definition. Only declarations should carry that attribute. Leaf attribute is specifically intended

[clang] ab0ddbc - Reland [NewPM] Add OptimizationLevel param to registerPipelineStartEPCallback

Author: Arthur Eubanks Date: 2020-11-04T13:11:40-08:00 New Revision: ab0ddbc38af9508ee0f753fb897d9050025a0763 URL: https://github.com/llvm/llvm-project/commit/ab0ddbc38af9508ee0f753fb897d9050025a0763 DIFF: https://github.com/llvm/llvm-project/commit/ab0ddbc38af9508ee0f753fb897d9050025a0763.diff

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 updated this revision to Diff 302935. njames93 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90531/new/ https://reviews.llvm.org/D90531 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/clang

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 marked 13 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:183 + struct ClangTidyBlock { +llvm::Optional> Enable; +/// List of checks to enable or disable, can use wildcards. sammccal

[PATCH] D90540: [Syntax] Add minimal TableGen for syntax nodes. NFC

hokein accepted this revision. hokein added inline comments. Comment at: clang/utils/TableGen/ClangSyntaxEmitter.cpp:107 +llvm::raw_ostream &OS) { + OS << "// Generated from " << Records.getInputFilename() << "\n"; + OS << R"cpp(

[PATCH] D82035: [PowerPC] Add Sema checks for MMA types

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. Overall LGTM, thanks for addressing comments Baptiste! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82035/new/ https://reviews.llvm.org/D8

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:263 + DeclContextLookupResult LookupResult; + switch (DC->getDeclKind()) { + case Decl::TranslationUnit: sammccall wrote: > sammccall wrote: > > explain this list somewhat?

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

hokein updated this revision to Diff 302928. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89790/new/ https://reviews.llvm.org/D89790 Files: clang-tools-extra/cla

[PATCH] D90221: Include more attribute details when dumping AST in JSON

aronsky added a comment. > It seems surprising to me that you'd have to add those declarations; I think > that's a layering violation. There's something somewhat strange going on here > that I think is related. Given: > [...] > Notice how the annotate attribute has an `inner` array with the argu

[PATCH] D82035: [PowerPC] Add Sema checks for MMA types

bsaleil updated this revision to Diff 302918. bsaleil added a comment. Change function name and improve comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82035/new/ https://reviews.llvm.org/D82035 Files: clang/include/clang/Basic/DiagnosticS

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd added a comment. Thanks for the reviews! I'll reformat the rest of the code before merging. Im going to be working on merging this downstream first before merging this upstream, so it will take a couple of days still. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90478: Basic: Split out DirectoryEntry.h, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG77a9e0a4af5a: Basic: Split out DirectoryEntry.h, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[clang] 77a9e0a - Basic: Split out DirectoryEntry.h, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-04T14:11:57-05:00 New Revision: 77a9e0a4af5aea3795ed79a0db61ee5b19b837e4 URL: https://github.com/llvm/llvm-project/commit/77a9e0a4af5aea3795ed79a0db61ee5b19b837e4 DIFF: https://github.com/llvm/llvm-project/commit/77a9e0a4af5aea3795ed79a0db61ee5b19b8

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:198 break; + case NeoverseV1: +PrefFunctionLogAlignment = 4; Please put with the other cpus above. Comment at: llvm/lib/Target/AArch64/AArch64Subt

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; aaron.ballman wrote: > gulfem wrote: > > aaron.ballman wrote: > >

[PATCH] D90486: [NewPM] Add OptimizationLevel param to TargetMachine::registerPassBuilderCallbacks()

aeubanks added inline comments. Comment at: llvm/lib/Target/BPF/BPFTargetMachine.cpp:129 bool DebugPassManager) { PB.registerPipelineStartEPCallback([=](ModulePassManager &MPM) { FunctionPassManager FPM(DebugPassManager

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

mibintc added a comment. In D90714#2372458 , @dblaikie wrote: > Test case? Thanks, done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90714/new/ https://reviews.llvm.org/D90714 ___

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

mibintc updated this revision to Diff 302902. mibintc added a comment. Add lit test case, based on test case in bug report Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90714/new/ https://reviews.llvm.org/D90714 Files: clang/lib/AST/MicrosoftMan

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0d43b58b109: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts (authored by cchen). Repository: rG LLVM Github Mon

[clang] d0d43b5 - [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

Author: cchen Date: 2020-11-04T12:36:57-06:00 New Revision: d0d43b58b109c2945e30d0bfabe77d3dcf1e4ad5 URL: https://github.com/llvm/llvm-project/commit/d0d43b58b109c2945e30d0bfabe77d3dcf1e4ad5 DIFF: https://github.com/llvm/llvm-project/commit/d0d43b58b109c2945e30d0bfabe77d3dcf1e4ad5.diff LOG: [O

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90704/new/ https://reviews.llvm.org/D90704 ___ c

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen updated this revision to Diff 302898. cchen added a comment. Refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90704/new/ https://reviews.llvm.org/D90704 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime

[PATCH] D90775: [clangd] ExternalIndex turns off BackgroundIndex only if it isn't set

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: ormris, MaskRay, ilya-biryukov. This will enable users to have a `B

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 302894. Conanap marked an inline comment as done. Conanap added a comment. Updated a test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:617 + StringRef ParentName, unsigned LineNum, + bool Registered = true) const; /// brief Applies action \a Action on all registere

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap marked an inline comment as done. Conanap added a comment. The unrelated change no longer shows as diff, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 __

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 302886. Conanap marked 5 inline comments as done. Conanap added a comment. Addressed some formatting problems as well as corrected incorrect arguments for Hi case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D90188: Add support for attribute 'using_if_exists'

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5273 + namespace empty_namespace {}; + using empty_namespace::does_not_exist __attribute__((using_if_exists)); // no error! + Mordante wrote: > erik.pilkington wrote: > > aa

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen updated this revision to Diff 302884. cchen added a comment. Fix coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90704/new/ https://reviews.llvm.org/D90704 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenM

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen updated this revision to Diff 302882. cchen edited the summary of this revision. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90704/new/ https://reviews.llvm.org/D90704 Files: clang/lib/CodeGen

[PATCH] D90221: Include more attribute details when dumping AST in JSON

aaron.ballman added a comment. In D90221#2358469 , @aronsky wrote: > In D90221#2357060 , @aaron.ballman > wrote: > >> In D90221#2356110 , @aronsky wrote: >> >>> In D90221#

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

eduucaldas updated this revision to Diff 302879. eduucaldas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90240/new/ https://reviews.llvm.org/D90240 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/Tooling/Syn

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

eduucaldas added a comment. As we discussed offline we will probably not provide `replaceChildRange` in the public mutations API anymore. As a result I don't think we should be chaining changes related to `replaceChildRange` in this patch, and thus it should be ready to go. Repository: rG L

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2958-2970 +auto PerDevice = OffloadEntriesTargetRegion.find(DeviceID); +if (PerDevice != OffloadEntriesTargetRegion.end()) { + auto PerFile = PerDevice->second.find(FileID); + if (P

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2958-2970 +auto PerDevice = OffloadEntriesTargetRegion.find(DeviceID); +if (PerDevice != OffloadEntriesTargetRegion.end()) { + auto PerFile = PerDevice->second.find(FileID); + if (Per

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl added a comment. In D90174#2373829 , @yaxunl wrote: > In D90174#2371577 , @rjmccall wrote: > >> Hmm. Do we actually want this behavior of `fast` overriding pragmas? What >> do other compilers do here? It

[PATCH] D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array.

erichkeane added a comment. Ping! This was requested in post-commit on the last patch, so I'm hoping it shouldn't be too controversial. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88298/new/ https://reviews.llvm.org/D88298 ___ cfe-commits

[PATCH] D90188: Add support for attribute 'using_if_exists'

Mordante added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5273 + namespace empty_namespace {}; + using empty_namespace::does_not_exist __attribute__((using_if_exists)); // no error! + erik.pilkington wrote: > aaron.ballman wrote: > > er

[PATCH] D90552: [clangd] Set the User option for clang-tidy to mimick its behaviour

njames93 updated this revision to Diff 302871. njames93 marked an inline comment as done. njames93 added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90552/new/ https://reviews.llvm.org/D90552 Files: clang-tools-extra/clang

[PATCH] D90552: [clangd] Set the User option for clang-tidy to mimick its behaviour

njames93 added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:812 +EmptyDefaults.User = llvm::sys::Process::GetEnv("USER"); +if (!EmptyDefaults.User) + EmptyDefaults.User = llvm::sys::Process::GetEnv("USEUSERNAMER"); sammcc

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2958-2970 +auto PerDevice = OffloadEntriesTargetRegion.find(DeviceID); +if (PerDevice != OffloadEntriesTargetRegion.end()) { + auto PerFile = PerDevice->second.find(FileID); + if (Per

[PATCH] D79279: Add overloaded versions of builtin mem* functions

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I went through all the comments here, plus looked at the code myself. I believe all of the comments by other reviewers have been fixed/answered acceptably. I don't have any additional

[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

eduucaldas added a comment. > Compared to Dmitri's prototype, Nodes.td looks more like a class hierarchy and > less like a grammar. (E.g. variants list the Alternatives parent rather than > vice versa). > e.g. we may introduce abstract bases like "loop" that the grammar doesn't > care about in

[PATCH] D90552: [clangd] Set the User option for clang-tidy to mimick its behaviour

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:812 +EmptyDefaults.User = llvm::sys::Process::GetEnv("USER"); +if (!EmptyDefaults.User) + Empt

[PATCH] D90486: [NewPM] Add OptimizationLevel param to TargetMachine::registerPassBuilderCallbacks()

ychen added inline comments. Comment at: llvm/lib/Target/BPF/BPFTargetMachine.cpp:129 bool DebugPassManager) { PB.registerPipelineStartEPCallback([=](ModulePassManager &MPM) { FunctionPassManager FPM(DebugPassManager);

[PATCH] D90531: [clangd] Add clang-tidy options to config

sammccall added a comment. Thank you! This design looks really good, just have some nits on comments, possible simplifications etc. (Sorry about the delay getting to these, on it now!) Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:268 + void checkAdjuster(std::st

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

kpn added a comment. Update for review comments. Comment at: clang/test/CodeGen/builtin_float_strictfp.c:1 +// RUN: %clang_cc1 -emit-llvm -triple x86_64-windows-pc -ffp-exception-behavior=maytrap -o - %s | FileCheck %s --check-prefixes=CHECK,FP16 +// RUN: %clang_cc1 -emit-llv

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl added a comment. In D90174#2371577 , @rjmccall wrote: > Hmm. Do we actually want this behavior of `fast` overriding pragmas? What > do other compilers do here? It might be reasonable to just treat this as a > bug. I think clang is just trying

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2851 +// Parse MASM style pseudo prefixes. +// FIXME: This prefix should only be used for MASM, not for intel-syntax. +if (isParsingIntelSyntax()) { epastor

  1   2   >