[PATCH] D90572: [clang] [MinGW] Allow using the vptr sanitizer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaae6fdf67e1: [clang] [MinGW] Allow using the vptr sanitizer (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D90571: [compiler-rt] [ubsan] Use the itanium type info lookup for mingw targets

This revision was automatically updated to reflect the committed changes. Closed by commit rG076d351e8bdd: [compiler-rt] [ubsan] Use the itanium type info lookup for mingw targets (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] eaae6fd - [clang] [MinGW] Allow using the vptr sanitizer

Author: Martin Storsjö Date: 2020-11-03T09:59:09+02:00 New Revision: eaae6fdf67e1f61599331d69a41a7dafe6199667 URL: https://github.com/llvm/llvm-project/commit/eaae6fdf67e1f61599331d69a41a7dafe6199667 DIFF: https://github.com/llvm/llvm-project/commit/eaae6fdf67e1f61599331d69a41a7dafe6199667.diff

[PATCH] D72184: [WIP][BPF] support exchange/compare-and-exchange instruction

yonghong-song updated this revision to Diff 302478. yonghong-song edited the summary of this revision. yonghong-song added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. changed encoding based on internal discussion on encoding add a test Repository: rG LLVM

[PATCH] D89670: [clangd] Store the containing symbol for refs

nridge added a comment. (I will wait for a response about the containers for top-level decls before committing.) Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:803 + + AssertSameContainer("toplevel1", "toplevel2"); + AssertSameContainer("classscope1"

[PATCH] D89670: [clangd] Store the containing symbol for refs

nridge updated this revision to Diff 302471. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89670/new/ https://reviews.llvm.org/D89670 Files: clang-tools-extra/clangd/index/Ref.h clang-tools-extra

[PATCH] D87030: Adapt CastExpr::getSubExprAsWritten to ConstantExpr

sberg added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87030/new/ https://reviews.llvm.org/D87030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D89670: [clangd] Store the containing symbol for refs

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:782 + +EXPECT_EQ(Ref1->Container, Ref2->Container); + }; kadircet wrote: > can you also assert containers here are

[clang] 7a5184e - [scan-build] Fix clang++ pathname again

Author: Stephan Bergmann Date: 2020-11-03T08:17:17+01:00 New Revision: 7a5184ed951ad38d652d7b3c339f4c6ae7842eeb URL: https://github.com/llvm/llvm-project/commit/7a5184ed951ad38d652d7b3c339f4c6ae7842eeb DIFF: https://github.com/llvm/llvm-project/commit/7a5184ed951ad38d652d7b3c339f4c6ae7842eeb.di

[PATCH] D89481: [scan-build] Fix clang++ pathname again

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a5184ed951a: [scan-build] Fix clang++ pathname again (authored by sberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89481/new/ https://reviews.llvm.org

[PATCH] D90654: [clangd] Add index server request logging

kbobyrev accepted this revision. kbobyrev added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:257 + + public: +TextProto(const google::protobuf::Message &M) : M(M) {} nit

[PATCH] D90670: Simplifying memory globalization from the front end to move optimizations to the middle end.

josemonsalve2 created this revision. josemonsalve2 added a reviewer: jdoerfert. Herald added projects: clang, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits. josemonsalve2 requested review of this revision. Herald added a subscriber: sstefan1. Memory globalizatio

[PATCH] D90376: [clangd] Add requests logging to clangd-index-server

kbobyrev abandoned this revision. kbobyrev added a comment. Closed in favor of D90654 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90376/new/ https://reviews.llvm.org/D90376 _

[clang] ee63acc - Put back the test pragma-fp-exc.cpp

Author: Serge Pavlov Date: 2020-11-03T13:18:40+07:00 New Revision: ee63acc37e319cdab6accd677fdf772ea3683867 URL: https://github.com/llvm/llvm-project/commit/ee63acc37e319cdab6accd677fdf772ea3683867 DIFF: https://github.com/llvm/llvm-project/commit/ee63acc37e319cdab6accd677fdf772ea3683867.diff

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 302461. atmnpatel added a comment. try 2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.h

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 302459. atmnpatel added a comment. ignore, testing pre-build bots again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp c

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 302458. atmnpatel added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.h

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

rjmccall added a comment. I agree this is useful. However, you need to update the manual to cover `faststd`. Could you also an IRGen test for this rather than only testing CUDA assembly output? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174

[clang] 0d4e172 - [docs] Fix clang/docs/UsersManual.rst after D87528 & D88446

Author: Fangrui Song Date: 2020-11-02T21:07:15-08:00 New Revision: 0d4e1729e36f6db464adf8342efce9734a1ec1ea URL: https://github.com/llvm/llvm-project/commit/0d4e1729e36f6db464adf8342efce9734a1ec1ea DIFF: https://github.com/llvm/llvm-project/commit/0d4e1729e36f6db464adf8342efce9734a1ec1ea.diff

[PATCH] D90662: [Syntax] Tablegen operator<<(NodeKind). NFC

sammccall created this revision. sammccall added reviewers: eduucaldas, hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90662 Files: clang/lib/Tooling/Syn

[PATCH] D90541: [Syntax] DeclaratorList is a List

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd6f7ee05e90: [Syntax] DeclaratorList is a List (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] dd6f7ee - [Syntax] DeclaratorList is a List

Author: Sam McCall Date: 2020-11-03T03:29:06+01:00 New Revision: dd6f7ee05e90edcca70ab5bb51315b3caba5206c URL: https://github.com/llvm/llvm-project/commit/dd6f7ee05e90edcca70ab5bb51315b3caba5206c DIFF: https://github.com/llvm/llvm-project/commit/dd6f7ee05e90edcca70ab5bb51315b3caba5206c.diff LO

[PATCH] D90659: [Syntax] Tablegen Sequence classes. NFC

sammccall added a comment. Again, the generated code is identical to the code being deleted apart from formatting and the fact that methods are defined inline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90659/new/ https://reviews.llvm.org/D9065

[PATCH] D90659: [Syntax] Tablegen Sequence classes. NFC

sammccall created this revision. sammccall added reviewers: eduucaldas, gribozavr2, hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall requested review of this revision. Similar to the previous patch, this doesn't convert *all* the classes that could be conver

[clang] 8a626f1 - Add textual header PPCTypes.def to module Clang_Basic after D81508

Author: Fangrui Song Date: 2020-11-02T18:23:26-08:00 New Revision: 8a626f1cc478298c8bf5da4b84bb2a3f6ffd01e1 URL: https://github.com/llvm/llvm-project/commit/8a626f1cc478298c8bf5da4b84bb2a3f6ffd01e1 DIFF: https://github.com/llvm/llvm-project/commit/8a626f1cc478298c8bf5da4b84bb2a3f6ffd01e1.diff

[PATCH] D90303: [ASTMatchers] Made isExpandedFromMacro Polymorphic

njames93 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:313 + AST_POLYMORPHIC_SUPPORTED_TYPES(Decl, Stmt, TypeLoc), + std::string, MacroName) { // Verifies that the statement' beginning and end

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo added a comment. In D89936#2364665 , @DmitryPolukhin wrote: > Looks good to me. Thanks @DmitryPolukhin and @njames93 for your help. > This revision is now accepted and ready to land.Fri, Oct 30, 8:57 PM When this patch will be merged and availab

[PATCH] D78807: Fix gendered documentation

keryell added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst:47 The check will give a warning message but will not be able to suggest a fix. The -user need to fix it on his own. +user needs to fix it on their o

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

NoQ added a comment. I don't think you actually need active support for invoking exit handlers path-sensitively at the end of `main()` in order to implement your checker. You can still find out in a path-insensitive manner whether any given function acts as an exit handler, like you already do.

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem marked an inline comment as done. gulfem added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3909 +The ``leaf`` attribute is used as a compiler hint to improve dataflow analysis in library functions. +Functions marked as ``leaf`` attribute are not all

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, some nits Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + } else if (LanguageRequiresProgress()) +LoopMustProgress = true; + Nit: Add braces

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 updated this revision to Diff 302437. njames93 added a comment. Added JsonNodeDumper and argument comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568 Files: clang/include/clang/AST/Decl.h

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

LiuChen3 added inline comments. Comment at: clang/test/CodeGen/X86/ms-inline-asm-prefix.c:1 +// RUN:%clang_cc1 %s -ferror-limit 0 -triple=x86_64-pc-widows-msvc -target-feature +avx512f -target-feature +avx2 -target-feature +avx512vl -fasm-blocks -mllvm -x86-asm-syntax=intel -S

[PATCH] D89481: [scan-build] Fix clang++ pathname again

NoQ added a comment. In D89481#2359093 , @sberg wrote: > Is there a reason why "NoQ accepted this revision." kept this at "Needs > Review" rather than moving it to "This revision is now accepted and ready to > land."? Dunno! I think you should commit th

[PATCH] D90531: [clangd][WIP] Start implementing clang-tidy options into clangd config

njames93 updated this revision to Diff 302431. njames93 added a comment. Rename Tidy to ClangTidy in Fragment Extract CheckOptions logic into a new class DynamicDictParser, this should help if config is extended to load other dictionaries where keys are unknown strings.e Repository: rG LLVM

[clang] 701456b - [darwin] add support for __isPlatformVersionAtLeast check for if (@available)

Author: Alex Lorenz Date: 2020-11-02T16:28:09-08:00 New Revision: 701456b52355c25089e1b536805164570f5def6f URL: https://github.com/llvm/llvm-project/commit/701456b52355c25089e1b536805164570f5def6f DIFF: https://github.com/llvm/llvm-project/commit/701456b52355c25089e1b536805164570f5def6f.diff L

[PATCH] D90367: [darwin] add support for __isPlatformVersionAtLeast check for if (@available)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG701456b52355: [darwin] add support for __isPlatformVersionAtLeast check for if (@available) (authored by arphaman). Repository: rG LLVM Github Mon

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

shafik added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:7866 SourceLocation(), &Context->Idents.get("std"), - /*PrevDecl*/ nullptr); + /*PrevDecl*/ nullptr, false); NS-

[PATCH] D83812: [clang][RelativeVTablesABI] Use dso_local_equivalent rather than emitting stubs

leonardchan updated this revision to Diff 302427. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83812/new/ https://reviews.llvm.org/D83812 Files: clang/lib/CodeGen/CGVTables.cpp clang/test/CodeGenCXX/RelativeVTablesABI/child-inheritted-from-par

[clang] bc847b3 - [cc1as] Close MCAsmParser before MCStreamer

Author: Fangrui Song Date: 2020-11-02T15:56:57-08:00 New Revision: bc847b31435e48ad0e54b322a716a4b9f07bc232 URL: https://github.com/llvm/llvm-project/commit/bc847b31435e48ad0e54b322a716a4b9f07bc232 DIFF: https://github.com/llvm/llvm-project/commit/bc847b31435e48ad0e54b322a716a4b9f07bc232.diff

[PATCH] D50739: Clean up macros to detect underling C library functionality

ldionne added a reviewer: libc++. ldionne added a comment. Is this still relevant? We don't have `_LIBCPP_HAS_C11_FEATURES` anymore. If not relevant, let's close this to clear up the queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50739/new/ https://reviews.llvm.org/D50739 __

[PATCH] D90654: [clangd] Add index server request logging

sammccall created this revision. sammccall added reviewers: kbobyrev, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. - Add verbose logging of payload

[PATCH] D47358: : Implement {un,}synchronized_pool_resource.

Quuxplusone abandoned this revision. Quuxplusone added a comment. Superseded by D89057 . Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47358/new/ https://reviews.llvm.org/D47358 ___

[PATCH] D47360: Implement as a copy of .

Quuxplusone abandoned this revision. Quuxplusone added a comment. Superseded by D89057 . Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47360/new/ https://reviews.llvm.org/D47360 ___

[PATCH] D47111: : Implement monotonic_buffer_resource.

Quuxplusone abandoned this revision. Quuxplusone marked 3 inline comments as done. Quuxplusone added a comment. Sure; not that D89057 is making any //more// progress... :) Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47111/ne

[PATCH] D90481: Basic: Change Module::Umbrella to a PointerUnion, NFC

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, thanks for cleaning it up CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90481/new/ https://reviews.llvm.org/D90481 ___ cfe-commi

[clang] ae9231c - Reland - [Clang] Add the ability to map DLL storage class to visibility

Author: Ben Dunbobbin Date: 2020-11-02T23:24:49Z New Revision: ae9231ca2a8125ce75fff3ff2539126610aa2eeb URL: https://github.com/llvm/llvm-project/commit/ae9231ca2a8125ce75fff3ff2539126610aa2eeb DIFF: https://github.com/llvm/llvm-project/commit/ae9231ca2a8125ce75fff3ff2539126610aa2eeb.diff LOG:

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

tra updated this revision to Diff 302419. tra added a comment. Remove the assert which is no longer valid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88345/new/ https://reviews.llvm.org/D88345 Files: clang/include/clang/Basic/DiagnosticSemaKi

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2369838 , @dschuff wrote: > One other question then: do you know if Debian and/or Ubuntu still have the > same support for running x32 programs on the regular x86-64 distribution? > (presumably yes, since you aren't ch

[PATCH] D90367: [darwin] add support for __isPlatformVersionAtLeast check for if (@available)

arphaman added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:3874 if (!CGM.IsOSVersionAtLeastFn) { llvm::FunctionType *FTy = thakis wrote: > Isn't the rest of the function basically dead code? Do non-darwin targets > support this feature? A

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

rupprecht added a comment. In D87194#2369485 , @aaronpuchert wrote: > @rupprecht, maybe you can try it again? Some more interesting errors this time :) The ones I originally saw look correct now (i.e. it's flagging the things that are valid, but not th

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

dschuff added a comment. One other question then: do you know if Debian and/or Ubuntu still have the same support for running x32 programs on the regular x86-64 distribution? (presumably yes, since you aren't changing the existing behavior). AFAIK clang's current support was developed against Ub

[clang] 0a3ebb4 - Revert "[CUDA] Allow local static variables with target attributes."

Author: Artem Belevich Date: 2020-11-02T15:09:07-08:00 New Revision: 0a3ebb4d8d988e063e395621d162fa224fa4fb08 URL: https://github.com/llvm/llvm-project/commit/0a3ebb4d8d988e063e395621d162fa224fa4fb08 DIFF: https://github.com/llvm/llvm-project/commit/0a3ebb4d8d988e063e395621d162fa224fa4fb08.diff

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf38a9e51178a: [CUDA] Allow local static variables with target attributes. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] f38a9e5 - [CUDA] Allow local static variables with target attributes.

Author: Artem Belevich Date: 2020-11-02T14:37:13-08:00 New Revision: f38a9e51178add132d2c8ae160787fb2175a48a4 URL: https://github.com/llvm/llvm-project/commit/f38a9e51178add132d2c8ae160787fb2175a48a4 DIFF: https://github.com/llvm/llvm-project/commit/f38a9e51178add132d2c8ae160787fb2175a48a4.diff

[PATCH] D88668: [CUDA] Add support for 11.1

tra added a comment. Herald added a subscriber: dexonsmith. This patch is also missing corresponding LLVM changes that define features for sm_86 and ptx71. See https://github.com/llvm/llvm-project/blob/master/llvm/lib/Target/NVPTX/NVPTX.td Comment at: clang/lib/Driver/ToolCh

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

tra added a comment. LGTM, but I'll defer to @rjmccall for the approval. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D90311: [CUDA][HIP] Fix linkage for -fgpu-rdc

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90311/new/ https://reviews.llvm.org/D90311 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D90641: [compiler-rt][AIX]: Link compiler-rt profile library when -fprofile-generate is specified

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90641/new/ https://reviews.llvm.org/D90641 ___ c

[PATCH] D47111: : Implement monotonic_buffer_resource.

ldionne added a comment. Can we please close this review as it's been superseded by D89057 ? Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47111/new/ https://reviews.llvm.org/D47111 ___

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 302407. atmnpatel added a comment. - Added triple to fix mangling errors in test - Modified (unrelated) recently added test to have the mustprogress attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8684

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz updated this revision to Diff 302404. glaubitz added a comment. Regenerated with more context (using git format-patch -W). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52050/new/ https://reviews.llvm.org/D52050 Files: clang/lib/Driver/

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3910 +Functions marked as ``leaf`` attribute are not allowed to enter their caller's translation unit. +Therefore, they cannot use or modify any data that does not escape the current compilation

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2369581 , @dschuff wrote: > Can you upload the diff with full context (e.g. use `diff -U ` or use > arcanist to upload)? > > I'm a bit confused; the commit message talks about X32 being a separate > architecture, b

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

tra added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8163 "%select{__device__|__global__|__host__|__host__ __device__}0 functions">; -def err_cuda_nonglobal_constant : Error<"__constant__ variables must be global">; +def err_cuda_nonstatic

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

dschuff added a comment. Can you upload the diff with full context (e.g. use `diff -U ` or use arcanist to upload)? I'm a bit confused; the commit message talks about X32 being a separate architecture, but you're not adding any new architecture triples here (it still uses x86_64 as the arc

[PATCH] D90646: [clang] Add warning when `-include-pch` is passed multiple times

keith created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. keith requested review of this revision. Previously this argument passed multiple times would result in the first being silently ignored. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

aabbaabb added a comment. I think there are also some patches that only exist here not on that repo so there is no strict upstream/downstream, just two forked versions. Since in our use case, we would likely use this version instead of the python version (easier to update/maintain), I suggest ju

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

tra updated this revision to Diff 302394. tra added a comment. Added few test cases for allowed initializers on device-side static vars. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88345/new/ https://reviews.llvm.org/D88345 Files: clang/includ

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3910 +in library functions. Functions marked with the ``leaf`` attribute are not allowed +to jump back into the caller's translation unit, whether through invoking a +callback function, a direct exte

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

xazax.hun added a comment. In D90362#2369394 , @phosek wrote: > What's the plan regarding updating scan-build-py to match the upstream? It > seems like this issue has already been address in the upstream version. As far as I understand, the author is no

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

aaronpuchert added a subscriber: rupprecht. aaronpuchert added a comment. @rupprecht, maybe you can try it again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87194/new/ https://reviews.llvm.org/D87194

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

aaronpuchert updated this revision to Diff 302388. aaronpuchert marked 2 inline comments as done. aaronpuchert added a comment. Rebased on D84604 , included static members, and addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

aaronpuchert added inline comments. Comment at: clang/test/SemaCXX/warn-thread-safety-negative.cpp:158 +} + } // end namespace ScopeTest aaron.ballman wrote: > Given that this is touching on declaration contexts, it would also be good to > have some tests chec

[PATCH] D90641: [compiler-rt][AIX]: Link compiler-rt profile library when -fprofile-generate is specified

etiotto created this revision. etiotto added reviewers: Whitney, daltenty, hubert.reinterpretcast, cebowleratibm, phosek. Herald added subscribers: cfe-commits, dberris. Herald added a project: clang. etiotto requested review of this revision. This patch enhances the clang driver to link the runt

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

phosek added a comment. What's the plan regarding updating scan-build-py to match the upstream? It seems like this issue has already been address in the upstream version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90362/new/ https://reviews.llv

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

Mordante added a comment. Just a few minor nits. I'll leave the approving to the other reviewers. Comment at: clang/lib/AST/TextNodeDumper.cpp:1828 + if (D->isNested()) +OS << " nested"; if (!D->isOriginalNamespace()) Can you also modify `JSONNodeDumper

[PATCH] D89836: Change Module::ASTFile and ModuleFile::File => Optional, NFC

dexonsmith added a comment. Note: the bots revealed I needed another update for some host compilers, which I pushed in 5cb8d93205463f169ad4dd532829147fed2e38d0 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

rjmccall added a comment. Pointer authentication can also make structs non-trivial to copy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83448/new/ https://reviews.llvm.org/D83448 ___ cfe-commits mailin

[clang] 5cb8d93 - Fix build error on bots after 9f151df17800e1668c32e5314a290ae94c8f2dd3

Author: Duncan P. N. Exon Smith Date: 2020-11-02T15:55:13-05:00 New Revision: 5cb8d93205463f169ad4dd532829147fed2e38d0 URL: https://github.com/llvm/llvm-project/commit/5cb8d93205463f169ad4dd532829147fed2e38d0 DIFF: https://github.com/llvm/llvm-project/commit/5cb8d93205463f169ad4dd532829147fed2e

[PATCH] D90571: [compiler-rt] [ubsan] Use the itanium type info lookup for mingw targets

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90571/new/ https://reviews.llvm.org/D90571 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante planned changes to this revision. Mordante marked 2 inline comments as done. Mordante added a comment. Then me try to clear up the confusion. The parser first parses the `LabelDecl` and tries to attach the attributes to this declaration. If that fails instead of issue a diagnostic for a

[PATCH] D90571: [compiler-rt] [ubsan] Use the itanium type info lookup for mingw targets

mstorsjo updated this revision to Diff 302374. mstorsjo added a comment. Just checking `_MSC_VER` instead of checking `SANITIZER_WINDOWS && !__MINGW32__`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90571/new/ https://reviews.llvm.org/D90571 Files: compiler-rt/lib/ubsan/ubsan_type

[clang-tools-extra] 65eaec9 - [clangd] Add -log=public to redact all request info from index server logs

Author: Sam McCall Date: 2020-11-02T21:25:12+01:00 New Revision: 65eaec9bd3f23f113a195edf8f2d544ec8e34b4e URL: https://github.com/llvm/llvm-project/commit/65eaec9bd3f23f113a195edf8f2d544ec8e34b4e DIFF: https://github.com/llvm/llvm-project/commit/65eaec9bd3f23f113a195edf8f2d544ec8e34b4e.diff LO

[PATCH] D90526: [clangd] Add -log=public to redact all request info from index server logs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG65eaec9bd3f2: [clangd] Add -log=public to redact all request info from index server logs (authored by sammccall). Changed prior to commit: https:/

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem updated this revision to Diff 302369. gulfem added a comment. Update the attribute documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 Files: clang/include/clang/Basic/Attr.td clang/inc

[PATCH] D90571: [compiler-rt] [ubsan] Use the itanium type info lookup for mingw targets

rnk added inline comments. Comment at: compiler-rt/lib/ubsan/ubsan_type_hash_itanium.cpp:15 #include "ubsan_platform.h" -#if CAN_SANITIZE_UB && !SANITIZER_WINDOWS +#if CAN_SANITIZE_UB && (!SANITIZER_WINDOWS || defined(__MINGW32__)) #include "ubsan_type_hash.h"

[clang] 537cc6d - Rename CXXUnresolvedConstructExpr::arg_size for consistency

Author: Stephen Kelly Date: 2020-11-02T20:21:48Z New Revision: 537cc6dd2b36a7219a9bbaa6bc6f32c99a1baae1 URL: https://github.com/llvm/llvm-project/commit/537cc6dd2b36a7219a9bbaa6bc6f32c99a1baae1 DIFF: https://github.com/llvm/llvm-project/commit/537cc6dd2b36a7219a9bbaa6bc6f32c99a1baae1.diff LOG:

[clang] 53df3be - Ignore template instantiations if not in AsIs mode

Author: Stephen Kelly Date: 2020-11-02T20:21:48Z New Revision: 53df3beb624989ed32d87697d0c17601d7871465 URL: https://github.com/llvm/llvm-project/commit/53df3beb624989ed32d87697d0c17601d7871465 DIFF: https://github.com/llvm/llvm-project/commit/53df3beb624989ed32d87697d0c17601d7871465.diff LOG:

[PATCH] D80961: [clang][AST] Ignore template instantiations if not in AsIs mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53df3beb6249: Ignore template instantiations if not in AsIs mode (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D80

[PATCH] D90553: Rename CXXUnresolvedConstructExpr::arg_size for consistency

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG537cc6dd2b36: Rename CXXUnresolvedConstructExpr::arg_size for consistency (authored by stephenkelly). Changed prior to commit: https://reviews.llv

[clang] 9f151df - Change Module::ASTFile and ModuleFile::File => Optional, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-02T15:11:51-05:00 New Revision: 9f151df17800e1668c32e5314a290ae94c8f2dd3 URL: https://github.com/llvm/llvm-project/commit/9f151df17800e1668c32e5314a290ae94c8f2dd3 DIFF: https://github.com/llvm/llvm-project/commit/9f151df17800e1668c32e5314a290ae94c8f

[PATCH] D89836: Change Module::ASTFile and ModuleFile::File => Optional, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f151df17800: Change Module::ASTFile and ModuleFile::File => Optional, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] c29513f - [clangd] Fix check-clangd with no clang built

Author: Sam McCall Date: 2020-11-02T21:10:43+01:00 New Revision: c29513f7e023f125c6d221db179dc40b79e5c074 URL: https://github.com/llvm/llvm-project/commit/c29513f7e023f125c6d221db179dc40b79e5c074 DIFF: https://github.com/llvm/llvm-project/commit/c29513f7e023f125c6d221db179dc40b79e5c074.diff LO

[PATCH] D90528: [clangd] Fix check-clangd with no clang built

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc29513f7e023: [clangd] Fix check-clangd with no clang built (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D90528?vs=3

[PATCH] D90436: [Bundler] Use argv[0] as the default choice for the Executable name.

sfantao added a comment. @tra, thank you for the patch. This makes sense. The patch looks good but it has to be someone else to okay it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90436/new/ https://reviews.llvm.org/D90436

[PATCH] D90526: [clangd] Add -log=public to redact all request info from index server logs

sammccall updated this revision to Diff 302360. sammccall added a comment. Use separate flag for log-public vs log level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90526/new/ https://reviews.llvm.org/D90526 Files: clang-tools-extra/clangd/ind

[PATCH] D78899: [Driver] Add callback to Command execution

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Compilation.h:118 + /// Callback called after the command has been executed. + std::function PostCallback; Can you comment what `int` means? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D90436: [Bundler] Use argv[0] as the default choice for the Executable name.

tra added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90436/new/ https://reviews.llvm.org/D90436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D78899: [Driver] Add callback to Command execution

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78899/new/ https://reviews.llvm.org/D78899

  1   2   >