aaronpuchert added inline comments.

================
Comment at: clang/test/SemaCXX/warn-thread-safety-negative.cpp:158
+}
+
 }  // end namespace ScopeTest
----------------
aaron.ballman wrote:
> Given that this is touching on declaration contexts, it would also be good to 
> have some tests checking for differences between declaration contexts (like 
> out-of-line method definitions)
Isn't there a semantic and a lexical declaration context, and aren't we 
consistently using the semantic context?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87194/new/

https://reviews.llvm.org/D87194

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to