[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Does anyone know why Harbormaster doesn't rebuild this revision after I update it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___

[PATCH] D89105: [X86] Support Intel avxvnni

LiuChen3 marked 2 inline comments as done. LiuChen3 added a comment. Thanks for all of your review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89105/new/ https://reviews.llvm.org/D89105 ___ cfe-commit

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. Reply code review suggestions. I will upload my change later. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:483 + std::move(CaseOptional), std::move(Prefix), std::move(Postfix), + std::move(HPOpt), HN

[clang] dd8297b - PR42513: Fix handling of function definitions lazily instantiated from

Author: Richard Smith Date: 2020-10-30T18:35:12-07:00 New Revision: dd8297b0669f8e69b03ba40171b195b5acf0f963 URL: https://github.com/llvm/llvm-project/commit/dd8297b0669f8e69b03ba40171b195b5acf0f963 DIFF: https://github.com/llvm/llvm-project/commit/dd8297b0669f8e69b03ba40171b195b5acf0f963.diff

[PATCH] D90518: [clangd] Make tests depend on Clang

smeenai created this revision. smeenai added reviewers: jkorous, kadircet, sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. smeenai requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The clangd lit confi

[PATCH] D90516: [clang] Limit scope of CLANG_VENDOR definition

smeenai created this revision. smeenai added reviewers: beanz, compnerd, phosek, tstellar. Herald added subscribers: cfe-commits, dexonsmith, mgorny. Herald added a project: clang. smeenai requested review of this revision. It's only used by Version.cpp, so limit the definition to just that one fi

[PATCH] D90517: [clangd] Account for vendor in version string

smeenai created this revision. smeenai added reviewers: sammccall, kadircet, hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. smeenai requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The vendor will be prefixed t

[clang] a787e09 - [WebAssembly] Prototype i64x2.bitmask

Author: Thomas Lively Date: 2020-10-30T17:23:30-07:00 New Revision: a787e0977912d53b7177e5c97e6e465be46285a2 URL: https://github.com/llvm/llvm-project/commit/a787e0977912d53b7177e5c97e6e465be46285a2 DIFF: https://github.com/llvm/llvm-project/commit/a787e0977912d53b7177e5c97e6e465be46285a2.diff

[PATCH] D90514: [WebAssembly] Prototype i64x2.bitmask

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa787e0977912: [WebAssembly] Prototype i64x2.bitmask (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D90514: [WebAssembly] Prototype i64x2.bitmask

tlively added a comment. Thanks for all the reviews! That's the last of them for now :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90514/new/ https://reviews.llvm.org/D90514 ___ cfe-commits mailing li

[PATCH] D89087: [MemProf] Pass down memory profile name with optional path from clang

tejohnson added a comment. In D89087#2359962 , @davidxl wrote: > There should be a related LLVM side of changes. Is it in a different patch? That's here too. See the change in llvm/lib/Transforms/Instrumentation/MemProfiler.cpp and a related test (they

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added a comment. Even GLOBAL may have a better addressing mode, the unpromotable `alloca` resolved in this change has an even significant performance issue. We could favor GLOBAL LOAD/STORE for kernel function as I proposed in other threads but, considering that an aggregate argument may

[PATCH] D90514: [WebAssembly] Prototype i64x2.bitmask

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. tlively requested review of this revision. As proposed in https://git

[PATCH] D90508: [WebAssembly] Prototype i64x2.eq

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a512a555a8d: [WebAssembly] Prototype i64x2.eq (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang] 0a512a5 - [WebAssembly] Prototype i64x2.eq

Author: Thomas Lively Date: 2020-10-30T16:38:15-07:00 New Revision: 0a512a555a8dbcd00eeaff5aaa14842f8614c2b4 URL: https://github.com/llvm/llvm-project/commit/0a512a555a8dbcd00eeaff5aaa14842f8614c2b4 DIFF: https://github.com/llvm/llvm-project/commit/0a512a555a8dbcd00eeaff5aaa14842f8614c2b4.diff

[clang-tools-extra] 8a28a29 - [clang-tidy][test] Fix test failure when LLVM_ENABLE_WERROR is set.

Author: Nathan James Date: 2020-10-30T23:17:11Z New Revision: 8a28a29c736e6ae88c86a8687e61a62b41e1c430 URL: https://github.com/llvm/llvm-project/commit/8a28a29c736e6ae88c86a8687e61a62b41e1c430 DIFF: https://github.com/llvm/llvm-project/commit/8a28a29c736e6ae88c86a8687e61a62b41e1c430.diff LOG:

[clang] 1cb0b56 - [WebAssembly] Prototype i64x2.widen_{low, high}_i32x4_{s, u}

Author: Thomas Lively Date: 2020-10-30T15:44:04-07:00 New Revision: 1cb0b5660777cb563637ff6bb80722f449ee97eb URL: https://github.com/llvm/llvm-project/commit/1cb0b5660777cb563637ff6bb80722f449ee97eb DIFF: https://github.com/llvm/llvm-project/commit/1cb0b5660777cb563637ff6bb80722f449ee97eb.diff

[PATCH] D90504: [WebAssembly] Prototype i64x2.widen_{low,high}_i32x4_{s,u}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cb0b5660777: [WebAssembly] Prototype i64x2.widen_{low,high}_i32x4_{s,u} (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

aaronpuchert added a comment. In D88295#2365474 , @rsmith wrote: > ... where `X` has a volatile copy constructor and a volatile move > constructor, I think we should produce the warning suggesting use of > `std::move`. If I read this correctly, we'd hav

[PATCH] D90508: [WebAssembly] Prototype i64x2.eq

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. tlively requested review of this revision. As proposed in https://git

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo created this revision. ayermolo added a reviewer: llvm-commits. Herald added subscribers: cfe-commits, dexonsmith, wenlei, dang. Herald added a project: clang. ayermolo requested review of this revision. @ikudrin enabled support for dwarf64 in D87011 . A

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

majnemer added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2782 + +// construct the vector of 'unsigned char' type +QualType CharVecTy = Ctx.getVectorType(Ctx.CharTy, NumVectorBytes, The code as written seems to be 'char' type, not 'uns

[PATCH] D90504: [WebAssembly] Prototype i64x2.widen_{low,high}_i32x4_{s,u}

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. tlively requested review of this revision. As proposed in https://git

[PATCH] D90497: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

dexonsmith updated this revision to Diff 302022. dexonsmith edited the summary of this revision. dexonsmith added a comment. Removed the `FIXME`s about the `...AsWritten` fields, as I just took a deeper look and we need them. The headers/etc. are looked up in the `FileManager` with the module di

[PATCH] D90497: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Push `FileEntryRef` and `DirectoryEntryRef` further, using it them `Module::Umbrella`, `Module::Header::Entry`, and `Module::Dire

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

dexonsmith updated this revision to Diff 302010. dexonsmith added a comment. Rebase on top of 814141f9bd0a64bbedae05773972d140f04f654d . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90484/new/ https://reviews.llvm.or

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

Quuxplusone added a comment. > So, how about we add another `CES` flag As the original author of `CES_AsIfByStdMove`, I am opposed to any attempt to complicate this patch. My medium-term goal, now that P1155 has been adopted, is to //eliminate// the complexity

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage

dexonsmith added a comment. In D89834#2365358 , @dexonsmith wrote: > Just pushed again in ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 > ; bots > look happier with this version. Not all of

[clang] bbf02e1 - [clang][NFC] Remove unused FileCheck prefix

Author: Keith Smiley Date: 2020-10-30T13:32:14-07:00 New Revision: bbf02e18f53681c079f7a88b2726d0714d92e1a0 URL: https://github.com/llvm/llvm-project/commit/bbf02e18f53681c079f7a88b2726d0714d92e1a0 DIFF: https://github.com/llvm/llvm-project/commit/bbf02e18f53681c079f7a88b2726d0714d92e1a0.diff

[PATCH] D90430: [clang][NFC] Remove unused FileCheck prefix

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbf02e18f536: [clang][NFC] Remove unused FileCheck prefix (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] 814141f - Remove `noexcept` from ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 to fix bots

Author: Duncan P. N. Exon Smith Date: 2020-10-30T16:29:16-04:00 New Revision: 814141f9bd0a64bbedae05773972d140f04f654d URL: https://github.com/llvm/llvm-project/commit/814141f9bd0a64bbedae05773972d140f04f654d DIFF: https://github.com/llvm/llvm-project/commit/814141f9bd0a64bbedae05773972d140f04f

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

aaronpuchert added a comment. In D88295#2365474 , @rsmith wrote: > The other is whether implicitly move in a `co_return` statement. In that > case, I think the use of `CES_AsIfByStdMove` is a mistake, and we should be > using `CES_Default` there. I did

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

rsmith added a comment. In D88295#2365312 , @Quuxplusone wrote: > I believe the organization of that directory implies that the path should be > `class/class.init/class.copy.elision/`, not `special/class.copy/`. > Otherwise LGTM, and I like this new test

[PATCH] D90424: AArch64: Use SBFX instead of UBFX to extract address granule in outlined HWASan checks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9b1a2b41dca: AArch64: Use SBFX instead of UBFX to extract address granule in outlined HWASan… (authored by pcc). Repository: rG LLVM Github Monor

[clang] c9b1a2b - AArch64: Use SBFX instead of UBFX to extract address granule in outlined HWASan checks.

Author: Peter Collingbourne Date: 2020-10-30T12:53:15-07:00 New Revision: c9b1a2b41dca6e6734aa39833a0dab0d0a8b53d3 URL: https://github.com/llvm/llvm-project/commit/c9b1a2b41dca6e6734aa39833a0dab0d0a8b53d3 DIFF: https://github.com/llvm/llvm-project/commit/c9b1a2b41dca6e6734aa39833a0dab0d0a8b53d3

[PATCH] D90422: AArch64: Switch to x20 as the shadow base register for outlined HWASan checks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3859fc653fb4: AArch64: Switch to x20 as the shadow base register for outlined HWASan checks. (authored by pcc). Repository: rG LLVM Github Monorep

[clang] 3859fc6 - AArch64: Switch to x20 as the shadow base register for outlined HWASan checks.

Author: Peter Collingbourne Date: 2020-10-30T12:51:30-07:00 New Revision: 3859fc653fb49f4acfb61b6f2c38736ec9bfae06 URL: https://github.com/llvm/llvm-project/commit/3859fc653fb49f4acfb61b6f2c38736ec9bfae06 DIFF: https://github.com/llvm/llvm-project/commit/3859fc653fb49f4acfb61b6f2c38736ec9bfae06

[PATCH] D90430: [clang][NFC] Remove unused FileCheck prefix

mtrofin accepted this revision. mtrofin added a comment. In D90430#2365397 , @google-llvm-upstream-contributions wrote: > lgtm ugh, sorry, that's an alias I am auto-logged in on my personal account. Still LGTM :) Repository: rG LLVM Github Monorepo

[PATCH] D90430: [clang][NFC] Remove unused FileCheck prefix

google-llvm-upstream-contributions accepted this revision. google-llvm-upstream-contributions added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90430/new/ https://reviews.llvm.org/D

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

dexonsmith updated this revision to Diff 301989. dexonsmith added a comment. Rebased on top of ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90484/new/ https://reviews.llvm.o

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

rupprecht added a comment. In D84604#2364568 , @aaronpuchert wrote: > In D84604#2363768 , @rupprecht wrote: > >> I applied D87194 locally and rebuilt the >> original source, and n

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage

dexonsmith added a comment. Just pushed again in ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 ; bots look happier with this version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D898

[PATCH] D90419: [AMDGPU] Add gfx90c target

scott.linder added inline comments. Comment at: llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml:161 # RUN: yaml2obj --docnum=41 %s > %t.o.41 # RUN: llvm-readobj -s -file-headers %t.o.41 | FileCheck --check-prefixes=ELF-ALL,ELF-GFX1031 %s Heads up, I just

[clang] ac49500 - Reapply "FileManager: Improve the FileEntryRef API and customize its OptionalStorage"

Author: Duncan P. N. Exon Smith Date: 2020-10-30T15:06:01-04:00 New Revision: ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 URL: https://github.com/llvm/llvm-project/commit/ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 DIFF: https://github.com/llvm/llvm-project/commit/ac49500cd0484e1b2dcf37fa4c0dade6f113

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

rsmith added inline comments. Comment at: clang/docs/LanguageExtensions.rst:466 + typedef bool bool4 __attribute__((ext_vector_type(4))); + // Objects of bool8 type hold 8 bits, sizeof(bool8) == 1 + Comment talks about `bool8` but we defined the type `bool4`.

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added a comment. Herald added a subscriber: dexonsmith. I'm going to follow up with another RFC about this on llvm-dev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83088/new/ https://reviews.llvm.org/D83088 _

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

Quuxplusone added a comment. I believe the organization of that directory implies that the path should be `class/class.init/class.copy.elision/`, not `special/class.copy/`. Otherwise LGTM, and I like this new test better than the old one! I still can't help re actually landing this patch, as I do

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/FileEntry.h:186 + + constexpr bool hasValue() const noexcept { +return MaybeRef.hasOptionalValue(); danielkiss wrote: > This broke the build, `constexpr` could be dropped IMHO. > FileEnt

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage

danielkiss added inline comments. Herald added a subscriber: ormris. Comment at: clang/include/clang/Basic/FileEntry.h:186 + + constexpr bool hasValue() const noexcept { +return MaybeRef.hasOptionalValue(); This broke the build, `constexpr` could be dropped

[PATCH] D90434: [CodeGen] Correct codegen for self-capturing __block var

ille updated this revision to Diff 301966. ille added a comment. Satisfy clang-format bot, at the cost of formatting a few adjacent lines. The other bot failures seem pretty clearly unrelated to this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D90447: [AMDGPU] Add gfx1033 target

t-tye added inline comments. Comment at: llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-headers.test:61-64 +# RUN: yaml2obj %s -o %t -DCPU=GFX90C +# RUN: llvm-readobj -h %t | FileCheck %s --match-full-lines -DFILE=%t -DCPU=GFX90C -DFLAGS=0x32 + # RUN: yaml2obj %s -o %t -DCPU=GFX10

[PATCH] D90447: [AMDGPU] Add gfx1033 target

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90447/new/ https://reviews.llvm.org/D90447 _

[PATCH] D90447: [AMDGPU] Add gfx1033 target

t-tye requested changes to this revision. t-tye added inline comments. This revision now requires changes to proceed. Comment at: llvm/docs/AMDGPUUsage.rst:317 + names. + ``gfx1033``

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

Mordante marked an inline comment as done. Mordante added a comment. Thanks for the review. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3161 + InGroup; +def note_attribute_has_no_effect_here : Note< + "annotating the %select{infinite loop}0 here">; -

[PATCH] D90336: [Sema] Diagnose annotating `if constexpr` with a likelihood attribute

Mordante marked an inline comment as done. Mordante added a comment. Thanks for the review! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3163 def note_attribute_has_no_effect_here : Note< - "annotating the %select{infinite loop}0 here">; + "annotating the %se

[clang] 940d0a3 - Revert "FileManager: Improve the FileEntryRef API and customize its OptionalStorage" and follow-ups

Author: Duncan P. N. Exon Smith Date: 2020-10-30T14:06:55-04:00 New Revision: 940d0a310dca31ae97080b068cef92eadfee6367 URL: https://github.com/llvm/llvm-project/commit/940d0a310dca31ae97080b068cef92eadfee6367 DIFF: https://github.com/llvm/llvm-project/commit/940d0a310dca31ae97080b068cef92eadfee

[clang] 5530fb5 - Speculative fix for bots after 84e8257937ec6a332aa0b688f4dce57016516ffd, v2

Author: Duncan P. N. Exon Smith Date: 2020-10-30T14:04:48-04:00 New Revision: 5530fb586f30da9dcb434f6be39198dbf016b866 URL: https://github.com/llvm/llvm-project/commit/5530fb586f30da9dcb434f6be39198dbf016b866 DIFF: https://github.com/llvm/llvm-project/commit/5530fb586f30da9dcb434f6be39198dbf016

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

aaron.ballman added a comment. In D83717#2364187 , @gamesh411 wrote: > In D83717#2279263 , @aaron.ballman > wrote: > >> One of the concerns I have with this not being a cfg-only check is that most >> of the bad si

[clang] 010238a - Speculative fix for bots after 84e8257937ec6a332aa0b688f4dce57016516ffd

Author: Duncan P. N. Exon Smith Date: 2020-10-30T14:01:01-04:00 New Revision: 010238a296e61cbf6f4d7f4383e26cf00c4e4992 URL: https://github.com/llvm/llvm-project/commit/010238a296e61cbf6f4d7f4383e26cf00c4e4992 DIFF: https://github.com/llvm/llvm-project/commit/010238a296e61cbf6f4d7f4383e26cf00c4e

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks added a comment. https://reviews.llvm.org/D90486 for adding OptimizationLevel to registerPassBuilderCallbacks(), although this one should land first since that one needs to update PassBuilder::runRegisteredEPCallbacks() to call TargetMachine::registerPassBuilderCallbacks() Repository

[PATCH] D90486: [NewPM] Add OptimizationLevel param to TargetMachine::registerPassBuilderCallbacks()

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, steven_wu, hiraditya, tpr, mgorny. Herald added a reviewer: bollu. Herald added projects: clang, LLVM. aeubanks requested review of this revision. To prevent targets from adding optional passes for -O0, TargetMac

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

rjmccall added a comment. I may not have been clear. I'm not saying SourceLocation is a meaningful concept in the driver. I'm saying that if you generalize the concept of "source location" to "location in the input", there is a clear analogue in the driver (namely, a position in the argument

[PATCH] D90485: Lex: Update Module::findHeader to return FileEntryRef, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Update `Module::findHeader` to return `Optional` and fix its one caller. https://reviews.llvm.org/D90485 Files: clang/includ

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Add `FileEntryRef::getDir`, which returns a `DirectoryEntryRef`. This includes a few changes: - Customize `OptionalStorage` so t

[PATCH] D90447: [AMDGPU] Add gfx1033 target

tpr updated this revision to Diff 301953. tpr added a comment. Herald added subscribers: emaste, jholewinski. Herald added a reviewer: espindola. V3: Add missing bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90447/new/ https://reviews.llvm.or

[PATCH] D90481: Basic: Change Module::Umbrella to a PointerUnion, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Change `Module::Umbrella` from a `const void *` to a `PointerUnion` of `FileEntry` and `DirectoryEntry`. We can drop the `HasUmbr

[PATCH] D90478: Basic: Split out DirectoryEntry.h, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Move `DirectoryEntry` and `DirectoryEntryRef` into their own header, similar to the creation of FileEntry.h. No functionality cha

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage

This revision was automatically updated to reflect the committed changes. Closed by commit rG84e8257937ec: FileManager: Improve the FileEntryRef API and customize its OptionalStorage (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 84e8257 - FileManager: Improve the FileEntryRef API and customize its OptionalStorage

Author: Duncan P. N. Exon Smith Date: 2020-10-30T13:25:46-04:00 New Revision: 84e8257937ec6a332aa0b688f4dce57016516ffd URL: https://github.com/llvm/llvm-project/commit/84e8257937ec6a332aa0b688f4dce57016516ffd DIFF: https://github.com/llvm/llvm-project/commit/84e8257937ec6a332aa0b688f4dce5701651

[clang] 2177e45 - PR47861: Expand dangling reference warning to look through copy

Author: Richard Smith Date: 2020-10-30T10:19:50-07:00 New Revision: 2177e4555ab84771c611a3295ab1149af7f79c29 URL: https://github.com/llvm/llvm-project/commit/2177e4555ab84771c611a3295ab1149af7f79c29 DIFF: https://github.com/llvm/llvm-project/commit/2177e4555ab84771c611a3295ab1149af7f79c29.diff

[PATCH] D90437: [NFC] Clean up PassBuilder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e31727a884a: [NFC] Clean up PassBuilder (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 2e31727 - [NFC] Clean up PassBuilder

Author: Arthur Eubanks Date: 2020-10-30T10:03:59-07:00 New Revision: 2e31727a884affa11f2955ddfa40590715f144df URL: https://github.com/llvm/llvm-project/commit/2e31727a884affa11f2955ddfa40590715f144df DIFF: https://github.com/llvm/llvm-project/commit/2e31727a884affa11f2955ddfa40590715f144df.diff

[clang] e5699b8 - [clang][driver] Rename DriverOption as NoXarchOption (NFC)

Author: Andrzej Warzynski Date: 2020-10-30T17:00:06Z New Revision: e5699b8ff1b6ea68e77dffb037e1c5d612131580 URL: https://github.com/llvm/llvm-project/commit/e5699b8ff1b6ea68e77dffb037e1c5d612131580 DIFF: https://github.com/llvm/llvm-project/commit/e5699b8ff1b6ea68e77dffb037e1c5d612131580.diff

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5699b8ff1b6: [clang][driver] Rename DriverOption as NoXarchOption (NFC) (authored by awarzynski). Changed prior to commit: https://reviews.llvm.o

[PATCH] D89158: [NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0

aeubanks updated this revision to Diff 301937. aeubanks retitled this revision from "[NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0 " to "[NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0". aeubanks added a comment. revert back to running all c

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

dmikis added a comment. @thakis I've got test working, here's the code: // RUN: chmod +w %t.dir || true // RUN: rm -rf %t.dir // RUN: mkdir %t.dir // RUN: cp %s %t.dir/read-only.cpp // RUN: chmod -w %t.dir // RUN: clang-format -style=LLVM -i %t.dir/read-only.cpp || test $? == 1 i

[PATCH] D90447: [AMDGPU] Add gfx1033 target

tpr updated this revision to Diff 301931. tpr added a comment. V2: Update ELFObjectFile.cpp and elf-header-flags-mach.yaml. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90447/new/ https://reviews.llvm.org/D90447 Files: clang/lib/Basic/Targets/A

[libunwind] 1d7786d - [libunwind] Support DW_CFA_remember/restore_state without heap allocation.

Author: Daniel Kiss Date: 2020-10-30T17:45:20+01:00 New Revision: 1d7786d45f48b4793baf4e4b903c4476f56ffc94 URL: https://github.com/llvm/llvm-project/commit/1d7786d45f48b4793baf4e4b903c4476f56ffc94 DIFF: https://github.com/llvm/llvm-project/commit/1d7786d45f48b4793baf4e4b903c4476f56ffc94.diff L

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a request about the note. Thank you for this! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3161 + InGroup; +def note_attribute

[PATCH] D90336: [Sema] Diagnose annotating `if constexpr` with a likelihood attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the point @rjmccall made about the note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90336/new/ https://reviews.

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

martong added inline comments. Comment at: clang/include/clang/APINotes/Types.h:25 +/// auditing. +enum class EnumExtensibilityKind { + None, compnerd wrote: > martong wrote: > > compnerd wrote: > > > martong wrote: > > > > compnerd wrote: > > > > > martong wrot

[clang] 973317c - [CodeGen][X86] Remove unused check-prefix in constrained fma tests

Author: Simon Pilgrim Date: 2020-10-30T16:23:08Z New Revision: 973317cc5e4612a85e39dc1ffb20423c96bc9db2 URL: https://github.com/llvm/llvm-project/commit/973317cc5e4612a85e39dc1ffb20423c96bc9db2 DIFF: https://github.com/llvm/llvm-project/commit/973317cc5e4612a85e39dc1ffb20423c96bc9db2.diff LOG:

[clang] 365f46e - [CodeGen][X86] Remove unused check-prefix in movdir tests

Author: Simon Pilgrim Date: 2020-10-30T16:23:08Z New Revision: 365f46efebe09378af57628f38bfe55018451d17 URL: https://github.com/llvm/llvm-project/commit/365f46efebe09378af57628f38bfe55018451d17 DIFF: https://github.com/llvm/llvm-project/commit/365f46efebe09378af57628f38bfe55018451d17.diff LOG:

[clang] 0ff9d8c - [CodeGen][X86] Remove unused check-prefix in bswap tests

Author: Simon Pilgrim Date: 2020-10-30T16:13:49Z New Revision: 0ff9d8c8baa317f4135e08cfe8d64e4b824b7c49 URL: https://github.com/llvm/llvm-project/commit/0ff9d8c8baa317f4135e08cfe8d64e4b824b7c49 DIFF: https://github.com/llvm/llvm-project/commit/0ff9d8c8baa317f4135e08cfe8d64e4b824b7c49.diff LOG:

[clang] d7389f0 - [CodeGen][X86] Cleanup + remove unused check-prefixes in avx union tests

Author: Simon Pilgrim Date: 2020-10-30T16:13:47Z New Revision: d7389f05ee27e703ac9c0873d3ac183d8d9cf0c5 URL: https://github.com/llvm/llvm-project/commit/d7389f05ee27e703ac9c0873d3ac183d8d9cf0c5 DIFF: https://github.com/llvm/llvm-project/commit/d7389f05ee27e703ac9c0873d3ac183d8d9cf0c5.diff LOG:

[clang] c44846f - [CodeGen][X86] Cleanup + fix unused check-prefixes in bmi tests

Author: Simon Pilgrim Date: 2020-10-30T16:13:54Z New Revision: c44846f537efb4f996becc6f665af828051a08f6 URL: https://github.com/llvm/llvm-project/commit/c44846f537efb4f996becc6f665af828051a08f6 DIFF: https://github.com/llvm/llvm-project/commit/c44846f537efb4f996becc6f665af828051a08f6.diff LOG:

[clang] 5cdd470 - [CodeGen][X86] Remove unused check-prefix in bitscan tests

Author: Simon Pilgrim Date: 2020-10-30T16:13:50Z New Revision: 5cdd47050408d826d7fb324d9a130cf8e74298e2 URL: https://github.com/llvm/llvm-project/commit/5cdd47050408d826d7fb324d9a130cf8e74298e2 DIFF: https://github.com/llvm/llvm-project/commit/5cdd47050408d826d7fb324d9a130cf8e74298e2.diff LOG:

[clang] fe3d765 - [CodeGen][X86] Tidyup CHECKs on bitscan tests

Author: Simon Pilgrim Date: 2020-10-30T16:13:52Z New Revision: fe3d765ac72ed58cc81cc93d5a1bf0f61491f80d URL: https://github.com/llvm/llvm-project/commit/fe3d765ac72ed58cc81cc93d5a1bf0f61491f80d DIFF: https://github.com/llvm/llvm-project/commit/fe3d765ac72ed58cc81cc93d5a1bf0f61491f80d.diff LOG:

[clang] bbe055d - [CodeGen][X86] Remove unused check-prefix in amx inline asm tests

Author: Simon Pilgrim Date: 2020-10-30T16:13:45Z New Revision: bbe055dd73cf3f87e6e6481b5aa36bcc875cbe23 URL: https://github.com/llvm/llvm-project/commit/bbe055dd73cf3f87e6e6481b5aa36bcc875cbe23 DIFF: https://github.com/llvm/llvm-project/commit/bbe055dd73cf3f87e6e6481b5aa36bcc875cbe23.diff LOG:

[PATCH] D90447: [AMDGPU] Add gfx1033 target

rampitec added a comment. Missing changes to these files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Basic/Targets/NVPTX.cpp clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp llvm/lib/Object/ELFObjectFile.cpp llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml llvm/test/tools/llvm-

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks for working through this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 __

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

fhahn added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:144 + assert(ValueExpr && "Attribute must have a valid value expression."); + if (S.CheckLoopHintExpr(ValueExpr, St->getBeginLoc())) +return nullptr; sdesmalen wrote: > dav

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. I've added tests for OptParserEmitter. Let me know if you had something more detailed in mind. Comment at: clang/include/clang/Driver/Options.td:1176 +defm reciprocal_math : OptInFFlag< "reciprocal-math", "Allow division operations to be reassoci

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

awarzynski added a comment. Hi @rjmccall , thank you for your quick reply! > It sounds like what you want is a diagnostic library that's almost completely > abstracted over the kinds of entities that can be stored in a diagnostic, > including the definition of a source location. No :) We sugge

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaStmtAttr.cpp:144 + assert(ValueExpr && "Attribute must have a valid value expression."); + if (S.CheckLoopHintExpr(ValueEx

[PATCH] D89761: Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC

dexonsmith added inline comments. Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:36 + bool operator<(const UniqueID &Other) const { +return std::tie(Device, File) < std::tie(Other.Device, Other.File); + } rnk wrote: > FYI std::tie is pretty exp

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 updated this revision to Diff 301913. jansvoboda11 added a comment. Herald added a subscriber: mgorny. Added LLVM unit tests, reverted back to `array_pod_sort`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 Files: clang/include/

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

kadircet updated this revision to Diff 301912. kadircet added a comment. - Explicitly handle FragmentDir.empty() case by returning Path as-is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90270/new/ https://reviews.llvm.org/D90270 Files: clang-

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:170 + [PathMatch(std::move(PathMatch)), + FragmentDir(FragmentDirectory)](const Params &P) { if (P.Path.empty()) -

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89936/new/ https://reviews.llvm.org/D89936

  1   2   >