[PATCH] D89852: [clangd] Use SmallString instead of std::string in marshalling code; NFC

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https

[PATCH] D89851: [clangd] Separate final_result into a different message; NFC

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Mono

[PATCH] D89849: Add option 'exceptions' to pragma clang fp

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, mibintc, kpn. Herald added a subscriber: dexonsmith. Herald added a project: clang. sepavloff requested review of this revision. Pragma 'clang fp' is extended to support a new option, 'exceptions'. It allows to specify f

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

arphaman updated this revision to Diff 299564. arphaman added a comment. Don't try to fallback to the "apple-a12" cpu type when the user explicitly specifies an older cpu. The default is still "apple-a12". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82699/new/ https://reviews.llvm.or

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

sepavloff accepted this revision. sepavloff added a comment. LGTM There is concern with restoring FP options but it could be solved separately. Looking forward to results of SPEC runs! Comment at: clang/docs/UsersManual.rst:1389 * ``precise`` Disables optimizations that a

[PATCH] D89664: [X86] Add missing code in D89102 [X86] Add HRESET instruction.

pengfei abandoned this revision. pengfei added a comment. HRESET is not supported on Sapphire Rapids. Thanks for pointing it out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89664/new/ https://reviews.llvm.org/D89664

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

jdoerfert added a comment. Generally OK. Unclear if we want to keep a flag so we don't need to test the pointer, but I guess it is fine too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

jdoerfert added a comment. I have no idea what from the commit message what this has to do with the OpenMP code gen but I saw this randomly while looking for something else so here we go: In D88978#2326036 , @scott.linder wrote: > In D88978#2325991

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining ssp into nossp

void added inline comments. Comment at: llvm/docs/LangRef.rst:1829 + +If a function with the ``nossp`` attribute calls a callee function that has +a stack protector function attribute, such as ``ssp``, ``sspreq``, or Do we care about the opposite situatio

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, grokos, ye-luo. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. tianshilei1992 requested review of this revision. Herald added a subscriber: sstefan1. The implementation of targ

[PATCH] D89301: [X86] Add User Interrupts(UINTR) instructions

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89301/new/ https://reviews.llvm.org/D89301 _

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added a comment. In D85474#2343356 , @dexonsmith wrote: > In D85474#2343326 , @MaskRay wrote: > >> In D85474#2342365 , @compnerd wrote: >> >>> Is there a reason to no

[PATCH] D89749: SourceManager: Don't allocate an SLocEntry until it's loaded

dexonsmith added a comment. This should be complementary to https://reviews.llvm.org/D89580, but I think it's independent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89749/new/ https://reviews.llvm.org/D89749 ___ cfe-commits mailing list

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

dexonsmith added a comment. In D85474#2343326 , @MaskRay wrote: > In D85474#2342365 , @compnerd wrote: > >> Is there a reason to not use the existing `-mlinker-version=` option and >> expanding that beyond just Dar

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Tue, Oct 20, 2020 at 6:19 PM Nico Weber via Phabricator wrote: > > thakis added a comment. > > Looks like this breaks tests on windows: > http://45.33.8.238/win/26253/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Sorry I saw this message late. Looks like Fan

[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

hubert.reinterpretcast added a comment. In D89684#2341922 , @hubert.reinterpretcast wrote: > `-mabi=aixvecextabi` was suggested when I discussed this with someone who is > familiar with GCC. The choice of `extabi` at the end is to match the spelling > o

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

MaskRay added a subscriber: yaxunl. MaskRay added a comment. @yaxunl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89799/new/ https://reviews.llvm.org/D89799 ___ cfe-commits mailing list cfe-commits@list

[clang] 829b9f6 - [test] Fix -fbasic-block-sections= test on Windows after D89500

Author: Fangrui Song Date: 2020-10-20T18:31:28-07:00 New Revision: 829b9f6606af03e24d7715712e05c941d1c661ce URL: https://github.com/llvm/llvm-project/commit/829b9f6606af03e24d7715712e05c941d1c661ce DIFF: https://github.com/llvm/llvm-project/commit/829b9f6606af03e24d7715712e05c941d1c661ce.diff

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added a comment. In D85474#2342365 , @compnerd wrote: > Is there a reason to not use the existing `-mlinker-version=` option and > expanding that beyond just Darwin targets? I feel like having the same > option would be much nicer. `-mlinker-ve

[clang] 4aa97e3 - SourceManager: Simplify early returns in ContentCache::getBufferOrNone, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-20T21:26:37-04:00 New Revision: 4aa97e3dacf3bdf5636fbf89dd8c64f1e4648065 URL: https://github.com/llvm/llvm-project/commit/4aa97e3dacf3bdf5636fbf89dd8c64f1e4648065 DIFF: https://github.com/llvm/llvm-project/commit/4aa97e3dacf3bdf5636fbf89dd8c64f1e464

[PATCH] D89722: SourceManager: Simplify early returns in ContentCache::getBufferOrNone, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG4aa97e3dacf3: SourceManager: Simplify early returns in ContentCache::getBufferOrNone, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

JohelEGP added a comment. Could you do a rebase? The patch no longer applies: error: patch failed: clang/docs/ClangFormatStyleOptions.rst:2711 error: clang/docs/ClangFormatStyleOptions.rst: patch does not apply error: patch failed: clang/docs/ReleaseNotes.rst:398 error: clang/docs/Release

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/26253/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89500/new/ https://reviews.llv

[clang] 2963145 - ContentCache: Simplify by always owning the MemoryBuffer

Author: Duncan P. N. Exon Smith Date: 2020-10-20T21:03:53-04:00 New Revision: 296314516d103f8eeb987a08b509c1381cfeef89 URL: https://github.com/llvm/llvm-project/commit/296314516d103f8eeb987a08b509c1381cfeef89 DIFF: https://github.com/llvm/llvm-project/commit/296314516d103f8eeb987a08b509c1381cfe

[PATCH] D67030: ContentCache: Simplify by always owning the MemoryBuffer

This revision was automatically updated to reflect the committed changes. Closed by commit rG296314516d10: ContentCache: Simplify by always owning the MemoryBuffer (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D67030?vs=298257&id=2995

[PATCH] D89612: NFC: Fix -Wsign-compare warnings on 32-bit builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG134ffa8138c3: NFC: Fix -Wsign-compare warnings on 32-bit builds (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES

[clang] 134ffa8 - NFC: Fix -Wsign-compare warnings on 32-bit builds

Author: Hubert Tong Date: 2020-10-20T20:52:10-04:00 New Revision: 134ffa8138c31444685013e10f592cd7c88d675b URL: https://github.com/llvm/llvm-project/commit/134ffa8138c31444685013e10f592cd7c88d675b DIFF: https://github.com/llvm/llvm-project/commit/134ffa8138c31444685013e10f592cd7c88d675b.diff L

[PATCH] D89297: [clangd] Add a TestWorkspace utility

nridge updated this revision to Diff 299526. nridge marked 8 inline comments as done. nridge added a comment. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 15e772e - Don't instantiate lambda closure types in default member initializers

Author: Richard Smith Date: 2020-10-20T17:37:07-07:00 New Revision: 15e772e8dc39f609115430f39078fbe58812fddb URL: https://github.com/llvm/llvm-project/commit/15e772e8dc39f609115430f39078fbe58812fddb DIFF: https://github.com/llvm/llvm-project/commit/15e772e8dc39f609115430f39078fbe58812fddb.diff

[clang] 6781fee - Don't permit array bound constant folding in OpenCL.

Author: Richard Smith Date: 2020-10-20T16:52:28-07:00 New Revision: 6781fee085058913444e0c5937da9c0e7e928db5 URL: https://github.com/llvm/llvm-project/commit/6781fee085058913444e0c5937da9c0e7e928db5 DIFF: https://github.com/llvm/llvm-project/commit/6781fee085058913444e0c5937da9c0e7e928db5.diff

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6781fee08505: Don't permit array bound constant folding in OpenCL. (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

rsmith updated this revision to Diff 299515. rsmith added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89520/new/ https://reviews.llvm.org/D89520 Files: clang/lib/AST/Decl.cpp clang/lib/AST/ExprConstant.cpp clang/lib/Sema

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

This revision was automatically updated to reflect the committed changes. Closed by commit rGf88785460ecf: Improve file doesnt exist error with -fbasic-block-sections= (authored by tmsriram). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f887854 - Improve file doesnt exist error with -fbasic-block-sections=

Author: Sriraman Tallam Date: 2020-10-20T16:41:56-07:00 New Revision: f88785460ecf40a9176f58637d38fb785eb91ac4 URL: https://github.com/llvm/llvm-project/commit/f88785460ecf40a9176f58637d38fb785eb91ac4 DIFF: https://github.com/llvm/llvm-project/commit/f88785460ecf40a9176f58637d38fb785eb91ac4.dif

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2342016 , @njames93 wrote: > In D86671#2341838 , @dougpuob wrote: > >> Hi @njames93, >> >> It's a smart idea, the rework for it is worth. There is a special case if >> lowercase

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 added inline comments. Comment at: clang/test/OpenMP/driver-openmp-target.c:2 +// REQUIRES: x86-registered-target +// REQUIRES: clang-64-bits +// RUN: %clang %s -c -E -dM -fopenmp=libomp -fopenmp-version=45 -fopenmp-targets=x86_64-unknown-unknown -o - | FileCheck --chec

[clang] 1d78e21 - clang/Basic: ContentCache::InvalidFlag => ContentCache::IsBufferInvalid, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-20T19:28:17-04:00 New Revision: 1d78e2101ab75f01615a45467c44da7181cccedb URL: https://github.com/llvm/llvm-project/commit/1d78e2101ab75f01615a45467c44da7181cccedb DIFF: https://github.com/llvm/llvm-project/commit/1d78e2101ab75f01615a45467c44da7181cc

[PATCH] D89431: clang/Basic: ContentCache::InvalidFlag => ContentCache::IsBufferInvalid, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d78e2101ab7: clang/Basic: ContentCache::InvalidFlag => ContentCache::IsBufferInvalid, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef

dexonsmith added a comment. Note that https://reviews.llvm.org/D89836 is an example of a follow-up patch that leverages these API changes. The original version of that patch was much, much noisier. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89834/new/ https://reviews.llvm.org/D8983

[PATCH] D89836: Change Module::ASTFile and ModuleFile::File => MaybeFileEntryRef, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere, teemperor. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Change `Module::ASTFile` and `ModuleFile::File` to use `MayeFileEntryRef` instead of `const FileEntry *`. One of many

[PATCH] D89835: ModuleManager: Simplify lookupModuleFile by only setting the out parameter once, NFC

dexonsmith created this revision. dexonsmith added a reviewer: JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. https://reviews.llvm.org/D89835 Files: clang/lib/Serialization/ModuleManager.cpp Index: clang/lib/Serialization/ModuleManager.cpp ===

[PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef

dexonsmith updated this revision to Diff 299506. dexonsmith added a comment. Attaching the correct diff :/. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89834/new/ https://reviews.llvm.org/D89834 Files: clang/include/clang/Basic/FileEntry.h clang/unittests/Basic/CMakeLists.txt c

[PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef

dexonsmith created this revision. dexonsmith added reviewers: JDevlieghere, arphaman, teemperor. Herald added subscribers: llvm-commits, ributzka, mgorny. Herald added a project: LLVM. dexonsmith requested review of this revision. Make a few changes to the `FileEntryRef` API in preparation for pro

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

tra updated this revision to Diff 299501. tra edited the summary of this revision. tra added a comment. Added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89832/new/ https://reviews.llvm.org/D89832 Files: clang/include/clang/Basic/D

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining ssp into nossp

nickdesaulniers added a comment. bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ https://reviews.llvm.org/D87956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty added inline comments. Comment at: clang/test/OpenMP/driver-openmp-target.c:2 +// REQUIRES: x86-registered-target +// REQUIRES: clang-64-bits +// RUN: %clang %s -c -E -dM -fopenmp=libomp -fopenmp-version=45 -fopenmp-targets=x86_64-unknown-unknown -o - | FileCheck --che

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, I'm happy with this, though please wait a day or two for comments from the other reviewers. We should also add some documentation covering the rules we're using for the floating-point

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

tra created this revision. tra added reviewers: jlebar, yaxunl, emankov. Herald added subscribers: dexonsmith, bixia. Herald added a project: clang. tra requested review of this revision. This is a follow-up to D89752 , If CUDA version can not be determined based

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra added inline comments. Comment at: clang/test/Driver/cuda-version-check.cu:13 // RUN:FileCheck %s --check-prefix=UNKNOWN_VERSION +// CUDA-11.1 does not carry version.txt file. Make sure we still detect it as a +// new version and handle it the same as we handle other new

[clang] 747b134 - clang/Basic: Remove SourceManager::getBufferPointer, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-20T18:02:42-04:00 New Revision: 747b134d019ce99bc4463d09992634965ee95031 URL: https://github.com/llvm/llvm-project/commit/747b134d019ce99bc4463d09992634965ee95031 DIFF: https://github.com/llvm/llvm-project/commit/747b134d019ce99bc4463d09992634965ee9

[PATCH] D89430: clang/Basic: Remove SourceManager::getBufferPointer, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG747b134d019c: clang/Basic: Remove SourceManager::getBufferPointer, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5c022d84699: [clangd][ObjC] Support nullability annotations (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://review

[clang-tools-extra] d5c022d - [clangd][ObjC] Support nullability annotations

Author: David Goldman Date: 2020-10-20T17:36:32-04:00 New Revision: d5c022d846999127352aa3c08c0f81418a942aab URL: https://github.com/llvm/llvm-project/commit/d5c022d846999127352aa3c08c0f81418a942aab DIFF: https://github.com/llvm/llvm-project/commit/d5c022d846999127352aa3c08c0f81418a942aab.diff

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

flx marked 2 inline comments as done. flx added a comment. Thank you all for the input! In D89332#2336566 , @njames93 wrote: > How does this type alias and typedef, In theory that should also be handled. > > using Functor = std::function<...>; > Funct

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

flx updated this revision to Diff 299471. flx added a comment. Use hasName matcher on the declaration of the canonical type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89332/new/ https://reviews.llvm.org/D89332 Files: clang-tools-extra/clang-

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

oneraynyday updated this revision to Diff 299470. oneraynyday added a comment. - Address clang-tidy - Address using C++17 left-fold expression in C++14 - Address minor style issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89765/new/ https://re

[PATCH] D89429: clang/Basic: Replace SourceManager::getMemoryBufferForFile, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dc7e0c6a586: clang/Basic: Replace SourceManager::getMemoryBufferForFile, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] 2dc7e0c - clang/Basic: Replace SourceManager::getMemoryBufferForFile, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-20T17:01:23-04:00 New Revision: 2dc7e0c6a586135fe236cd7ebf065617a7638bdb URL: https://github.com/llvm/llvm-project/commit/2dc7e0c6a586135fe236cd7ebf065617a7638bdb DIFF: https://github.com/llvm/llvm-project/commit/2dc7e0c6a586135fe236cd7ebf065617a763

[PATCH] D83088: Introduce CfgTraits abstraction

dblaikie reopened this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sorry about the delays in review - but please revert this patch until we can hash out a few more details. I really don't think this is the best direction forward for a core abstraction & I

[PATCH] D89573: [Driver] Incorporate -mfloat-abi in the computed triple on ARM

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89573/new/ https://reviews.llvm.org/D89573 ___ cfe-commits mailing list cfe-commits

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

oneraynyday added a comment. In D89765#2342624 , @awarzynski wrote: > > - Have you considered sending an RFC to cfe-dev regarding this tool? I think > that it would be a great way of attracting peoples attention. More > importantly, should we add an

[clang] 27a909a - [Apple-stage2] Install FileCheck and yaml2obj in the toolchain

Author: Jonas Devlieghere Date: 2020-10-20T13:46:44-07:00 New Revision: 27a909a24f99d4de40c4ce6553b9cd420b11c056 URL: https://github.com/llvm/llvm-project/commit/27a909a24f99d4de40c4ce6553b9cd420b11c056 DIFF: https://github.com/llvm/llvm-project/commit/27a909a24f99d4de40c4ce6553b9cd420b11c056.d

[PATCH] D89763: [Apple-stage2] Install FileCheck and yaml2obj in the toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG27a909a24f99: [Apple-stage2] Install FileCheck and yaml2obj in the toolchain (authored by JDevlieghere). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: h

[PATCH] D89766: Driver: Add integer sanitizers to trapping group automatically.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5acd3490b79: Driver: Add integer sanitizers to trapping group automatically. (authored by pcc). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] c5acd34 - Driver: Add integer sanitizers to trapping group automatically.

Author: Peter Collingbourne Date: 2020-10-20T13:45:39-07:00 New Revision: c5acd3490b79703426931f7b88b544fe7c6e1ef2 URL: https://github.com/llvm/llvm-project/commit/c5acd3490b79703426931f7b88b544fe7c6e1ef2 DIFF: https://github.com/llvm/llvm-project/commit/c5acd3490b79703426931f7b88b544fe7c6e1ef2

[PATCH] D89766: Driver: Add integer sanitizers to trapping group automatically.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89766/new/ https://reviews.llvm.org/D89766 ___

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

rnk added a comment. This seems like pretty corner case functionality. Do we really need this diagnostic? @tra @yaxun Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89799/new/ https://reviews.llvm.org/D89799 ___

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

awarzynski added a comment. Hi @oneraynyday ! This looks very interesting - thanks for uploading! I've only quickly skimmed through. Two high level points: - Have you considered sending an RFC to cfe-dev regarding this tool? I think that it would be a great way of attracting peoples attention.

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev updated this revision to Diff 299449. kbobyrev added a comment. Resolve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/ https://reviews.llvm.org/D88553 Files: clang-tools-extra/clangd/SemanticSelection.cpp clang-too

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

MaskRay added a comment. LGTM. I think a number of options can probably drop the flag, but that can be left as a future clean-up for macOS -Xarch (can someone add a reviewer for macOS?) and CUDA -Xarch* folks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D67030: ContentCache: Simplify by always owning the MemoryBuffer

dexonsmith added a comment. ping In D67030#2331280 , @dexonsmith wrote: > Rebased on top of https://reviews.llvm.org/D89431 (the tests haven't finished > yet; I'll update if necessary, but this is pretty straightforward). (FTR, the tests passed as expec

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 299443. njames93 added a comment. Rebased and fix issues relating to rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tidy/llvm/

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:52-55 +const syntax::Token *FirstToken = Tree->findFirstLeaf()->getToken(), +*LastToken = Tree->findLastLeaf()->getToken(); +assert(FirstToken->kind() == to

[PATCH] D78760: Check a class doesn't have a dependent type before iterating over its base classes

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78760/new/ https://reviews.llvm.org/D78760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:52-55 +const syntax::Token *FirstToken = Tree->findFirstLeaf()->getToken(), +*LastToken = Tree->findLastLeaf()->getToken(); +assert(FirstToken->kind() == tok

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev updated this revision to Diff 299438. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/ https://reviews.llvm.org/D88553 Files: clang-to

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83448/new/ https://reviews.llvm.org/D83448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:238 + if (D->hasAttr()) +return IsDarwin ? CC_C : CC_AArch64Darwin; + mstorsjo wrote: > aaron.ballman wrote: > > Can you help me understand this change a bit better? If the declara

[PATCH] D89814: [TableGen] Change !getop and !setop to !getdagop and !setdagop

Paul-C-Anagnostopoulos created this revision. Paul-C-Anagnostopoulos added reviewers: lattner, nhaehnle, rengolin, asl. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, dmgreen, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Paul-C-Anagnostopoulos requested review of

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 299426. mibintc added a comment. I made the change requested by @rsmith to HandleIntToFloatCast, avoiding the check if Info.InConstantContext, then I corrected 2 tests so that -verify matches. clang/test/CXX/expr/expr.const/p2-0x.cpp clang/test/Parser/p

[PATCH] D89573: [Driver] Incorporate -mfloat-abi in the computed triple on ARM

john.brawn updated this revision to Diff 299420. john.brawn edited the summary of this revision. john.brawn added a comment. Adjusted to give an error when the specified float abi is incompatible with the default. Was a bit trickier than I expected as it required extracting out the logic to dete

[PATCH] D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze added a comment. In D89651#2338266 , @njames93 wrote: > Should point out there is already a check for cert-oop57-cpp, added in D72488 > . Do these play nice with each other or > should they perhaps be merged or sh

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

compnerd added a comment. Is there a reason to not use the existing `-mlinker-version=` option and expanding that beyond just Darwin targets? I feel like having the same option would be much nicer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums

aaron.ballman added a comment. In D85697#2340258 , @njames93 wrote: > In D85697#2339055 , @aaron.ballman > wrote: > >> I tend to be very skeptical of the value of checks that basically throw out >> entire usable c

[PATCH] D89469: FileManager: Test FileManager::getFileRef

dexonsmith added a comment. Herald added a subscriber: ormris. In D89469#2342117 , @arphaman wrote: > Thanks. Could you expand the comment in the test that this test path > specifically exercises the behavior produced by the RedirectingFileSystem? Yup, d

[PATCH] D89469: FileManager: Test FileManager::getFileRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG729d7d23282e: FileManager: Test FileManager::getFileRef (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D89469?vs=298379&id=299416#toc Reposit

[clang] 729d7d2 - FileManager: Test FileManager::getFileRef

Author: Duncan P. N. Exon Smith Date: 2020-10-20T13:40:23-04:00 New Revision: 729d7d23282e9b00eaa7a5f35a4224929d73d3a4 URL: https://github.com/llvm/llvm-project/commit/729d7d23282e9b00eaa7a5f35a4224929d73d3a4 DIFF: https://github.com/llvm/llvm-project/commit/729d7d23282e9b00eaa7a5f35a4224929d73

[PATCH] D89429: clang/Basic: Replace SourceManager::getMemoryBufferForFile, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks for the explanation! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89429/new/ https://reviews.llvm.org/D89429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D89427: clang/Frontend: Use MemoryBufferRef in FrontendInputFile (and remove SourceManager::getBuffer)

This revision was automatically updated to reflect the committed changes. Closed by commit rG51d1d585e583: clang/Frontend: Use MemoryBufferRef in FrontendInputFile (and remove… (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra updated this revision to Diff 299410. tra marked 2 inline comments as done. tra added a comment. addresses review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89752/new/ https://reviews.llvm.org/D89752 Files: clang/lib/Driver/Tool

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:161 + if (FS.exists(LibDevicePath + "/libdevice.10.bc")) { +Version = CudaVersion::LATEST; +DetectedVersionIsNotSupported = Version > CudaVersion::LATEST_SUPPORTED;

[clang] 51d1d58 - clang/Frontend: Use MemoryBufferRef in FrontendInputFile (and remove SourceManager::getBuffer)

Author: Duncan P. N. Exon Smith Date: 2020-10-20T13:35:46-04:00 New Revision: 51d1d585e5838ea0f02f1271f7543c4e43639969 URL: https://github.com/llvm/llvm-project/commit/51d1d585e5838ea0f02f1271f7543c4e43639969 DIFF: https://github.com/llvm/llvm-project/commit/51d1d585e5838ea0f02f1271f7543c4e4363

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

aaron.ballman added a comment. In D89743#2341900 , @sammccall wrote: > In D89743#2341779 , @aaron.ballman > wrote: > >> This is *awesome*, thank you so much for working on it! > > Thanks for the comments - haven't

[PATCH] D88659: [FE]Split SuitableAlign into two parts

Xiangling_L updated this revision to Diff 299404. Xiangling_L added a comment. Herald added a subscriber: dexonsmith. Edit the definition of `SuitableAlign`; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88659/new/ https://reviews.llvm.org/D88659 Files: clang/include/clang/Basic/Targ

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc marked 2 inline comments as done. mibintc added a comment. In D87528#2270541 , @rsmith wrote: >> @rsmith asked "I don't see changes to the constant evaluator". The semantic >> rules for enabling this pragma require that strict or precise semantics

[PATCH] D83088: Introduce CfgTraits abstraction

antiagainst added inline comments. Comment at: mlir/include/mlir/IR/Dominance.h:49 +template <> +struct llvm::CfgTraitsFor { + using CfgTraits = mlir::CfgTraits; rriddle wrote: > This seems to have broken the GCC5 build: > https://buildkite.com/mlir/mlir-core/bu

[PATCH] D83088: Introduce CfgTraits abstraction

rriddle added inline comments. Comment at: mlir/include/mlir/IR/Dominance.h:49 +template <> +struct llvm::CfgTraitsFor { + using CfgTraits = mlir::CfgTraits; This seems to have broken the GCC5 build: https://buildkite.com/mlir/mlir-core/builds/8739#7a957564-9850

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 299395. mibintc added a comment. Herald added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. I added StrictFPAttr clang function attribute accroding to @rjmccall 's suggestion instead of using a boolean on the function decl, rebased, and r

[PATCH] D89469: FileManager: Test FileManager::getFileRef

arphaman added a comment. Thanks. Could you expand the comment in the test that this test path specifically exercises the behavior produced by the RedirectingFileSystem? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89469/new/ https://reviews.llvm.org/D89469 __

[PATCH] D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS

zibi added a comment. LGTM, though not sure why comment is referencing -fshort-enums=0. If '=0' is not significant perhaps delete it to remove confusion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89801/new/ https://reviews.llvm.org/D89801

  1   2   3   >