rriddle added inline comments.
================ Comment at: mlir/include/mlir/IR/Dominance.h:49 +template <> +struct llvm::CfgTraitsFor<mlir::Block> { + using CfgTraits = mlir::CfgTraits; ---------------- This seems to have broken the GCC5 build: https://buildkite.com/mlir/mlir-core/builds/8739#7a957564-9850-487c-a814-c6818890bd14 ``` /mlir/include/mlir/IR/Dominance.h:49:14: error: specialization of 'template<class CfgRelatedTypeT> struct llvm::CfgTraitsFor' in different namespace [-fpermissive] struct llvm::CfgTraitsFor<mlir::Block> { ^ In file included from mlir/include/mlir/IR/Dominance.h:13:0, from mlir/lib/IR/Verifier.cpp:30: llvm/include/llvm/Support/CfgTraits.h:294:44: error: from definition of 'template<class CfgRelatedTypeT> struct llvm::CfgTraitsFor' [-fpermissive] template <typename CfgRelatedTypeT> struct CfgTraitsFor; ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83088/new/ https://reviews.llvm.org/D83088 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits