[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

2020-10-13 Thread Jonas Paulsson via Phabricator via cfe-commits
jonpa reopened this revision. jonpa added a comment. This revision is now accepted and ready to land. Patch temporarily reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279

[clang] 625fa47 - Revert "[clang] Improve handling of physical registers in inline assembly operands."

2020-10-13 Thread Jonas Paulsson via cfe-commits
Author: Jonas Paulsson Date: 2020-10-14T08:42:51+02:00 New Revision: 625fa47617022b2d1ed7b940f9621162874175ee URL: https://github.com/llvm/llvm-project/commit/625fa47617022b2d1ed7b940f9621162874175ee DIFF: https://github.com/llvm/llvm-project/commit/625fa47617022b2d1ed7b940f9621162874175ee.diff

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

2020-10-13 Thread Thomas Lively via Phabricator via cfe-commits
tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: llvm-commits, cfe-commits, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. Herald added projects: clang, LLVM. tlively requested review of this revision. Prototype the newly proposed load_

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

2020-10-13 Thread Vitaly Buka via cfe-commits
They do on staging. http://lab.llvm.org:8014/#/builders/sanitizer-windows http://lab.llvm.org:8014/#/builders/clang-x64-windows-msvc Galina, when do you plan to push this to the primary server? If it's a few days, I'd rather keep bots on staging to have colors. On Tue, 13 Oct 2020 at 11:11, Rei

[PATCH] D89184: Support complex target features combinations

2020-10-13 Thread LiuChen via Phabricator via cfe-commits
LiuChen3 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2389 } -if (!hasRequiredFeatures(ReqFeatures, CGM, FD, MissingFeature)) +if (!llvm::all_of(ReqFeatures, [&](StringRef Feature) { + if (!CallerFeatureMap.lookup(Feature)) {

[PATCH] D89276: Support ObjC in IncludeInserter

2020-10-13 Thread Joe Turner via Phabricator via cfe-commits
compositeprimes updated this revision to Diff 298029. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp clang-tools-extra/clang-tidy/utils/Include

[PATCH] D89276: Support ObjC in IncludeInserter

2020-10-13 Thread Joe Turner via Phabricator via cfe-commits
compositeprimes updated this revision to Diff 298027. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/unittests/clang-tidy/IncludeInserterTest.cpp Index: clang-tools-extra/unittes

[PATCH] D89276: Support ObjC in IncludeInserter

2020-10-13 Thread Joe Turner via Phabricator via cfe-commits
compositeprimes updated this revision to Diff 298026. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: ___

[PATCH] D89362: [MS] Apply `inreg` to AArch64 sret parms on instance methods

2020-10-13 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:1077 -static bool hasMicrosoftABIRestrictions(const CXXRecordDecl *RD) { +static bool isCXX14Aggregate(const CXXRecordDecl *RD) { // For AArch64, we use the C++14 definition of an aggregate, so

[PATCH] D89361: [X86][NFC] Fix RUN line bug in the testcase

2020-10-13 Thread LiuChen via Phabricator via cfe-commits
LiuChen3 added a comment. Thanks for all of your help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89361/new/ https://reviews.llvm.org/D89361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D89361: [X86][NFC] Fix RUN line bug in the testcase

2020-10-13 Thread LiuChen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbd05afcb3f40: [X86][NFC] Fix RUN line bug in the testcase (authored by LiuChen3). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org

[clang] bd05afc - [X86][NFC] Fix RUN line bug in the testcase

2020-10-13 Thread via cfe-commits
Author: Liu, Chen3 Date: 2020-10-14T12:40:34+08:00 New Revision: bd05afcb3f4093fe76dd64fe2920bfd894ec URL: https://github.com/llvm/llvm-project/commit/bd05afcb3f4093fe76dd64fe2920bfd894ec DIFF: https://github.com/llvm/llvm-project/commit/bd05afcb3f4093fe76dd64fe2920bfd894ec.diff LO

[PATCH] D89025: [RISCV] Add -mtune support

2020-10-13 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng added a comment. > If possible that would good, since -mcpu is deprecated (for e.g. x86_64) or > unsupported in GCC (for e.g. RISC-V). So doing that would further align Clang > with GCC. But I wonder if this might be too problematic, in terms of > compatibility. I am also working on

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

2020-10-13 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Okay. I can accept the fairly unfortunate thing with `const int` initializers. When is `IsConstantContext` set in C, just static initializers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89360/new/ https://reviews.llv

[PATCH] D89362: [MS] Apply `inreg` to AArch64 sret parms on instance methods

2020-10-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added reviewers: mgrang, efriedma. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: clang. rnk requested review of this revision. The documentation rules indicate that instance methods should return large, trivially copyable aggregates via

LLVM buildbot will be updated and restarted soon

2020-10-13 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b72813f - [CMake][Fuchsia] Start building arm64 Darwin runtimes

2020-10-13 Thread Petr Hosek via cfe-commits
Author: Petr Hosek Date: 2020-10-13T19:50:45-07:00 New Revision: b72813f4d6a0a0f1dc79afc1ca7e0e4d55ad6a72 URL: https://github.com/llvm/llvm-project/commit/b72813f4d6a0a0f1dc79afc1ca7e0e4d55ad6a72 DIFF: https://github.com/llvm/llvm-project/commit/b72813f4d6a0a0f1dc79afc1ca7e0e4d55ad6a72.diff LO

[clang] 69f7c00 - Revert "PR47805: Use a single object for a function parameter in the caller and"

2020-10-13 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-10-13T19:32:03-07:00 New Revision: 69f7c006ff72167231b569a0fd2d7955ca597ffa URL: https://github.com/llvm/llvm-project/commit/69f7c006ff72167231b569a0fd2d7955ca597ffa DIFF: https://github.com/llvm/llvm-project/commit/69f7c006ff72167231b569a0fd2d7955ca597ffa.diff

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

2020-10-13 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. FYI: I posted a patch to implement the "manifestly constant evaluated" rule as https://reviews.llvm.org/D89360. It looks like the stricter rule doesn't work in practice; far too much C++ code uses `-frounding-math` and expects to be able to still include things like stan

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

2020-10-13 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith created this revision. rsmith added reviewers: rjmccall, mibintc, sepavloff. Herald added a project: clang. rsmith requested review of this revision. This addresses a regression where pretty much all C++ compilations using -frounding-math now fail, due to rounding being performed in constex

[PATCH] D89184: Support complex target features combinations

2020-10-13 Thread LiuChen via Phabricator via cfe-commits
LiuChen3 added a comment. > D89105 appears to use only `"avx512vl , > avx512vnni | avxvnni"`. > Does it mean `(avx512vl , avx512vnni) | avxvnni` or `avx512vl , (avx512vnni | > avxvnni)` ? Yes. "avx512vl , avx512vnni | avxvnni" means (avx512vl , avx512vnni) | a

[clang] 8f8b9f2 - PR47805: Use a single object for a function parameter in the caller and

2020-10-13 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-10-13T18:50:46-07:00 New Revision: 8f8b9f2cca0b73314342c721186ae9c860ca273c URL: https://github.com/llvm/llvm-project/commit/8f8b9f2cca0b73314342c721186ae9c860ca273c DIFF: https://github.com/llvm/llvm-project/commit/8f8b9f2cca0b73314342c721186ae9c860ca273c.diff

[PATCH] D78699: [X86] Passing union type through register.

2020-10-13 Thread LiuChen via Phabricator via cfe-commits
LiuChen3 added a comment. In D78699#2328541 , @dyung wrote: > Hi, the test you added seems to pass both before and after your change, is > this intended? Oh, yes. I made mistake on my RUN line. So these tests are not really checked. Thanks for your help

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

2020-10-13 Thread Steven Johnson via Phabricator via cfe-commits
srj added a comment. This is marked as "needs revision", but it's not clear to me what the requested changes actually are. The proposed fix here may not be perfect, but AFAICT, there is simply no good way to exclude headers that are beyond your control at present. Repository: rL LLVM CHANG

[clang] 498c7fa - [SemaObjC] Fix a crash on an invalid ternary with ARC pointers

2020-10-13 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-10-13T21:20:20-04:00 New Revision: 498c7fa48a02a5e0c12bbb90ef8c0d8468affcdd URL: https://github.com/llvm/llvm-project/commit/498c7fa48a02a5e0c12bbb90ef8c0d8468affcdd DIFF: https://github.com/llvm/llvm-project/commit/498c7fa48a02a5e0c12bbb90ef8c0d8468affcdd.dif

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

2020-10-13 Thread Douglas Chen via Phabricator via cfe-commits
dougpuob added a comment. Hi @aaron.ballman and @njames93, I addressed your code review suggestions and supported Hungarian Notation prefix for decl of enum and class(option) at latest patch. Unfortunately, I encountered a problem that new patch failed on remote BuildBot, it showed the "No such

[PATCH] D78658: [clang][Frontend] Add missing error handling

2020-10-13 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added inline comments. Comment at: clang/lib/Frontend/ASTUnit.cpp:1158-1160 + if (!Clang->hasTarget()) { return true; + } You can remove these braces now - since it's a superfluous change here now there's no need

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

2020-10-13 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. https://bugs.llvm.org/show_bug.cgi?id=47837 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 ___ cfe-commits mailing list cfe-comm

[PATCH] D89348: clang/Basic: Replace ContentCache::getBuffer with Optional semantics

2020-10-13 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith updated this revision to Diff 297990. dexonsmith added a comment. Fix a few more places where `Invalid` needs to be set to `false`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89348/new/ https://reviews.llvm.org/D89348 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnos

[PATCH] D89348: clang/Basic: Replace ContentCache::getBuffer with Optional semantics

2020-10-13 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith updated this revision to Diff 297987. dexonsmith added a comment. Fixed a bug where `Invalid` was only set when it was `true`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89348/new/ https://reviews.llvm.org/D89348 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticCo

[clang] ab870f3 - Revert "PR47805: Use a single object for a function parameter in the caller and"

2020-10-13 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-10-13T15:59:00-07:00 New Revision: ab870f3030fc288cd101905d730ef3425da5ac16 URL: https://github.com/llvm/llvm-project/commit/ab870f3030fc288cd101905d730ef3425da5ac16 DIFF: https://github.com/llvm/llvm-project/commit/ab870f3030fc288cd101905d730ef3425da5ac16.diff

[clang] 8d03a97 - PR47805: Use a single object for a function parameter in the caller and

2020-10-13 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-10-13T15:45:04-07:00 New Revision: 8d03a972ce8e92815ffe3d5d86aa027605ed92e2 URL: https://github.com/llvm/llvm-project/commit/8d03a972ce8e92815ffe3d5d86aa027605ed92e2 DIFF: https://github.com/llvm/llvm-project/commit/8d03a972ce8e92815ffe3d5d86aa027605ed92e2.diff

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

2020-10-13 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd updated this revision to Diff 297983. compnerd added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Herald added a project: clang. Rebase; there are a 4 more test failures to go through Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D89348: clang/Basic: Replace ContentCache::getBuffer with Optional semantics

2020-10-13 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Note that this is split off from https://reviews.llvm.org/D66782. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89348/new/ https://reviews.llvm.org/D89348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D89348: clang/Basic: Replace ContentCache::getBuffer with Optional semantics

2020-10-13 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: ributzka, martong. Herald added a reviewer: shafik. dexonsmith requested review of this revision. Remove `ContentCache::getBuffer`, which always returned a dereferenceable `MemoryBuffer*` and had a `

[PATCH] D89276: Support ObjC in IncludeInserter

2020-10-13 Thread Joe Turner via Phabricator via cfe-commits
compositeprimes updated this revision to Diff 297980. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/unittests/clang-tidy/IncludeInserterTest.cpp Index: clang-tools-extra/unittes

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

2020-10-13 Thread Justin Lebar via Phabricator via cfe-commits
jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8163 "%select{__device__|__global__|__host__|__host__ __device__}0 functions">; -def err_cuda_nonglobal_

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

2020-10-13 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. @NoQ > Can we collapse this function further towards this goal? Say, why not pump > every region unconditionally through castRegion()? Does dispatchCast() use > castRegion() internally - and if it does, why are there so many branches in > this function? I've mad

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

2020-10-13 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 297970. nickdesaulniers added a comment. - remove modification to docs about legacy fn attr encoding Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ https://reviews.llvm.org/D87956 Files: cl

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

2020-10-13 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: llvm/docs/BitCodeFormat.rst:953 base 2 of the requested alignment, plus 1 +* bit 40: ``nossp`` ah, I should remove this; this block is legacy encodings which I do not modify. Comment at: l

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

2020-10-13 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 297969. nickdesaulniers added a comment. - add -passes='cgscc(inline)' to inline_nossp.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ https://reviews.llvm.org/D87956 Files: clang/include

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

2020-10-13 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 297967. nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. - address todos and review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ https://reviews.ll

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

2020-10-13 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: llvm/include/llvm/Bitcode/LLVMBitCodes.h:610 + // TODO: reorder + ATTR_KIND_NO_STACK_PROTECT = 70, ATTR_KIND_STACK_PROTECT = 26, nickdesaulniers wrote: > any comments from reviewers before I go and do a tedi

[clang] e7fe3c6 - Basic: Simplify SourceManager::getBuffer overload, NFC

2020-10-13 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-13T17:52:59-04:00 New Revision: e7fe3c6dfede8d5781bd000741c3dea7088307a4 URL: https://github.com/llvm/llvm-project/commit/e7fe3c6dfede8d5781bd000741c3dea7088307a4 DIFF: https://github.com/llvm/llvm-project/commit/e7fe3c6dfede8d5781bd000741c3dea70883

[PATCH] D78699: [X86] Passing union type through register.

2020-10-13 Thread Douglas Yung via Phabricator via cfe-commits
dyung added inline comments. Comment at: clang/test/CodeGen/X86/avx-union.c:2 +// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -target-feature +avx -emit-llvm -o %t %s || FileCheck < %t %s --check-prefix=CHECK, AVX +// RUN: %clang_cc1 -w -ffreestanding -triple x86_

[PATCH] D78658: [clang][Frontend] Add missing error handling

2020-10-13 Thread LemonBoy via Phabricator via cfe-commits
LemonBoy updated this revision to Diff 297959. LemonBoy added a comment. Use `ScopeExit` instead of a bare lambda. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 Files: clang/lib/Frontend/ASTUnit.cpp clang/unittests/Frontend/ASTUnitTest.cpp

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

2020-10-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-static-member.cpp:144-147 +// For some reason, const_va is not emitted when the target is MS. +// NOT-MS: !DIDerivedType(tag: DW_TAG_member, name: "const_va", +// NOT-MS-SAME: line: [[@LINE-3]] +//

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

2020-10-13 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L marked 8 inline comments as done. Xiangling_L added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:340 +LANGOPT(AIXPragmaPack, 1, 0, "AIX #pragma pack handling") + jasonliu wrote: > Not sure if AIXPragmaPack is the best name

[clang] 4c10d65 - [AIX] Support two itanium alignment LIT testcases for AIX using regex

2020-10-13 Thread Xiangling Liao via cfe-commits
Author: Xiangling Liao Date: 2020-10-13T16:47:01-04:00 New Revision: 4c10d6508f546ee986df0994663984cb15354c08 URL: https://github.com/llvm/llvm-project/commit/4c10d6508f546ee986df0994663984cb15354c08 DIFF: https://github.com/llvm/llvm-project/commit/4c10d6508f546ee986df0994663984cb15354c08.diff

[PATCH] D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex

2020-10-13 Thread Xiangling Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4c10d6508f54: [AIX] Support two itanium alignment LIT testcases for AIX using regex (authored by Xiangling_L). Changed prior to commit: https://reviews.llvm.org/D89064?vs=297848&id=297950#toc Repositor

[PATCH] D78699: [X86] Passing union type through register.

2020-10-13 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. Hi, the test you added seems to pass both before and after your change, is this intended? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78699/new/ https://reviews.llvm.org/D78699

[PATCH] D89184: Support complex target features combinations

2020-10-13 Thread Eric Christopher via Phabricator via cfe-commits
echristo requested changes to this revision. echristo added a comment. This revision now requires changes to proceed. Mark as requesting changes :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 ___ c

[PATCH] D89184: Support complex target features combinations

2020-10-13 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. Hi Peng, Looks interesting, but I think the language support needs some more comments about what's expected and in addition through everything else please? I've added some inline comments with places I think could use it for sure. -eric Comment at:

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

2020-10-13 Thread Albion Fung via Phabricator via cfe-commits
Conanap marked 3 inline comments as done. Conanap added a comment. Addressed Nemenja's concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84962/new/ https://reviews.llvm.org/D84962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

2020-10-13 Thread Albion Fung via Phabricator via cfe-commits
Conanap updated this revision to Diff 297936. Conanap added a comment. Use regex match to check for variable order in IR instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84962/new/ https://reviews.llvm.org/D84962 Files: clang/lib/Headers/altivec.h clang/test/CodeGen/builtins-

[clang] 0ec1cf1 - Revert "DirectoryWatcher: add an implementation for Windows"

2020-10-13 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-10-13T12:35:22-07:00 New Revision: 0ec1cf13f2a4e31aa2c5ccc665c5fbdcd3a94577 URL: https://github.com/llvm/llvm-project/commit/0ec1cf13f2a4e31aa2c5ccc665c5fbdcd3a94577 DIFF: https://github.com/llvm/llvm-project/commit/0ec1cf13f2a4e31aa2c5ccc665c5fbdcd3a94577.diff

[PATCH] D78658: [clang][Frontend] Add missing error handling

2020-10-13 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D78658#2327615 , @LemonBoy wrote: >> Perhaps this'd be more robust with ScopeExit? > > Not really, `OnError` is not executed when/if the function succeeds. Ah, sorry - ScopeExit has a 'release()' function intended to disengage

[PATCH] D89210: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt

2020-10-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Thank you for the continued work on this feature! I'd like to better understand the behavior of fallthrough labels because I think there are two conceptual models we could follow. When a label falls through to another label, should both labels be treated as having

[clang] 10f1ca9 - Revert "[analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions."

2020-10-13 Thread Artem Dergachev via cfe-commits
Author: Artem Dergachev Date: 2020-10-13T12:07:36-07:00 New Revision: 10f1ca99b498347186ec74b01046ad292bde9a4c URL: https://github.com/llvm/llvm-project/commit/10f1ca99b498347186ec74b01046ad292bde9a4c DIFF: https://github.com/llvm/llvm-project/commit/10f1ca99b498347186ec74b01046ad292bde9a4c.dif

[clang] 662ed9e - Revert "[analyzer] NFC: Move IssueHash to libAnalysis."

2020-10-13 Thread Artem Dergachev via cfe-commits
Author: Artem Dergachev Date: 2020-10-13T12:07:28-07:00 New Revision: 662ed9e67adace3d011f42478bc8bcb1773a2821 URL: https://github.com/llvm/llvm-project/commit/662ed9e67adace3d011f42478bc8bcb1773a2821 DIFF: https://github.com/llvm/llvm-project/commit/662ed9e67adace3d011f42478bc8bcb1773a2821.dif

[clang] 77bb3eb - Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis."

2020-10-13 Thread Artem Dergachev via cfe-commits
Author: Artem Dergachev Date: 2020-10-13T12:03:04-07:00 New Revision: 77bb3ebebbca13f0648beb433fbd1b06ba95a19c URL: https://github.com/llvm/llvm-project/commit/77bb3ebebbca13f0648beb433fbd1b06ba95a19c DIFF: https://github.com/llvm/llvm-project/commit/77bb3ebebbca13f0648beb433fbd1b06ba95a19c.dif

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

2020-10-13 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3469 + + // The value can be empty, which indicates the system default should be used. + StringRef CXXABI = Args.getLastArgValue(OPT_fcxx_abi_E

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

2020-10-13 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D76620#2328305 , @rjmccall wrote: > In D76620#2328031 , @erichkeane > wrote: > >> In D76620#2328011 , @rjmccall wrote: >> >>> In D76620#232798

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

2020-10-13 Thread Venkataramanan Kumar via Phabricator via cfe-commits
venkataramanan.kumar.llvm updated this revision to Diff 297925. venkataramanan.kumar.llvm added a comment. Updated the patch as per review comments received. The test cases are updated the checks based on the below comment from Francesco. ---Snip-- I think you are over-testing here. It is enough

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

2020-10-13 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D76620#2328031 , @erichkeane wrote: > In D76620#2328011 , @rjmccall wrote: > >> In D76620#2327988 , @erichkeane >> wrote: >> >>> In D76620#23279

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

2020-10-13 Thread Siva Chandra via cfe-commits
On Mon, Oct 12, 2020 at 10:01 PM Galina Kistanova via lldb-commits wrote: > If somebody else could move their AnnotatedCommand bots to the staging area, > that would be much appreciated. I moved the libc bots to staging to now. Thanks, Siva Chandra __

[PATCH] D89184: Support complex target features combinations

2020-10-13 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. In D89184#2328144 , @craig.topper wrote: > This is needed for D89105 and was split > from it. D89105

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

2020-10-13 Thread Reid Kleckner via cfe-commits
FWIW, I don't see any issues with my two bots that use buildbot annotated commands: http://lab.llvm.org:8011/#/builders/sanitizer-windows http://lab.llvm.org:8011/#/builders/clang-x64-windows-msvc The individual steps don't highlight as green or red, but that's OK for now. On Mon, Oct 12, 2020 at

[PATCH] D89078: Add `-f[no-]split-cold-code` toggling outlining & enable in -O

2020-10-13 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd abandoned this revision. compnerd added a comment. Sure, I think I can do that instead. Thanks for pointing me to that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89078/new/ https://reviews.llvm.org/D89078

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

2020-10-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:46 + +void ConstCorrectnessCheck::registerMatchers(MatchFinder *Finder) { + const auto ConstType = hasType(isConstQualified()); JonasToth w

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

2020-10-13 Thread Felix Berger via Phabricator via cfe-commits
flx added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:52 AllowedTypes( utils::options::parseStringList(Options.get("AllowedTypes", ""))) {} lebedev.ri wrote: > Just put it here? I tr

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

2020-10-13 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:103 #ifndef NDEBUG - for (auto *N = New; N; N = N->getNextSibling()) { + for (auto *N = New; N; N = N->NextSibling) { assert(N->Parent == nullptr); eduucaldas wrote: > Through

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

2020-10-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER Szelethus wrote: > NoQ wrote: > > Szelethus wrote: > > > No

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

2020-10-13 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER Szelethus wrote: > NoQ wrote: > > Szelethus wrote: > > > NoQ wrote: >

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

2020-10-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:52 AllowedTypes( utils::options::parseStringList(Options.get("AllowedTypes", ""))) {} Just put it here? Repository: r

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

2020-10-13 Thread Artem Dergachev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb76dc111dd02: [analyzer] NFC: Move IssueHash to libAnalysis. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67421/new/ https://rev

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

2020-10-13 Thread Artem Dergachev via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG44b7cf2983b6: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis. (authored by dergachev.a). Ch

[clang] b76dc11 - [analyzer] NFC: Move IssueHash to libAnalysis.

2020-10-13 Thread Artem Dergachev via cfe-commits
Author: Artem Dergachev Date: 2020-10-13T10:53:10-07:00 New Revision: b76dc111dd02672488df794570d82e3edbbfa5d8 URL: https://github.com/llvm/llvm-project/commit/b76dc111dd02672488df794570d82e3edbbfa5d8 DIFF: https://github.com/llvm/llvm-project/commit/b76dc111dd02672488df794570d82e3edbbfa5d8.dif

[clang] 44b7cf2 - [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

2020-10-13 Thread Artem Dergachev via cfe-commits
Author: Artem Dergachev Date: 2020-10-13T10:53:10-07:00 New Revision: 44b7cf2983b6a8373c99a9b254f8c3f944e03f35 URL: https://github.com/llvm/llvm-project/commit/44b7cf2983b6a8373c99a9b254f8c3f944e03f35 DIFF: https://github.com/llvm/llvm-project/commit/44b7cf2983b6a8373c99a9b254f8c3f944e03f35.dif

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

2020-10-13 Thread Artem Dergachev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfd4b3f123d6e: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions. (authored by dergachev.a). Herald added a subscriber: steakhal. Repository: rG LLVM Github Monorepo CHANGES S

[clang] fd4b3f1 - [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

2020-10-13 Thread Artem Dergachev via cfe-commits
Author: Artem Dergachev Date: 2020-10-13T10:53:10-07:00 New Revision: fd4b3f123d6e64769881e4c6351d5bbbdac30ce3 URL: https://github.com/llvm/llvm-project/commit/fd4b3f123d6e64769881e4c6351d5bbbdac30ce3 DIFF: https://github.com/llvm/llvm-project/commit/fd4b3f123d6e64769881e4c6351d5bbbdac30ce3.dif

[PATCH] D88314: Added llvm-string-referencing check

2020-10-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D88314#2322870 , @bogser01 wrote: > @aaron.ballman Thank you for picking up this review! Running the check over > the entire LLVM causes ~74K warnings across 430 files. As to the false > positive rate it's tricky to meas

[PATCH] D89184: Support complex target features combinations

2020-10-13 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. This is needed for D89105 and was split from it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 ___ cfe-commits mailing list cfe-commit

[PATCH] D89332: Always allow std::function to be copied.

2020-10-13 Thread Felix Berger via Phabricator via cfe-commits
flx created this revision. flx added a reviewer: aaron.ballman. Herald added a project: clang. flx requested review of this revision. Since its call operator is const but can modify the state of its underlying functor we cannot tell whether the copy is necessary or not. This avoids false positive

[PATCH] D89184: Support complex target features combinations

2020-10-13 Thread Artem Belevich via Phabricator via cfe-commits
tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. Sorry, I didn't mean to stamp the change as LGTM overall yet. Can't find a way to un-LGTM, so marking it as `Request Changes` for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D89184: Support complex target features combinations

2020-10-13 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a subscriber: echristo. tra added a comment. This revision is now accepted and ready to land. @echristo : FYI, just in case you have an opinion on bringing required feature constraint checks one step closer to being Turing-complete. :-) LGTM as far as syntax

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

2020-10-13 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/ASTImporter.cpp:8109 + FromAttr->getAttributeSpellingListIndex()); + ToAttr->setPackExpansion(FromAttr->isPackExpansion()); + ToAttr->se

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

2020-10-13 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D76620#2328011 , @rjmccall wrote: > In D76620#2327988 , @erichkeane > wrote: > >> In D76620#2327976 , @rjmccall wrote: >> >>> In D76620#232791

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

2020-10-13 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D76620#2327988 , @erichkeane wrote: > In D76620#2327976 , @rjmccall wrote: > >> In D76620#2327910 , @erichkeane >> wrote: >> >>> In D76620#23279

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

2020-10-13 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:618-619 FPOptions OldFPFeatures; +llvm::fp::ExceptionBehavior OldExcept; +llvm::RoundingMode OldRounding; Optional FMFGuard; sepavloff wrote: > Is it possible to merge th

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

2020-10-13 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D76620#2327976 , @rjmccall wrote: > In D76620#2327910 , @erichkeane > wrote: > >> In D76620#2327901 , @rjmccall wrote: >> >>> You know on both

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

2020-10-13 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D76620#2327910 , @erichkeane wrote: > In D76620#2327901 , @rjmccall wrote: > >> You know on both sides that a lambda is used as a kernel, yes? Why not >> simply introduce that into the

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

2020-10-13 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. I've also been seeing some failures on phab reviews, e.g. https://reviews.llvm.org/D89188. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ https://reviews.llvm.org/D88666

Re: [PATCH] D88666: DirectoryWatcher: add an implementation for Windows

2020-10-13 Thread Adrian McCarthy via cfe-commits
If I had to guess, my money would be on a deadlock. To unblock, I'd propose reverting this patch until we can figure it out. During the review, a deadlock was fixed related to the watcher thread, but perhaps we missed one for the notifier thread. On Tue, Oct 13, 2020 at 8:40 AM Hans Wennborg via

[clang] e2eaa91 - AMDGPU: Remove -mamdgpu-debugger-abi option

2020-10-13 Thread Konstantin Zhuravlyov via cfe-commits
Author: Konstantin Zhuravlyov Date: 2020-10-13T12:20:28-04:00 New Revision: e2eaa914514c26c8e51c76148996a2e9cf74613c URL: https://github.com/llvm/llvm-project/commit/e2eaa914514c26c8e51c76148996a2e9cf74613c DIFF: https://github.com/llvm/llvm-project/commit/e2eaa914514c26c8e51c76148996a2e9cf7461

[PATCH] D89312: [SVE][CodeGen]Use TypeSize comparison functions in clang

2020-10-13 Thread Caroline via Phabricator via cfe-commits
CarolineConcatto updated this revision to Diff 297884. CarolineConcatto added a comment. -Use getFixedSize instead of isKnowXY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89312/new/ https://reviews.llvm.org/D89312 Files: clang/lib/CodeGen/CGBu

[PATCH] D89125: AMDGPU: Remove -mamdgpu-debugger-abi option

2020-10-13 Thread Konstantin Zhuravlyov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe2eaa914514c: AMDGPU: Remove -mamdgpu-debugger-abi option (authored by kzhuravl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

2020-10-13 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D76620#2327901 , @rjmccall wrote: > You know on both sides that a lambda is used as a kernel, yes? Why not > simply introduce that into the mangling of lambdas, so that the subset of > lambdas used as kernels form a stable

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

2020-10-13 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. You know on both sides that a lambda is used as a kernel, yes? Why not simply introduce that into the mangling of lambdas, so that the subset of lambdas used as kernels form a stable sequence? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

2020-10-13 Thread Sylvain Audi via Phabricator via cfe-commits
saudi added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1420 + if (Var->getInit()) +Value = Var->evaluateValue(); + else if (auto *TemplateDecl = Var->getInstantiatedFromStaticDataMember()) { saudi wrote: > I encountered an assert inside

  1   2   >