nickdesaulniers added inline comments.
================ Comment at: llvm/docs/BitCodeFormat.rst:953 base 2 of the requested alignment, plus 1 +* bit 40: ``nossp`` ---------------- ah, I should remove this; this block is legacy encodings which I do not modify. ================ Comment at: llvm/lib/IR/Verifier.cpp:1977-1984 + if (Attrs.hasFnAttribute(Attribute::NoStackProtect)) + ++N; + if (Attrs.hasFnAttribute(Attribute::StackProtect)) + ++N; + if (Attrs.hasFnAttribute(Attribute::StackProtectReq)) + ++N; + if (Attrs.hasFnAttribute(Attribute::StackProtectStrong)) ---------------- I'd love to cast these booleans to `unsigned` and add them, but I find that all of the `static_casts` don't really make this more concise. Thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ https://reviews.llvm.org/D87956 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
