[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. This broke a few tests for me (generating code that now gives the fail result at runtime). I'm not entirely sure which bit is the culprit, but the difference in output (that breaks tests) for one object file is available at https://martin.st/temp/vc1_block-diff-aarch6

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

rjmccall added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2427 +FPOptions FPFeatures = Cast->getFPFeaturesInEffect(Info.Ctx.getLangOpts()); +RM = FPFeatures.getRoundingMode(); + } I think the options really need to be passed in or else c

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#2280617 , @tentzen wrote: > Hi, John, thank you for reviewing this patch and providing feedback. > regarding your comments: > > 1, In the RFC thread early, Reid K (the major contributor of Windows SEH/EH > support) had

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 292696. tianshilei1992 added a comment. Fixed the test failure in OMP50 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOpenMPRuntim

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Just marking this not ready to keep my queue clean until the comments are addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 292690. tianshilei1992 added a comment. Fixed the test case `target_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOpe

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

nemanjai added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14267 +assert((ArgWidth == 32 || ArgWidth == 64) && "Invalid argument width"); +if (BuiltinID == PPC::BI__builtin_altivec_vec_replace_elt) + ConstArg *= ArgWidth / 8; `// The

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee added a comment. Can someone commit my changes on behalf of it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 ___ cfe-commits mailing list cfe-commits@li

Re: [Diffusion] rG03358becbf22: [NFC][Lsan] Fix zero-sized array compilation error

On Thu, 17 Sep 2020 at 18:00, Vitaly Buka via Phabricator < revi...@reviews.llvm.org> wrote: > vitalybuka committed rG03358becbf22: [NFC][Lsan] Fix zero-sized array > compilation error (authored by vitalybuka). > > [NFC][Lsan] Fix zero-sized array compilation error > > > BRANCHES > master > > Fi

[clang] 55edf70 - [NFC] clang-format one line

Author: Vitaly Buka Date: 2020-09-17T18:03:55-07:00 New Revision: 55edf7039e22312790ac950305746262d2856d97 URL: https://github.com/llvm/llvm-project/commit/55edf7039e22312790ac950305746262d2856d97 DIFF: https://github.com/llvm/llvm-project/commit/55edf7039e22312790ac950305746262d2856d97.diff L

[clang] 03358be - [NFC][Lsan] Fix zero-sized array compilation error

Author: Vitaly Buka Date: 2020-09-17T17:59:52-07:00 New Revision: 03358becbf22a221d6d965ec8f3f7068668f7d29 URL: https://github.com/llvm/llvm-project/commit/03358becbf22a221d6d965ec8f3f7068668f7d29 DIFF: https://github.com/llvm/llvm-project/commit/03358becbf22a221d6d965ec8f3f7068668f7d29.diff L

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

rsmith added inline comments. Comment at: libcxx/include/version:254 // # define __cpp_lib_concepts 201806L +# define __cpp_lib_constexpr_dynamic_alloc 201907L // # define __cpp_lib_constexpr_misc 201811L --

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang marked an inline comment as done. weiwang added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:90 + } else { +if (Output.isFilename()) + F = Output.getFilename(); MaskRay wrote: > The output selection logic is untested.

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 292676. weiwang added a comment. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Drive

[PATCH] D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body.

sukraat91 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp:66 +bool isPassedToStdMove(const ParmVarDecl &Param, ASTContext &Context) { + // Check if the parameter has a name, in case of functions like - ---

[PATCH] D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body.

sukraat91 updated this revision to Diff 292669. sukraat91 added a comment. Address comments to remove top level `const auto` in the helper function to check if the argument is being moved, and replace it with its type spelled out. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87540/new/

[PATCH] D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c3bc918db35: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang (authored by amyk). Changed prior to commit: https://reviews.llvm.

[clang] 2c3bc91 - [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang

Author: Amy Kwan Date: 2020-09-17T18:20:53-05:00 New Revision: 2c3bc918db35913437e9302b77b11c08eb3ea6e4 URL: https://github.com/llvm/llvm-project/commit/2c3bc918db35913437e9302b77b11c08eb3ea6e4 DIFF: https://github.com/llvm/llvm-project/commit/2c3bc918db35913437e9302b77b11c08eb3ea6e4.diff LOG:

[PATCH] D87858: [hip] Add HIP scope atomic ops.

t-tye added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:792-799 +ATOMIC_BUILTIN(__hip_atomic_compare_exchange_strong, "v.", "t") +ATOMIC_BUILTIN(__hip_atomic_exchange, "v.", "t") +ATOMIC_BUILTIN(__hip_atomic_fetch_add, "v.", "t") +ATOMIC_BUILTIN(__hip_atom

[PATCH] D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang

steven.zhang accepted this revision. steven.zhang added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82725/new/ https://reviews.llvm.org/D82725

[PATCH] D86895: [Modules] Add stats to measure performance of building and loading modules.

vsapsai updated this revision to Diff 292658. vsapsai added a comment. Tweak stats' names and descriptions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86895/new/ https://reviews.llvm.org/D86895 Files: clang/lib/Frontend/CompilerInstance.cpp

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

aaronpuchert added a comment. Looks pretty good, thanks! I think this clears up the misunderstandings. Since I'm not a native speaker I'd like to wait for @aaron.ballman's opinion before we merge this. Comment at: clang/docs/ThreadSafetyAnalysis.rst:128-135 The set of capabi

[PATCH] D84414: [RISCV] Support Shadow Call Stack

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c466477ad46: [RISCV] Support Shadow Call Stack (authored by zzheng). Changed prior to commit: https://reviews.llvm.org/D84414?vs=292378&id=292651

[clang] 1c46647 - [RISCV] Support Shadow Call Stack

Author: Zhaoshi Zheng Date: 2020-09-17T16:02:35-07:00 New Revision: 1c466477ad468d8a18c43b738df7b7fc6213e9a8 URL: https://github.com/llvm/llvm-project/commit/1c466477ad468d8a18c43b738df7b7fc6213e9a8 DIFF: https://github.com/llvm/llvm-project/commit/1c466477ad468d8a18c43b738df7b7fc6213e9a8.diff

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Hi, John, thank you for reviewing this patch and providing feedback. regarding your comments: 1, In the RFC thread early, Reid K (the major contributor of Windows SEH/EH support) had agreed that "the value proposition is clear and large". 2, could you elaborate why do

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85118/new/ https://reviews.llvm.org/D85118 _

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

ryanofsky marked 4 inline comments as done. ryanofsky added a comment. In D87629#2280475 , @ajtowns wrote: > AJ, maybe this discussion could moved to another issue? I find the details hard to follow, so having another issue would be helpful just to unde

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

ajtowns added a comment. In D87629#2278580 , @aaronpuchert wrote: >> Not sure the `try { AssertHeld } catch (...) { a = 0; }` example reveals >> very much: it seems like thread safety annotations aren't checked within a >> catch block at all? >> `void g

[PATCH] D85810: [clang] Pass-through remarks options to linker

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:90 + } else { +if (Output.isFilename()) + F = Output.getFilename(); The output selection logic is untested. Comment at: clang/test/Driver/opt-record

[PATCH] D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang

amyk updated this revision to Diff 292634. amyk added a comment. - Rebased patch. - Update patch to remove unnecessary immediate handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82725/new/ https://reviews.llvm.org/D82725 Files: clang/incl

[PATCH] D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:10054 + + case Intrinsic::ppc_altivec_mtvsrbm: { +// The llvm.ppc.altivec.mtvsrbm intrinsic can correspond to two different steven.zhang wrote: > Can we handle this inside th

[PATCH] D87858: [hip] Add HIP scope atomic ops.

jfb added a comment. Please provide documentation in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87858/new/ https://reviews.llvm.org/D87858 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D85810: [clang] Pass-through remarks options to linker

thegameg accepted this revision. thegameg added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D87858: [hip] Add HIP scope atomic ops.

t-tye added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:792-799 +ATOMIC_BUILTIN(__hip_atomic_compare_exchange_strong, "v.", "t") +ATOMIC_BUILTIN(__hip_atomic_exchange, "v.", "t") +ATOMIC_BUILTIN(__hip_atomic_fetch_add, "v.", "t") +ATOMIC_BUILTIN(__hip_atom

[PATCH] D85685: Support dwarf fission for wasm object files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ff28fa6a756: Support dwarf fission for wasm object files (authored by dschuff). Changed prior to commit: https://reviews.llvm.org/D85685?vs=29262

[clang] 0ff28fa - Support dwarf fission for wasm object files

Author: Derek Schuff Date: 2020-09-17T14:42:41-07:00 New Revision: 0ff28fa6a75617d61b1aeea77463d6a1684c3c89 URL: https://github.com/llvm/llvm-project/commit/0ff28fa6a75617d61b1aeea77463d6a1684c3c89 DIFF: https://github.com/llvm/llvm-project/commit/0ff28fa6a75617d61b1aeea77463d6a1684c3c89.diff

[PATCH] D87853: [Sema] Update specialization iterator after template argument deduction.

rsmith added a comment. Thanks, this is pretty subtle. Here's a small C++20 testcase that invalidates `InsertPos` while matching partial specializations: template constexpr bool v = true; template requires v constexpr bool v = true; template<> constexpr bool v = true; int k = v; =

[PATCH] D85685: Support dwarf fission for wasm object files

dschuff updated this revision to Diff 292624. dschuff added a comment. rebase, address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85685/new/ https://reviews.llvm.org/D85685 Files: llvm/lib/MC/WasmObjectWriter.cpp Index: llvm/lib/MC/

[PATCH] D87858: [hip] Add HIP scope atomic ops.

hliao updated this revision to Diff 292622. hliao added a comment. Revise formatting following the clang-format suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87858/new/ https://reviews.llvm.org/D87858 Files: clang/include/clang/AST/E

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

ldionne added inline comments. Comment at: libcxx/include/version:254 // # define __cpp_lib_concepts 201806L +# define __cpp_lib_constexpr_dynamic_alloc 201907L // # define __cpp_lib_constexpr_misc 201811L -

[PATCH] D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins

amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:4 // RUN: -target-cpu pwr10 -triple powerpc64-unknown-unknown -emit-llvm %s \ -// RUN: -o - | FileCheck %s -check-prefixes=CHECK-BE,CHECK +// RUN: -o - | FileCheck %s -check-prefixes=CHECK-

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

eandrews added a comment. In D87701#2280246 , @dmajor wrote: > This broke Firefox builds too, in one of our helper binaries that uses a > `wWinMain`, although I'm having trouble writing a minimal reproducer for it. > Simply making a barebones `wWinMain`

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:71-72 if (T->isBooleanType() && !Policy.MSVCFormatting) { Out << (Val.getBoolValue() ? "true" : "false"); } else if (T->isCharType()) { reikdas wrote: > rsmith wrote: > > rsmith

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

mcarrasco added a comment. @jroelofs yes please :p After you mentioned it, I rechecked the guidelines and read: > Once a patch has been reviewed and approved on Phabricator it can then be > committed to trunk. If you do not have commit access, someone has to commit > the change for you (with a

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

rsmith added inline comments. Comment at: libcxx/include/version:254 // # define __cpp_lib_concepts 201806L +# define __cpp_lib_constexpr_dynamic_alloc 201907L // # define __cpp_lib_constexpr_misc 201811L --

[PATCH] D87858: [hip] Add HIP scope atomic ops.

hliao added a comment. `singlethread` scope is added for completeness for the atomicity considering signal handling. It may not be applicable to GPU yet. We could simply ignore them in the late phases of the compiler. If desired, I may remove it as well. Repository: rG LLVM Github Monorepo

[PATCH] D87858: [hip] Add HIP scope atomic ops.

hliao created this revision. hliao added reviewers: yaxunl, b-sumner. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. hliao requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87858 Files: clang/include/clang/AST/Expr.h

[PATCH] D58531: [clang] Specify type of pthread_create builtin

MaskRay added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2058 +/// Missing a type from +GE_Missing_pthread }; You can append a comma so that next time the list gets appended the diff does not have to touch this line. Reposito

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

rsmith added a comment. In D77491#2280096 , @jrtc27 wrote: > If someone cares about pthread_create they might wish to follow up on my > https://reviews.llvm.org/D58531, which I filed early last year to permit > pthread_create to have a proper type in the

[PATCH] D58531: [clang] Specify type of pthread_create builtin

rsmith added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:1223 /// The number of special type IDs. const unsigned NumSpecialTypeIDs = 8; This presumably needs to be increased. Are we missing test coverage that would ha

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. This works for me. @arichardson you want to continue the review or should we take this and if needed improve upon it in subsequent patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/ https://reviews.llvm.or

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

dmajor added a comment. This broke Firefox builds too, in one of our helper binaries that uses a `wWinMain`, although I'm having trouble writing a minimal reproducer for it. Simply making a barebones `wWinMain` program doesn't hit the error. If the patch re-lands, please cc me and I'll re-test.

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

nikic added a comment. In D87188#2277728 , @spatel wrote: > LGTM - I think we should give this a try as-is (with the one-use check still > there), see if anything regresses, then ease/remove the use check as a > follow-on. Okay, let's do that. > As not

[PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

shafik updated this revision to Diff 292607. shafik added a comment. Fix handling of multi-dimensional arrays. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86660/new/ https://reviews.llvm.org/D86660 Files: clang/lib/AST/ASTImporter.cpp lldb/test/API/commands/expression/codegen-cr

[PATCH] D87853: [Sema] Update specialization iterator after template argument deduction.

hoy added a comment. The bug is exposed by instantiating a large variadic template. I haven't managed to get down to a decent size of regression test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87853/new/ https://reviews.llvm.org/D87853 __

[clang] 05d4c4e - [InstCombine] Canonicalize SPF_ABS to abs intrinc

Author: Nikita Popov Date: 2020-09-17T22:28:34+02:00 New Revision: 05d4c4ebc2fb006b8a2bd05b24c6aba10dd2eef8 URL: https://github.com/llvm/llvm-project/commit/05d4c4ebc2fb006b8a2bd05b24c6aba10dd2eef8 DIFF: https://github.com/llvm/llvm-project/commit/05d4c4ebc2fb006b8a2bd05b24c6aba10dd2eef8.diff

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

This revision was automatically updated to reflect the committed changes. Closed by commit rG05d4c4ebc2fb: [InstCombine] Canonicalize SPF_ABS to abs intrinc (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

ldionne added a comment. In D68364#2280187 , @rsmith wrote: > The mechanism by which this interacts with Clang looks good to me. Excellent. > I've not done any detailed analysis to check all the functions made > `constexpr` by P0784 are handled by this

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

dblaikie added a subscriber: rsmith. dblaikie added a comment. @rsmith What's the deal with these anonymous structs/unions? Why do they have copy/move constructors (are those technically called from the enclosing class's copy/move constructors?) but no default constructor to be called from the o

[PATCH] D86895: [Modules] Add stats to measure performance of building and loading modules.

vsapsai planned changes to this revision. vsapsai added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:60 + +ALWAYS_ENABLED_STATISTIC(NumCompileModule, "Number of compiled modules."); + aprantl wrote: > `NumCompiledModules`? Sounds good to m

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

rsmith added a comment. The mechanism by which this interacts with Clang looks good to me. I've not done any detailed analysis to check all the functions made `constexpr` by P0784 are handled by this patch, though. Comment at: libcxx/include/version:254 // # define __cpp_lib

[PATCH] D68364: Prototype implementation of P0784R7: mark all members of std::allocator and std::allocator_traits as constexpr.

ldionne updated this revision to Diff 292600. ldionne added a comment. Herald added a reviewer: libc++. Complete implementation of P0784 with tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68364/new/ https://reviews.llvm.org/D68364 Files: l

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

jroelofs added a comment. btw, do you need me to commit it for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87164/new/ https://reviews.llvm.org/D87164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D87853: [Sema] Update specialization iterator after template argument deduction.

hoy created this revision. Herald added subscribers: cfe-commits, wenlei. Herald added a project: clang. hoy requested review of this revision. Template argument deduction may update the underlying specialization container and invalidate previous iterators of the container. This triggered an asse

[PATCH] D87749: [SyntaxTree][Synthesis] Implement `deepCopy`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/BuildTree.h:45 +/// Deep copies `N`. +/// "Creates a completely independent copy of `N` (a deep

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

jrtc27 added a comment. If someone cares about pthread_create they might wish to follow up on my https://reviews.llvm.org/D58531, which I filed early last year to permit pthread_create to have a proper type in the syntax. It will likely need rebasing, but probably isn't that much work. Reposi

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

Conanap updated this revision to Diff 292589. Conanap added a comment. Herald added a subscriber: kbarton. Added extra test case to demonstrate that the arguments will be reversed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84962/new/ https://reviews.llvm.org/D84962 Files: clang/li

[PATCH] D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins

Conanap added inline comments. Comment at: clang/lib/Headers/altivec.h:17394 +static __inline__ vector signed __int128 __ATTRS_o_ai +vec_mod(vector signed __int128 __a, vector signed __int128 __b) { + return __builtin_altivec_vmodsq(__a, __b); amyk wrote: > nit:

[clang] c145a1c - AArch64::ArchKind's underlying type is uint64_t

Author: Jon Roelofs Date: 2020-09-17T12:13:57-07:00 New Revision: c145a1ca2593e3b8b79687d5ba8c3230c41b5130 URL: https://github.com/llvm/llvm-project/commit/c145a1ca2593e3b8b79687d5ba8c3230c41b5130 DIFF: https://github.com/llvm/llvm-project/commit/c145a1ca2593e3b8b79687d5ba8c3230c41b5130.diff L

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279987 , @MaskRay wrote: > Several previous comments are FreeBSD specific. To we clang developers, the > concrete request is > >> Given that GCC will inline at -O, at least these days, ... > > right? I think this makes s

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

ryanofsky marked 4 inline comments as done. ryanofsky added a comment. Agree with everything in D87629#2278073 . "Assumed" is the key word, and a wrong assumption doesn't imply UB or generating incorrect code

[PATCH] D79916: Map -O to -O1 instead of -O2

MaskRay added a comment. Several previous comments are FreeBSD specific. To we clang developers, the concrete request is > Given that GCC will inline at -O, at least these days, ... right? I think this makes sense, especially when `inline` is explicitly specified... This appears to be related

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

ryanofsky updated this revision to Diff 292576. ryanofsky added a comment. Removed bad information about exceptions, added sentence to clarify what it means for the analysis to "assume" something, tweaked description to only say asserts affect assumptions after calls instead of at or before call

[PATCH] D87791: [CUDA][HIP] Fix -gsplit-dwarf option

yaxunl marked an inline comment as done. yaxunl added a comment. In D87791#2279885 , @tra wrote: > In D87791#2279864 , @yaxunl wrote: > >> It is requested by our debugger team, so it should work with amdgpu. > > Is

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279918 , @jrtc27 wrote: > In D79916#2279901 , @Bdragon28 wrote: > >> In D79916#2279884 , @jrtc27 wrote: >> >>> But also you really shoul

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279901 , @Bdragon28 wrote: > In D79916#2279884 , @jrtc27 wrote: > >> But also you really should not get warnings for unused static functions in >> included headers, only ones defi

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279884 , @jrtc27 wrote: > But also you really should not get warnings for unused static functions in > included headers, only ones defined in the C source file itself. We'd have > countless warnings in the kernel acr

[PATCH] D87791: [CUDA][HIP] Fix -gsplit-dwarf option

MaskRay added a comment. (Note that ideally -gsplit-dwarf should not imply -g2 but it currents does so. And Clang and GCC have not agreed whether we should add a new flag like -fsplit-dwarf. /For -gsplit-dwarf builds, it is the best to ensure -g is also specified/.) CHANGES SINCE LAST ACTION

[PATCH] D87791: [CUDA][HIP] Fix -gsplit-dwarf option

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:918 if (FinalOutput && Args.hasArg(options::OPT_c)) { -SmallString<128> T(FinalOutput->getValue()); +SmallString<128> T(llvm::sys::path::stem(FinalOutput->getValue())); +AddPostfi

[PATCH] D87791: [CUDA][HIP] Fix -gsplit-dwarf option

tra added a comment. In D87791#2279864 , @yaxunl wrote: > It is requested by our debugger team, so it should work with amdgpu. Is the naming scheme for GPU-side DWO files dictated by debugger? If that's the case, it may be worth adding a comment about th

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279875 , @jrtc27 wrote: > In D79916#2279871 , @Bdragon28 wrote: > >> In D79916#2279866 , @jrtc27 wrote: >> >>> In D79916#2279863

RE: [clang] 829d14e - Revert "[NFC] Refactor DiagnosticBuilder and PartialDiagnostic"

[AMD Public Use] It was reverted because it caused regressions in some CUDA apps. Is there a way for me to modify the commit message? Thanks. Sam -Original Message- From: Roman Lebedev Sent: Thursday, September 17, 2020 2:14 PM To: Liu, Yaxun (Sam) ; Yaxun Liu Cc: cfe-commits@lists.

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279871 , @Bdragon28 wrote: > In D79916#2279866 , @jrtc27 wrote: > >> In D79916#2279863 , @Bdragon28 >> wrote: >> >>> In D79916#2279816

Re: [clang-tools-extra] 772bd8a - Revert "[CUDA][HIP] Defer overloading resolution diagnostics for host device functions"

Same comment about commit message, thanks On Thu, Sep 17, 2020 at 8:56 PM Yaxun Liu via cfe-commits wrote: > > > Author: Yaxun (Sam) Liu > Date: 2020-09-17T13:55:31-04:00 > New Revision: 772bd8a7d99b8db899f594d393986e4b6cd85aa1 > > URL: > https://github.com/llvm/llvm-project/commit/772bd8a7d99b8

Re: [clang] 829d14e - Revert "[NFC] Refactor DiagnosticBuilder and PartialDiagnostic"

On Thu, Sep 17, 2020 at 8:57 PM Yaxun Liu via cfe-commits wrote: > > > Author: Yaxun (Sam) Liu > Date: 2020-09-17T13:56:09-04:00 > New Revision: 829d14ee0a6aa79c89f7f3d9fcd9d27d3efd2b91 > > URL: > https://github.com/llvm/llvm-project/commit/829d14ee0a6aa79c89f7f3d9fcd9d27d3efd2b91 > DIFF: > http

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. (and FreeBSD has an `__always_inline` in sys/sys/cdef.s like `__inline`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79916/new/ https://reviews.llvm.org/D79916 ___ cfe-commits m

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279866 , @jrtc27 wrote: > In D79916#2279863 , @Bdragon28 wrote: > >> In D79916#2279816 , @jrtc27 wrote: >> >>> In D79916#2279812

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279863 , @Bdragon28 wrote: > In D79916#2279816 , @jrtc27 wrote: > >> In D79916#2279812 , @Bdragon28 >> wrote: >> >>> In D79916#2279045

[PATCH] D87791: [CUDA][HIP] Fix -gsplit-dwarf option

yaxunl marked an inline comment as done. yaxunl added a comment. In D87791#2279821 , @tra wrote: > In D87791#2278417 , @yaxunl wrote: > >> Therefore in either case there is no need to rename the intermediate .o >>

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279863 , @Bdragon28 wrote: > In D79916#2279816 , @jrtc27 wrote: > >> In D79916#2279812 , @Bdragon28 >> wrote: >> >>> In D79916#2279045

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279816 , @jrtc27 wrote: > In D79916#2279812 , @Bdragon28 wrote: > >> In D79916#2279045 , @jrtc27 wrote: >> >>> This has significantly re

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

tra added a comment. In D84362#2279688 , @tra wrote: > Apparently this patch triggers compiler crashes on some of our code. I'll try > to create a reproducer, but it would be great to revert the patch for now. It's likely the same issue as the one report

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

yaxunl added a comment. In D84364#2279684 , @hctim wrote: > Looks like this patch broke the MSan buildbots, PTAL (repro instructions > https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild): > > http://lab.llvm.org:8011/builders/sanitizer-x

[clang] 829d14e - Revert "[NFC] Refactor DiagnosticBuilder and PartialDiagnostic"

Author: Yaxun (Sam) Liu Date: 2020-09-17T13:56:09-04:00 New Revision: 829d14ee0a6aa79c89f7f3d9fcd9d27d3efd2b91 URL: https://github.com/llvm/llvm-project/commit/829d14ee0a6aa79c89f7f3d9fcd9d27d3efd2b91 DIFF: https://github.com/llvm/llvm-project/commit/829d14ee0a6aa79c89f7f3d9fcd9d27d3efd2b91.dif

[clang-tools-extra] 772bd8a - Revert "[CUDA][HIP] Defer overloading resolution diagnostics for host device functions"

Author: Yaxun (Sam) Liu Date: 2020-09-17T13:55:31-04:00 New Revision: 772bd8a7d99b8db899f594d393986e4b6cd85aa1 URL: https://github.com/llvm/llvm-project/commit/772bd8a7d99b8db899f594d393986e4b6cd85aa1 DIFF: https://github.com/llvm/llvm-project/commit/772bd8a7d99b8db899f594d393986e4b6cd85aa1.dif

[PATCH] D87791: [CUDA][HIP] Fix -gsplit-dwarf option

tra added a comment. In D87791#2278417 , @yaxunl wrote: > Therefore in either case there is no need to rename the intermediate .o files > since they are temporary files which have unique names. > > The .dwo files are not temporary files. They are supposed

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

rnk added inline comments. Comment at: clang/lib/Driver/Distro.cpp:205 +const llvm::Triple &TargetOrHost) { + static Distro::DistroType Type = Distro::UninitializedDistro; + rnk wrote: > aganea wrote: > > I'm not sure if this

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279812 , @Bdragon28 wrote: > In D79916#2279045 , @jrtc27 wrote: > >> This has significantly regressed FreeBSD's performance with the new version >> of Clang. It seems Clang does n

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279045 , @jrtc27 wrote: > This has significantly regressed FreeBSD's performance with the new version > of Clang. It seems Clang does not inline functions at -O1, unlike GCC, and > since FreeBSD currently compiles it

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

rnk added inline comments. Comment at: clang/lib/Driver/Distro.cpp:205 +const llvm::Triple &TargetOrHost) { + static Distro::DistroType Type = Distro::UninitializedDistro; + aganea wrote: > I'm not sure if this is safe. @rnk D

  1   2   >