Re: [clang] a8503b8 - [NFC] Remove unused static function

Yup, unless you this breaks something, I'd really prefer to keep it. On Sat, 12 Sep 2020, 03:24 David Blaikie, wrote: > LLVM_DUMP_METHOD is meant to be used for annotating functions that might > be useful to execute from a debugger to dump data structures, etc - so it's > expected that they'd be

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. This should be ok, I think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87547/new/ https://reviews.llvm.org/D87547 __

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mstorsjo added a comment. Does the static lib built in this case include any dllexport attributes (that can cause issues if linking it statically into another DLL)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87539/new/ https://reviews.llvm.org/

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob updated this revision to Diff 291371. dougpuob added a comment. Fixed crash on Windows when run regression test (llvm-lit for `readability-identifier-naming.cpp` file). This is because over range parameter made ctor of std::string copying out of range memory from source. The over range

[PATCH] D87537: [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

tlively added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:246-252 + llvm::Reloc::Model RelocationModel; + unsigned PICLevel; + bool IsPIE; + std::tie(RelocationModel, PICLevel, IsPIE) = ParsePICArgs(*this, DriverArgs); + if (RelocationModel == ll

[PATCH] D86926: FormatTest: Provide real line number in failure messages

dblaikie added a comment. Could this be done with a custom matcher, perhaps? (might be a bit tidier than macros with __FILE__ and __LINE__ manually handled, etc? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86926/new/ https://reviews.llvm.org/D86

Re: [clang] a8503b8 - [NFC] Remove unused static function

LLVM_DUMP_METHOD is meant to be used for annotating functions that might be useful to execute from a debugger to dump data structures, etc - so it's expected that they'd be unused. Do you find that this function is not useful to use from a debugger/similar situation? (or perhaps because the functio

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

zixuw updated this revision to Diff 291364. zixuw added a comment. Separate warning message improvement and fix-it hint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82118/new/ https://reviews.llvm.org/D82118 Files: clang/lib/Lex/PPLexerChange.

[clang] 928d419 - Fix a couple of tests that relied on the clang binary having 'clang' somewhere in the name

Author: David Blaikie Date: 2020-09-11T17:45:56-07:00 New Revision: 928d419797ea173090e26f624f08801c7d6661e3 URL: https://github.com/llvm/llvm-project/commit/928d419797ea173090e26f624f08801c7d6661e3 DIFF: https://github.com/llvm/llvm-project/commit/928d419797ea173090e26f624f08801c7d6661e3.diff

[PATCH] D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20

CaseyCarter accepted this revision. CaseyCarter added a comment. LGTM! Comment at: libcxx/include/iterator:1052 class _LIBCPP_TEMPLATE_VIS ostream_iterator : public iterator { `std::iterator` has been deprecated since C++17. Should this inheritance be d

[clang] a8503b8 - [NFC] Remove unused static function

Author: Vitaly Buka Date: 2020-09-11T16:50:30-07:00 New Revision: a8503b87f739776cc9d5738f69aa0990db952340 URL: https://github.com/llvm/llvm-project/commit/a8503b87f739776cc9d5738f69aa0990db952340 DIFF: https://github.com/llvm/llvm-project/commit/a8503b87f739776cc9d5738f69aa0990db952340.diff L

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

zequanwu closed this revision. zequanwu added a comment. committed here https://reviews.llvm.org/rG83286a1a8f059d1664b64341854676a36a85cecd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80409/new/ https://reviews.llvm.org/D80409

[clang] 83286a1 - [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

Author: Zequan Wu Date: 2020-09-11T16:19:43-07:00 New Revision: 83286a1a8f059d1664b64341854676a36a85cecd URL: https://github.com/llvm/llvm-project/commit/83286a1a8f059d1664b64341854676a36a85cecd DIFF: https://github.com/llvm/llvm-project/commit/83286a1a8f059d1664b64341854676a36a85cecd.diff LOG

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

zequanwu updated this revision to Diff 291355. zequanwu added a comment. update comment. add a test case for template function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80409/new/ https://reviews.llvm.org/D80409 Files: clang/include/clang/B

[PATCH] D87482: Fix clang Wrange-loop-analysis in BuildTree.cpp

gribozavr2 added a comment. Sorry, I didn't realize you don't have commit access. Pushed this patch to git, thanks for the contribution! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87482/new/ https://reviews.llvm.org/D87482

[PATCH] D87482: Fix clang Wrange-loop-analysis in BuildTree.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe10df779f097: Fix clang Wrange-loop-analysis in BuildTree.cpp (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D86156: [BFI] Make BFI information available through loop passes inside LoopStandardAnalysisResults

modimo updated this revision to Diff 291353. modimo added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86156/new/ https://reviews.llvm.org/D86156 Files: llvm/include/llvm/Analysis/LoopAnalysisManager.h llvm/include/llvm/Transforms/Scalar/LoopPassManager.h llvm/

[clang] e10df77 - Fix clang Wrange-loop-analysis in BuildTree.cpp

Author: Dmitri Gribenko Date: 2020-09-12T01:07:54+02:00 New Revision: e10df779f097e3a1fb02d901117ce71a5dd9dda2 URL: https://github.com/llvm/llvm-project/commit/e10df779f097e3a1fb02d901117ce71a5dd9dda2 DIFF: https://github.com/llvm/llvm-project/commit/e10df779f097e3a1fb02d901117ce71a5dd9dda2.dif

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

aganea added a comment. @russell.gallop Do you think you can upload the patch again by setting the Repository to "Monorepo"? F12921062: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86694/new/ https:/

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87395/new/ https://reviews.llvm.org/D87395

[clang] 43e6c59 - docs: add a newline to appease Sphinx

Author: Saleem Abdulrasool Date: 2020-09-11T22:09:29Z New Revision: 43e6c59f1c1fc3c1b9cdcddfe9826b9abf2cfb73 URL: https://github.com/llvm/llvm-project/commit/43e6c59f1c1fc3c1b9cdcddfe9826b9abf2cfb73 DIFF: https://github.com/llvm/llvm-project/commit/43e6c59f1c1fc3c1b9cdcddfe9826b9abf2cfb73.diff

[PATCH] D87517: [MinGW] Use lib prefix for libraries

mati865 added a comment. `-DLLVM_ENABLE_PROJECTS="clang;lldb" -DLLVM_BUILD_LLVM_DYLIB=1` with only this patch applied (`<` is before, `>` is after): $ diff <(cd ../build && find ./ | sort) <(cd ../build2/ && find ./ | sort) 38a39,41 > ./bin/libLLVM.dll > ./bin/libLTO.dll > ./bin/libRem

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd updated this revision to Diff 291346. compnerd edited the summary of this revision. compnerd added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87396/new/ https://reviews.llvm.org/D87396 Files: clang/include

[clang] ee13ae0 - Fix test hip-gz-options.hip

Author: Yaxun (Sam) Liu Date: 2020-09-11T17:57:36-04:00 New Revision: ee13ae030e21d584c72d384ea463896400ccee1c URL: https://github.com/llvm/llvm-project/commit/ee13ae030e21d584c72d384ea463896400ccee1c DIFF: https://github.com/llvm/llvm-project/commit/ee13ae030e21d584c72d384ea463896400ccee1c.dif

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80409/new/ https://reviews.llvm.org/D80409 __

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5ab5b20fb2a: Sema: add support for `__attribute__((__swift_error__))` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D87331?vs=290990&id=291336#toc Repository: rG LLVM Git

[clang] f5ab5b2 - Sema: add support for `__attribute__((__swift_error__))`

Author: Saleem Abdulrasool Date: 2020-09-11T21:20:38Z New Revision: f5ab5b20fb2aae5567e6c50cc642ff63eb2146d4 URL: https://github.com/llvm/llvm-project/commit/f5ab5b20fb2aae5567e6c50cc642ff63eb2146d4 DIFF: https://github.com/llvm/llvm-project/commit/f5ab5b20fb2aae5567e6c50cc642ff63eb2146d4.diff

[PATCH] D87321: Fix -gz=zlib options for linker

This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rGccb4124a4172: Fix -gz=zlib options for linker (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D87321?vs=29

[clang] ccb4124 - Fix -gz=zlib options for linker

Author: Yaxun (Sam) Liu Date: 2020-09-11T17:12:58-04:00 New Revision: ccb4124a4172bf2cb2e1cd7c253f0f1654fce294 URL: https://github.com/llvm/llvm-project/commit/ccb4124a4172bf2cb2e1cd7c253f0f1654fce294 DIFF: https://github.com/llvm/llvm-project/commit/ccb4124a4172bf2cb2e1cd7c253f0f1654fce294.dif

[PATCH] D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body.

sukraat91 updated this revision to Diff 291334. sukraat91 added a comment. Updated patch to contain changes to variable case from `paramName` to `ParamName`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87540/new/ https://reviews.llvm.org/D87540 Files: clang-tools-extra/clang-tidy/

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

zequanwu updated this revision to Diff 291331. zequanwu added a comment. Add check for MSVC version 19.14 (removed `AutoParmTemplate auto_bool` as its mangled name conflicts with `AutoParmTemplate<0> auto_int` in V19.14). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D87533: [SyntaxTree][Synthesis] Add support for Tree.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c37b82f5ba5: [SyntaxTree][Synthesis] Add support for Tree. (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87533/new/ https://revie

[clang] 7c37b82 - [SyntaxTree][Synthesis] Add support for Tree.

Author: Eduardo Caldas Date: 2020-09-11T20:37:23Z New Revision: 7c37b82f5ba5883b331608b0077c0b30bf301874 URL: https://github.com/llvm/llvm-project/commit/7c37b82f5ba5883b331608b0077c0b30bf301874 DIFF: https://github.com/llvm/llvm-project/commit/7c37b82f5ba5883b331608b0077c0b30bf301874.diff LOG

[clang] df477db - [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

Author: Xun Li Date: 2020-09-11T13:35:37-07:00 New Revision: df477db5f9e0ea2a4890040b65002d93e33209b0 URL: https://github.com/llvm/llvm-project/commit/df477db5f9e0ea2a4890040b65002d93e33209b0 DIFF: https://github.com/llvm/llvm-project/commit/df477db5f9e0ea2a4890040b65002d93e33209b0.diff LOG: [

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf477db5f9e0: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle (authored by lxfind). Repository: rG LLVM Github Monore

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind added a comment. In D87470#2268911 , @rjmccall wrote: > Thanks, LGTM. Thank you for reviewing and the suggestions on testcase! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://review

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470

[PATCH] D87517: [MinGW] Use lib prefix for libraries

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. This looks good to me! I can push it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87517/new/ https://reviews.llvm.org/D87517 __

[PATCH] D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body.

sukraat91 updated this revision to Diff 291326. sukraat91 added a comment. Revert to older commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87540/new/ https://reviews.llvm.org/D87540 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp clang-tools-ex

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind updated this revision to Diff 291324. lxfind added a comment. remove asan option, not needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 Files: clang/lib/Sema/SemaCoroutine.cpp clang/test/Cod

[PATCH] D87537: [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

sbc100 updated this revision to Diff 291323. sbc100 edited the summary of this revision. sbc100 added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87537/new/ https://reviews.llvm.org/D87537 Files: clang/lib/Driver/ToolChains

[PATCH] D87537: [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

sbc100 marked an inline comment as done. sbc100 added inline comments. Comment at: lld/wasm/Writer.cpp:478 + toString(*sym) + "`. Use --no-check-features to suppress."); + else if (sym->isExported()) +error(Twine("mutable global exported but

[PATCH] D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body.

sukraat91 updated this revision to Diff 291322. sukraat91 added a comment. Changed the case for the first character in variable `paramName` from lowercase to uppercase, to pass pre-merge checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87540/new/ https://reviews.llvm.org/D87540 F

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews.llvm.org/D87243

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind updated this revision to Diff 291321. lxfind added a comment. Add test to verify that lifetime.end appears right after the address call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 Files: clang

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2173 + SubjectList<[Enum, EnumConstant, Field, Function, GlobalVar, Struct, TypedefName, + ObjCInterface, ObjCClassMethod, ObjCInstanceMethod, ObjCProperty, ObjCProtocol], +

[PATCH] D87517: [MinGW] Use lib prefix for libraries

mati865 added a comment. I haven't tried ` BUILD_SHARED_LIBS=TRUE` TBH. Effects visible at first glance: bin/LLVM.dll -> bin/libLLVM.dll bin/LTO.dll -> bin/libLTO.dll lib/liblibclang.a -> lib/libclang.a lib/liblibclang.dll.a -> lib/libclang.a lib/libliblldb.d

[PATCH] D87533: [SyntaxTree][Synthesis] Add support for Tree.

eduucaldas updated this revision to Diff 291320. eduucaldas marked an inline comment as done. eduucaldas added a comment. Add argument names to function declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87533/new/ https://reviews.llvm.org/D

[PATCH] D87537: [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

tlively added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:246-252 + llvm::Reloc::Model RelocationModel; + unsigned PICLevel; + bool IsPIE; + std::tie(RelocationModel, PICLevel, IsPIE) = ParsePICArgs(*this, DriverArgs); + if (RelocationModel == ll

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 created this revision. mati865 added a reviewer: clang. mati865 added a project: clang. Herald added subscribers: cfe-commits, mgorny. mati865 requested review of this revision. It builds without errors and makes possible to use `CLANG_LINK_CLANG_DYLIB=1` Repository: rG LLVM Github Mon

[PATCH] D87321: Fix -gz=zlib options for linker

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-gz-options.hip:14 +// CHECK-DAG: {{".*clang.*" .* "--compress-debug-sections=zlib"}} +// CHECK: {{"--compress-debug-sections=zlib"}} MaskRay wrote: > Since th

[PATCH] D87537: [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

sbc100 added a comment. OK.. updated PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87537/new/ https://reviews.llvm.org/D87537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D87321: Fix -gz=zlib options for linker

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/hip-gz-options.hip:14 +// CHECK-DAG: {{".*clang.*" .* "--compress-debug-sections=zlib"}} +// CHECK: {{"--compress-debug-sections=zlib"}} -

[PATCH] D87537: [lld][WebAssembly] Add mutable-globals to feature section if needed

sbc100 updated this revision to Diff 291317. sbc100 edited the summary of this revision. sbc100 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. switch to verification in wasm-ld Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D87321: Fix -gz=zlib options for linker

yaxunl updated this revision to Diff 291310. yaxunl marked 3 inline comments as done. yaxunl added a comment. fix tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87321/new/ https://reviews.llvm.org/D87321 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/lib/Driver/ToolChains

[PATCH] D87321: Fix -gz=zlib options for linker

yaxunl added inline comments. Comment at: clang/test/Driver/hip-gz-options.hip:1 +// REQUIRES: clang-driver, x86-registered-target, amdgpu-registered-target + MaskRay wrote: > clang-driver is for some legacy cygwin stuff. It should not be needed. > > Does --offl

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. In D86694#2268182 , @russell.gallop wrote: > > Thanks. I'm looking at porting the standalone variant, drawing on D42519 > and Windows support from sanitizer_common. > Does that sound like a

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

srhines added a comment. In D83144#2268760 , @fmayer wrote: > Thanks for the review! Should I wait for Alex to take a look, or is it fine > like this? George added @alexfh a while ago, but if it's ok with you, maybe give him until Tuesday or Wednesday n

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer added a comment. Should I wait for Alex to take a look, or is it fine like this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83144/new/ https://reviews.llvm.org/D83144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D87482: Fix clang Wrange-loop-analysis in BuildTree.cpp

jthemphill added a comment. Will someone come by and land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87482/new/ https://reviews.llvm.org/D87482 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body.

sukraat91 created this revision. sukraat91 added a reviewer: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. sukraat91 requested review of this revision. This patch solves a bug (https://bugs.llvm.org/show_bug.cgi?id=44598) that was filed for a

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

rnk added a comment. Looks good, but we should test both sides of the MSVC behavior. Comment at: clang/test/CodeGenCXX/mangle-ms-auto-templates.cpp:17 + AutoParmTemplate<0> auto_int; + // CHECK: call {{.*}} @"??0?$AutoParmTemplate@$H0A@@@QAE@XZ" + AutoParmTemplate auto_bool;

[PATCH] D87517: [MinGW] Use lib prefix for libraries

mstorsjo added a comment. Herald added a reviewer: JDevlieghere. What's the practical effect of this? I see that a number of libraries already have a lib prefix prepended, like libclang/liblldb - I presume this changes the name of the individual libs (for BUILD_SHARED_LIBS=TRUE configurations)?

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mati865 created this revision. mati865 added a reviewer: clang. mati865 added a project: clang. Herald added subscribers: cfe-commits, mgorny. mati865 requested review of this revision. It builds fine for MinGW on Windows. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87539 F

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

rjmccall added a comment. IRGen generally doesn't query the AST constant evaluator for arbitrary expressions; we do it for certain calls and loads because otherwise we might emit an illegal ODR-use, but otherwise we just expect LLVM's constant-folding to do a decent job. Repository: rG LLVM

[PATCH] D87533: [SyntaxTree][Synthesis] Add support for Tree.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/BuildTree.h:39 +syntax::Tree * +createTree(Arena &A, std::vector>, + syntax::NodeKind);

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

rjmccall added a comment. In D87470#2268267 , @lxfind wrote: > hmm @rjmccall, I don't think there is a stable way to test this. The code > generated for symmetric transfer is way too complicated to stably pattern > match one less item in the frame. I do

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

nickdesaulniers added a comment. I don't have any thoughts on the change per se, so just minor thoughts/generic code review. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6995 + case llvm::Triple::aarch64_be: +if (Arg *A = Args.getLastArg(options::OPT_mmark_bti_proper

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Just a minor tweak and then LGTM. Comment at: clang/include/clang/Driver/Options.td:4287-4290 +def fpass_by_value_noalias: Flag<["-"], "fpass-by-value-noalias">, + HelpT

[clang] 238ae4e - [SyntaxTree] Add const qualifiers, from [llvm-qualified-auto]

Author: Eduardo Caldas Date: 2020-09-11T18:39:02Z New Revision: 238ae4eee05187758e42c00af237592612d585c2 URL: https://github.com/llvm/llvm-project/commit/238ae4eee05187758e42c00af237592612d585c2 DIFF: https://github.com/llvm/llvm-project/commit/238ae4eee05187758e42c00af237592612d585c2.diff LOG

[PATCH] D87522: [SyntaxTree] Add const qualifiers, from [llvm-qualified-auto]

This revision was automatically updated to reflect the committed changes. Closed by commit rG238ae4eee051: [SyntaxTree] Add const qualifiers, from [llvm-qualified-auto] (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87522/new

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks for creating the new test, and for making this more flexible. Everything else looks good here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83144/new/ https://reviews.llvm.

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer updated this revision to Diff 291297. fmayer added a comment. Added new file for the tests. This way, we keep the tests for the normal case as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83144/new/ https://reviews.llvm.org/D83144 Files: clang-tools-extra/clang-tidy/an

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/android-comparison-in-temp-failure-retry.c:1 -// RUN: %check_clang_tidy %s android-comparison-in-temp-failure-retry %t +// RUN: %check_clang_tidy %s android-comparison-in-temp-failure-retry %t -

[PATCH] D87523: [SyntaxTree] Reduce visibility of `Arena::lexBuffer`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG515238d5b113: [SyntaxTree] Reduce visibility of `Arena::lexBuffer`. (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 515238d - [SyntaxTree] Reduce visibility of `Arena::lexBuffer`.

Author: Eduardo Caldas Date: 2020-09-11T18:32:38Z New Revision: 515238d5b1133f87f85445b9f35783ca2d3a2e7b URL: https://github.com/llvm/llvm-project/commit/515238d5b1133f87f85445b9f35783ca2d3a2e7b DIFF: https://github.com/llvm/llvm-project/commit/515238d5b1133f87f85445b9f35783ca2d3a2e7b.diff LOG

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish marked 3 inline comments as done. snehasish added a subscriber: dblaikie. snehasish added a comment. > It feels wrong that the assembly+llvm-profdata test is in clang/test I agree with @dblaikie and your assessment that it feels wrong to add such a test to clang. In the first version o

[PATCH] D87523: [SyntaxTree] Reduce visibility of `Arena::lexBuffer`.

eduucaldas updated this revision to Diff 291293. eduucaldas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87523/new/ https://reviews.llvm.org/D87523 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/Tooling/Syn

[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

jyknight added a comment. But this (re-)breaks the functionality of -fvisibility-inlines-hidden on Darwin. That seems bad? I'd've liked to see more of an explanation as to why this was considered a necessary breakage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d152127d48f: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump (authored by eduucaldas). Repository: rG LLVM Githu

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish updated this revision to Diff 291292. snehasish added a comment. Remove clang/CodeGen test, update arg render logic. - Removed the clang/CodeGen test. - Added a check for the option to be rendered. - Fixed extra flags in driver test. Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 5d15212 - [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump

Author: Eduardo Caldas Date: 2020-09-11T18:22:00Z New Revision: 5d152127d48fbcf47a8d059aa68a84c365ae3cb9 URL: https://github.com/llvm/llvm-project/commit/5d152127d48fbcf47a8d059aa68a84c365ae3cb9 DIFF: https://github.com/llvm/llvm-project/commit/5d152127d48fbcf47a8d059aa68a84c365ae3cb9.diff LOG

[PATCH] D86508: [clang] improve GCC-compat for C90 __builtin_ functions

nickdesaulniers added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2370 +* ``bcmp`` * ``memchr`` nickdesaulniers wrote: > rsmith wrote: > > aaron.ballman wrote: > > > Can you mention the deprecation issue here? > > Do we really provide consta

[PATCH] D87321: Fix -gz=zlib options for linker

MaskRay added inline comments. Comment at: clang/test/Driver/hip-gz-options.hip:1 +// REQUIRES: clang-driver, x86-registered-target, amdgpu-registered-target + clang-driver is for some legacy cygwin stuff. It should not be needed. Does --offload-arch=gfx906 have

[PATCH] D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain

tambre abandoned this revision. tambre added a comment. In D86877#2262448 , @phosek wrote: > It's not clear why couldn't we support per-target runtime directory? It uses > the standard multiarch layout, so in you'd end up using a directory like > `[path/

[PATCH] D87321: Fix -gz=zlib options for linker

yaxunl added inline comments. Comment at: clang/test/Driver/compress.c:26 +// CHECK-OPT_GZ_EQ_NONE: {{".*clang.*".* "--compress-debug-sections=none"}} +// CHECK-OPT_GZ_EQ_NONE: {{".*ld.*".* "--compress-debug-sections=none"}} + MaskRay wrote: > If the user sets CL

[PATCH] D87321: Fix -gz=zlib options for linker

yaxunl updated this revision to Diff 291285. yaxunl marked 3 inline comments as done. yaxunl added a comment. fix tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87321/new/ https://reviews.llvm.org/D87321 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/lib/Driver/ToolChains

[PATCH] D87533: [SyntaxTree][Synthesis] Add support for Tree.

eduucaldas updated this revision to Diff 291284. eduucaldas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87533/new/ https://reviews.llvm.org/D87533 Files: clang/include/clang/Tooling/Syntax/BuildTree.h clang/lib/Toolin

[PATCH] D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump

eduucaldas updated this revision to Diff 291280. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. Remove `createLeafLowLevel` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87495/new/ https://reviews.llvm.org/D87495 Files:

[PATCH] D87519: [analyzer][Liveness][NFC] Enqueue the CFGBlocks post-order

xazax.hun added inline comments. Comment at: clang/lib/Analysis/LiveVariables.cpp:522 - // FIXME: we should enqueue using post order. - for (const CFGBlock *B : cfg->nodes()) { + for (const CFGBlock *B : *AC.getAnalysis()) { worklist.enqueueBlock(B); Wi

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a project: clang. compnerd requested review of this revision. This introduces the new `swift_name` attribute that allows annotating interfaces with an alternate spelling for Swift. This is used as part of the i

[PATCH] D87533: [SyntaxTree][Synthesis] Add support for Tree.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. In a future patch - Implement helper function to generate Trees for tests - and test Tree methods, namely `findFirstLeaf` and `findLastLeaf` Rep

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a project: clang. compnerd requested review of this revision. This extends semantic analysis of attributes for Swift interoperability by introducing the `swift_bridge` attribute. This attribute enables bridging

[PATCH] D87518: [analyzer][Liveness][NFC] Remove an unneeded pass to collect variables that appear in an assignment

xazax.hun added inline comments. Comment at: clang/lib/Analysis/LiveVariables.cpp:332 if (B->isAssignmentOp()) { if (!LV.killAtAssign) return; Nit: Maybe moving this to the front of the function would simplify the code a bit. Repository: rG LL

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

lebedev.ri added a comment. Thank you for looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/ https://reviews.llvm.org/D71199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87518: [analyzer][Liveness][NFC] Remove an unneeded pass to collect variables that appear in an assignment

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Looks a lot cleaner this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87518/new/ https://reviews.llvm.org/D87518

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

lebedev.ri added a comment. Thank you for looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87527/new/ https://reviews.llvm.org/D87527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] ab2ed8b - [SVE] Regenerate sve vector bits tests. NFC

Author: David Green Date: 2020-09-11T18:51:57+01:00 New Revision: ab2ed8bce9e924a2fc734ca4369419c18d124043 URL: https://github.com/llvm/llvm-project/commit/ab2ed8bce9e924a2fc734ca4369419c18d124043 DIFF: https://github.com/llvm/llvm-project/commit/ab2ed8bce9e924a2fc734ca4369419c18d124043.diff L

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2121 +def SwiftBridgedTypedef : Attr { + let Spellings = [GNU<"swift_bridged_typedef">]; aaron.ballman wrote: > Should this be inherited on redeclarations? I don't see why not. @rjm

[PATCH] D87518: [analyzer][Liveness][NFC] Remove an unneeded pass to collect variables that appear in an assignment

xazax.hun added inline comments. Comment at: clang/lib/Analysis/LiveVariables.cpp:326 void TransferFunctions::VisitBinaryOperator(BinaryOperator *B) { + if (LV.killAtAssign && B->getOpcode() == BO_Assign) { +if (const auto *DR = dyn_cast(B->getLHS()->IgnoreParens())) {

  1   2   3   >