[PATCH] D85834: [AST] Fix a crash on calling getASTRecordLayout on an invalid RecordDecl.

hokein abandoned this revision. hokein added a comment. Richard fixed this in https://github.com/llvm/llvm-project/commit/269bc3f5df6c3b75de515a48063c6941ef8fbbe6 last night. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85834/new/ https://review

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

eduucaldas updated this revision to Diff 285265. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 Files: clang/lib/AST/NestedNameSpecifier.cpp Index: clang/lib/AST/NestedNam

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

jdoerfert updated this revision to Diff 285264. jdoerfert added a comment. Rebase on top of D85878 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85735/new/ https://reviews.llvm.org/D85735 Files: clang/include/cl

[PATCH] D85879: [OpenMP] Overload `std::isnan` and friends multiple times for the GPU

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, jhuber6, ABataev, MaskRay. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. `std::isnan` and friends can b

[PATCH] D85878: [OpenMP] Context selector extensions for return value overloading

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, jhuber6, ABataev. Herald added subscribers: llvm-commits, guansong, bollu, kristof.beyls, yaxunl. Herald added a reviewer: aaron.ballman. Herald added projects: clang, LLVM. jdoerfert requested review of this revision. Her

[PATCH] D85877: [OpenMP] Support nested OpenMP context selectors (declare variant)

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, jhuber6, ABataev. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Due to `omp begin/end declare variant`,

[PATCH] D85876: [OpenMP][FIX] Do not drop a '$' while demangling declare variant names

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, jhuber6, ABataev. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monorepo

[PATCH] D85875: [OpenMP][FIX] Do not crash trying to print a missing (demangled) user condition

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, jhuber6, ABataev. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monorepo

[PATCH] D85874: [PowerPC] Add readflm/setflm intrinsics to Clang

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, steven.zhang, ZhangKang, PowerPC. Herald added subscribers: llvm-commits, cfe-commits, shchenz, kbarton. Herald added projects: clang, LLVM. qiucf requested review of this revision. Herald added a subscriber: wuzish. dbcfbffc

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. It still seems to trigger on structs at head: $ cat /tmp/a.cc struct A { const char *a; const char *b; const char *c; }; static A a = {"", "" "", ""}; $ ./build/bin/clang++ -Wstring-concatenation -o /dev/null -c /tmp/a.cc C:/src/tmp/a.cc:10:15: warning:

[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

NoQ added inline comments. Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:39 void derefAfterRelease() { - std::unique_ptr P(new A()); + std::unique_ptr P(new A()); // expected-note {{Smart pointer 'P' is constructed}} P.release(); // expected-note {{Smart pointe

[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:619 getCheckerManager().runCheckersForEvalCall(DstEvaluated, *I, *Call, *this, - CallOpts); +

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85799/new/ https://reviews.llvm.org/D85799 _

[PATCH] D85798: Split Preprocessor/init.c test. NFC.

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Preprocessor/init-arm.c:19 +// ARM:#define __CHAR16_TYPE__ unsigned short +// ARM:#define __CHAR32_TYPE__ unsigned int +// ARM:#define __CHAR_BIT

[PATCH] D85778: More accurately compute the ranges of possible values for +, -, *, &, %.

rtrieu accepted this revision. rtrieu added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaChecking.cpp:10166 + /// The number of bits active in the int. Note that this includes exactly one + /// sign bit if !NoNegative. uns

[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80263/new/ https://reviews.llvm.org/D80263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84458/new/ https://reviews.llvm.org/D84458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

leonardchan updated this revision to Diff 285219. leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://reviews.llvm.org/D85576 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/lib/

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang updated this revision to Diff 285214. akhuang added a comment. Add more extensive check that -fuse-ctor-homing only does something when -debug-info-kind=limited Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85799/new/ https://reviews.llvm.

[clang] bd08e0c - PR47143: Don't crash while constant-evaluating value-initialization of

Author: Richard Smith Date: 2020-08-12T16:53:45-07:00 New Revision: bd08e0cf1cb1f1f294e4253ba5907ec4c81b05fe URL: https://github.com/llvm/llvm-project/commit/bd08e0cf1cb1f1f294e4253ba5907ec4c81b05fe DIFF: https://github.com/llvm/llvm-project/commit/bd08e0cf1cb1f1f294e4253ba5907ec4c81b05fe.diff

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang added a comment. In D85799#2214330 , @dblaikie wrote: > If possible, could you test the negative cases too? That -fuse-ctor-homing > doesn't override -debug-info-kind=line-tables-only or no -debug-info-kind at > all? Oh, good point. Repository

[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:619 getCheckerManager().runCheckersForEvalCall(DstEvaluated, *I, *Call, *this, - CallOpts); +

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3136cbe29e74: [PowerPC] Implement Vector Shift Builtins (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D83338?vs=283980

[clang] 3136cbe - [PowerPC] Implement Vector Shift Builtins

Author: Albion Fung Date: 2020-08-12T18:26:58-05:00 New Revision: 3136cbe29e74e19e6cb71c5ce71e4b92a63d03d8 URL: https://github.com/llvm/llvm-project/commit/3136cbe29e74e19e6cb71c5ce71e4b92a63d03d8 DIFF: https://github.com/llvm/llvm-project/commit/3136cbe29e74e19e6cb71c5ce71e4b92a63d03d8.diff L

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

dblaikie added a comment. If possible, could you test the negative cases too? That -fuse-ctor-homing doesn't override -debug-info-kind=line-tables-only or no -debug-info-kind at all? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85799/new/ https:

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa31c89c1b7a0: [Coverage] Enable emitting gap area between macros (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] a31c89c - [Coverage] Enable emitting gap area between macros

Author: Zequan Wu Date: 2020-08-12T16:25:27-07:00 New Revision: a31c89c1b7a0a2fd3e2c0b8a587a60921abf4abd URL: https://github.com/llvm/llvm-project/commit/a31c89c1b7a0a2fd3e2c0b8a587a60921abf4abd DIFF: https://github.com/llvm/llvm-project/commit/a31c89c1b7a0a2fd3e2c0b8a587a60921abf4abd.diff LOG

[PATCH] D85810: [clang] Pass-through remarks options to lld

weiwang updated this revision to Diff 285205. weiwang added a comment. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver

[PATCH] D85808: [remarks] Optimization remarks hotness filtering from profile summary

tejohnson added a comment. In D85808#2212297 , @weiwang wrote: > This is the 3rd of 3 dependent patches: > > 1. [lld] Enable remarks hotness filtering in lld: > https://reviews.llvm.org/D85809 > 2. [clang] Pass-through remarks options to lld: > https://r

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang added a comment. Yep, just added a line to the existing ctor homing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85799/new/ https://reviews.llvm.org/D85799 ___ cfe-commits mailing lis

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang updated this revision to Diff 285203. akhuang added a comment. Add test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85799/new/ https://reviews.llvm.org/D85799 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Comp

[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

jdoerfert added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:390 +for nameless_value in nameless_values: +if re.fullmatch(nameless_value.ir_prefix + r'[0-9]+?', var, re.IGNORECASE): +warn("Change IR value name '%s' to prevent possibl

[PATCH] D85819: [SyntaxTree] Split tests

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Please also consider splitting the file into multiple. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1238 +namespace n { +template +struct ST {

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan updated this revision to Diff 285192. leonardchan marked 2 inline comments as done. leonardchan edited the summary of this revision. leonardchan added a comment. - Check for lowercase flag values - Remove fuchsia-specific changes Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:275 + if (DriverArgs.getLastArgValue(options::OPT_fcxx_abi_EQ) == "Fuchsia") +CC1Args.push_back("-fexperimental-relative-c++-abi-vtables"); } phosek wrote: > mcgrathr wro

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, looks good to me! Please check for any issues in a stage2 coverage build before landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85

[PATCH] D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:289 + for (QualType CastToTy: CastToTyVec) { +if (CastFromTy->isPointerType()) + CastToTy = C.getAS

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, i see, fair enough! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85817/new/ https://reviews.llvm.org/D85817 ___

[PATCH] D83088: Introduce CfgTraits abstraction

dblaikie added a comment. In D83088#2213864 , @nhaehnle wrote: > In D83088#2213802 , @dblaikie wrote: > >> In D83088#2213797 , @nhaehnle wrote: >> >>> In D83088#2208611

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:275 + if (DriverArgs.getLastArgValue(options::OPT_fcxx_abi_EQ) == "Fuchsia") +CC1Args.push_back("-fexperimental-relative-c++-abi-vtables"); } mcgrathr wrote: > It's surprising

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added a comment. In D83088#2213802 , @dblaikie wrote: > In D83088#2213797 , @nhaehnle wrote: > >> In D83088#2208611 , @dblaikie wrote: >> >>> This seems like a stran

[PATCH] D85807: [Target] Cache the command line derived feature map in TargetOptions.

nickdesaulniers added a comment. Thanks @craig.topper ! `++beers_owed;` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85807/new/ https://reviews.llvm.org/D85807 ___ cfe-commits mailing list cfe-commits@l

[clang] 5c1fe4e - [Target] Cache the command line derived feature map in TargetOptions.

Author: Craig Topper Date: 2020-08-12T12:37:23-07:00 New Revision: 5c1fe4e20f887286baac6989943a0875e12834fe URL: https://github.com/llvm/llvm-project/commit/5c1fe4e20f887286baac6989943a0875e12834fe DIFF: https://github.com/llvm/llvm-project/commit/5c1fe4e20f887286baac6989943a0875e12834fe.diff

[PATCH] D85807: [Target] Cache the command line derived feature map in TargetOptions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c1fe4e20f88: [Target] Cache the command line derived feature map in TargetOptions. (authored by craig.topper). Repository: rG LLVM Github Monorep

[clang] 269bc3f - PR47138: Don't crash if the preferred alignment of an invalid record

Author: Richard Smith Date: 2020-08-12T12:31:20-07:00 New Revision: 269bc3f5df6c3b75de515a48063c6941ef8fbbe6 URL: https://github.com/llvm/llvm-project/commit/269bc3f5df6c3b75de515a48063c6941ef8fbbe6 DIFF: https://github.com/llvm/llvm-project/commit/269bc3f5df6c3b75de515a48063c6941ef8fbbe6.diff

[PATCH] D83088: Introduce CfgTraits abstraction

dblaikie added a comment. In D83088#2213797 , @nhaehnle wrote: > In D83088#2208611 , @dblaikie wrote: > >> This seems like a strange hybrid between a static-polymorphism (with traits) >> and dynamic polymorphism (w

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added a comment. In D83088#2208611 , @dblaikie wrote: > This seems like a strange hybrid between a static-polymorphism (with traits) > and dynamic polymorphism (with base classes/virtual functions). Could this > more readily be just one or the o

[PATCH] D85193: [clang] Check `expr` inside `InitListChecker::UpdateStructuredListElement()`

This revision was automatically updated to reflect the committed changes. Closed by commit rG3fa0a039ab6f: [clang] Check `expr` inside `InitListChecker::UpdateStructuredListElement()` (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 3fa0a03 - [clang] Check `expr` inside `InitListChecker::UpdateStructuredListElement()`

Author: Aleksandr Platonov Date: 2020-08-12T22:12:43+03:00 New Revision: 3fa0a039ab6f856e39dab973df56831b63ed51c5 URL: https://github.com/llvm/llvm-project/commit/3fa0a039ab6f856e39dab973df56831b63ed51c5 DIFF: https://github.com/llvm/llvm-project/commit/3fa0a039ab6f856e39dab973df56831b63ed51c5.

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand added a comment. In D82317#2212145 , @jdoerfert wrote: > TBH, I don't see how this solves any problem. It just makes it a problem for > someone in the future... (FWIW, I say this being in full support of `noundef`) That's true. At the same time, i

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

dblaikie added a comment. Looks good! Could you add a test case for this too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85799/new/ https://reviews.llvm.org/D85799 ___ cfe-commits mailing list cfe-com

[PATCH] D85806: [WebAssembly] Don't depend on the flags set by handleTargetFeatures in initFeatureMap.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b8ad6b60408: [WebAssembly] Don't depend on the flags set by handleTargetFeatures in… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 2b8ad6b - [WebAssembly] Don't depend on the flags set by handleTargetFeatures in initFeatureMap.

Author: Craig Topper Date: 2020-08-12T11:43:46-07:00 New Revision: 2b8ad6b6040833f4f8702721ebaa7749e5c23e60 URL: https://github.com/llvm/llvm-project/commit/2b8ad6b6040833f4f8702721ebaa7749e5c23e60 DIFF: https://github.com/llvm/llvm-project/commit/2b8ad6b6040833f4f8702721ebaa7749e5c23e60.diff

[PATCH] D85710: Code generation support for lvalue bit-field conditionals.

rsmith added a comment. In D85710#2212174 , @rjmccall wrote: > I always imagined that we'd implement this by just inverting the emission: > emit the RHS of the assignment and then pass a callback down to a function > that descended into conditional opera

[PATCH] D85743: [CodeGen][AArch64] Support arm_sve_vector_bits attribute

efriedma added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3330 +// appendices to the Procedure Call Standard for the Arm Architecture, see: +// https://github.com/ARM-software/abi-aa/blob/master/aapcs64/aapcs64.rst#appendix-c-mangling +void CXXNameMangler::mang

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:115 +// either due to crashes or false positives. +const char *getClangTidyBlacklist() { + static const std::string FalsePositives = kadircet wrote: > aaron.ballman wrote:

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

mcgrathr added inline comments. Comment at: clang/include/clang/Basic/TargetCXXABI.h:39 + static const auto &getABIMap() { +static llvm::StringMap ABIMap = { The option UI should use lowercase values by default, or else just do case-insensitive matching.

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:115 +// either due to crashes or false positives. +const char *getClangTidyBlacklist() { + static const std::string FalsePositives = aaron.ballman wrote: > njames93 wrote: > >

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet updated this revision to Diff 285141. kadircet added a comment. - Change logic to find all signatures without any dependent args and post filter non-viable overloads using the argument counts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D85806: [WebAssembly] Don't depend on the flags set by handleTargetFeatures in initFeatureMap.

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85806/new/ https://reviews.llvm.org/D85806 _

[clang] a7a06de - Recommit "[InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X transforms" and its follow up patches

Author: Craig Topper Date: 2020-08-12T10:45:27-07:00 New Revision: a7a06ded8b0635268b5db218b3aca0b5b2bfb04a URL: https://github.com/llvm/llvm-project/commit/a7a06ded8b0635268b5db218b3aca0b5b2bfb04a DIFF: https://github.com/llvm/llvm-project/commit/a7a06ded8b0635268b5db218b3aca0b5b2bfb04a.diff

[PATCH] D85736: [Sema][AArch64] Support arm_sve_vector_bits attribute

rsandifo-arm added inline comments. Comment at: clang/include/clang/AST/Type.h:1897 + /// 'arm_sve_vector_bits' type attribute as VectorType. + QualType getFixedLengthSveEltType(const ASTContext &Ctx) const; + It feels to me like the information is more general

[PATCH] D85807: [Target] Cache the command line derived feature map in TargetOptions.

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. LGTM; comparing the report at the bottom of https://reviews.llvm.org/D85257#2197114, repasted (before this patch): +3.59% clang-12 [.] llvm::X86::get

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

vsavchenko added a comment. In D85817#2213435 , @NoQ wrote: > That's a fix for https://bugs.llvm.org/show_bug.cgi?id=46264. > > Your code looks great but i don't understand at a glance what the crash was > caused by and how does your code fix it, can you

[PATCH] D85193: [clang] Check `expr` inside `InitListChecker::UpdateStructuredListElement()`

aaron.ballman accepted this revision. aaron.ballman added a comment. In D85193#2213384 , @ArcsinX wrote: > In D85193#2212976 , @aaron.ballman > wrote: > >> I have a suggestion for the added comment, > > Fixed comme

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

eduucaldas added a comment. Unit tests will be provided once we decide that this is the way to go ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 ___ cfe-commi

[PATCH] D85736: [Sema][AArch64] Support arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 285124. c-rhodes added a comment. Added missing implicit conversions for C++. I considered handling this with the existing implicit vector conversion although one side of the conversion will be an SVE builtin, so instead I've added a new conversion specifical

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

miyuki added a comment. For intrinsics that are plain functions (not macros) you could just check the signatures using assignments to function pointers, e.g.: #include uint16_t (*fp1)(int32_t) = &vqmovuns_s32; $ clang -target=aarch64-arm-none-eabi -march=armv8-a+simd -c neon.c -fsynta

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5573 + // performing any semantic checks on availability. That's to improve user + // experience, it is better to see all overloads rather than none. + if (Expr::hasAnyTypeDependentArguments(Args))

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

eduucaldas updated this revision to Diff 285129. eduucaldas added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 Files: clang/lib/AST/NestedNameSpecifier.cpp Index: clang/lib/

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

xbolva00 added inline comments. Comment at: cfe/trunk/lib/Frontend/CompilerInvocation.cpp:3457 + if (Diags.isIgnored(diag::warn_profile_data_misexpect, SourceLocation())) +Res.FrontendOpts.LLVMArgs.push_back("-pgo-warn-misexpect"); + rnk wrote: > Clang gener

[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

thakis added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:390 +for nameless_value in nameless_values: +if re.fullmatch(nameless_value.ir_prefix + r'[0-9]+?', var, re.IGNORECASE): +warn("Change IR value name '%s' to prevent possible c

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

eduucaldas updated this revision to Diff 285122. eduucaldas added a comment. Don't assume the code is completely correct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 Files: clang/lib/AST/NestedNameSpec

[clang] df3bfaa - [Driver] Change -fnostack-clash-protection to -fno-stack-clash-protection

Author: Dávid Bolvanský Date: 2020-08-12T18:36:26+02:00 New Revision: df3bfaa39071a1382a59a94658ee1a2da30d92fd URL: https://github.com/llvm/llvm-project/commit/df3bfaa39071a1382a59a94658ee1a2da30d92fd DIFF: https://github.com/llvm/llvm-project/commit/df3bfaa39071a1382a59a94658ee1a2da30d92fd.dif

[PATCH] D85844: [Driver] Change -fnostack-clash-protection to -fno-stack-clash-protection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf3bfaa39071: [Driver] Change -fnostack-clash-protection to -fno-stack-clash-protection (authored by xbolva00). Repository: rG LLVM Github Monore

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet updated this revision to Diff 285117. kadircet marked 2 inline comments as done. kadircet added a comment. - Fix typo in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85826/new/ https://reviews.llvm.org/D85826 Files: clang-tools

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet updated this revision to Diff 285116. kadircet added a comment. - Add tests into clang-lit - Make sure current number of args is less than overloads param count. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85826/new/ https://reviews.llvm

[PATCH] D85844: [Driver] Change -fnostack-clash-protection to -fno-stack-clash-protection

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85844/new/ https://reviews.llvm.org/D85844

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

NoQ added a comment. That's a fix for https://bugs.llvm.org/show_bug.cgi?id=46264. Your code looks great but i don't understand at a glance what the crash was caused by and how does your code fix it, can you explain? Like, the original test doesn't have any `void *`s and it doesn't have any ind

[PATCH] D85844: [Driver] Change -fnostack-clash-protection to -fno-stack-clash-protection

xbolva00 created this revision. xbolva00 added a reviewer: sberg. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. xbolva00 requested review of this revision. Clang command line docs mention `-fno-stack-clash-protection`, and GCC also uses -fno-stack-clash-protection.

[PATCH] D85843: Add "status" to the list of absl libraries.

oontvoo created this revision. oontvoo added a reviewer: sbenza. Herald added a project: clang. Herald added a subscriber: cfe-commits. oontvoo requested review of this revision. The Abseil-NoInternalDependenciesCheck currently mistakenly triggers on any usage of internal helpers even if it is wi

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. >From the documentation comment above >`NestedNameSpecifierLoc::getLocalSourceRange()` /// Retrieve the source range covering just the last par

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. In D72705#2213300 , @whisperity wrote: > In D72705#2210255 , @balazske wrote: > >> More results in CodeChecker: emacs_errorreturn >>

[PATCH] D85193: [clang] Check `expr` inside `InitListChecker::UpdateStructuredListElement()`

ArcsinX added a comment. In D85193#2212976 , @aaron.ballman wrote: > I have a suggestion for the added comment, Fixed comment according to your suggestion. > but I also forgot to ask, do you need someone to commit on your behalf? I already have commit

[PATCH] D84248: [analyzer][StdLibraryFunctionsChecker] Add POSIX time handling functions

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:2040 + +if (ConstStructTimevalPtrTy && StructTimespecPtrTy) + // int nanosleep(const struct timespec *rqtp, struct timespec *rmtp); Should be `C

[PATCH] D85193: [clang] Check `expr` inside `InitListChecker::UpdateStructuredListElement()`

ArcsinX updated this revision to Diff 285101. ArcsinX added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85193/new/ https://reviews.llvm.org/D85193 Files: clang/lib/Sema/SemaInit.cpp clang/test/Sema/init-invalid-struct-

[clang-tools-extra] fc915d1 - [clang-tidy] use stable_sort instead of sort to fix EXPENSIVE_CHECKS tests

Author: Erik Pilkington Date: 2020-08-12T12:12:10-04:00 New Revision: fc915d13b8671ceddea06e3f2f2d0e18869c41fe URL: https://github.com/llvm/llvm-project/commit/fc915d13b8671ceddea06e3f2f2d0e18869c41fe DIFF: https://github.com/llvm/llvm-project/commit/fc915d13b8671ceddea06e3f2f2d0e18869c41fe.dif

[PATCH] D84908: [darwin][compiler-rt] build libclang_rt.sim.a Apple Silicon slice, if SDK supports it

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84908/new/ https://reviews.llvm.org/D84908 ___ cfe-commits mailing list cfe-commi

[PATCH] D68720: Support -fstack-clash-protection for x86

sberg added a comment. I filed https://bugs.llvm.org/show_bug.cgi?id=47139 "Misspelled -fnostack-clash-protection" now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 _

[clang] fbd6d2c - [OPENMP] Fix PR47063: crash when trying to get captured statetment.

Author: Alexey Bataev Date: 2020-08-12T12:05:58-04:00 New Revision: fbd6d2c54e57a4968d29bb22742dd49759b3ecd0 URL: https://github.com/llvm/llvm-project/commit/fbd6d2c54e57a4968d29bb22742dd49759b3ecd0 DIFF: https://github.com/llvm/llvm-project/commit/fbd6d2c54e57a4968d29bb22742dd49759b3ecd0.diff

[clang] f4f3f67 - [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

Author: Alexey Bataev Date: 2020-08-12T11:28:19-04:00 New Revision: f4f3f678f1994d47f745cbfd6a1026f2408425c6 URL: https://github.com/llvm/llvm-project/commit/f4f3f678f1994d47f745cbfd6a1026f2408425c6 DIFF: https://github.com/llvm/llvm-project/commit/f4f3f678f1994d47f745cbfd6a1026f2408425c6.diff

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

whisperity added a comment. In D72705#2210255 , @balazske wrote: > More results in CodeChecker: emacs_errorreturn >

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantConditionCheck.cpp:73 + // If the variable has an alias then it can be changed by that alias as well. + // FIXME: Track pointers and references. + if (hasPtrOrReferenceInFunc(Func, Cond

[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c8a4ee0764c: [OpenCL] Remove warning for variadic macros in C++ for OpenCL. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85429/new

[clang] 3c8a4ee - [OpenCL] Remove warning for variadic macros in C++ for OpenCL.

Author: Anastasia Stulova Date: 2020-08-12T16:17:54+01:00 New Revision: 3c8a4ee0764cafb2ba204c7cb7d8b37e6adf72a8 URL: https://github.com/llvm/llvm-project/commit/3c8a4ee0764cafb2ba204c7cb7d8b37e6adf72a8 DIFF: https://github.com/llvm/llvm-project/commit/3c8a4ee0764cafb2ba204c7cb7d8b37e6adf72a8.d

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein added a comment. friendly ping @rsmith, the patch is ready for another round of review. Would be nice to have it in clang11. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantConditionCheck.cpp:73 + // If the variable has an alias then it can be changed by that alias as well. + // FIXME: Track pointers and references. + if (hasPtrOrReferenceInFunc(Func,

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. Ping for an opinion on the recent discussion of how to move forward with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 ___

[PATCH] D85834: [AST] Fix a crash on calling getASTRecordLayout on an invalid RecordDecl.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ASTContext.cpp:2463 -unsigned PreferredAlign = static_cast( -toBits(getASTRecordLayout(RT->getDecl()).PreferredAlignment));

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:115 +// either due to crashes or false positives. +const char *getClangTidyBlacklist() { + static const std::string FalsePositives = njames93 wrote: > Return by StringRef?

  1   2   >