jdoerfert added inline comments.
================
Comment at: llvm/utils/UpdateTestChecks/common.py:390
+ for nameless_value in nameless_values:
+ if re.fullmatch(nameless_value.ir_prefix + r'[0-9]+?', var,
re.IGNORECASE):
+ warn("Change IR value name '%s' to prevent possible conflict with
scripted FileCheck name." % (var,))
----------------
thakis wrote:
> This is Py3.4+. Per https://llvm.org/docs/GettingStarted.html#id7 we still
> support 2.7, which is why all my bots run that, which is why this breaks my
> bots :) (...and everyone still using Python 2.7 locally). Can you do this
> some other way? Maybe just surround the re with "^..$'?
Addressed and restored actual functionality in
07448c550457d2afb1e7d69254a58ad44dece3d2
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85099/new/
https://reviews.llvm.org/D85099
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
