[PATCH] D85565: [Clang][Test] add specific targets for OSX failures

dblaikie added inline comments. Comment at: clang/test/CodeGen/debug-info-unused-types.cpp:1-5 +// RUN: %clangxx --target=x86_64-linux-gnu -fno-eliminate-unused-debug-types -g -emit-llvm -S -o - %s | FileCheck %s +// RUN: %clangxx --target=x86_64-linux-gnu -fno-eliminate-unused-

[clang] fb94369 - PR47025, PR47043: Diagnose unexpanded parameter packs in concept

Author: Richard Smith Date: 2020-08-07T18:19:39-07:00 New Revision: fb943696cbc695b28d7deabf8ee0d1b1a6cc605a URL: https://github.com/llvm/llvm-project/commit/fb943696cbc695b28d7deabf8ee0d1b1a6cc605a DIFF: https://github.com/llvm/llvm-project/commit/fb943696cbc695b28d7deabf8ee0d1b1a6cc605a.diff

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: mgorny. leonardchan requested review of this revision. This adds a multilib for Fuchsia that is built with the relative vtables ABI. This depend

[PATCH] D85575: [ARM] Speed up arm-cortex-cpus.c test

tra created this revision. tra added a reviewer: LukeGeeson. Herald added subscribers: danielkiss, sanjoy.google, bixia, kristof.beyls. Herald added a project: clang. tra requested review of this revision. Trailing wildcard regex searches greedily continue searching through the whole input and mak

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

hiraditya added a comment. cc: @t.p.northover does this fix look reasonable for PR37240? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68076/new/ https://reviews.llvm.org/D68076 ___ cfe-commits mailing list cfe-commits

[PATCH] D85559: [MSAN] Reintroduce libatomic load/store instrumentation

guiand marked 2 inline comments as done. guiand added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3513 +assert(InsPoint); +if (!InsPoint) { + return; TODO: Remove this redudant call Repository: rG LLVM Git

[PATCH] D85559: [MSAN] Reintroduce libatomic load/store instrumentation

guiand updated this revision to Diff 284102. guiand removed a reviewer: rsmith. guiand added a comment. Separated out the frontend change. Addressed other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85559/new/ https://reviews.llvm.org/D

[PATCH] D85457: [NewPM][optnone] Mark various passes as required

ychen added a comment. Looks reasonable to me. Please let @asbirlea double-check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85457/new/ https://reviews.llvm.org/D85457 ___ cfe-commits mailing list cfe

[PATCH] D85574: [Sema] Fix missing warning on initializer lists on field initializers with overloaded operators

zequanwu created this revision. zequanwu added a reviewer: rtrieu. Herald added a project: clang. Herald added a subscriber: cfe-commits. zequanwu requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85574 Files: clang/lib/Sema/SemaDeclCXX.cpp cl

[PATCH] D85573: [CGAtomic] Mark atomic libcall functions `nounwind`

guiand created this revision. guiand added reviewers: rsmith, eugenis. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. guiand requested review of this revision. These functions won't ever unwind. This is useful for MemorySanitizer as it simplifies handling __atomic_l

[PATCH] D85457: [NewPM][optnone] Mark various passes as required

aeubanks updated this revision to Diff 284093. aeubanks added a comment. Herald added subscribers: cfe-commits, jfb, eraman. Herald added a project: clang. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85457/new/ https://reviews.llvm.org/D

[PATCH] D83942: [analyzer][tests] Add a notion of project sizes

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I can't say any of my ideas about better naming are exceptionally bright. The existing scale seems perfectly reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. So it looks like `%clang++` should be `%clangxx` for windows, then for OSX the default value of `debug-info-kind` is different, while the tests also seem to fail there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] abb9bf4 - Revert "[Clang] implement -fno-eliminate-unused-debug-types"

Author: Nick Desaulniers Date: 2020-08-07T16:11:41-07:00 New Revision: abb9bf4bcf98a226d9350448e31411eb55e9efb0 URL: https://github.com/llvm/llvm-project/commit/abb9bf4bcf98a226d9350448e31411eb55e9efb0 DIFF: https://github.com/llvm/llvm-project/commit/abb9bf4bcf98a226d9350448e31411eb55e9efb0.di

[clang] 73413d2 - Revert "fix windows build for D80242"

Author: Nick Desaulniers Date: 2020-08-07T16:11:26-07:00 New Revision: 73413d266abc2436bd1993a4e21a9151bd102f17 URL: https://github.com/llvm/llvm-project/commit/73413d266abc2436bd1993a4e21a9151bd102f17 DIFF: https://github.com/llvm/llvm-project/commit/73413d266abc2436bd1993a4e21a9151bd102f17.di

[PATCH] D85565: [Clang][Test] add specific targets for OSX failures

nickdesaulniers added a comment. I'm just going to revert cbd8ec93709376fbf404c99f4eee399790e26db7 and e486921fd6cf96ae9114adac455f7c0b5c1088a7 and sort t

[clang] 3adc9ae - [OpenMP 5.0] Fix PR-45212: Shouldn't error out while using overloaded operator for map clause

Author: cchen Date: 2020-08-07T18:07:48-05:00 New Revision: 3adc9aeb250cb9a9d4e5abf7ee5752e142ffe9b8 URL: https://github.com/llvm/llvm-project/commit/3adc9aeb250cb9a9d4e5abf7ee5752e142ffe9b8 DIFF: https://github.com/llvm/llvm-project/commit/3adc9aeb250cb9a9d4e5abf7ee5752e142ffe9b8.diff LOG: [O

[PATCH] D85563: [OpenMP 5.0] Fix PR-45212: Shouldn't error out while using overloaded operator for map clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3adc9aeb250c: [OpenMP 5.0] Fix PR-45212: Shouldn't error out while using overloaded operator… (authored by cchen). Repository: rG LLVM Github Mono

[PATCH] D85565: [Clang][Test] add specific targets for OSX failures

aprantl added a comment. I think this could be problematic when building a Clang without an X86 target, unless you also mark X86 REQUIRED (at least in the CodeGen tests). Would using cc1 and hardcoding --debug-info-kind=limited (or something like that) work, too? Repository: rG LLVM Github M

[PATCH] D85559: [MSAN] Reintroduce libatomic load/store instrumentation

eugenis added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:315 + llvm::FunctionCallee fn = + CGF.CGM.CreateRuntimeFunction(fnTy, fnName, fnAttrs); auto callee = CGCallee::forDirect(fn); This needs a clang test, and better move it to a sepa

[PATCH] D85565: [Clang][Test] add specific targets for OSX failures

nickdesaulniers created this revision. nickdesaulniers added reviewers: dblaikie, mschifer. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers requested review of this revision. Tests added in https://reviews.llvm.org/D80242 https://reviews.llvm.org/rGcbd8ec9370

[PATCH] D85563: [OpenMP 5.0] Fix PR-45212 - Shouldn't error out while using overloaded operator for map clause

cchen updated this revision to Diff 284082. cchen added a comment. Fix commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85563/new/ https://reviews.llvm.org/D85563 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/target_map_me

[PATCH] D85559: [MSAN] Reintroduce libatomic load/store instrumentation

guiand updated this revision to Diff 284080. guiand added a comment. Rebased on master (again) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85559/new/ https://reviews.llvm.org/D85559 Files: clang/lib/CodeGen/CGAtomic.cpp compiler-rt/test/msan

[PATCH] D85563: [OpenMP 5.0] Fix PR-45212 - Shouldn't error out while using overloaded operator for map clause

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the quick turnaround time! Nit: We usually avoid the `-` between PR and the number (your commit message). I guess that makes it easier to copy it into `llvm.org/PRX`

[PATCH] D85559: [MSAN] Reintroduce libatomic load/store instrumentation

guiand updated this revision to Diff 284079. guiand added a comment. Rebased on master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85559/new/ https://reviews.llvm.org/D85559 Files: clang/lib/CodeGen/CGAtomic.cpp compiler-rt/test/msan/libatom

[PATCH] D85563: [OpenMP 5.0] Fix PR-45212 - Shouldn't error out while using overloaded operator for map clause

cchen created this revision. cchen added reviewers: jdoerfert, ABataev. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. cchen requested review of this revision. Herald added a subscriber: sstefan1. LValue map checker should handle CXXOperatorCallExpr Repos

[PATCH] D85559: [MSAN] Reintroduce libatomic load/store instrumentation

guiand updated this revision to Diff 284076. guiand edited the summary of this revision. guiand added a reviewer: rsmith. guiand added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Simplified by returning to the old implementation, but having libatomic calls ma

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. Looks like another related failure for http://green.lab.llvm.org/green/job/clang-stage1-RA/13460/consoleFull#-42777206a1ca8a51-895e-46c6-af87-ce24fa4cd561 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/

[PATCH] D85562: [clang] Allow cross-compiling in standalone builds

isuruf created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. isuruf requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85562 Files: clang/CMakeLists.txt Index: clang/CMakeLists.txt

[PATCH] D85502: [clangd] Add more error details on the remote index server side

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:322 +return makeStringError( +llvm::formatv("Can not use URI schemes other

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps added a comment. In D84467#2180421 , @vsk wrote: > I haven't taken a close look at the tests yet, but plan on getting to it soon. > > I'm not sure whether this is something you've already tried, but for this > kind of change, it can be helpful

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. fix pushed in cbd8ec93709376fbf404c99f4eee399790e26db7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242

[clang] cbd8ec9 - fix windows build for D80242

Author: Nick Desaulniers Date: 2020-08-07T14:59:35-07:00 New Revision: cbd8ec93709376fbf404c99f4eee399790e26db7 URL: https://github.com/llvm/llvm-project/commit/cbd8ec93709376fbf404c99f4eee399790e26db7 DIFF: https://github.com/llvm/llvm-project/commit/cbd8ec93709376fbf404c99f4eee399790e26db7.di

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. build failure on windows: http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/1886/steps/test-check-clang/logs/FAIL%3A%20Clang%3A%3Adebug-info-unused-types.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6916 +for (unsigned i = 0; i < numConcat; ++i) + if (SL->getStrTokenLoc(i).isMacroID()) { +hasMacro = true; Quuxplusone wrote: > I wonder if perhaps the warning s

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6921 +if (!hasMacro) + Diag(SL->getBeginLoc(), diag::warn_concatenated_literal_array_init); + } riccibruno wrote: > Should this point to the location of the suspected mi

[clang] e486921 - [Clang] implement -fno-eliminate-unused-debug-types

Author: Nick Desaulniers Date: 2020-08-07T14:13:48-07:00 New Revision: e486921fd6cf96ae9114adac455f7c0b5c1088a7 URL: https://github.com/llvm/llvm-project/commit/e486921fd6cf96ae9114adac455f7c0b5c1088a7 DIFF: https://github.com/llvm/llvm-project/commit/e486921fd6cf96ae9114adac455f7c0b5c1088a7.di

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe486921fd6cf: [Clang] implement -fno-eliminate-unused-debug-types (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 284048. nickdesaulniers added a comment. - git clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

xbolva00 updated this revision to Diff 284043. xbolva00 marked 2 inline comments as done. xbolva00 added a comment. New testcases. Emit note to tell user how to supress warning - extra parentheses. Emit fixit with comma. Addressed review notes. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

xbolva00 added inline comments. Comment at: clang/test/Sema/string-concat.c:55 + "optional", + "packaged_task"}; Quuxplusone wrote: > > What if the user did actually want to concatenate the strings > > > Is there a way

[PATCH] D85523: [clang-tidy] Fix a crash in bugprone-not-null-terminated-result check when `__STDC_WANT_LIB_EXT1__` was undefined after definition.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-not-null-terminated-result-undef-stdc-want-lib-ext1.c:17 +} \ No newline at end of file Please add newline. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd01980f308a: [OpenMP] Split OpenMP/target_map_codegen test [NFC] (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_map_codegen_18.cpp:5 + +///==/// +// RUN: %clang_cc1 -DUSE -DCK19 -verify -fopenmp -fopenmp-targets=powerpc64le-ibm-linux-gnu -x c++ -tri

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 _

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85551/new/ https://reviews.llvm.org/D85551 ___ c

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

tra added inline comments. Comment at: clang/test/OpenMP/target_map_codegen_18.cpp:5 + +///==/// +// RUN: %clang_cc1 -DUSE -DCK19 -verify -fopenmp -fopenmp-targets=powerpc64le-ibm-linux-gnu -x c++ -triple p

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

jdoerfert added a comment. In D85551#2203758 , @tra wrote: > In D85551#2203711 , @jdoerfert wrote: > >> Wow, cool. I imagine it was hard to split this given the manual check lines. >> We really need to start using

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6916 +for (unsigned i = 0; i < numConcat; ++i) + if (SL->getStrTokenLoc(i).isMacroID()) { +hasMacro = true; I wonder if perhaps the warning should trigger only

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

tra added a comment. In D85551#2203711 , @jdoerfert wrote: > Wow, cool. I imagine it was hard to split this given the manual check lines. > We really need to start using the upgrade scripts here. > > I'm fine with this, @ABataev WDYT? It was not that har

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

NoQ added a comment. In D85545#2203661 , @xbolva00 wrote: > Parentheses could work here Yay great! Let's add such test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85545/new/ https://reviews.llvm.org/D85545 __

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 284011. nickdesaulniers added a comment. - rebase, centralize DebugInfoKind update as per @dblaikie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: cla

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

jdoerfert added a comment. Wow, cool. I imagine it was hard to split this given the manual check lines. We really need to start using the upgrade scripts here. I'm fine with this, @ABataev WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85551/

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

tra created this revision. tra added a reviewer: ABataev. Herald added subscribers: sanjoy.google, bixia, guansong, yaxunl. Herald added a project: clang. tra requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. The test file is the single lon

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

riccibruno added a comment. Is there a way to suppress this diagnostic if someone wants to legitimately initialize an element of the array with a long string by relying on string literal concatenation? Comment at: clang/lib/Sema/SemaExpr.cpp:6910 << InitArgList[I]->g

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

xbolva00 added a comment. Do not warn for macros (found false positives when compiling linux kernel) In D85545#2203660 , @NoQ wrote: > What if the user did actually want to concatenate the strings? Eg., one of > the strings in the list is long and clang-

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

NoQ added a comment. What if the user did actually want to concatenate the strings? Eg., one of the strings in the list is long and clang-format suggests breaking it up for the 80-column limit which causes the new warning to appear. How would the user suppress the warning in this case? CHANGE

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

xbolva00 updated this revision to Diff 284002. xbolva00 added a comment. Do not warn for macros - found false positives when compiling linux kernel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85545/new/ https://reviews.llvm.org/D85545 Files: clang/include/clang/Basic/DiagnosticSem

[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor edits. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:213 + + llvm_unreachable("unexpected c++ library type, only libc++ is

[PATCH] D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName

riccibruno added a comment. ... or if a string such as `(unnamed struct at /path/to/input.cc:1:3)` is suitable in an USR then `printName` can be used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84599/new/ https://reviews.llvm.org/D84599 __

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

Szelethus added a comment. Layering violations are a running theme in the analyzer -- CheckerRegistry and the entire MallocChecker fiasco are two glaring examples. Luckily, this isn't a severe case so I wouldn't worry about it much. I've been follo

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3787-3788 (void)checkDebugInfoOption(A, Args, D, TC); if (DebugInfoKind == codegenoptions::LimitedDebugInfo && NeedFullDebug) DebugInfoKind = codegenoptions::FullDebugInfo; --

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ updated this revision to Diff 283993. NoQ marked 2 inline comments as done. NoQ added a comment. Whoops fxd! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67422/new/ https://reviews.llvm.org/D67422 Files: clang/include/clang/Analysis/PathDiagnosticConsumers.def clang/include/cl

[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

ShuhongL updated this revision to Diff 283988. ShuhongL added a comment. Added test cases for fatal error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85315/new/ https://reviews.llvm.org/D85315 Files: clang/lib/Driver/ToolChains/AIX.cpp clang

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 283989. eduucaldas added a comment. Last version sent upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84348/new/ https://reviews.llvm.org/D84348 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 283985. Tyker added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h

[PATCH] D85144: [clang] Improve Dumping of APValues

Tyker updated this revision to Diff 283984. Tyker marked an inline comment as done. Tyker added a comment. this a patch i had to improve dumping before your improvement to dumping. I think there is benefits to being able to dump APValues like LValues without an ASTContext even if the output will

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

xbolva00 created this revision. xbolva00 added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. xbolva00 requested review of this revision. Motivation (from PR37674): const char *ss[] = { "foo", "bar", "baz", "qux" // <-- Missing comma! "ab

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

Conanap added inline comments. Comment at: clang/lib/Headers/altivec.h:17243 + // return (vector signed __int128)vec_sr((vector unsigned __int128)__a, __b); + return (vector signed __int128)( +((vector unsigned __int128) __a) >> amyk wrote: > Could

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

Conanap updated this revision to Diff 283980. Conanap marked 8 inline comments as done. Conanap added a comment. Added shl tests, formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83338/new/ https://reviews.llvm.org/D83338 Files: cl

[PATCH] D85543: Limit Max Vector alignment on COFF targets to 8192

erichkeane created this revision. erichkeane added reviewers: craig.topper, lebedev.ri. erichkeane requested review of this revision. COFF targets have a max object alignment of 8192, so trying to create one with a larger size results in an unreachable in WinCOFFObjectWriter. For the reproducer I

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

efriedma accepted this revision. efriedma added a comment. clang changes look fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D85287: Extend -Wtautological-bitwise-compare "bitwise or with non-zero value" warnings

xbolva00 added a comment. Looks useful, +1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85287/new/ https://reviews.llvm.org/D85287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

NoQ added a comment. Thanks, excellent! Let's not change warning text without good reasons. Too few of us speak English well enough to check the articles. The original text seems concise and on-point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

NoQ added a comment. Tests? There should be no `UndefinedVal`s in function arguments unless you disable `core` checkers (which isn't supported). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85424/new/ https://reviews.llvm.org/D85424 ___

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

NoQ added a comment. Aha, ok, sounds like the right thing to do. Like, for Z3 it's actually the wrong thing to do (you'd prefer to evaluate the cast perfectly by adding `SymbolCast`) but for pure RangeConstraintManager this is the lesser of two evils. Because this patch changes the behavior of

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

NoQ added inline comments. Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:63 +void derefOnReleasedNullRawPtr() { + std::unique_ptr P; + A *AP = P.release(); // expected-note {{'AP' initialized to a null pointer value}} Unlike the next line, this lin

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

NoQ added inline comments. Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:65 + A *AP = P.release(); // expected-note {{'AP' initialized to a null pointer value}} + //TODO add note "Smart pointer 'P' is released and set to null" + AP->foo(); // expected-warning {{Ca

[PATCH] D85390: [Clang] Add note for bad conversion error when expression is of forward-declared type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc354b2e3bfe6: [Clang] Add note for bad conversion when expression is pointer to forward… (authored by zequanwu). Changed prior to commit: https://

[clang] c354b2e - [Clang] Add note for bad conversion when expression is pointer to forward-declared type

Author: Zequan Wu Date: 2020-08-07T11:06:08-07:00 New Revision: c354b2e3bfe6709ffd78d0fcd017b7e5be7a7a23 URL: https://github.com/llvm/llvm-project/commit/c354b2e3bfe6709ffd78d0fcd017b7e5be7a7a23 DIFF: https://github.com/llvm/llvm-project/commit/c354b2e3bfe6709ffd78d0fcd017b7e5be7a7a23.diff LOG

[clang] 8abb5fb - [SyntaxTree] Use simplified grammar rule for `NestedNameSpecifier` grammar nodes

Author: Eduardo Caldas Date: 2020-08-07T18:05:47Z New Revision: 8abb5fb68f81b0e42d824bf080b1cef9a61559d6 URL: https://github.com/llvm/llvm-project/commit/8abb5fb68f81b0e42d824bf080b1cef9a61559d6 DIFF: https://github.com/llvm/llvm-project/commit/8abb5fb68f81b0e42d824bf080b1cef9a61559d6.diff LOG

[PATCH] D85471: Make clang HIP headers compatible with C++98

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac3e720dc1af: Make clang HIP headers compatible with C++98 (authored by yaxunl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ac3e720 - Make clang HIP headers compatible with C++98

Author: Yaxun (Sam) Liu Date: 2020-08-07T13:50:22-04:00 New Revision: ac3e720dc1af9555c5591017bd2b6c7f6641a34d URL: https://github.com/llvm/llvm-project/commit/ac3e720dc1af9555c5591017bd2b6c7f6641a34d DIFF: https://github.com/llvm/llvm-project/commit/ac3e720dc1af9555c5591017bd2b6c7f6641a34d.dif

[PATCH] D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend

amyk added a comment. I realized I didn't put a comment on this earlier but this overall LGTM, but I think it would be good to see if @nemanjai has any additional comments on this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ ht

[PATCH] D85390: [Clang] Add note for bad conversion error when expression is of forward-declared type

zequanwu updated this revision to Diff 283949. zequanwu added a comment. Update diag note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85390/new/ https://reviews.llvm.org/D85390 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/l

[clang] 47cadd6 - [analyzer] pr47030: MoveChecker: Unforget a comma in the suppression list.

Author: Artem Dergachev Date: 2020-08-07T10:39:28-07:00 New Revision: 47cadd6106c0a9218f653760dd045cbd16df0fd6 URL: https://github.com/llvm/llvm-project/commit/47cadd6106c0a9218f653760dd045cbd16df0fd6 DIFF: https://github.com/llvm/llvm-project/commit/47cadd6106c0a9218f653760dd045cbd16df0fd6.dif

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

steakhal added a comment. LGTM In D85424#2199471 , @baloghadamsoftware wrote: > Unfortunately, I could not create test for it. It is extremely rare that the > //Analyzer// creates an `UndefinedVal`. You can work around the issue by creating a unit-test

[PATCH] D85390: [Clang] Add note for bad conversion error when expression is of forward-declared type

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks great, thanks! I put a suggestion for different wording of the note, but I'll leave it up to you to decide. Comment at: clang/test/SemaCXX/pointer-forward-declared-class-c

[PATCH] D85324: [z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan updated this revision to Diff 283942. abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added a comment. Thanks Hubert for reviewing. I updated the patch to fix the wchar_t comment and the if guards for the macros. I also updated the lit tes

[PATCH] D85247: [Darwin] [Driver] Clang should invoke dsymutil for multiarch builds

beanz added inline comments. Comment at: clang/test/Driver/darwin-dsymutil.c:74 +// CHECK-DSYMUTIL-MULTIARCH: "/usr/bin/ld" "-demangle" "-object_path_lto" +// CHECK-DSYMUTIL-MULTIARCH: "/usr/bin/dsymutil" "-o" "a.out.dSYM" "a.out" aprantl wrote: > Is a.out the `l

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

rjmccall added a comment. In D75574#2202136 , @theraven wrote: > This feature looks generally useful. A few small suggestions: > > - This is really a way of transforming a formal protocol into an informal > protocol. Objective-C has had a convention of

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal updated this revision to Diff 283936. steakhal added a comment. - Moved the FIXME closer to the subject. - Added tests for covering incomplete enums as well. - Added `REQUIRES: z3`. This will mark the test case `unsupported` on every buildbots. See my notes about this behavior at D83677

[PATCH] D85536: [clang] Add a matcher for template template parameters.

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, klimek, njames93. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. riccibruno requested review of this revision. There are already matchers for type template parameters and non-type template par

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

tahonermann accepted this revision. tahonermann added a comment. I'm not a regular Clang reviewer. But for what it is worth, the changes look correct, clear, and appropriate from my lens (though I disagree slightly with some of the lint recommendations in the cases where the recommendation devi

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. I confirm that I have reviewed the Clang part of this change, which is entirely consistent with the status quo for XCOFF. I'm not seeing any outstanding comments, and I do not believe that the changes are cont

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

kadircet added a comment. Regarding tests, it feels like we can also test this in ASTUnitTests which is directly in clang, as it is also using PrecompiledPreamble::Build. What about moving the test there instead? Comment at: clang-tools-extra/clangd/unittests/ModulesTests.cpp

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

whisperity added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:98-104 +const auto IsIntegralOrUnscopedCompleteEnumerationType = [](QualType Ty) { + const Type *CanonicalType = Ty.getCanonicalType().getTypePtr(); +

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

whisperity added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:98-104 +const auto IsIntegralOrUnscopedCompleteEnumerationType = [](QualType Ty) { + const Type *CanonicalType = Ty.getCanonicalType().getTypePtr(); +

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal planned changes to this revision. steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:98-104 +const auto IsIntegralOrUnscopedCompleteEnumerationType = [](QualType Ty) { + const Type *CanonicalType = Ty

  1   2   >