NoQ added inline comments.
================
Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:65
+ A *AP = P.release(); // expected-note {{'AP' initialized to a null pointer
value}}
+ //TODO add note "Smart pointer 'P' is released and set to null"
+ AP->foo(); // expected-warning {{Called C++ object pointer is null
[core.CallAndMessage]}}
----------------
Such note is unnecessary. We don't care what happens to `P` after it's
released; we only care about its old value.
================
Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:79
+
+// TODO: Enabale this test when "std::swap" is modeled seperately.
+void derefOnStdSwappedNullPtr() {
----------------
Instead of commenting out tests, i recommend testing the incorrect behavior
(with a FIXME comment telling us why it's incorrect). This way we'll be
notified when the test is fixed, accidentally or intentionally, and also
generally that's more testing for everybody.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84600/new/
https://reviews.llvm.org/D84600
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
