[PATCH] D81912: [AST] Dump containsErrors bit for the Type.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG493d8059f399: [AST] Dump containsErrors bit for the Type. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D81404: [AArch64] Add clang command line support for -mharden-sls=

This revision was automatically updated to reflect the committed changes. Closed by commit rGc113b59ef525: [AArch64] Add clang command line support for -mharden-sls= (authored by kristof.beyls). Changed prior to commit: https://reviews.llvm.org/D81404?vs=269247&id=271925#toc Repository: rG L

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

balazske added a comment. I do not understand fully this "globally". A new option should be added that affects all checkers that detect some kind of resource leak? And then implement that kind of report uniqueness in all checkers that detect resource leak. Other possible solution: Leave the cur

[clang] 493d805 - [AST] Dump containsErrors bit for the Type.

Author: Haojian Wu Date: 2020-06-19T08:45:46+02:00 New Revision: 493d8059f3991e35c9d4dd1cb6cbeade426dc0ea URL: https://github.com/llvm/llvm-project/commit/493d8059f3991e35c9d4dd1cb6cbeade426dc0ea DIFF: https://github.com/llvm/llvm-project/commit/493d8059f3991e35c9d4dd1cb6cbeade426dc0ea.diff LO

[clang] c113b59 - [AArch64] Add clang command line support for -mharden-sls=

Author: Kristof Beyls Date: 2020-06-19T07:31:48+01:00 New Revision: c113b59ef52593818bcd207521fd490ba3deeaea URL: https://github.com/llvm/llvm-project/commit/c113b59ef52593818bcd207521fd490ba3deeaea DIFF: https://github.com/llvm/llvm-project/commit/c113b59ef52593818bcd207521fd490ba3deeaea.diff

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 271918. sepavloff added a comment. Clang-formatted the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files: clang/include/clang/Driver/Job.h clang/lib/Dri

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 271917. sepavloff added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files: clang/include/clang/Driver/Job.h clang/lib/Driver/Job.cpp

[PATCH] D77334: [AVR] Remove duplicate specification of lib directory

This revision was automatically updated to reflect the committed changes. Closed by commit rG03b0831144a9: [AVR] Remove duplicate specification of lib directory (authored by dylanmckay). Changed prior to commit: https://reviews.llvm.org/D77334?vs=254606&id=271915#toc Repository: rG LLVM Gith

[PATCH] D77334: [AVR] Remove duplicate specification of lib directory

dylanmckay added a comment. Sorry, I lost track of this. Committed in 01741d6dbec11c0a0c8e610f0033831735c78d1e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77334/new/ https://

[clang] 01741d6 - [AVR] Remove duplicate specification of lib directory

Author: Dylan McKay Date: 2020-06-19T17:39:18+12:00 New Revision: 01741d6dbec11c0a0c8e610f0033831735c78d1e URL: https://github.com/llvm/llvm-project/commit/01741d6dbec11c0a0c8e610f0033831735c78d1e DIFF: https://github.com/llvm/llvm-project/commit/01741d6dbec11c0a0c8e610f0033831735c78d1e.diff L

[clang] aeaa09e - Revert "[AVR] Remove duplicate specification of lib directory"

Author: Dylan McKay Date: 2020-06-19T17:37:15+12:00 New Revision: aeaa09ec10ee41ef2469f4d69320d386d492bf23 URL: https://github.com/llvm/llvm-project/commit/aeaa09ec10ee41ef2469f4d69320d386d492bf23 DIFF: https://github.com/llvm/llvm-project/commit/aeaa09ec10ee41ef2469f4d69320d386d492bf23.diff L

[clang] 03b0831 - [AVR] Remove duplicate specification of lib directory

Author: Dylan McKay Date: 2020-06-19T17:35:09+12:00 New Revision: 03b0831144a9fe25aac81498b0a1dec82f4ec5df URL: https://github.com/llvm/llvm-project/commit/03b0831144a9fe25aac81498b0a1dec82f4ec5df DIFF: https://github.com/llvm/llvm-project/commit/03b0831144a9fe25aac81498b0a1dec82f4ec5df.diff L

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

mehdi_amini added a comment. It seems like this pass was added in lib/Transforms but does not have any unit-tests (lit tests) provided. It isn't even linked into `opt`. As it is an LLVM IR pass it should be tested as such I believe. Can you provide tests for this? Repository: rG LLVM Github

[PATCH] D82141: [sve][acle] Add SVE BFloat16 extensions.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, ctetreau, efriedma, david-arm. Herald added subscribers: llvm-commits, cfe-commits, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added projects: clang, LLVM. List of intrin

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:103-118 + case Decl::CXXRecord: // struct/union/class X; [C++] +if (CGDebugInfo *DI = getDebugInfo()) + if (CGM.getCodeGenOpts().hasMaybeUnusedDebugInfo() && + cast(D).hasDefinition()) +

[clang] 6f9fe31 - More test cleanup for c36b03e32556a966e584386ac7dbb110bc7e4bc5.

Author: Richard Smith Date: 2020-06-18T18:17:35-07:00 New Revision: 6f9fe31cff083c3bc93ffe9fa80346c1c594a359 URL: https://github.com/llvm/llvm-project/commit/6f9fe31cff083c3bc93ffe9fa80346c1c594a359 DIFF: https://github.com/llvm/llvm-project/commit/6f9fe31cff083c3bc93ffe9fa80346c1c594a359.diff

[clang] 9ca50e8 - [libTooling] Add parser for string representation of `RangeSelector`.

Author: Yitzhak Mandelbaum Date: 2020-06-19T01:11:29Z New Revision: 9ca50e887db7f903c04a90593d2beed8a96794f1 URL: https://github.com/llvm/llvm-project/commit/9ca50e887db7f903c04a90593d2beed8a96794f1 DIFF: https://github.com/llvm/llvm-project/commit/9ca50e887db7f903c04a90593d2beed8a96794f1.diff

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 8PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c36b03e - The type of a reference to a non-type template parameter pack should

Author: Richard Smith Date: 2020-06-18T17:52:13-07:00 New Revision: c36b03e32556a966e584386ac7dbb110bc7e4bc5 URL: https://github.com/llvm/llvm-project/commit/c36b03e32556a966e584386ac7dbb110bc7e4bc5 DIFF: https://github.com/llvm/llvm-project/commit/c36b03e32556a966e584386ac7dbb110bc7e4bc5.diff

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 271887. nickdesaulniers added a comment. - git clang-format HEAD~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/docs/ClangCommandLineReference.

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

dschuff added a comment. Yeah I think a 64-bit version of userstack.ll makes sense. (a fork or a second set of CHECKs, whatever you think would be cleaner). There's also `stack-alignment.ll` which covers dynamic stack adjustment. Comment at: lld/wasm/Driver.cpp:385 +Stri

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 271884. nickdesaulniers added a comment. - rebase - make feature progression of debug-info-kind - fix docs (define, not declare) - add driver tests - use OptOutFFlag tablegen helper - rename helper to EmitAndRetainType - dont emit debug info for declar

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. Ok, I think I have all feedback addresses locally. One issue I'm hitting is that I'm regressing clang/test/OpenMP/parallel_codegen.cpp. Specifically, it seems it has code like: template

[clang] 0f92096 - Revert "Hook up OpenBSD 64-bit PowerPC support"

Author: Brad Smith Date: 2020-06-18T20:05:39-04:00 New Revision: 0f92096c0a9aa97a2818a8cc8e23e0bfc5d3831f URL: https://github.com/llvm/llvm-project/commit/0f92096c0a9aa97a2818a8cc8e23e0bfc5d3831f DIFF: https://github.com/llvm/llvm-project/commit/0f92096c0a9aa97a2818a8cc8e23e0bfc5d3831f.diff LO

[PATCH] D78190: Add Bfloat IR type

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm-c/Core.h:149 LLVMHalfTypeKind,/**< 16 bit floating point type */ + LLVMBFloatTypeKind, /**< 16 bit brain floating point type */ LLVMFloatTypeKind, /**< 32

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

MaskRay added a comment. @eduucaldas Hi, you can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differentia

[clang-tools-extra] 8b0df1c - [NFC] Refactor Registry loops to range for

Author: Nathan James Date: 2020-06-19T00:40:10+01:00 New Revision: 8b0df1c1a992d203212901c1139665261e0bbc1c URL: https://github.com/llvm/llvm-project/commit/8b0df1c1a992d203212901c1139665261e0bbc1c DIFF: https://github.com/llvm/llvm-project/commit/8b0df1c1a992d203212901c1139665261e0bbc1c.diff

[clang] 8b0df1c - [NFC] Refactor Registry loops to range for

Author: Nathan James Date: 2020-06-19T00:40:10+01:00 New Revision: 8b0df1c1a992d203212901c1139665261e0bbc1c URL: https://github.com/llvm/llvm-project/commit/8b0df1c1a992d203212901c1139665261e0bbc1c DIFF: https://github.com/llvm/llvm-project/commit/8b0df1c1a992d203212901c1139665261e0bbc1c.diff

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271874. saghir added a reviewer: stefanp. saghir added a comment. Updated comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/include/clang/Basic/Dia

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] 3008609 - Hook up OpenBSD 64-bit PowerPC support

Author: Brad Smith Date: 2020-06-18T19:19:45-04:00 New Revision: 3008609d4509c3efc577c0ccbe9d80a8a2eef31a URL: https://github.com/llvm/llvm-project/commit/3008609d4509c3efc577c0ccbe9d80a8a2eef31a DIFF: https://github.com/llvm/llvm-project/commit/3008609d4509c3efc577c0ccbe9d80a8a2eef31a.diff LO

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

This revision was automatically updated to reflect the committed changes. Closed by commit rGed1b556954eb: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc() (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271860. saghir edited the summary of this revision. saghir added a comment. Updated comment to reflect the change in allowed types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.o

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel created this revision. aardappel added reviewers: sbc100, dschuff. Herald added subscribers: llvm-commits, cfe-commits, sunfish, aheejin, hiraditya, jgravelle-google. Herald added projects: clang, LLVM. aardappel updated this revision to Diff 271859. aardappel added a comment. This is a

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel updated this revision to Diff 271859. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82130/new/ https://reviews.llvm.org/D82130 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp lld/wasm/Config.h lld/wasm/Driver.cpp lld/wasm/InputChunks.cpp lld/wasm/Options.td llvm/

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel added a comment. This is a first iteration, probably needs more tests :) I was thinking of forking `userstack.ll` since it has most `__stack_pointer` tests, but I am not sure if it's that useful. Needs a test that uses the new wasm-ld flag. Opinions welcome. CHANGES SINCE LAST ACTIO

[clang] ed1b556 - [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

Author: Xiangling Liao Date: 2020-06-18T18:49:23-04:00 New Revision: ed1b556954eb2b1bb50db973860b7cf20494ce15 URL: https://github.com/llvm/llvm-project/commit/ed1b556954eb2b1bb50db973860b7cf20494ce15 DIFF: https://github.com/llvm/llvm-project/commit/ed1b556954eb2b1bb50db973860b7cf20494ce15.diff

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 added a comment. In D82089#2100802 , @Eugene.Zelenko wrote: > It'll be interesting to run improved check over LLVM code base. I haven't tried running it over llvm, but I have had success using it with clangd in my editor, every loop I've tried

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. Herald added a subscriber: sstefan1. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 271856. njames93 added a comment. - Change default c++20 include to `ranges` instead of `algorithm` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files: clang-tool

[PATCH] D81923: [clang-tidy] Add modernize-use-ranges check.

njames93 updated this revision to Diff 271855. njames93 added a comment. Added `IncludeInserter` to include the `` header. Added support for reverse iteration controlled by config. Added support for begin/end calls via pointers. Made the begin/end call matcher more robust if other checks want to u

[clang] d8c9729 - [docs] Regenerate clang/docs/ClangCommandLineReference.rst

Author: Fangrui Song Date: 2020-06-18T14:52:39-07:00 New Revision: d8c9729216032e82adeb4965ae4e118c01f6b321 URL: https://github.com/llvm/llvm-project/commit/d8c9729216032e82adeb4965ae4e118c01f6b321 DIFF: https://github.com/llvm/llvm-project/commit/d8c9729216032e82adeb4965ae4e118c01f6b321.diff

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added a comment. Thanks; LGTM with minor nit. Comment at: clang/lib/CodeGen/CodeGenModule.h:1060 + + /// Add a sterm finalizer to the C++ global clean

[PATCH] D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGc45c1611303b: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in… (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80935

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

lxfind marked an inline comment as done. lxfind added inline comments. Comment at: clang/test/SemaCXX/coroutine-final-suspend-noexcept.cpp:14 +struct coroutine_handle { + static coroutine_handle from_address(void *); // expected-note {{must be declared with 'noexcept'}} +}; ---

[clang] c45c161 - [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

Author: Amy Kwan Date: 2020-06-18T16:23:56-05:00 New Revision: c45c1611303b4609016fa69c1c987ede3bf92006 URL: https://github.com/llvm/llvm-project/commit/c45c1611303b4609016fa69c1c987ede3bf92006 DIFF: https://github.com/llvm/llvm-project/commit/c45c1611303b4609016fa69c1c987ede3bf92006.diff LOG:

[PATCH] D82085: [TRE] markTails marks call sites as tailcalls though some of them are not.

avl added a comment. > It makes sense to teach tail recursion elimination not to depend so heavily > on tail markings. But I don't think that implies we want to mess with the > markings themselves. Ok. Thus I need to drop part of this patch related to more strict tail marking, and continue wit

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

lewissbaker added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10521 +def err_coroutine_promise_final_suspend_requires_nothrow : Error< + "all code generated by co_await __promise.final_suspend() must not throw" +>; I'd perhaps w

[PATCH] D82085: [TRE] markTails marks call sites as tailcalls though some of them are not.

efriedma added a comment. All "tail" needs to mean is "this call does not reference the current function's stack." That's all, no more or less. The relevant documentation and APIs are a bit confusing. A "tail" marking is a prerequisite for tailcall optimization, but it's not really related to

[PATCH] D82126: [libTooling] Change `selection` stencil to handle some cases of text in macros.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a project: clang. Currently, the `selection` stencil validates the selection before extracting the text. However, this means that any range inside a macro is rejected as an error. This patch changes the implementatio

[PATCH] D81466: [SveEmitter] Add builtins for struct loads/stores (ld2/ld3/etc)

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7890 + Value *Predicate = EmitSVEPredicateCast(Ops[0], VTy); + Value *BasePtr= Builder.CreateBitCast(Ops[1], VecPtrTy);

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rGc830d517b4e4: [HIP] Enable -amdgpu-internalize-symbols (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D819

[PATCH] D82085: [TRE] markTails marks call sites as tailcalls though some of them are not.

laytonio added a comment. Relevant llvm-dev thread. Noncapture use of locals disabling TailRecursionElimination Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://revie

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. I took a look. It consistently fails for me on mac and on Windows in a `git bash` shell, but it passes in cmd with unxutils. Maybe this needs something like eac56724fd955af0f8521557cacc57a83f371649 ?

[PATCH] D82122: [analyzer][Liveness][RFC][NFC] Propose to turn statement liveness into expression liveness

Szelethus created this revision. Szelethus added reviewers: xazax.hun, NoQ, vsavchenko, balazske, martong, baloghadamsoftware, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.s

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. Reverted in rG2ae0df5be7408a79524743762b6c74953f31b805 . I'll investigate the issue on my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ h

[clang] c830d51 - [HIP] Enable -amdgpu-internalize-symbols

Author: Yaxun (Sam) Liu Date: 2020-06-18T16:34:37-04:00 New Revision: c830d517b4e46abb617a80b3967b26546370c928 URL: https://github.com/llvm/llvm-project/commit/c830d517b4e46abb617a80b3967b26546370c928 DIFF: https://github.com/llvm/llvm-project/commit/c830d517b4e46abb617a80b3967b26546370c928.dif

[clang] 2ae0df5 - [CodeView] Revert 8374bf43634725dc02a262a77b5f940fca25938c and 403f9537924b8910ed4f741ed96c61f5e657915b

Author: Alexandre Ganea Date: 2020-06-18T16:18:46-04:00 New Revision: 2ae0df5be7408a79524743762b6c74953f31b805 URL: https://github.com/llvm/llvm-project/commit/2ae0df5be7408a79524743762b6c74953f31b805 DIFF: https://github.com/llvm/llvm-project/commit/2ae0df5be7408a79524743762b6c74953f31b805.dif

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b2f6b4a08ba: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions (authored by eduucaldas, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D82085: [TRE] markTails marks call sites as tailcalls though some of them are not.

avl added a comment. > It's OK to set "tail" on any call that satisfies these requirements (from > https://llvm.org/docs/LangRef.html#call-instruction): "Both markers [tail and > musttail] imply that the callee does not access allocas from the caller. The > tail marker additionally implies that

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

zixuw created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Upstream methods for action wrappers in generating modules; - Change the warning message for -Wincomplete-umbrella to report the location of the umbrella header; - Add a fix-it hint to include un

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. In D80833#2101690 , @thakis wrote: > Hm http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16533 is > happy so it's not broken on all Windows machines. Guess I'll take a look on > what's going on. You can hold off on

[clang] 1b2f6b4 - Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

Author: Eduardo Caldas Date: 2020-06-18T21:05:23+02:00 New Revision: 1b2f6b4a08ba74d965dcf7c9fee97d286c0250f8 URL: https://github.com/llvm/llvm-project/commit/1b2f6b4a08ba74d965dcf7c9fee97d286c0250f8 DIFF: https://github.com/llvm/llvm-project/commit/1b2f6b4a08ba74d965dcf7c9fee97d286c0250f8.diff

[PATCH] D80981: [AST] Fix a crash on accessing a class without definition in constexpr function context.

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4320 +if (!RD->hasDefinition()) + return APValue(); APValue Struct(APValue::UninitStruct(), RD->getNumBases(), hokein wrote: > rsmith wrote: > > hokein wrote: > > > sammccall w

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

lxfind updated this revision to Diff 271801. lxfind added a comment. Herald added a subscriber: arphaman. Address feedback and update failed tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82029/new/ https://reviews.llvm.org/D82029 Files: cl

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. Hm http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16533 is happy so it's not broken on all Windows machines. Guess I'll take a look on what's going on. You can hold off on the revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. In D80833#2101636 , @thakis wrote: > This is still broken; bots have been red for a few hours now. Can we revert > and analyze async, to keep the bots green please? Yes I will revert, but I don't understand. All the tests pass he

[PATCH] D82115: [OPENMP50]Codegen for scan directives in parallel for simd regions.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. Added codegen for scan directives in parallel for simd regions. Emits the code for the directive with inscan reductions. Original code: #pra

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

guiand added a comment. In an email conversation with @rsmith and @eugenis, they raised the issue that it's not necessarily wrong to pass aggregate types by value, even when some fields are uninit. A relevant excerpt from Richard: > In addition to the union case, there's another strange case f

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 271789. abelkocsis added a comment. Small comment fix Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModul

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 271790. dang added a comment. Address the clang-tidy issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td clang/incl

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. This is still broken; bots have been red for a few hours now. Can we revert and analyze async, to keep the bots green please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 _

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271784. eduucaldas added a comment. change if -> asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

gamesh411 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DoNotReferAtomicTwiceCheck.cpp:21 + Finder->addMatcher( + declRefExpr(hasType(hasUnqualifiedDesugaredType(atomicType())), + to(varDecl().bind("atomic")), I

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

atrosinenko added a comment. @samsonov Something strange happens with the compiler-rt tests: when this patch was initially uploaded, the tests were failed with seemingly unrelated failures: B59287 . Some tests are broken upstream, I concluded. Today I have reba

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

ymandel added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81868/new/ https://reviews.llvm.org/D81868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

amyk marked an inline comment as done. amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCScheduleP9.td:47 + let UnsupportedFeatures = [HasQPX, HasSPE, PrefixInstrs, PCRelativeMemops, + IsISA3_1]; lei wrote: > Are `P

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

ymandel updated this revision to Diff 271782. ymandel marked 3 inline comments as done. ymandel added a comment. removed Twine argument per clang-tidy warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81868/new/ https://reviews.llvm.org/D81868

[PATCH] D81885: [Coroutines] Return false on error of buildSuspends

lxfind abandoned this revision. lxfind added a comment. Makes sense. I will abandon this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81885/new/ https://reviews.llvm.org/D81885 ___ cfe-commits

[PATCH] D81837: [ARM][bfloat] Removing lowering of bfloat arguments and returns from Clang's CodeGen

This revision was automatically updated to reflect the committed changes. Closed by commit rG035795659b60: [ARM][bfloat] Do not coerce bfloat arguments and returns to integers (authored by stuij). Changed prior to commit: https://reviews.llvm.org/D81837?vs=271130&id=271775#toc Repository: rG

[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81311/new/ https://reviews.llvm.org/D81311 ___ cfe-commits mailing list cfe

[PATCH] D82112: [RFC][BPF] Implement getUserCost() for BPFTargetTransformInfo

yonghong-song created this revision. yonghong-song added a reviewer: ast. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This patch tries to partially prevent speculative code motion for BPF. First, some use cases on why we want to prevent spec

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

ymandel updated this revision to Diff 271770. ymandel marked 3 inline comments as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81868/new/ https://reviews.llvm.org/D81868 Files: clang/include/clang

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

aganea added a comment. But that won't work when compiling & crashing with `-fno-integrated-cc1`, would it? (or if building with `cmake ... -DCLANG_SPAWN_CC1=1`). In that case, normal crashes (not -gen-reproducer) won't go through the `CrashRecoveryContext`. Try running: $ CCC_OVERRIDE_OPTION

[clang] eed45b5 - [OPENMP][DOCS]Update status of supported constructs, NFC.

Author: Alexey Bataev Date: 2020-06-18T13:29:33-04:00 New Revision: eed45b5fa2b638360ebfde037d284b9dc69e54c0 URL: https://github.com/llvm/llvm-project/commit/eed45b5fa2b638360ebfde037d284b9dc69e54c0 DIFF: https://github.com/llvm/llvm-project/commit/eed45b5fa2b638360ebfde037d284b9dc69e54c0.diff

[clang] 0357956 - [ARM][bfloat] Do not coerce bfloat arguments and returns to integers

Author: Ties Stuij Date: 2020-06-18T18:26:01+01:00 New Revision: 035795659b604246b873f659f8feed8084898247 URL: https://github.com/llvm/llvm-project/commit/035795659b604246b873f659f8feed8084898247 DIFF: https://github.com/llvm/llvm-project/commit/035795659b604246b873f659f8feed8084898247.diff LO

[PATCH] D82019: [OPENMP]Fix PR46357: Do not allow types declarations in pragmas.

This revision was automatically updated to reflect the committed changes. Closed by commit rG437cbad3b35c: [OPENMP]Fix PR46357: Do not allow types declarations in pragmas. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82019/new

[PATCH] D80913: [update_cc_test_checks.py] Correctly skip function definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rGead7a8beccc1: [update_cc_test_checks.py] Correctly skip function definitions (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80913/n

[PATCH] D80914: [update_cc_test_checks.py] Handle C++ methods

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ce0e92f45f5: [update_cc_test_checks.py] Handle C++ methods (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80914/new/ https://revi

[PATCH] D82046: [HIP] Improve check patterns to avoid test failures in case string "opt",etc. happens to be in the InstallDir path in the -### output.

This revision was automatically updated to reflect the committed changes. Closed by commit rGce82b8e8af6d: [HIP] Improve check patterns to avoid test failures in case string "opt", etc. (authored by yamauchi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:88 // C checkers // CON abelkocsis wrote: > Eugene.Zelenko wrote: > > Please use //check// here. > Should I replace the `// C++ checkers` comment to

[clang] 437cbad - [OPENMP]Fix PR46357: Do not allow types declarations in pragmas.

Author: Alexey Bataev Date: 2020-06-18T13:17:03-04:00 New Revision: 437cbad3b35c7cf0f49d2bcea0a521651113 URL: https://github.com/llvm/llvm-project/commit/437cbad3b35c7cf0f49d2bcea0a521651113 DIFF: https://github.com/llvm/llvm-project/commit/437cbad3b35c7cf0f49d2bcea0a521651113.diff

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. But I suggest to wait for @hubert.reinterpretcast to have another scan at this before landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin added a comment. @njames93 - friendly ping, could you please take another look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 ___ cfe-commits m

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/Nodes.cpp:182 + for (auto *C = firstChild(); C; C = C->nextSibling()) { +if (C->role() == syntax::NodeRole::NestedNameSp

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Transformer/Parsing.cpp:169 + +// For consistency with matcher parser and C++ code, node id's are written as +// strings. However, w

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis marked an inline comment as done. abelkocsis added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:88 // C checkers // CON Eugene.Zelenko wrote: > Please use //check// here. Should I replace the `// C++ che

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

john.brawn updated this revision to Diff 271757. john.brawn edited the summary of this revision. john.brawn added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Moved BugReportMsg printing into CrashRecoveryContext, and stopped printing of backtrace wh

[clang] ce82b8e - [HIP] Improve check patterns to avoid test failures in case string "opt",

Author: Hiroshi Yamauchi Date: 2020-06-18T10:14:31-07:00 New Revision: ce82b8e8af6d9e95e15624c4fb8af2faac68ff63 URL: https://github.com/llvm/llvm-project/commit/ce82b8e8af6d9e95e15624c4fb8af2faac68ff63 DIFF: https://github.com/llvm/llvm-project/commit/ce82b8e8af6d9e95e15624c4fb8af2faac68ff63.di

[clang] 3ce0e92 - [update_cc_test_checks.py] Handle C++ methods

Author: Alex Richardson Date: 2020-06-18T18:09:21+01:00 New Revision: 3ce0e92f45f56fc1b93db35dec8c53dceb5c54a5 URL: https://github.com/llvm/llvm-project/commit/3ce0e92f45f56fc1b93db35dec8c53dceb5c54a5 DIFF: https://github.com/llvm/llvm-project/commit/3ce0e92f45f56fc1b93db35dec8c53dceb5c54a5.dif

  1   2   3   >