[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

hliao added a comment. Basically, I think that should be a generic issue. As argument coercing doesn't handle pointer previously, we need to that address pointer-specific issue. That is, if the original argument has qualifiers being able to map onto LLVM attributes, the coerced argument should

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song updated this revision to Diff 261427. yonghong-song added a comment. rebase on top of master. Fix build error due to a recent func name change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74572/new/ https://reviews.llvm.org/D74572

[PATCH] D74668: [Clang][BPF] implement __builtin_btf_type_id() builtin function

yonghong-song updated this revision to Diff 261426. yonghong-song added a comment. rebase on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74668/new/ https://reviews.llvm.org/D74668 Files: clang/include/clang/Basic/BuiltinsBPF.def

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

dexonsmith added a comment. In D77621#2002430 , @dblaikie wrote: > (seems a bit questionable to rely on uintptr_t being necessarily the same > type as either uint32_t or uint64_t - but maybe that's guaranteed/written > down somewhere)? I think in pract

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

rjmccall added a comment. Sorry, I should've been more straight with you. I'm still happy to raise this internally, but this is a hectic time of the year at Apple, and I'm not actually going to raise it until after WWDC. It wouldn't be making it into the new Xcode release anyway. Repository

[PATCH] D78874: [clang] Add vendor identity for Hygon Dhyana processor

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf28e02e74fb: [clang] Add vendor identity for Hygon Dhyana processor to cpuid.h (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D788

[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

kerbowa added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2270 + CGF.ConvertType(Ty)->getPointerAddressSpace() == 0 && + ArgI.getCoerceToType()->getPointerElementType() == + CGF.ConvertType(Ty)->getPointerElementType(); y

[clang] af28e02 - [clang] Add vendor identity for Hygon Dhyana processor to cpuid.h

Author: Craig Topper Date: 2020-04-30T18:17:01-07:00 New Revision: af28e02e74fbc9f955d292c19fa6dc790386bc4b URL: https://github.com/llvm/llvm-project/commit/af28e02e74fbc9f955d292c19fa6dc790386bc4b DIFF: https://github.com/llvm/llvm-project/commit/af28e02e74fbc9f955d292c19fa6dc790386bc4b.diff

[PATCH] D79223: Fix pr31836 on Windows too, and correctly handle repeated separators.

thakis created this revision. thakis added a reviewer: hans. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. The approach in D3 assumes that the '/' returned by path::begin() is the first element for absolute paths, but that's not true

[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2270 + CGF.ConvertType(Ty)->getPointerAddressSpace() == 0 && + ArgI.getCoerceToType()->getPointerElementType() == + CGF.ConvertType(Ty)->getPointerElementType(); ke

[PATCH] D79121: Add nomerge function attribute to clang

zequanwu updated this revision to Diff 261406. zequanwu added a comment. change `nomerge` to statement attribute CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79121/new/ https://reviews.llvm.org/D79121 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

kerbowa added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2270 + CGF.ConvertType(Ty)->getPointerAddressSpace() == 0 && + ArgI.getCoerceToType()->getPointerElementType() == + CGF.ConvertType(Ty)->getPointerElementType(); y

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea reopened this revision. asbirlea added a comment. This revision is now accepted and ready to land. Herald added a project: LLVM. I'm working to update this revision to address the compile-time regression. Re-opening so I can rebase and add misc fixes and will mark as changes planned unti

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea updated this revision to Diff 261404. asbirlea added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77341/new/ https://reviews.llvm.org/D77341 Files: clang/include/clang/Analysis/Analyses/Dominators.h llvm/include/ll

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek created this revision. phosek added reviewers: smeenai, compnerd. Herald added subscribers: llvm-commits, lldb-commits, Sanitizers, cfe-commits, hiraditya, mgorny. Herald added projects: clang, Sanitizers, LLDB, LLVM. Rather than handling zlib handling manually, use `find_package` from CMa

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:439 + bool AdjacentCode = + !Chunks.empty() && Chunks.back().Kind == Chunk::InlineCode; std::string Norm = canonicalizeSpaces(std::move(C

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

sammccall updated this revision to Diff 261399. sammccall marked an inline comment as done. sammccall added a comment. tweak coment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79139/new/ https://reviews.llvm.org/D79139 Files: clang-tools-extra

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

sammccall added a comment. Looks OK but covers a lot of cases that can't happen, we should probably not test those at least :-) Comment at: clang/lib/Format/TokenAnnotator.cpp:2817 return false; - if (Right.is(tok::star) && Left.is(tok::star)) + if (Right.isOneOf(tok::s

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:39 +if (!isInsideMainFile(HashLoc, SM)) { + auto PreLoc = SM.getPresumedLoc(HashLoc); + if (auto FE = SM.getFileManager().getFile(PreLoc.getFilename())) { Is it possib

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. @rjmccall Hey John, I sent the proposal to the addresses I was pointed to but haven't heard back in multiple weeks. Any update on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574

[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2268 + return LangOpts.HIP && isa(ArgI.getCoerceToType()) && + ArgI.getCoerceToType()->getPointerAddressSpace() == 1 && + CGF.ConvertType(Ty)->getPointerAddressSpace() == 0 &&

[PATCH] D79210: Let clang print registered targets for --version

yaxunl added a comment. A sample output: clang --version clang version 11.0.0 (https://github.com/llvm/llvm-project d0a30964c78cec2e3907be8ec16cfbec69bc3f2d) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /home/yaxunl/git/llvm/assert/bin Registered Targets: aarch64

[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2267 + const ABIArgInfo &ArgI, const QualType &Ty) { + return LangOpts.HIP && isa(ArgI.getCoerceToType()) && + ArgI.getCoerceToType()->getPointerAddressSpace() == 1 && --

[PATCH] D79194: Add header guards for header files that should not be included on the PS4 platform

This revision was automatically updated to reflect the committed changes. dyung marked an inline comment as done. Closed by commit rG046130490f23: Add header guards for header files that should not be included on the PS4… (authored by dyung). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

asbirlea added a comment. Gentle ping for more comments :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72893/new/ https://reviews.llvm.org/D72893 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

kerbowa updated this revision to Diff 261388. kerbowa added a comment. Fix test formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79213/new/ https://reviews.llvm.org/D79213 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGenCUDA/amd

[PATCH] D79194: Add header guards for header files that should not be included on the PS4 platform

dyung marked 2 inline comments as done. dyung added inline comments. Comment at: clang/test/Headers/x86intrin-2.c:7 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ffreestanding -Wcast-qual -x c++ %s -verify +// REQUIRES: x86-registered-target // expected-no-d

[PATCH] D79194: Add header guards for header files that should not be included on the PS4 platform

dyung updated this revision to Diff 261385. dyung added a comment. Removed REQUIRES line in test since it is not needed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79194/new/ https://reviews.llvm.org/D79194 Files: clang/lib/Headers/bmiintrin.h clang/lib/Headers/immintrin.h clan

[clang] 0461304 - Add header guards for header files that should not be included on the PS4 platform.

Author: Douglas Yung Date: 2020-04-30T16:17:34-07:00 New Revision: 046130490f230559e8dae7d7cb4959bd04f89bb8 URL: https://github.com/llvm/llvm-project/commit/046130490f230559e8dae7d7cb4959bd04f89bb8 DIFF: https://github.com/llvm/llvm-project/commit/046130490f230559e8dae7d7cb4959bd04f89bb8.diff

[PATCH] D79204: [clang-format] NFC - clang-format the FormatTests

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Makes sense to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79204/new/ https://reviews.llvm.org/D79204 ___

[PATCH] D79210: Let clang print registered targets for --version

echristo added a comment. LGTM if it works? Can you post the output into the commit message so we can review that here? I guess clang -v or something? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79210/new/ https://reviews.llvm.org/D79210 ___

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

sammccall added a comment. This is excellent, a pretty nice model in the end! Good job puzzling it out, when we discussed the idea in the past I imagined this part would be a pile of hacks. Thanks for the offline help understanding this, too... Comment at: clang-tools-extra/c

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

curdeius added a comment. In D78982#2013221 , @RKSimon wrote: > @asmith I'm seeing MSVC warnings from this patch: > > E:\llvm\llvm-project\clang\lib\Format\UnwrappedLineParser.cpp(1475): warning > C4305: 'argument': truncation from 'clang::tok::TokenKind'

[PATCH] D78655: [HIP] Let lambda be host device by default

tra added a comment. In D78655#2013616 , @pfultz2 wrote: > > I.e. if I pass a mutable lambda by reference to the GPU kernel > > I dont think we are enabling passing host objects by reference through > functions. Although it could be possible to capture th

[PATCH] D79210: Let clang print registered targets for --version

tra added a reviewer: echristo. tra added a subscriber: echristo. tra added a comment. LGTM, I've been annoyed by the lack of this info in the past. I've added @echristo for the driver owner's stamp of approval. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79210/new/ https://reviews.ll

[PATCH] D79194: Add header guards for header files that should not be included on the PS4 platform

craig.topper accepted this revision. craig.topper added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Headers/x86intrin-2.c:3 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ffreestanding -Wcast-qual %s -verify +// RUN

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

browneee added a comment. https://reviews.llvm.org/D79214 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

kerbowa created this revision. kerbowa added reviewers: yaxunl, hliao. Herald added subscribers: cfe-commits, nhaehnle, jvesely. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79213 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGenCUDA/amd

[PATCH] D78429: [clangd] Metric tracking through Tracer

sammccall accepted this revision. sammccall added a comment. Thanks! In D78429#2013635 , @kadircet wrote: > Also while writing the test for rename I've noticed we were actually counting > renamed files rather than occurrences, had to put a loop that woul

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

nikic updated this revision to Diff 261375. nikic added a comment. Fix rebase mistake in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78862/new/ https://reviews.llvm.org/D78862 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/delet

[PATCH] D72281: [Matrix] Add matrix type to Clang.

rjmccall added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1274 + TRY_TO(TraverseType(TL.getTypePtr()->getElementType())); +}) + fhahn wrote: > rjmccall wrote: > > Might as well do this instead of accumulating the technical debt.

[PATCH] D79210: Let clang print registered targets for --version

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. We need a way to know supported targets by clang since we use clang as assembler. This patch let clang print registered targets when --version option is passed to clang. https://reviews.llvm.org/D79210 Files: clang/lib/Dr

[PATCH] D79194: Add header guards for header files that should not be included on the PS4 platform

dyung added inline comments. Comment at: clang/test/Headers/x86intrin-2.c:3 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ffreestanding -Wcast-qual %s -verify +// RUN: %clang_cc1 -triple i386-unknown-unknown -fsyntax-only -ffreestanding -flax-vector-conversi

[clang] afc287e - Fix clang test after D76886

Author: Nikita Popov Date: 2020-04-30T23:42:38+02:00 New Revision: afc287e0abec710398465ee1f86237513f2b5091 URL: https://github.com/llvm/llvm-project/commit/afc287e0abec710398465ee1f86237513f2b5091 DIFF: https://github.com/llvm/llvm-project/commit/afc287e0abec710398465ee1f86237513f2b5091.diff

[clang] d1c4361 - [clang-format] Add the missing default argument.

Author: Michael Liao Date: 2020-04-30T17:36:43-04:00 New Revision: d1c43615ed068f2f915ccdd959ef583cd5177929 URL: https://github.com/llvm/llvm-project/commit/d1c43615ed068f2f915ccdd959ef583cd5177929 DIFF: https://github.com/llvm/llvm-project/commit/d1c43615ed068f2f915ccdd959ef583cd5177929.diff

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

mgehre added a comment. This change breaks `modernize-use-using` fixits. The code `typedef int A, B;` is replaced into using A = int; using B = int; when directly applying fixits with clang-tidy. But it is replaced into using A = int; using B = int; when applying fixits with `clang-

[PATCH] D79121: Add nomerge function attribute to clang

rnk added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1799 + let Spellings = [Clang<"nomerge">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [NoMergeDocs]; rnk wrote: > aaron.ballman wrote: > > zequanwu wrote: > > > rnk w

[PATCH] D79121: Add nomerge function attribute to clang

rnk added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1799 + let Spellings = [Clang<"nomerge">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [NoMergeDocs]; aaron.ballman wrote: > zequanwu wrote: > > rnk wrote: > > > Clang

[PATCH] D79204: [clang-format] NFC - clang-format the FormatTests

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, mitchell-stellar, sammccall. MyDeveloperDay added projects: clang, clang-format. Ensure the clang-format unit tests are themselves clang-formatted Having areas of the llvm code which are clang-format clean, give us mo

[PATCH] D79172: [clang-format] [PR45626] SpacesInAngles does not insert or preserve leading space before :: operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG511868dcf3b9: [clang-format] [PR45626] SpacesInAngles does not insert or preserve leading… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D79172: [clang-format] [PR45626] SpacesInAngles does not insert or preserve leading space before :: operator

MyDeveloperDay updated this revision to Diff 261340. MyDeveloperDay added a comment. Update so the pre-merge checks do there thing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79172/new/ https://reviews.llvm.org/D79172 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/For

[PATCH] D79194: Add header guards for header files that should not be included on the PS4 platform

craig.topper added inline comments. Comment at: clang/test/Headers/x86intrin-2.c:3 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ffreestanding -Wcast-qual %s -verify +// RUN: %clang_cc1 -triple i386-unknown-unknown -fsyntax-only -ffreestanding -flax-vector-c

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:439 + bool AdjacentCode = + !Chunks.empty() && Chunks.back().Kind == Chunk::InlineCode; std::string Norm = canonicalizeSpaces(std::move(Code)); I would say we should

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: sylvestre.ledru, sammccall, krasimir, Abpostelnicu. MyDeveloperDay added projects: clang, clang-format. Follow on from D78879: [clang-format] [PR45357] Fix issue found with operator spacing to

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

ABataev added a comment. In D79186#2013603 , @jdoerfert wrote: > What would you think about moving the allocator definitions to OMPKinds.def > instead of listing them explicitly? As far as I can tell we really only > distinguish between predefined and us

[clang] 511868d - [clang-format] [PR45626] SpacesInAngles does not insert or preserve leading space before :: operator

Author: mydeveloperday Date: 2020-04-30T21:47:19+01:00 New Revision: 511868dcf3b9d4fdeb817763165b9a830e9ab9a1 URL: https://github.com/llvm/llvm-project/commit/511868dcf3b9d4fdeb817763165b9a830e9ab9a1 DIFF: https://github.com/llvm/llvm-project/commit/511868dcf3b9d4fdeb817763165b9a830e9ab9a1.diff

[PATCH] D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified

This revision was automatically updated to reflect the committed changes. Closed by commit rG226489715cb8: [clang] Disable check for system sanitizer blacklists files if -fno-sanitizer… (authored by saudi). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D78035: [PoC][RISCV] enable LTO/ThinLTO on RISCV

tejohnson added inline comments. Comment at: llvm/test/LTO/RISCV/mabi-invalid.ll:10 +; RUN: opt -module-summary -o %t2.summary %S/Inputs/foo_ilp32.ll +; RUN: llvm-lto2 run -r %t2.summary,foo,plx -r %t1.summary,main,plx -r %t1.summary,foo, -o %t3 %t1.summary %t2.summary 2>&1 | Fi

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

browneee added a comment. In D77621#2013546 , @nikic wrote: > @browneee Looks like LLVM already defines `LLVM_PTR_SIZE` as a more portable > version of `__SIZEOF_POINTER__`. I saw LLVM_PTR_SIZE, but its definition may be based on sizeof()

[PATCH] D78429: [clangd] Metric tracking through Tracer

kadircet updated this revision to Diff 261329. kadircet marked 4 inline comments as done. kadircet added a comment. Herald added a subscriber: mgorny. - Test real metrics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78429/new/ https://reviews.llvm

[PATCH] D78429: [clangd] Metric tracking through Tracer

kadircet added a comment. In D78429#2012873 , @sammccall wrote: > Awesome, ship it! > > ... though, how do you feel about testing the actual metrics we export? > > Suggest a slightly generalized TestTracer that installs itself (RAII), and > has a > > //

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

jdoerfert added a comment. Herald added a reviewer: aaron.ballman. What would you think about moving the allocator definitions to OMPKinds.def instead of listing them explicitly? As far as I can tell we really only distinguish between predefined and user allocators, right? Repository: rG LLV

[PATCH] D78655: [HIP] Let lambda be host device by default

pfultz2 added a comment. > I.e. if I pass a mutable lambda by reference to the GPU kernel I dont think we are enabling passing host objects by reference through functions. Although it could be possible to capture the mutable lambda by reference by another lambda. > will the same lambda called

[clang] 2264897 - [clang] Disable check for system sanitizer blacklists files if -fno-sanitizer-blacklist was specified

Author: Sylvain Audi Date: 2020-04-30T16:04:50-04:00 New Revision: 226489715cb892993ce36f62845867aa9100e6d1 URL: https://github.com/llvm/llvm-project/commit/226489715cb892993ce36f62845867aa9100e6d1 DIFF: https://github.com/llvm/llvm-project/commit/226489715cb892993ce36f62845867aa9100e6d1.diff

[PATCH] D79034: [OPENMP50]Codegen for reduction clauses with 'task' modifier.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Some nits noted below. Can be done prior to commit. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2374 +break; + } case OMPRTL__kmpc_alloc: { --

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

nikic added a comment. @browneee Looks like LLVM already defines `LLVM_PTR_SIZE` as a more portable version of `__SIZEOF_POINTER__`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 __

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1274 + TRY_TO(TraverseType(TL.getTypePtr()->getElementType())); +}) + rjmccall wrote: > Might as well do this instead of accumulating the technical debt. > MatrixTypeLoc sho

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn updated this revision to Diff 261313. fhahn marked 8 inline comments as done. fhahn added a comment. Addressed comments, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72281/new/ https://reviews.llvm.org/D72281 Files: clang/include/

[PATCH] D78577: [OPENMP50]Basic support for uses_allocators clause.

ABataev marked 5 inline comments as done. ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:18614 + if (DRE) +IsPredefinedAllocator = PredefinedAllocators.count(DRE->getDecl()); + if (!DRE || jdoerfert wrote: > Nit: I gues

[PATCH] D78941: [OPENMP]Allow cancellation constructs in target parallel regions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb737b814feea: [OPENMP]Allow cancellation constructs in target parallel regions. (authored by ABataev). Changed prior to commit: https://reviews.llvm.org/D78941?vs=260355&id=261317#toc Repository: rG

[PATCH] D79194: Add header guards for header files that should not be included on the PS4 platform

dyung created this revision. dyung added a reviewer: craig.topper. dyung added a project: clang. For the PS4 platform, we want to exclude certain headers from being included because we do not support the features they provide. To achieve this, we do not include any header files by default, and r

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

dblaikie added a comment. In D77621#2013400 , @browneee wrote: > Thanks for the tips, MaskRay. > > Yes, I expect this would fix that issue. > > smeenai, SizeTypeMax() is intended to return size_t. > > --- > > I see a couple of options for fixing the trunc

[PATCH] D79121: Add nomerge function attribute to clang

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This should also have Sema tests ensuring that it only applies to the correct subjects, accepts no arguments, etc. Comment at: clang/include/clang/Basic/Attr.td:1799 + let Spellings = [Clang<"nomerg

[clang] b737b81 - [OPENMP]Allow cancellation constructs in target parallel regions.

Author: Alexey Bataev Date: 2020-04-30T15:10:52-04:00 New Revision: b737b814feea66379f026550d088fafcd46cb3d2 URL: https://github.com/llvm/llvm-project/commit/b737b814feea66379f026550d088fafcd46cb3d2 DIFF: https://github.com/llvm/llvm-project/commit/b737b814feea66379f026550d088fafcd46cb3d2.diff

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

browneee added a comment. Thanks for the tips, MaskRay. Yes, I expect this would fix that issue. smeenai, SizeTypeMax() is intended to return size_t. --- I see a couple of options for fixing the truncation warning on 32-bit platforms: 1. Add an explicit cast to remove the warning. - Disadva

[PATCH] D79142: [clangd] Render doc-comment code spans with `backticks` in plaintext mode

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG2cf93ef9fe1d: [clangd] Render doc-comment code spans with `backticks` in plaintext mode (authored by sammccall). Changed prior to commit: https://reviews.llvm

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

sammccall updated this revision to Diff 261301. sammccall marked an inline comment as done. sammccall added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79139/new/ https://reviews.llvm.org/D79139 Files: clang-tools-

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:419 C.Contents = std::move(Norm); C.Kind = Chunk::InlineCode; return *this; kadircet wrote: > i think we always want a s

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2011582 , @jvesely wrote: > In D78979#2006901 , @yaxunl wrote: > > > In D78979#2006847 , @arsenm wrote: > > > > > I'm also wondering if u

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Looks OK to me. Please give @sepavloff and @rjmccall a day or so to make final comments before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D79106: [clangd] Move inserted include from detail -> documentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG54d7db165d43: [clangd] Move inserted include from detail -> documentation. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D79106?vs=260962&id=261298#toc Repository: rG LLV

[PATCH] D79121: Add nomerge function attribute to clang

zequanwu updated this revision to Diff 261292. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79121/new/ https://reviews.llvm.org/D79121 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/attr-nomerge.c

[clang-tools-extra] 2cf93ef - [clangd] Render doc-comment code spans with `backticks` in plaintext mode

Author: Sam McCall Date: 2020-04-30T20:16:51+02:00 New Revision: 2cf93ef9fe1df61b2aac97dc3320a12386a7dab5 URL: https://github.com/llvm/llvm-project/commit/2cf93ef9fe1df61b2aac97dc3320a12386a7dab5 DIFF: https://github.com/llvm/llvm-project/commit/2cf93ef9fe1df61b2aac97dc3320a12386a7dab5.diff LO

[PATCH] D79121: Add nomerge function attribute to clang

zequanwu marked 2 inline comments as done. zequanwu added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1799 + let Spellings = [Clang<"nomerge">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [NoMergeDocs]; rnk wrote: > Clan

[PATCH] D78655: [HIP] Let lambda be host device by default

tra added a comment. In D78655#2013226 , @pfultz2 wrote: > > Not only the capture is an issue, like a regular function, lambda could > > also access non-local variables/functions. > > In practice this is not an issue. Hcc will implictly treat anything inl

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl, jholewinski. Herald added a project: clang. omp.h header file defines omp_null_allocator as a predefined allocator, need to consider it also as a predefined allocator. Repository: rG

[PATCH] D79106: [clangd] Move inserted include from detail -> documentation.

sammccall marked an inline comment as done. sammccall added a comment. This needed a nontrivial merge after D79157 , because we need to concatenate markup::Documents. Don't think there's anything surprising in there so going ahead, happy to address any comments t

[clang-tools-extra] 54d7db1 - [clangd] Move inserted include from detail -> documentation.

Author: Sam McCall Date: 2020-04-30T19:58:53+02:00 New Revision: 54d7db165d438bf1bc4f13212a0a7bd3e61aae39 URL: https://github.com/llvm/llvm-project/commit/54d7db165d438bf1bc4f13212a0a7bd3e61aae39 DIFF: https://github.com/llvm/llvm-project/commit/54d7db165d438bf1bc4f13212a0a7bd3e61aae39.diff LO

[PATCH] D78655: [HIP] Let lambda be host device by default

pfultz2 added a comment. > Not only the capture is an issue, like a regular function, lambda could also > access non-local variables/functions. In practice this is not an issue. Hcc will implictly treat anything inlinable as host device, and user's are not confused or surprised when they use n

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

nikic updated this revision to Diff 261279. nikic marked an inline comment as done. nikic added a comment. Rebase over committed NFC changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78862/new/ https://reviews.llvm.org/D78862 Files: clang/l

[PATCH] D79155: [CodeGen] Increase applicability of ffine-grained-bitfield-accesses for targets with limited native integer widths

efriedma added a comment. The -ffine-grained-bitfield-accesses seems to generate weird results in certain cases. For example, on x86 we generate an unaligned load in the following example. struct S { long c : 8; long z: 24; long : 0; }; struct S s; int f() { return s.c+s.z; } I guess t

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

RKSimon added a comment. @asmith I'm seeing MSVC warnings from this patch: E:\llvm\llvm-project\clang\lib\Format\UnwrappedLineParser.cpp(1475): warning C4305: 'argument': truncation from 'clang::tok::TokenKind' to 'bool' E:\llvm\llvm-project\clang\lib\Format\UnwrappedLineParser.cpp(1828): warnin

[PATCH] D79157: [clangd] Render code complete documentation as plaintext/markdown.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3a27a7aeed6: [clangd] Render code complete documentation as plaintext/markdown. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D79157?vs=261185&id=261278#toc Repository:

[PATCH] D77936: [Windows SEH] Fix abnormal-exits in _try

This revision was automatically updated to reflect the committed changes. Closed by commit rG4eabd0061254: [Windows SEH] Fix abnormal-exits in _try (authored by asmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77936/new/ https://reviews.llvm.o

[PATCH] D79157: [clangd] Render code complete documentation as plaintext/markdown.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:377 + auto SetDoc = [&](llvm::StringRef Doc) { +if (!Doc.trim().empty()) { + Completion.Documentation.emplace(); --

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

MaskRay added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:403 switch (Linkage) { case GlobalValue::CommonLinkage: case GlobalValue::LinkOnceAnyLinkage: hubert.reinterpretcast wrote: > I have my doubts that `CommonLinkage` shou

[clang-tools-extra] a3a27a7 - [clangd] Render code complete documentation as plaintext/markdown.

Author: Sam McCall Date: 2020-04-30T19:00:49+02:00 New Revision: a3a27a7aeed6d9fee447e1c589811017b091384c URL: https://github.com/llvm/llvm-project/commit/a3a27a7aeed6d9fee447e1c589811017b091384c DIFF: https://github.com/llvm/llvm-project/commit/a3a27a7aeed6d9fee447e1c589811017b091384c.diff LO

[clang] 4eabd00 - [Windows SEH] Fix abnormal-exits in _try

Author: Aaron Smith Date: 2020-04-30T09:38:19-07:00 New Revision: 4eabd006125424f879a7129eca824998192d89a9 URL: https://github.com/llvm/llvm-project/commit/4eabd006125424f879a7129eca824998192d89a9 DIFF: https://github.com/llvm/llvm-project/commit/4eabd006125424f879a7129eca824998192d89a9.diff L

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

This revision was automatically updated to reflect the committed changes. Closed by commit rG292058a5d6d7: [clang-format] Fix Microsoft style for enums (authored by asmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.ll

[PATCH] D78577: [OPENMP50]Basic support for uses_allocators clause.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. A few nits and one question/concern below. Once/If that one is addressed this LGTM. Comment at:

  1   2   3   >