ABataev marked 5 inline comments as done. ABataev added inline comments.
================ Comment at: clang/lib/Sema/SemaOpenMP.cpp:18614 + if (DRE) + IsPredefinedAllocator = PredefinedAllocators.count(DRE->getDecl()); + if (!DRE || ---------------- jdoerfert wrote: > Nit: I guess after the condition below these three lines can be placed as > `bool IsPredefinedAllocator = PredefinedAllocators.count(DRE->getDecl());` `IsPredefinedAllocator` is used in the condition itself ================ Comment at: clang/test/OpenMP/target_uses_allocators_messages.cpp:54 +} + ---------------- jdoerfert wrote: > Do we handle/test the case where the trait array is empty? > > ``` > omp_alloctrait_t empty_traits[0]; > ``` > I guess that doesn't mean much and we should error out? Runtime supports it, returns default allocator in this case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78577/new/ https://reviews.llvm.org/D78577 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
