[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso updated this revision to Diff 253394. Charusso marked 19 inline comments as done. Charusso edited the summary of this revision. Charusso added a comment. Herald added a subscriber: ASDenysPetrov. - Fix `VLASizeChecker`'s multi-dimensional array early return. - So that fix the regression i

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicSize.h:25 -/// Get the stored dynamic size for the region \p MR. +/// \returns The stored dynamic size for the region \p MR. DefinedOrUnknownSVal getDynamicSize(ProgramSta

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253388. oontvoo added a comment. Add more tests (From Bug 39206) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:708-710 +return std::tie(M1.FilePath, M1.FileOffset, LHS.DiagnosticName, +M1.Message) < + std::tie(M2.FilePath, M2.FileOffset, RHS.Diagnostic

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

njames93 added a comment. I'm not entirely sure this is where the fix needs to be for this. The test case code is whacky as hell, but from what I can see clang should always emit a `BinaryOperator` for dependent type operators. No idea why it is spewing out a `CXXOperatorCallExpr` instead. Woul

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253382. oontvoo added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/

[clang] 09d4021 - Fix compatibility for __builtin_stdarg_start

Author: Joerg Sonnenberger Date: 2020-03-28T23:24:13+01:00 New Revision: 09d402185394fdbf1f60233a7f42a4a1108c2cd3 URL: https://github.com/llvm/llvm-project/commit/09d402185394fdbf1f60233a7f42a4a1108c2cd3 DIFF: https://github.com/llvm/llvm-project/commit/09d402185394fdbf1f60233a7f42a4a1108c2cd3.

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg added a comment. Herald added a subscriber: broadwaylamb. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73245/new/ https://reviews.llvm.org/D73245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

f00kat created this revision. f00kat added reviewers: aaron.ballman, lebedev.ri, NoQ, martong. f00kat added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun.

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added a comment. > In D75591#1936152 , @lebedev.ri > wrote: > It should be handled consistently with how other newer openmp features are > handled with older openmp version specified. In terms of consistency, the newer openmp features are hand

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added inline comments. Comment at: clang/include/clang/AST/Expr.h:2573 + FPOptions FPFeatures; + mibintc wrote: > rjmccall wrote: > > Let's split the CallExpr changes out into a separate patch, so that we have > > one patch that's *purely* about unif

Re: [PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

To illustrate another workflow: I also got format-on-save turned on, but filter the irrelevant changes before committing by doing `git add -p` instead of adding all modifications. On Sat, Mar 28, 2020 at 9:17 PM Nathan Ridge via Phabricator < revi...@reviews.llvm.org> wrote: > nridge marked an in

[PATCH] D76587: [BPF] support 128bit int explicitly in layout spec

This revision was automatically updated to reflect the committed changes. Closed by commit rGced0d1f42b39: [BPF] support 128bit int explicitly in layout spec (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76587/new/ https

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:206 + tooling::Replacements R; + if (auto Err = R.add(tooling::Replacement( + SM, CharSourceRange::getTokenRange(NNSL.getSourceRange()), "", sammccall wro

[clang] ced0d1f - [BPF] support 128bit int explicitly in layout spec

Author: Yonghong Song Date: 2020-03-28T11:46:29-07:00 New Revision: ced0d1f42b39bd93b350b2597ce6587d107c26a7 URL: https://github.com/llvm/llvm-project/commit/ced0d1f42b39bd93b350b2597ce6587d107c26a7 DIFF: https://github.com/llvm/llvm-project/commit/ced0d1f42b39bd93b350b2597ce6587d107c26a7.diff

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 253367. plotfi added a comment. fixing linter errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/ https://reviews.llvm.org/D76979 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/lib/Front

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 253369. plotfi added a comment. Adding a better test to check the deprecated v1 format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/ https://reviews.llvm.org/D76979 Files: clang/lib/Frontend/Compi

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 253368. DmitryPolukhin added a comment. Resolve merge conflict, revert clang-format for ASTBitCodes.h to avoid further conflicts, use C++ cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ ht

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska updated this revision to Diff 253366. Bouska added a comment. Do not touch current tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71512/new/ https://reviews.llvm.org/D71512 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unittests/Format/FormatTest.cpp Index

[clang] 4065e92 - Upgrade some instances of std::sort to llvm::sort. NFC.

Author: Benjamin Kramer Date: 2020-03-28T19:23:29+01:00 New Revision: 4065e92195b1815367d619292080a9a1d3032015 URL: https://github.com/llvm/llvm-project/commit/4065e92195b1815367d619292080a9a1d3032015 DIFF: https://github.com/llvm/llvm-project/commit/4065e92195b1815367d619292080a9a1d3032015.dif

[clang-tools-extra] 4065e92 - Upgrade some instances of std::sort to llvm::sort. NFC.

Author: Benjamin Kramer Date: 2020-03-28T19:23:29+01:00 New Revision: 4065e92195b1815367d619292080a9a1d3032015 URL: https://github.com/llvm/llvm-project/commit/4065e92195b1815367d619292080a9a1d3032015 DIFF: https://github.com/llvm/llvm-project/commit/4065e92195b1815367d619292080a9a1d3032015.dif

[clang] 347e31c - Remove constexpr that MSVC doesn't like

Author: Benjamin Kramer Date: 2020-03-28T19:23:29+01:00 New Revision: 347e31c052d5a36890c484b6753d480ac8f0062f URL: https://github.com/llvm/llvm-project/commit/347e31c052d5a36890c484b6753d480ac8f0062f DIFF: https://github.com/llvm/llvm-project/commit/347e31c052d5a36890c484b6753d480ac8f0062f.dif

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:708-710 +return std::tie(M1.FilePath, M1.FileOffset, LHS.DiagnosticName, +M1.Message) < + std::tie(M2.

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

aganea added a comment. In D75153#1947956 , @zero9178 wrote: > This patch seems to break when disabling threading (aka LLVM_ENABLE_THREADS > == 0) as get_threadpool_strategy is undefined therefore creating linker > failures in clang. (Tested on Windows)

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:708-710 +return std::tie(M1.FilePath, M1.FileOffset, LHS.DiagnosticName, +M1.Message) < + std::tie(M2.

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

compnerd added a comment. Please address the linter warnings. I think that adding an additional test to demonstrate that the `experimental-ifs-version-v1` is properly diagnosed is a good idea. LGTM other than that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] e8743c0 - Const-initialize ParsedAttrInfos

Author: Benjamin Kramer Date: 2020-03-28T19:04:53+01:00 New Revision: e8743c0f389d43aeab053904c6407280bfbfd3a6 URL: https://github.com/llvm/llvm-project/commit/e8743c0f389d43aeab053904c6407280bfbfd3a6 DIFF: https://github.com/llvm/llvm-project/commit/e8743c0f389d43aeab053904c6407280bfbfd3a6.dif

[clang] 3ab3f3c - After 09158252f777c2e2f06a86b154c44abcbcf9bb74, fix build when -DLLVM_ENABLE_THREADS=OFF

Author: Alexandre Ganea Date: 2020-03-28T13:54:58-04:00 New Revision: 3ab3f3c5d5825476dc1be15992f7c964629de688 URL: https://github.com/llvm/llvm-project/commit/3ab3f3c5d5825476dc1be15992f7c964629de688 DIFF: https://github.com/llvm/llvm-project/commit/3ab3f3c5d5825476dc1be15992f7c964629de688.dif

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

sammccall added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:708-710 +return std::tie(M1.FilePath, M1.FileOffset, LHS.DiagnosticName, +M1.Message) < + std::tie(M2.FilePath, M2.FileOffset, RHS.Diagnosti

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 253360. plotfi added a comment. Changing some of the version checks. I don't think we need to have rigid checks considering this format is experimental. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:708-710 +return std::tie(M1.FilePath, M1.FileOffset, LHS.DiagnosticName, +M1.Message) < + std::tie(M2.

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

ztamas updated this revision to Diff 253354. ztamas added a comment. Run clang-format on test code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76990/new/ https://reviews.llvm.org/D76990 Files: clang-tools-extra/clang-tidy/bugprone/UnhandledSe

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

fickert updated this revision to Diff 253349. fickert added a comment. Added documentation and missing test cases for 0-width tabs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75034/new/ https://reviews.llvm.org/D75034 Files: clang/docs/ClangF

[PATCH] D76943: [clang analysis] Make mutex guard detection more reliable.

aaronpuchert added inline comments. Comment at: clang/test/SemaCXX/warn-thread-safety-analysis.cpp:5659 + } + struct Convertible { Convertible(); operator ReadLockedPtr(); }; + void use_conversion() { Honestly I'd prefer the annotation to be on this operator i

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG9619c2cc9a22: [clang][Syntax] Handle macro arguments in spelledForExpanded (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D75446?vs=

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

aganea added a comment. In D75153#1947956 , @zero9178 wrote: > This patch seems to break when disabling threading (aka LLVM_ENABLE_THREADS > == 0) as get_threadpool_strategy is undefined therefore creating linker > failures in clang. (Tested on Windows)

[clang] 9619c2c - [clang][Syntax] Handle macro arguments in spelledForExpanded

Author: Kadir Cetinkaya Date: 2020-03-28T16:35:46+01:00 New Revision: 9619c2cc9a22a3ca1375f2f4a64e50c0a56e95d1 URL: https://github.com/llvm/llvm-project/commit/9619c2cc9a22a3ca1375f2f4a64e50c0a56e95d1 DIFF: https://github.com/llvm/llvm-project/commit/9619c2cc9a22a3ca1375f2f4a64e50c0a56e95d1.dif

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:623 std::string TaskName = llvm::formatv("Update ({0})", Inputs.Version); auto Task = [=]() mutable { auto RunPublish = [&](llvm::function_ref Publish) { sammccall wro

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 253347. kadircet marked 26 inline comments as done. kadircet added a comment. Herald added a subscriber: jfb. - Update description and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76725/new/

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

ztamas created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. ztamas edited the summary of this revision. ztamas added a reviewer: aaron.ballman. It seems we need a different matcher for binary operator in a template context. Fixes this issue: http

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

xbolva00 added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:3100 } - F.TypeOffsets = (const uint32_t *)Blob.data(); + F.TypeOffsets = (const uint64_t *)Blob.data(); F.LocalNumTypes = Record[0]; use C++ cast style Re

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

zero9178 added a comment. This patch seems to break when disabling threading (aka LLVM_ENABLE_THREADS == 0) as get_threadpool_strategy is undefined therefore creating linker failures in clang. (Tested on Windows) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. On my RHEL8 system building Debug clang;clang-tools-extra, check-all is passing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 ___ cf

[clang] cb63893 - Fix GCC warning on enum class bitfield. NFC.

Author: Michael Liao Date: 2020-03-28T10:20:34-04:00 New Revision: cb6389360b05e8f89d09ff133a4ba1fd011866c5 URL: https://github.com/llvm/llvm-project/commit/cb6389360b05e8f89d09ff133a4ba1fd011866c5 DIFF: https://github.com/llvm/llvm-project/commit/cb6389360b05e8f89d09ff133a4ba1fd011866c5.diff

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 253341. mibintc marked 12 inline comments as done. mibintc added a comment. @rjmccall Many thanks for your code review. Please take a look at this when you get a chance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked an inline comment as done. mibintc added a comment. I added some inline replies to John. I'm not certain I have everything yet exactly the way he wants it. Comment at: clang/include/clang/AST/Expr.h:2573 + FPOptions FPFeatures; + rjmccall wr

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:201 + /// Returns the subrange of spelled tokens corresponding to AST node spanning + /// \p Expanded.

[PATCH] D76987: Rename options --cuda-gpu-arch and --no-cuda-gpu-arch

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl edited the summary of this revision. Options --cuda-gpu-arch and --no-cuda-gpu-arch are shared between CUDA and HIP. It is desirable to rename them for more generic names to avoid confusion. One option is --gpu-arch and --no-gpu-a

[PATCH] D76943: [clang analysis] Make mutex guard detection more reliable.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76943/new/ https://reviews.llvm.org/D76943 ___ cfe-commits mailing list cfe-comm

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

fickert updated this revision to Diff 253327. fickert added a comment. I moved the changed behavior to a new option (`UT_AlignWithSpaces`), and added corresponding unit tests by copying and adapting the tests for `UT_ForContinuationAndIndentation`. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

fickert added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:10146 "\t int i;\n" "}")); This test seems to be missing the tab configuration (`Tab`) as an argument to `format`, and the same test with m

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:708-710 +return std::tie(M1.FilePath, M1.FileOffset, LHS.DiagnosticName, +M1.Message) < + std::tie(M2.FilePath, M2.FileOffset, RHS.Diagnostic

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

kadircet updated this revision to Diff 253325. kadircet added a comment. - Rebase, update comments for spelledForExpanded and add tests for multiple arguments. - Do not dive into macro bodies while looking for a common expansion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 253314. plotfi added a comment. Herald added a subscriber: wuzish. -U999 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/ https://reviews.llvm.org/D76979 Files: clang/lib/Frontend/CompilerInvocation.c

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. plotfi updated this revision to Diff 253314. plotfi added a comment. Herald added a subscriber: wuzish. -U999 These file format changes have b